Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-8568

Replace the deprecated zk-address property in the HA config example in ResourceManagerHA.md

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.2.0, 3.0.4, 3.1.2
    • yarn
    • None
    • Reviewed

    Description

      yarn.resourcemanager.zk-address is deprecated. Instead, use hadoop.zk.address

      In the example,  "yarn.resourcemanager.zk-address" is used which is deprecated. In the description, the property name is correct "hadoop.zk.address".

      Attachments

        1. YARN-8568.001.patch
          0.7 kB
          Antal Bálint Steinbach

        Issue Links

          Activity

            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 23s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
                  trunk Compile Tests
            +1 mvninstall 27m 16s trunk passed
            +1 mvnsite 0m 20s trunk passed
            +1 shadedclient 38m 44s branch has no errors when building and testing our client artifacts.
                  Patch Compile Tests
            +1 mvnsite 0m 18s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 12m 17s patch has no errors when building and testing our client artifacts.
                  Other Tests
            +1 asflicense 0m 23s The patch does not generate ASF License warnings.
            52m 32s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08
            JIRA Issue YARN-8568
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12933602/YARN-8568.001.patch
            Optional Tests asflicense mvnsite
            uname Linux d7abb7f335dd 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 952dc2f
            maven version: Apache Maven 3.3.9
            Max. process+thread count 301 (vs. ulimit of 10000)
            modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
            Console output https://builds.apache.org/job/PreCommit-YARN-Build/21434/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests +1 mvninstall 27m 16s trunk passed +1 mvnsite 0m 20s trunk passed +1 shadedclient 38m 44s branch has no errors when building and testing our client artifacts.       Patch Compile Tests +1 mvnsite 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 12m 17s patch has no errors when building and testing our client artifacts.       Other Tests +1 asflicense 0m 23s The patch does not generate ASF License warnings. 52m 32s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 JIRA Issue YARN-8568 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12933602/YARN-8568.001.patch Optional Tests asflicense mvnsite uname Linux d7abb7f335dd 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 952dc2f maven version: Apache Maven 3.3.9 Max. process+thread count 301 (vs. ulimit of 10000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Console output https://builds.apache.org/job/PreCommit-YARN-Build/21434/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            bsteinbach Thanks for filing the issue and the patch . Patch looks good. +1

            suma.shivaprasad Suma Shivaprasad added a comment - bsteinbach Thanks for filing the issue and the patch . Patch looks good. +1
            snemeth Szilard Nemeth added a comment -

            LGTM +1 (non-binding) from me as well!

            snemeth Szilard Nemeth added a comment - LGTM +1 (non-binding) from me as well!
            rkanter Robert Kanter added a comment -

            hadoop.zk.address normally goes in core-site.xml.  Does it still work if specified in yarn-site.xml?  If not, we should add a note about that because as-is, it sounds like you should put it in yarn-site.xml with the other properties.

            rkanter Robert Kanter added a comment - hadoop.zk.address normally goes in core-site.xml.  Does it still work if specified in yarn-site.xml?  If not, we should add a note about that because as-is, it sounds like you should put it in yarn-site.xml with the other properties.

            Hi rkanter ,

            I was using hadoop.zk.address configuration in yarn-site.xml during testing RM HA and it was working.

            bsteinbach Antal Bálint Steinbach added a comment - Hi rkanter , I was using  hadoop.zk.address configuration  in yarn-site.xml during  testing RM HA and it was working.
            rkanter Robert Kanter added a comment -

            +1 LGTM

            rkanter Robert Kanter added a comment - +1 LGTM
            rkanter Robert Kanter added a comment -

            Thanks bsteinbach and snemeth for the review. Committed to trunk, branch-3, and branch-3.1!

            rkanter Robert Kanter added a comment - Thanks bsteinbach and snemeth for the review. Committed to trunk, branch-3, and branch-3.1!
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14732 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14732/)
            YARN-8568. Replace the deprecated zk-address property in the HA config (rkanter: rev 8478732bb28e9e71061d6b4a043a3a1b5c688902)

            • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerHA.md
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14732 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14732/ ) YARN-8568 . Replace the deprecated zk-address property in the HA config (rkanter: rev 8478732bb28e9e71061d6b4a043a3a1b5c688902) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerHA.md

            Committed to trunk, branch-3, and branch-3.1!

            rkanter did you mean to commit this to branch-3.0 instead of branch-3? branch-3 should not exist and does not track an active release line.

            jlowe Jason Darrell Lowe added a comment - Committed to trunk, branch-3, and branch-3.1! rkanter did you mean to commit this to branch-3.0 instead of branch-3? branch-3 should not exist and does not track an active release line.
            rkanter Robert Kanter added a comment -

            Oops. I've now pushed it to branch-3.0. We have so many branches...

            rkanter Robert Kanter added a comment - Oops. I've now pushed it to branch-3.0. We have so many branches...

            Thanks rkanter! I marked this as fixed in 3.0.4 since 3.0.3 was released back in May.

            jlowe Jason Darrell Lowe added a comment - Thanks rkanter ! I marked this as fixed in 3.0.4 since 3.0.3 was released back in May.

            People

              bsteinbach Antal Bálint Steinbach
              bsteinbach Antal Bálint Steinbach
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: