Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14741

Refactor curator based ZooKeeper communication into common library

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently we have ZooKeeper based store implementations for multiple state stores like RM, YARN Federation, HDFS router-based federation, RM queue configs etc. This jira proposes to unify the curator based ZK communication to eliminate redundancies.

      1. HADOOP-14741-000.patch
        28 kB
        Íñigo Goiri
      2. HADOOP-14741-001.patch
        33 kB
        Íñigo Goiri
      3. HADOOP-14741-002.patch
        35 kB
        Íñigo Goiri
      4. HADOOP-14741-003.patch
        36 kB
        Íñigo Goiri
      5. HADOOP-14741-004.patch
        43 kB
        Íñigo Goiri
      6. HADOOP-14741-005.patch
        43 kB
        Íñigo Goiri
      7. HADOOP-14741-branch-2.patch
        43 kB
        Íñigo Goiri
      8. HADOOP-14741-branch-2-001.patch
        43 kB
        Íñigo Goiri
      9. HADOOP-14741-branch-2-002.patch
        43 kB
        Íñigo Goiri

        Issue Links

          Activity

          Hide
          randgalt Jordan Zimmerman added a comment -

          As the main author of Curator I'm happy to help if needed.

          Show
          randgalt Jordan Zimmerman added a comment - As the main author of Curator I'm happy to help if needed.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Íñigo Goiri for rebasing the patch, I committed it to branch-2.

          Show
          subru Subru Krishnan added a comment - Thanks Íñigo Goiri for rebasing the patch, I committed it to branch-2.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Checked the failed unit test in branch-2 and don't seem related.

          Show
          elgoiri Íñigo Goiri added a comment - Checked the failed unit test in branch-2 and don't seem related.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 6m 44s branch-2 passed
          +1 compile 6m 3s branch-2 passed with JDK v1.8.0_144
          +1 compile 6m 55s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 1m 34s branch-2 passed
          +1 mvnsite 2m 43s branch-2 passed
          +1 findbugs 5m 34s branch-2 passed
          +1 javadoc 1m 54s branch-2 passed with JDK v1.8.0_144
          +1 javadoc 2m 10s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 16s the patch passed
          +1 compile 5m 55s the patch passed with JDK v1.8.0_144
          +1 javac 5m 55s the patch passed
          +1 compile 6m 59s the patch passed with JDK v1.7.0_131
          +1 javac 6m 59s the patch passed
          +1 checkstyle 1m 39s root: The patch generated 0 new + 346 unchanged - 3 fixed = 346 total (was 349)
          +1 mvnsite 2m 53s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 6m 30s the patch passed
          +1 javadoc 0m 47s hadoop-common in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 32s hadoop-yarn-common in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 0 new + 854 unchanged - 4 fixed = 854 total (was 858)
          +1 javadoc 2m 24s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 9m 6s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_131.
          +1 unit 2m 36s hadoop-yarn-common in the patch passed with JDK v1.7.0_131.
          -1 unit 44m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          201m 50s



          Reason Tests
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881593/HADOOP-14741-branch-2-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux b98a2b71808a 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ed4d6aa
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13024/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13024/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13024/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 6m 44s branch-2 passed +1 compile 6m 3s branch-2 passed with JDK v1.8.0_144 +1 compile 6m 55s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 1m 34s branch-2 passed +1 mvnsite 2m 43s branch-2 passed +1 findbugs 5m 34s branch-2 passed +1 javadoc 1m 54s branch-2 passed with JDK v1.8.0_144 +1 javadoc 2m 10s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 16s the patch passed +1 compile 5m 55s the patch passed with JDK v1.8.0_144 +1 javac 5m 55s the patch passed +1 compile 6m 59s the patch passed with JDK v1.7.0_131 +1 javac 6m 59s the patch passed +1 checkstyle 1m 39s root: The patch generated 0 new + 346 unchanged - 3 fixed = 346 total (was 349) +1 mvnsite 2m 53s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 6m 30s the patch passed +1 javadoc 0m 47s hadoop-common in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 32s hadoop-yarn-common in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 0 new + 854 unchanged - 4 fixed = 854 total (was 858) +1 javadoc 2m 24s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 9m 6s hadoop-common in the patch passed with JDK v1.7.0_131. +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_131. +1 unit 2m 36s hadoop-yarn-common in the patch passed with JDK v1.7.0_131. -1 unit 44m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 201m 50s Reason Tests JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881593/HADOOP-14741-branch-2-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux b98a2b71808a 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ed4d6aa Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13024/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13024/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13024/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 58s Maven dependency ordering for branch
          -1 mvninstall 3m 55s root in branch-2 failed.
          -1 compile 3m 11s root in branch-2 failed with JDK v1.8.0_144.
          -1 compile 3m 39s root in branch-2 failed with JDK v1.7.0_131.
          +1 checkstyle 1m 29s branch-2 passed
          -1 mvnsite 0m 24s hadoop-yarn-server-resourcemanager in branch-2 failed.
          -1 findbugs 0m 20s hadoop-yarn-server-resourcemanager in branch-2 failed.
          +1 javadoc 1m 49s branch-2 passed with JDK v1.8.0_144
          +1 javadoc 2m 7s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 16s Maven dependency ordering for patch
          -1 mvninstall 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 3m 12s root in the patch failed with JDK v1.8.0_144.
          -1 javac 3m 12s root in the patch failed with JDK v1.8.0_144.
          -1 compile 3m 42s root in the patch failed with JDK v1.7.0_131.
          -1 javac 3m 42s root in the patch failed with JDK v1.7.0_131.
          +1 checkstyle 1m 33s root: The patch generated 0 new + 346 unchanged - 3 fixed = 346 total (was 349)
          -1 mvnsite 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 47s hadoop-common in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 31s hadoop-yarn-common in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 0 new + 854 unchanged - 4 fixed = 854 total (was 858)
          +1 javadoc 2m 20s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_131.
          +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_131.
          -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          93m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881593/HADOOP-14741-branch-2-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 2d23b26f92c3 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ce0cdc5
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-compile-root-jdk1.8.0_144.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 58s Maven dependency ordering for branch -1 mvninstall 3m 55s root in branch-2 failed. -1 compile 3m 11s root in branch-2 failed with JDK v1.8.0_144. -1 compile 3m 39s root in branch-2 failed with JDK v1.7.0_131. +1 checkstyle 1m 29s branch-2 passed -1 mvnsite 0m 24s hadoop-yarn-server-resourcemanager in branch-2 failed. -1 findbugs 0m 20s hadoop-yarn-server-resourcemanager in branch-2 failed. +1 javadoc 1m 49s branch-2 passed with JDK v1.8.0_144 +1 javadoc 2m 7s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch -1 mvninstall 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 3m 12s root in the patch failed with JDK v1.8.0_144. -1 javac 3m 12s root in the patch failed with JDK v1.8.0_144. -1 compile 3m 42s root in the patch failed with JDK v1.7.0_131. -1 javac 3m 42s root in the patch failed with JDK v1.7.0_131. +1 checkstyle 1m 33s root: The patch generated 0 new + 346 unchanged - 3 fixed = 346 total (was 349) -1 mvnsite 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 47s hadoop-common in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 31s hadoop-yarn-common in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 0 new + 854 unchanged - 4 fixed = 854 total (was 858) +1 javadoc 2m 20s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_131. +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_131. +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_131. -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 93m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881593/HADOOP-14741-branch-2-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2d23b26f92c3 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ce0cdc5 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-compile-root-jdk1.8.0_144.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13012/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing checkstyle.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing checkstyle.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Jenkins is complaining about AllocationFileLoaderService but I have no issues locally.
          I don't evne think it has anything to do with this patch.

          Show
          elgoiri Íñigo Goiri added a comment - Jenkins is complaining about AllocationFileLoaderService but I have no issues locally. I don't evne think it has anything to do with this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 52s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 59s Maven dependency ordering for branch
          -1 mvninstall 4m 12s root in branch-2 failed.
          -1 compile 3m 58s root in branch-2 failed with JDK v1.8.0_144.
          -1 compile 3m 44s root in branch-2 failed with JDK v1.7.0_131.
          +1 checkstyle 1m 56s branch-2 passed
          -1 mvnsite 0m 25s hadoop-yarn-server-resourcemanager in branch-2 failed.
          -1 findbugs 0m 20s hadoop-yarn-server-resourcemanager in branch-2 failed.
          +1 javadoc 1m 53s branch-2 passed with JDK v1.8.0_144
          +1 javadoc 2m 8s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 16s Maven dependency ordering for patch
          -1 mvninstall 0m 22s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 3m 11s root in the patch failed with JDK v1.8.0_144.
          -1 javac 3m 11s root in the patch failed with JDK v1.8.0_144.
          -1 compile 3m 41s root in the patch failed with JDK v1.7.0_131.
          -1 javac 3m 41s root in the patch failed with JDK v1.7.0_131.
          -0 checkstyle 1m 33s root: The patch generated 1 new + 346 unchanged - 3 fixed = 347 total (was 349)
          -1 mvnsite 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 0m 24s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 46s hadoop-common in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 30s hadoop-yarn-common in the patch passed with JDK v1.8.0_144.
          +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 0 new + 854 unchanged - 4 fixed = 854 total (was 858)
          +1 javadoc 2m 20s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 8m 26s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_131.
          +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_131.
          -1 unit 0m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          108m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881570/HADOOP-14741-branch-2-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux a36968dd704d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ce0cdc5
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-compile-root-jdk1.8.0_144.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 52s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 59s Maven dependency ordering for branch -1 mvninstall 4m 12s root in branch-2 failed. -1 compile 3m 58s root in branch-2 failed with JDK v1.8.0_144. -1 compile 3m 44s root in branch-2 failed with JDK v1.7.0_131. +1 checkstyle 1m 56s branch-2 passed -1 mvnsite 0m 25s hadoop-yarn-server-resourcemanager in branch-2 failed. -1 findbugs 0m 20s hadoop-yarn-server-resourcemanager in branch-2 failed. +1 javadoc 1m 53s branch-2 passed with JDK v1.8.0_144 +1 javadoc 2m 8s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch -1 mvninstall 0m 22s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 3m 11s root in the patch failed with JDK v1.8.0_144. -1 javac 3m 11s root in the patch failed with JDK v1.8.0_144. -1 compile 3m 41s root in the patch failed with JDK v1.7.0_131. -1 javac 3m 41s root in the patch failed with JDK v1.7.0_131. -0 checkstyle 1m 33s root: The patch generated 1 new + 346 unchanged - 3 fixed = 347 total (was 349) -1 mvnsite 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 0m 24s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 46s hadoop-common in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 30s hadoop-yarn-common in the patch passed with JDK v1.8.0_144. +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 0 new + 854 unchanged - 4 fixed = 854 total (was 858) +1 javadoc 2m 20s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 8m 26s hadoop-common in the patch passed with JDK v1.7.0_131. +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_131. +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_131. -1 unit 0m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 108m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881570/HADOOP-14741-branch-2-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a36968dd704d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ce0cdc5 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-compile-root-jdk1.8.0_144.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13011/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 18m 22s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 59s Maven dependency ordering for branch
          +1 mvninstall 6m 39s branch-2 passed
          +1 compile 5m 53s branch-2 passed with JDK v1.8.0_144
          +1 compile 6m 10s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 1m 23s branch-2 passed
          +1 mvnsite 2m 28s branch-2 passed
          +1 findbugs 5m 1s branch-2 passed
          +1 javadoc 1m 45s branch-2 passed with JDK v1.8.0_144
          +1 javadoc 2m 3s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          -1 mvninstall 0m 25s hadoop-common in the patch failed.
          -1 mvninstall 0m 20s hadoop-yarn-api in the patch failed.
          -1 mvninstall 0m 19s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 0m 35s root in the patch failed with JDK v1.8.0_144.
          -1 javac 0m 35s root in the patch failed with JDK v1.8.0_144.
          -1 compile 0m 40s root in the patch failed with JDK v1.7.0_131.
          -1 javac 0m 40s root in the patch failed with JDK v1.7.0_131.
          -0 checkstyle 1m 23s root: The patch generated 1 new + 346 unchanged - 3 fixed = 347 total (was 349)
          -1 mvnsite 0m 27s hadoop-common in the patch failed.
          -1 mvnsite 0m 25s hadoop-yarn-api in the patch failed.
          -1 mvnsite 0m 22s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 0m 21s hadoop-common in the patch failed.
          -1 findbugs 0m 14s hadoop-yarn-api in the patch failed.
          -1 findbugs 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 7 new + 854 unchanged - 4 fixed = 861 total (was 858)
          -1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131 with JDK v1.7.0_131 generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
                Other Tests
          -1 unit 0m 29s hadoop-common in the patch failed with JDK v1.7.0_131.
          -1 unit 0m 27s hadoop-yarn-api in the patch failed with JDK v1.7.0_131.
          +1 unit 2m 47s hadoop-yarn-common in the patch passed with JDK v1.7.0_131.
          -1 unit 0m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          94m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881546/HADOOP-14741-branch-2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux c50e9df6a852 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 2566e5f
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_131.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_131.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 18m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 59s Maven dependency ordering for branch +1 mvninstall 6m 39s branch-2 passed +1 compile 5m 53s branch-2 passed with JDK v1.8.0_144 +1 compile 6m 10s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 1m 23s branch-2 passed +1 mvnsite 2m 28s branch-2 passed +1 findbugs 5m 1s branch-2 passed +1 javadoc 1m 45s branch-2 passed with JDK v1.8.0_144 +1 javadoc 2m 3s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch -1 mvninstall 0m 25s hadoop-common in the patch failed. -1 mvninstall 0m 20s hadoop-yarn-api in the patch failed. -1 mvninstall 0m 19s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 0m 35s root in the patch failed with JDK v1.8.0_144. -1 javac 0m 35s root in the patch failed with JDK v1.8.0_144. -1 compile 0m 40s root in the patch failed with JDK v1.7.0_131. -1 javac 0m 40s root in the patch failed with JDK v1.7.0_131. -0 checkstyle 1m 23s root: The patch generated 1 new + 346 unchanged - 3 fixed = 347 total (was 349) -1 mvnsite 0m 27s hadoop-common in the patch failed. -1 mvnsite 0m 25s hadoop-yarn-api in the patch failed. -1 mvnsite 0m 22s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 0m 21s hadoop-common in the patch failed. -1 findbugs 0m 14s hadoop-yarn-api in the patch failed. -1 findbugs 0m 21s hadoop-yarn-server-resourcemanager in the patch failed. -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144 with JDK v1.8.0_144 generated 7 new + 854 unchanged - 4 fixed = 861 total (was 858) -1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131 with JDK v1.7.0_131 generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)       Other Tests -1 unit 0m 29s hadoop-common in the patch failed with JDK v1.7.0_131. -1 unit 0m 27s hadoop-yarn-api in the patch failed with JDK v1.7.0_131. +1 unit 2m 47s hadoop-yarn-common in the patch passed with JDK v1.7.0_131. -1 unit 0m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 94m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881546/HADOOP-14741-branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c50e9df6a852 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2566e5f Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.8.0_144.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_144.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_131.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_131.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13010/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12169 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12169/)
          HADOOP-14741. Refactor curator based ZooKeeper communication into common (subru: rev bbbf0e2a4136b30cad9dfd36ef138650a1adea60)

          • (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/package-info.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMZKUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ActiveStandbyElectorBasedElectorService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java
          • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java
          • (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/curator/TestZKCuratorManager.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12169 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12169/ ) HADOOP-14741 . Refactor curator based ZooKeeper communication into common (subru: rev bbbf0e2a4136b30cad9dfd36ef138650a1adea60) (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/package-info.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMZKUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ActiveStandbyElectorBasedElectorService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/curator/TestZKCuratorManager.java
          Hide
          elgoiri Íñigo Goiri added a comment -

          Kindly backporting to branch-2.

          Show
          elgoiri Íñigo Goiri added a comment - Kindly backporting to branch-2.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Íñigo Goiri for working on this. I committed to trunk but cherry-pick to branch-2 failed. So can you kindly post a patch for branch-2?

          Show
          subru Subru Krishnan added a comment - Thanks Íñigo Goiri for working on this. I committed to trunk but cherry-pick to branch-2 failed. So can you kindly post a patch for branch-2?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Inigo/Subru Krishnan for helping this, I may not have cycle to review this, please get it in when you think it is ready.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Inigo / Subru Krishnan for helping this, I may not have cycle to review this, please get it in when you think it is ready.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Inigo for contributing this. The latest patch (v5) LGTM.

          Zhe Zhang/Wangda Tan/Kai Zheng, do you guys want to take a quick look before I go ahead and commit this?

          Show
          subru Subru Krishnan added a comment - Thanks Inigo for contributing this. The latest patch (v5) LGTM. Zhe Zhang / Wangda Tan / Kai Zheng , do you guys want to take a quick look before I go ahead and commit this?
          Hide
          elgoiri Íñigo Goiri added a comment -

          I ran the failed unit test locally and worked.
          They didn't fail previously either.
          So I guess these are spurious, I think this is good to go.
          Comments?

          Show
          elgoiri Íñigo Goiri added a comment - I ran the failed unit test locally and worked. They didn't fail previously either. So I guess these are spurious, I think this is good to go. Comments?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 32s Maven dependency ordering for branch
          +1 mvninstall 19m 53s trunk passed
          +1 compile 17m 55s trunk passed
          +1 checkstyle 2m 34s trunk passed
          +1 mvnsite 4m 25s trunk passed
          +1 findbugs 6m 8s trunk passed
          +1 javadoc 2m 58s trunk passed
                Patch Compile Tests
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 2m 51s the patch passed
          +1 compile 13m 33s the patch passed
          +1 javac 13m 33s the patch passed
          +1 checkstyle 2m 35s root: The patch generated 0 new + 340 unchanged - 3 fixed = 340 total (was 343)
          +1 mvnsite 4m 53s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 7m 16s the patch passed
          +1 javadoc 1m 4s hadoop-common in the patch passed.
          +1 javadoc 0m 35s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 55s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 38s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)
                Other Tests
          -1 unit 9m 28s hadoop-common in the patch failed.
          +1 unit 0m 48s hadoop-yarn-api in the patch passed.
          +1 unit 3m 4s hadoop-yarn-common in the patch passed.
          -1 unit 48m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 42s The patch does not generate ASF License warnings.
          175m 53s



          Reason Tests
          Failed junit tests hadoop.security.TestRaceWhenRelogin
            hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881037/HADOOP-14741-005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux a079894088b9 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 63cfcb9
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 19m 53s trunk passed +1 compile 17m 55s trunk passed +1 checkstyle 2m 34s trunk passed +1 mvnsite 4m 25s trunk passed +1 findbugs 6m 8s trunk passed +1 javadoc 2m 58s trunk passed       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 51s the patch passed +1 compile 13m 33s the patch passed +1 javac 13m 33s the patch passed +1 checkstyle 2m 35s root: The patch generated 0 new + 340 unchanged - 3 fixed = 340 total (was 343) +1 mvnsite 4m 53s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 7m 16s the patch passed +1 javadoc 1m 4s hadoop-common in the patch passed. +1 javadoc 0m 35s hadoop-yarn-api in the patch passed. +1 javadoc 0m 55s hadoop-yarn-common in the patch passed. +1 javadoc 0m 38s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)       Other Tests -1 unit 9m 28s hadoop-common in the patch failed. +1 unit 0m 48s hadoop-yarn-api in the patch passed. +1 unit 3m 4s hadoop-yarn-common in the patch passed. -1 unit 48m 29s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 175m 53s Reason Tests Failed junit tests hadoop.security.TestRaceWhenRelogin   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881037/HADOOP-14741-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a079894088b9 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 63cfcb9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12993/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixed unit test and javadoc.

          Show
          elgoiri Íñigo Goiri added a comment - Fixed unit test and javadoc.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 0s Maven dependency ordering for branch
          +1 mvninstall 14m 25s trunk passed
          +1 compile 14m 36s trunk passed
          +1 checkstyle 2m 5s trunk passed
          +1 mvnsite 3m 32s trunk passed
          +1 findbugs 5m 12s trunk passed
          +1 javadoc 2m 34s trunk passed
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 20s the patch passed
          +1 compile 11m 1s the patch passed
          +1 javac 11m 1s the patch passed
          +1 checkstyle 2m 6s root: The patch generated 0 new + 340 unchanged - 3 fixed = 340 total (was 343)
          +1 mvnsite 3m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 5m 52s the patch passed
          -1 javadoc 0m 32s hadoop-yarn-server-resourcemanager in the patch failed.
                Other Tests
          -1 unit 8m 28s hadoop-common in the patch failed.
          +1 unit 0m 38s hadoop-yarn-api in the patch passed.
          +1 unit 2m 35s hadoop-yarn-common in the patch passed.
          +1 unit 42m 40s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          149m 8s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag
            hadoop.conf.TestCommonConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880941/HADOOP-14741-004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 1cb652635f87 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ad2a350
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 0s Maven dependency ordering for branch +1 mvninstall 14m 25s trunk passed +1 compile 14m 36s trunk passed +1 checkstyle 2m 5s trunk passed +1 mvnsite 3m 32s trunk passed +1 findbugs 5m 12s trunk passed +1 javadoc 2m 34s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 20s the patch passed +1 compile 11m 1s the patch passed +1 javac 11m 1s the patch passed +1 checkstyle 2m 6s root: The patch generated 0 new + 340 unchanged - 3 fixed = 340 total (was 343) +1 mvnsite 3m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 5m 52s the patch passed -1 javadoc 0m 32s hadoop-yarn-server-resourcemanager in the patch failed.       Other Tests -1 unit 8m 28s hadoop-common in the patch failed. +1 unit 0m 38s hadoop-yarn-api in the patch passed. +1 unit 2m 35s hadoop-yarn-common in the patch passed. +1 unit 42m 40s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 149m 8s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.conf.TestCommonConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880941/HADOOP-14741-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 1cb652635f87 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ad2a350 Default Java 1.8.0_131 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12989/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixed unit tests.

          Show
          elgoiri Íñigo Goiri added a comment - Fixed unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 1m 6s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 14m 34s trunk passed
          +1 compile 17m 3s trunk passed
          +1 checkstyle 2m 11s trunk passed
          +1 mvnsite 2m 51s trunk passed
          +1 findbugs 3m 43s trunk passed
          +1 javadoc 1m 50s trunk passed
                Patch Compile Tests
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 1m 50s the patch passed
          +1 compile 13m 39s the patch passed
          +1 javac 13m 39s the patch passed
          -0 checkstyle 2m 7s root: The patch generated 2 new + 321 unchanged - 3 fixed = 323 total (was 324)
          +1 mvnsite 2m 56s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 36s the patch passed
          +1 javadoc 1m 5s hadoop-common in the patch passed.
          +1 javadoc 0m 36s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 39s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)
                Other Tests
          -1 unit 7m 57s hadoop-common in the patch failed.
          +1 unit 0m 39s hadoop-yarn-api in the patch passed.
          -1 unit 49m 32s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          152m 37s



          Reason Tests
          Failed junit tests hadoop.net.TestDNS
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880904/HADOOP-14741-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 74ab56908060 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e0c2414
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 1m 6s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 14m 34s trunk passed +1 compile 17m 3s trunk passed +1 checkstyle 2m 11s trunk passed +1 mvnsite 2m 51s trunk passed +1 findbugs 3m 43s trunk passed +1 javadoc 1m 50s trunk passed       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 13m 39s the patch passed +1 javac 13m 39s the patch passed -0 checkstyle 2m 7s root: The patch generated 2 new + 321 unchanged - 3 fixed = 323 total (was 324) +1 mvnsite 2m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 36s the patch passed +1 javadoc 1m 5s hadoop-common in the patch passed. +1 javadoc 0m 36s hadoop-yarn-api in the patch passed. +1 javadoc 0m 39s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)       Other Tests -1 unit 7m 57s hadoop-common in the patch failed. +1 unit 0m 39s hadoop-yarn-api in the patch passed. -1 unit 49m 32s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 152m 37s Reason Tests Failed junit tests hadoop.net.TestDNS   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880904/HADOOP-14741-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 74ab56908060 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e0c2414 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12986/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixed unit tests.

          Show
          elgoiri Íñigo Goiri added a comment - Fixed unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 36s Maven dependency ordering for branch
          +1 mvninstall 14m 36s trunk passed
          +1 compile 14m 23s trunk passed
          +1 checkstyle 2m 1s trunk passed
          +1 mvnsite 2m 53s trunk passed
          +1 findbugs 4m 21s trunk passed
          +1 javadoc 1m 49s trunk passed
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 42s the patch passed
          +1 compile 10m 36s the patch passed
          +1 javac 10m 36s the patch passed
          +1 checkstyle 2m 14s root: The patch generated 0 new + 321 unchanged - 3 fixed = 321 total (was 324)
          +1 mvnsite 3m 2s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 35s the patch passed
          +1 javadoc 0m 56s hadoop-common in the patch passed.
          +1 javadoc 0m 32s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)
                Other Tests
          -1 unit 9m 9s hadoop-common in the patch failed.
          +1 unit 0m 42s hadoop-yarn-api in the patch passed.
          -1 unit 44m 35s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          143m 36s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.security.TestKDiag
            hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
            hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels
            hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA
            hadoop.yarn.server.resourcemanager.TestRMStoreCommands
            hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            hadoop.yarn.server.resourcemanager.TestReservationSystemWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880773/HADOOP-14741-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8a76438e13ed 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8d3fd81
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 1m 36s Maven dependency ordering for branch +1 mvninstall 14m 36s trunk passed +1 compile 14m 23s trunk passed +1 checkstyle 2m 1s trunk passed +1 mvnsite 2m 53s trunk passed +1 findbugs 4m 21s trunk passed +1 javadoc 1m 49s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 10m 36s the patch passed +1 javac 10m 36s the patch passed +1 checkstyle 2m 14s root: The patch generated 0 new + 321 unchanged - 3 fixed = 321 total (was 324) +1 mvnsite 3m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 35s the patch passed +1 javadoc 0m 56s hadoop-common in the patch passed. +1 javadoc 0m 32s hadoop-yarn-api in the patch passed. +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)       Other Tests -1 unit 9m 9s hadoop-common in the patch failed. +1 unit 0m 42s hadoop-yarn-api in the patch passed. -1 unit 44m 35s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 143m 36s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.security.TestKDiag   hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   hadoop.yarn.server.resourcemanager.TestRMHAForNodeLabels   hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA   hadoop.yarn.server.resourcemanager.TestRMStoreCommands   hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   hadoop.yarn.server.resourcemanager.TestReservationSystemWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880773/HADOOP-14741-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8a76438e13ed 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8d3fd81 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12977/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing compilation issues.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing compilation issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 27s Maven dependency ordering for branch
          +1 mvninstall 18m 15s trunk passed
          +1 compile 19m 38s trunk passed
          +1 checkstyle 2m 28s trunk passed
          +1 mvnsite 3m 56s trunk passed
          +1 findbugs 5m 35s trunk passed
          +1 javadoc 2m 37s trunk passed
                Patch Compile Tests
          0 mvndep 0m 23s Maven dependency ordering for patch
          -1 mvninstall 0m 30s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 5m 55s root in the patch failed.
          -1 javac 5m 55s root in the patch failed.
          +1 checkstyle 2m 23s root: The patch generated 0 new + 320 unchanged - 3 fixed = 320 total (was 323)
          -1 mvnsite 0m 40s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 58s hadoop-common in the patch passed.
          +1 javadoc 0m 29s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)
                Other Tests
          +1 unit 9m 45s hadoop-common in the patch passed.
          -1 unit 0m 40s hadoop-yarn-api in the patch failed.
          -1 unit 0m 34s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          108m 8s



          Reason Tests
          Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880749/HADOOP-14741-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 62c8d2fa5479 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c61f2c4
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-compile-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 1m 27s Maven dependency ordering for branch +1 mvninstall 18m 15s trunk passed +1 compile 19m 38s trunk passed +1 checkstyle 2m 28s trunk passed +1 mvnsite 3m 56s trunk passed +1 findbugs 5m 35s trunk passed +1 javadoc 2m 37s trunk passed       Patch Compile Tests 0 mvndep 0m 23s Maven dependency ordering for patch -1 mvninstall 0m 30s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 5m 55s root in the patch failed. -1 javac 5m 55s root in the patch failed. +1 checkstyle 2m 23s root: The patch generated 0 new + 320 unchanged - 3 fixed = 320 total (was 323) -1 mvnsite 0m 40s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 58s hadoop-common in the patch passed. +1 javadoc 0m 29s hadoop-yarn-api in the patch passed. +1 javadoc 0m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)       Other Tests +1 unit 9m 45s hadoop-common in the patch passed. -1 unit 0m 40s hadoop-yarn-api in the patch failed. -1 unit 0m 34s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 108m 8s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880749/HADOOP-14741-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 62c8d2fa5479 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c61f2c4 Default Java 1.8.0_131 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-compile-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12975/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 15m 14s trunk passed
          +1 compile 15m 9s trunk passed
          +1 checkstyle 2m 38s trunk passed
          +1 mvnsite 3m 6s trunk passed
          +1 findbugs 3m 44s trunk passed
          +1 javadoc 1m 45s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          -1 mvninstall 0m 22s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 4m 9s root in the patch failed.
          -1 javac 4m 9s root in the patch failed.
          -0 checkstyle 1m 57s root: The patch generated 8 new + 246 unchanged - 3 fixed = 254 total (was 249)
          -1 mvnsite 0m 25s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 47s hadoop-common in the patch passed.
          +1 javadoc 0m 22s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)
                Other Tests
          -1 unit 7m 9s hadoop-common in the patch failed.
          -1 unit 0m 31s hadoop-yarn-api in the patch failed.
          -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          87m 24s



          Reason Tests
          Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
            hadoop.yarn.conf.TestYarnConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14741
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880717/HADOOP-14741-000.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ffc0ebfd530b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bc20680
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-compile-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 15m 14s trunk passed +1 compile 15m 9s trunk passed +1 checkstyle 2m 38s trunk passed +1 mvnsite 3m 6s trunk passed +1 findbugs 3m 44s trunk passed +1 javadoc 1m 45s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch -1 mvninstall 0m 22s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 4m 9s root in the patch failed. -1 javac 4m 9s root in the patch failed. -0 checkstyle 1m 57s root: The patch generated 8 new + 246 unchanged - 3 fixed = 254 total (was 249) -1 mvnsite 0m 25s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 21s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 47s hadoop-common in the patch passed. +1 javadoc 0m 22s hadoop-yarn-api in the patch passed. +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 348 unchanged - 4 fixed = 348 total (was 352)       Other Tests -1 unit 7m 9s hadoop-common in the patch failed. -1 unit 0m 31s hadoop-yarn-api in the patch failed. -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 87m 24s Reason Tests Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14741 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880717/HADOOP-14741-000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ffc0ebfd530b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bc20680 Default Java 1.8.0_131 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12972/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Tackling Subru Krishnan comments.

          Show
          elgoiri Íñigo Goiri added a comment - Tackling Subru Krishnan comments.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Inigo for working on this. I am fine with merging the configurations as:

          • I feel strongly that we already have way too many config knobs already.
          • From what I have observed in production deployments, RMs and NNs are deployed on different physical machines so they could still have different values (i.e. role based configuration). Additionally, even in same machines you can set the hadoop confs per process.

          Regarding the patch itself, I just have a few minor comments:

          • CuratorManager --> ZKCuratorManager (or CuratorZKManager).
          • The keys should be defined in CommonConfigurationKeys so that they can be overridden via core-site.xml.
          • Can you add exists check before and after we do an op in the tests.
          • Nit: some public methods are missing Javadocs.
          Show
          subru Subru Krishnan added a comment - Thanks Inigo for working on this. I am fine with merging the configurations as: I feel strongly that we already have way too many config knobs already. From what I have observed in production deployments, RMs and NNs are deployed on different physical machines so they could still have different values (i.e. role based configuration). Additionally, even in same machines you can set the hadoop confs per process. Regarding the patch itself, I just have a few minor comments: CuratorManager --> ZKCuratorManager (or CuratorZKManager ). The keys should be defined in CommonConfigurationKeys so that they can be overridden via core-site.xml . Can you add exists check before and after we do an op in the tests. Nit: some public methods are missing Javadocs.
          Hide
          elgoiri Íñigo Goiri added a comment -

          The main problem about unifying is that with the current proposal, all the curators are configured with the same parameters (i.e., same ZK address). Personally, we are OK with that but I understand there might be other deployments with finer-grain requirements.

          Show
          elgoiri Íñigo Goiri added a comment - The main problem about unifying is that with the current proposal, all the curators are configured with the same parameters (i.e., same ZK address). Personally, we are OK with that but I understand there might be other deployments with finer-grain requirements.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Proposal for refactor.

          Show
          elgoiri Íñigo Goiri added a comment - Proposal for refactor.

            People

            • Assignee:
              elgoiri Íñigo Goiri
              Reporter:
              subru Subru Krishnan
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development