Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0-beta
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      YarnVersionAnnotation is not used at all, and the version information can be accessed through YarnVersionInfo instead.

        Issue Links

          Activity

          Hide
          Zhijie Shen added a comment -

          The patch removes YarnVersionAnnotation.

          Show
          Zhijie Shen added a comment - The patch removes YarnVersionAnnotation.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12588008/YARN-828.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1267//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1267//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12588008/YARN-828.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1267//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1267//console This message is automatically generated.
          Hide
          Zhijie Shen added a comment -

          Simple class removal, it should be fine without additional tests.

          Show
          Zhijie Shen added a comment - Simple class removal, it should be fine without additional tests.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          This was added in MAPREDUCE-279, when we originally open-sourced YARN. Checked with Siddharth Seth too and we've no idea of its purpose. We may need it for rolling-upgrades, but can add it as and when it is really needed.

          +1 for this. Checking it in.

          Show
          Vinod Kumar Vavilapalli added a comment - This was added in MAPREDUCE-279 , when we originally open-sourced YARN. Checked with Siddharth Seth too and we've no idea of its purpose. We may need it for rolling-upgrades, but can add it as and when it is really needed. +1 for this. Checking it in.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Committed this to trunk, branch-2 and branch-2.1. Thanks Zhijie!

          Marked this incompatible just in case some alpha user was using it. Just in case.

          Show
          Vinod Kumar Vavilapalli added a comment - Committed this to trunk, branch-2 and branch-2.1. Thanks Zhijie! Marked this incompatible just in case some alpha user was using it. Just in case.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3940 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3940/)
          YARN-828. Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3940 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3940/ ) YARN-828 . Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #243 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/243/)
          YARN-828. Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #243 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/243/ ) YARN-828 . Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1433 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1433/)
          YARN-828. Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592)

          Result = FAILURE
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1433 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1433/ ) YARN-828 . Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1460 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1460/)
          YARN-828. Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1460 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1460/ ) YARN-828 . Removed the unsed YarnVersionAnnotation. Contributed by Zhijie Shen. (Revision 1493592) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1493592 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java

            People

            • Assignee:
              Zhijie Shen
              Reporter:
              Zhijie Shen
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development