Tx for the review, Sid.
A lot of the public classes need Javadoc. I think a follow-up jira can be used for this, which shouldn't block 2.1.0 (assuming 2.1.1 will be soon after).
Also, there's a bunch of non-annotated classes in yarn-api as well - YarnException, YarnRuntimeException, YarnConfiguration, RecordFactory* being some of the important ones.
That is being done at
Unrelated, should the PBImpls be moved from yarn-api to yarn-common (They're private anyway).
Saw that and wanted to check with you before doing it. +1.
AggregatedLogsDeletionService - Private to LimitedPrivate. Used in the MR history server since a Yarn log/app history server does not exist. I don't mind leaving this as Private as well though - since it's use in MR is temporary.
Yeah, it is temporary so marked it private. Will leave it at that.
Should ClientToAMTokenSecretManager be final, or do you think there's use cases where users may want to extend this.
Should ServiceStateModel be private
ApplicaionClassLoader - leave as Unstable ?
Until Apps, ConverterUtils etc are cleaned up - mark them as private ? Apps.addToEnvironment should be public though.
ResourceCalculatorPlugin and related classes - public Unstable or LimitedPrivate. This is already used in MapReduce
Similarly for RackResolver
Unrelated, should ApplcaitionTokenIdentifer be renamed to something like AMTokenIdentifier ?
Yes, I remember Omkar had a patch for this.