[YARN-8096] Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.2.0
• Hadoop Flags: Reviewed
• Assignee: Oleksandr Shevchenko
• Reporter: Oleksandr Shevchenko
• Created: 30/Mar/18 14:25
• Updated: 17/Apr/18 20:46
• Resolved: 17/Apr/18 20:08

Description

In AmIpFilter#getProxyAddresses() we have the following condition:

 if (proxyAddresses == null || (lastUpdate + UPDATE_INTERVAL) >= now) { 
   //update RM address 
 }

By design, the address should be updated if the last update was more then 5 min ago. But as we see this condition is wrong.

Currently, RM address updates permanently. But after 5 minutes after the last update, RM address will never be updated again. As a result, we are always redirected to the fail page that was added by YARN-4767, even if a network issue is resolved now.

So, we should change this condition to:

 if (proxyAddresses == null || (lastUpdate + UPDATE_INTERVAL) <= now) \{ 
   //update RM address 
 }