Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-8096

Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In AmIpFilter#getProxyAddresses() we have the following condition:

       if (proxyAddresses == null || (lastUpdate + UPDATE_INTERVAL) >= now) { 
         //update RM address 
       }
      

      By design, the address should be updated if the last update was more then 5 min ago. But as we see this condition is wrong.

      Currently, RM address updates permanently. But after 5 minutes after the last update, RM address will never be updated again. As a result, we are always redirected to the fail page that was added by YARN-4767, even if a network issue is resolved now.

      So, we should change this condition to:

       if (proxyAddresses == null || (lastUpdate + UPDATE_INTERVAL) <= now) \{ 
         //update RM address 
       }
      

        Attachments

        1. YARN-8096.001.patch
          1 kB
          Oleksandr Shevchenko
        2. YARN-8096.002.patch
          5 kB
          Oleksandr Shevchenko
        3. YARN-8096.003.patch
          5 kB
          Oleksandr Shevchenko

          Activity

            People

            • Assignee:
              oshevchenko Oleksandr Shevchenko
              Reporter:
              oshevchenko Oleksandr Shevchenko
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: