[YARN-7647] NM print inappropriate error log when node-labels is enabled

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0, 3.0.0-alpha1
• Fix Version/s: 2.8.2, 3.1.0, 2.10.0, 2.9.1, 3.0.1
• Target Version/s: 2.8.2, 3.1.0, 2.9.1, 3.0.1
• Hadoop Flags: Reviewed
• Assignee: Yang Wang
• Reporter: Yang Wang
• Created: 13/Dec/17 03:25
• Updated: 13/Dec/17 05:35
• Resolved: 13/Dec/17 05:14

Description

NodeStatusUpdaterImpl.java

      ... ...
      if (response.getAreNodeLabelsAcceptedByRM() && LOG.isDebugEnabled()) {
          LOG.debug("Node Labels {" + StringUtils.join(",", previousNodeLabels)
              + "} were Accepted by RM ");
        } else {
          // case where updated labels from NodeLabelsProvider is sent to RM and
          // RM rejected the labels
          LOG.error(
              "NM node labels {" + StringUtils.join(",", previousNodeLabels)
                  + "} were not accepted by RM and message from RM : "
                  + response.getDiagnosticsMessage());
        }
      ... ...

When LOG.isDebugEnabled() is false, NM will always print error log. It is an obvious error and is so misleading.

Issue Links

• is broken by: YARN-4176 Resync NM nodelabels with RM periodically for distributed nodelabels