Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7647

NM print inappropriate error log when node-labels is enabled

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.8.0, 3.0.0-alpha1
    • 2.8.2, 3.1.0, 2.10.0, 2.9.1, 3.0.1
    • None
    • None

    Description

      NodeStatusUpdaterImpl.java
            ... ...
            if (response.getAreNodeLabelsAcceptedByRM() && LOG.isDebugEnabled()) {
                LOG.debug("Node Labels {" + StringUtils.join(",", previousNodeLabels)
                    + "} were Accepted by RM ");
              } else {
                // case where updated labels from NodeLabelsProvider is sent to RM and
                // RM rejected the labels
                LOG.error(
                    "NM node labels {" + StringUtils.join(",", previousNodeLabels)
                        + "} were not accepted by RM and message from RM : "
                        + response.getDiagnosticsMessage());
              }
            ... ...
      

      When LOG.isDebugEnabled() is false, NM will always print error log. It is an obvious error and is so misleading.

      Attachments

        1. YARN-7647.001.patch
          1 kB
          Yang Wang

        Issue Links

          Activity

            People

              wangyang0918 Yang Wang
              wangyang0918 Yang Wang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: