[YARN-7023] Incorrect ReservationId.compareTo() implementation

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.6.0, 3.0.0-alpha1
• Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.2, 3.1.0
• Component/s: reservation system
• Hadoop Flags: Reviewed
• Flags: Patch
• Assignee: Oleg Danilov
• Reporter: Oleg Danilov
• Created: 16/Aug/17 12:18
• Updated: 02/May/18 09:28
• Resolved: 01/Sep/17 19:39

Description

Obviously this is a typo and the second getId() call should be rewritten as 'other.getId()'

Lines 94-102

  @Override
  public int compareTo(ReservationId other) {
    if (this.getClusterTimestamp() - other.getClusterTimestamp() == 0) {
      return getId() > getId() ? 1 : getId() < getId() ? -1 : 0;
    } else {
      return this.getClusterTimestamp() > other.getClusterTimestamp() ? 1
          : this.getClusterTimestamp() < other.getClusterTimestamp() ? -1 : 0;
    }
  }

Issue Links

• duplicates: YARN-6296 ReservationId.compareTo ignores id when clustertimestamp is the same
• links to: GitHub Pull Request #262