[YARN-6296] ReservationId.compareTo ignores id when clustertimestamp is the same

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.0.0-alpha2
• Labels: newbie
• Assignee: Unassigned
• Reporter: Haibo Chen
• Created: 07/Mar/17 19:14
• Updated: 02/May/18 09:28
• Resolved: 02/May/18 09:28

Description

Per YARN-6252

  public int compareTo(ReservationId other) {
    if (this.getClusterTimestamp() - other.getClusterTimestamp() == 0) {
      return getId() > getId() ? 1 : getId() < getId() ? -1 : 0;
    } else {
    }
  }

compares id with itself. It should be

return this.getId() > other.getId() ? 1 : (this.getId() < other.getId() ? -1 : 0);

Issue Links

• is duplicated by: YARN-7023 Incorrect ReservationId.compareTo() implementation
• is related to: YARN-6252 Suspicious code fragments: comparing with itself