Description
Container update is introduced in YARN-5221. Federation Interceptor needs to support it when splitting (merging) the allocate request (response).
Public signup for this instance is disabled. Go to our Self serve sign up page to request an account. Report potential security issues privately
Container update is introduced in YARN-5221. Federation Interceptor needs to support it when splitting (merging) the allocate request (response).
Thanks Botong Huang for working on this. The patch itself LGTM, can you please add a simple test?
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 17s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
trunk Compile Tests | |||
+1 | mvninstall | 13m 48s | trunk passed |
+1 | compile | 0m 42s | trunk passed |
+1 | checkstyle | 0m 19s | trunk passed |
+1 | mvnsite | 0m 28s | trunk passed |
-1 | findbugs | 0m 44s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 1 extant Findbugs warnings. |
+1 | javadoc | 0m 18s | trunk passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 25s | the patch passed |
+1 | compile | 0m 41s | the patch passed |
+1 | javac | 0m 41s | the patch passed |
+1 | checkstyle | 0m 15s | the patch passed |
+1 | mvnsite | 0m 26s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 0m 49s | the patch passed |
+1 | javadoc | 0m 15s | the patch passed |
Other Tests | |||
-1 | unit | 14m 16s | hadoop-yarn-server-nodemanager in the patch failed. |
+1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
35m 19s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.yarn.server.nodemanager.containermanager.TestContainerManager |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:71bbb86 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887937/YARN-6962.v2.patch |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux 77a2eab87357 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 31b5840 |
Default Java | 1.8.0_144 |
findbugs | v3.1.0-RC1 |
findbugs | https://builds.apache.org/job/PreCommit-YARN-Build/17518/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html |
unit | https://builds.apache.org/job/PreCommit-YARN-Build/17518/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17518/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17518/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
testContainerUpdateExecTypeOpportunisticToGuaranteed failure is not related, and being handled in YARN-7196.
Thanks Botong Huang for adding the test, +1 on the latest patch.
Thanks Botong Huang for the contribution, I committed this to trunk/branch-2.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12992 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12992/)
YARN-6962. Add support for updateContainers when allocating using (subru: rev ca669f9f8bc7abe5b7d4648c589aa1756bd336d1)
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14057/)
YARN-6962. Add support for updateContainers when allocating using (xyao: rev f90381ea3e595e6a47136e3747dda69fd4d30780)
YARN-6962This message was automatically generated.