Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5221

Expose UpdateResourceRequest API to allow AM to request for change in container properties

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      YARN-1197 introduced APIs to allow an AM to request for Increase and Decrease of Container Resources after initial allocation.
      YARN-5085 proposes to allow an AM to request for a change of Container ExecutionType.
      This JIRA proposes to unify both of the above into an Update Container API.

      1. YARN-5221.001.patch
        121 kB
        Arun Suresh
      2. YARN-5221.002.patch
        125 kB
        Arun Suresh
      3. YARN-5221.003.patch
        176 kB
        Arun Suresh
      4. YARN-5221.004.patch
        178 kB
        Arun Suresh
      5. YARN-5221.005.patch
        233 kB
        Arun Suresh
      6. YARN-5221.006.patch
        250 kB
        Arun Suresh
      7. YARN-5221.007.patch
        252 kB
        Arun Suresh
      8. YARN-5221.008.patch
        253 kB
        Arun Suresh
      9. YARN-5221.009.patch
        269 kB
        Arun Suresh
      10. YARN-5221.010.patch
        268 kB
        Arun Suresh
      11. YARN-5221.011.patch
        270 kB
        Arun Suresh
      12. YARN-5221.012.patch
        270 kB
        Arun Suresh
      13. YARN-5221.013.patch
        270 kB
        Arun Suresh
      14. YARN-5221-branch-2.8-v1.patch
        259 kB
        Arun Suresh
      15. YARN-5221-branch-2-v1.patch
        266 kB
        Arun Suresh

        Issue Links

          Activity

          Hide
          asuresh Arun Suresh added a comment -

          As per discussions with Wangda Tan, Vinod Kumar Vavilapalli, Karthik Kambatla and Subru Krishnan :

          This JIRA proposes the following :

          • Introduce a new container version field to Container
          • Introduce an UpdateContainerRequest record that consists of
            • current container version
            • container Id
            • new capability
            • new execution type
          • Remove the increase_requests and decrease_requests lists in the AllocateRequest and replace with update_requests which is a list of UpdateContainerRequest records
          • Remove the increased_containers and decreases_containers lists in the AllocateResponse and replace with updated_containers which is a list Container records. The containers whose update requests are satisfied by the RM will be returned with the container version incremented.
          Show
          asuresh Arun Suresh added a comment - As per discussions with Wangda Tan , Vinod Kumar Vavilapalli , Karthik Kambatla and Subru Krishnan : This JIRA proposes the following : Introduce a new container version field to Container Introduce an UpdateContainerRequest record that consists of current container version container Id new capability new execution type Remove the increase_requests and decrease_requests lists in the AllocateRequest and replace with update_requests which is a list of UpdateContainerRequest records Remove the increased_containers and decreases_containers lists in the AllocateResponse and replace with updated_containers which is a list Container records. The containers whose update requests are satisfied by the RM will be returned with the container version incremented.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks for summarizing this, Arun Suresh!

          MENG DING, could you take a look at this proposal as well?

          Show
          leftnoteasy Wangda Tan added a comment - Thanks for summarizing this, Arun Suresh ! MENG DING , could you take a look at this proposal as well?
          Hide
          asuresh Arun Suresh added a comment -

          Attaching initial patch that refactors all the api.
          The patch does not propagate the container version to the Scheduler/RMContainer yet.. The purpose of the patch is to ensure that the change does not break anything.
          Wangda Tan, Karthik Kambatla.. do take a look..

          Show
          asuresh Arun Suresh added a comment - Attaching initial patch that refactors all the api. The patch does not propagate the container version to the Scheduler/RMContainer yet.. The purpose of the patch is to ensure that the change does not break anything. Wangda Tan , Karthik Kambatla .. do take a look..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 37s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 7m 8s trunk passed
          +1 checkstyle 1m 36s trunk passed
          +1 mvnsite 3m 8s trunk passed
          +1 mvneclipse 1m 34s trunk passed
          +1 findbugs 5m 8s trunk passed
          +1 javadoc 2m 10s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 2m 34s the patch passed
          +1 compile 6m 45s the patch passed
          +1 cc 6m 45s the patch passed
          +1 javac 6m 45s the patch passed
          -1 checkstyle 1m 40s root: The patch generated 21 new + 1186 unchanged - 18 fixed = 1207 total (was 1204)
          +1 mvnsite 3m 9s the patch passed
          +1 mvneclipse 1m 36s the patch passed
          -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 6m 1s the patch passed
          -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)
          +1 unit 0m 26s hadoop-yarn-api in the patch passed.
          -1 unit 2m 12s hadoop-yarn-common in the patch failed.
          -1 unit 12m 1s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 31m 59s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 67m 28s hadoop-yarn-client in the patch failed.
          -1 unit 7m 57s hadoop-mapreduce-client-app in the patch failed.
          -1 unit 0m 33s hadoop-sls in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          177m 23s



          Reason Tests
          Failed junit tests hadoop.yarn.api.TestPBImplRecords
            hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestApplicationMasterService
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.api.impl.TestDistributedScheduling
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.api.impl.TestAMRMClientOnRMRestart
            hadoop.mapreduce.v2.app.rm.TestRMContainerAllocator
            hadoop.yarn.sls.TestSLSRunner
          Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809354/YARN-5221.001.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux e879a2b94d42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9581fb7
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/whitespace-eol.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11953/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11953/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 7m 8s trunk passed +1 checkstyle 1m 36s trunk passed +1 mvnsite 3m 8s trunk passed +1 mvneclipse 1m 34s trunk passed +1 findbugs 5m 8s trunk passed +1 javadoc 2m 10s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 2m 34s the patch passed +1 compile 6m 45s the patch passed +1 cc 6m 45s the patch passed +1 javac 6m 45s the patch passed -1 checkstyle 1m 40s root: The patch generated 21 new + 1186 unchanged - 18 fixed = 1207 total (was 1204) +1 mvnsite 3m 9s the patch passed +1 mvneclipse 1m 36s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 6m 1s the patch passed -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156) +1 unit 0m 26s hadoop-yarn-api in the patch passed. -1 unit 2m 12s hadoop-yarn-common in the patch failed. -1 unit 12m 1s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 31m 59s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 67m 28s hadoop-yarn-client in the patch failed. -1 unit 7m 57s hadoop-mapreduce-client-app in the patch failed. -1 unit 0m 33s hadoop-sls in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 177m 23s Reason Tests Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.api.impl.TestDistributedScheduling   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.api.impl.TestAMRMClientOnRMRestart   hadoop.mapreduce.v2.app.rm.TestRMContainerAllocator   hadoop.yarn.sls.TestSLSRunner Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809354/YARN-5221.001.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux e879a2b94d42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9581fb7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt https://builds.apache.org/job/PreCommit-YARN-Build/11953/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11953/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11953/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Updating patch to fix test-cases

          Show
          asuresh Arun Suresh added a comment - Updating patch to fix test-cases
          Hide
          mding MENG DING added a comment -

          Hi, Wangda Tan

          I have not been following this for a while, but it does make sense to merge any change to a container into one unified API. Just to be sure, this won't have any compatibility issue since the container resize feature is not out officially yet, right?

          Also, are users allowed to increase AND decrease different resource index in one update API, since we call it "update" now?

          Arun Suresh, when this ticket is completed, will you be able to update YARN-4175 for an update example? This may be useful for people who are already prototyping with the container resize feature.

          Thanks,
          Meng

          Show
          mding MENG DING added a comment - Hi, Wangda Tan I have not been following this for a while, but it does make sense to merge any change to a container into one unified API. Just to be sure, this won't have any compatibility issue since the container resize feature is not out officially yet, right? Also, are users allowed to increase AND decrease different resource index in one update API, since we call it "update" now? Arun Suresh , when this ticket is completed, will you be able to update YARN-4175 for an update example? This may be useful for people who are already prototyping with the container resize feature. Thanks, Meng
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 12s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 1m 35s trunk passed
          +1 mvnsite 3m 10s trunk passed
          +1 mvneclipse 1m 30s trunk passed
          +1 findbugs 5m 21s trunk passed
          +1 javadoc 2m 7s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 2m 37s the patch passed
          +1 compile 6m 49s the patch passed
          +1 cc 6m 49s the patch passed
          +1 javac 6m 49s the patch passed
          -1 checkstyle 1m 34s root: The patch generated 31 new + 1186 unchanged - 18 fixed = 1217 total (was 1204)
          +1 mvnsite 3m 11s the patch passed
          +1 mvneclipse 1m 32s the patch passed
          -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 6m 8s the patch passed
          -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)
          +1 unit 0m 26s hadoop-yarn-api in the patch passed.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed.
          +1 unit 12m 5s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 35m 38s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 67m 47s hadoop-yarn-client in the patch failed.
          +1 unit 8m 41s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 55s hadoop-sls in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          181m 33s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.cli.TestLogsCLI
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.api.impl.TestDistributedScheduling
          Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809462/YARN-5221.002.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 855c924aecd7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0b7b8a3
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/whitespace-eol.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11972/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11972/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 3m 10s trunk passed +1 mvneclipse 1m 30s trunk passed +1 findbugs 5m 21s trunk passed +1 javadoc 2m 7s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 2m 37s the patch passed +1 compile 6m 49s the patch passed +1 cc 6m 49s the patch passed +1 javac 6m 49s the patch passed -1 checkstyle 1m 34s root: The patch generated 31 new + 1186 unchanged - 18 fixed = 1217 total (was 1204) +1 mvnsite 3m 11s the patch passed +1 mvneclipse 1m 32s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 6m 8s the patch passed -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156) +1 unit 0m 26s hadoop-yarn-api in the patch passed. +1 unit 2m 12s hadoop-yarn-common in the patch passed. +1 unit 12m 5s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 35m 38s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 67m 47s hadoop-yarn-client in the patch failed. +1 unit 8m 41s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 55s hadoop-sls in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 181m 33s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestLogsCLI   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.api.impl.TestDistributedScheduling Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809462/YARN-5221.002.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 855c924aecd7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0b7b8a3 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/11972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11972/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11972/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          MENG DING

          when this ticket is completed, will you be able to update YARN-4175 for an update example?

          Sure.. will do

          Can you / Wangda Tan please take a look at the latest patch, given that Container Resizing is due for 2.8.0, It maybe better for it go with the new API..

          Thoughts ?

          Show
          asuresh Arun Suresh added a comment - MENG DING when this ticket is completed, will you be able to update YARN-4175 for an update example? Sure.. will do Can you / Wangda Tan please take a look at the latest patch, given that Container Resizing is due for 2.8.0, It maybe better for it go with the new API.. Thoughts ?
          Hide
          asuresh Arun Suresh added a comment -

          Rebasing with trunk.. and included some container version plumbing..
          Will add more testcases shortly..

          Show
          asuresh Arun Suresh added a comment - Rebasing with trunk.. and included some container version plumbing.. Will add more testcases shortly..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 33 new or modified test files.
          0 mvndep 5m 28s Maven dependency ordering for branch
          +1 mvninstall 6m 39s trunk passed
          +1 compile 6m 42s trunk passed
          +1 checkstyle 1m 44s trunk passed
          +1 mvnsite 3m 51s trunk passed
          +1 mvneclipse 2m 0s trunk passed
          +1 findbugs 6m 12s trunk passed
          +1 javadoc 2m 30s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 3m 8s the patch passed
          +1 compile 6m 31s the patch passed
          +1 cc 6m 31s the patch passed
          +1 javac 6m 31s the patch passed
          -1 checkstyle 1m 48s root: The patch generated 34 new + 1985 unchanged - 26 fixed = 2019 total (was 2011)
          +1 mvnsite 3m 50s the patch passed
          +1 mvneclipse 1m 56s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 7m 52s the patch passed
          -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)
          -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 989 unchanged - 0 fixed = 991 total (was 989)
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed.
          +1 unit 0m 26s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 18s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 32m 24s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 6m 26s hadoop-yarn-server-tests in the patch failed.
          -1 unit 7m 50s hadoop-yarn-client in the patch failed.
          +1 unit 8m 40s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 54s hadoop-sls in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          138m 4s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.client.cli.TestLogsCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810961/YARN-5221.003.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux ed831603935a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5dfc38f
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12031/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12031/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 33 new or modified test files. 0 mvndep 5m 28s Maven dependency ordering for branch +1 mvninstall 6m 39s trunk passed +1 compile 6m 42s trunk passed +1 checkstyle 1m 44s trunk passed +1 mvnsite 3m 51s trunk passed +1 mvneclipse 2m 0s trunk passed +1 findbugs 6m 12s trunk passed +1 javadoc 2m 30s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 3m 8s the patch passed +1 compile 6m 31s the patch passed +1 cc 6m 31s the patch passed +1 javac 6m 31s the patch passed -1 checkstyle 1m 48s root: The patch generated 34 new + 1985 unchanged - 26 fixed = 2019 total (was 2011) +1 mvnsite 3m 50s the patch passed +1 mvneclipse 1m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 7m 52s the patch passed -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156) -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 989 unchanged - 0 fixed = 991 total (was 989) +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 11s hadoop-yarn-common in the patch passed. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed. +1 unit 13m 18s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 32m 24s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 6m 26s hadoop-yarn-server-tests in the patch failed. -1 unit 7m 50s hadoop-yarn-client in the patch failed. +1 unit 8m 40s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 54s hadoop-sls in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 138m 4s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.client.cli.TestLogsCLI Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810961/YARN-5221.003.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux ed831603935a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5dfc38f Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12031/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12031/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12031/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Uploading new patch:

          1. Fixing TestIncreaseAllocationExpirer, the remaining test case errors are spurious
          2. Fixing javadocs and some of the checkstyles
          Show
          asuresh Arun Suresh added a comment - Uploading new patch: Fixing TestIncreaseAllocationExpirer , the remaining test case errors are spurious Fixing javadocs and some of the checkstyles
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 35s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 33 new or modified test files.
          0 mvndep 0m 30s Maven dependency ordering for branch
          +1 mvninstall 6m 18s trunk passed
          +1 compile 6m 29s trunk passed
          +1 checkstyle 1m 48s trunk passed
          +1 mvnsite 3m 44s trunk passed
          +1 mvneclipse 1m 59s trunk passed
          +1 findbugs 6m 9s trunk passed
          +1 javadoc 2m 47s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 3m 13s the patch passed
          +1 compile 6m 51s the patch passed
          +1 cc 6m 51s the patch passed
          +1 javac 6m 51s the patch passed
          -1 checkstyle 1m 53s root: The patch generated 26 new + 1985 unchanged - 26 fixed = 2011 total (was 2011)
          +1 mvnsite 4m 0s the patch passed
          +1 mvneclipse 2m 4s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 7m 23s the patch passed
          +1 javadoc 0m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 151 unchanged - 5 fixed = 151 total (was 156)
          +1 javadoc 0m 30s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 18s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 974 unchanged - 15 fixed = 974 total (was 989)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 13s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 13s hadoop-sls in the patch passed.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 8s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 36m 26s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 6m 21s hadoop-yarn-server-tests in the patch failed.
          -1 unit 7m 56s hadoop-yarn-client in the patch failed.
          +1 unit 9m 13s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 54s hadoop-sls in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          137m 45s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.client.api.impl.TestYarnClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811066/YARN-5221.004.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 38561428da44 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2ca7344
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12035/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12035/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 33 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 6m 18s trunk passed +1 compile 6m 29s trunk passed +1 checkstyle 1m 48s trunk passed +1 mvnsite 3m 44s trunk passed +1 mvneclipse 1m 59s trunk passed +1 findbugs 6m 9s trunk passed +1 javadoc 2m 47s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 3m 13s the patch passed +1 compile 6m 51s the patch passed +1 cc 6m 51s the patch passed +1 javac 6m 51s the patch passed -1 checkstyle 1m 53s root: The patch generated 26 new + 1985 unchanged - 26 fixed = 2011 total (was 2011) +1 mvnsite 4m 0s the patch passed +1 mvneclipse 2m 4s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 7m 23s the patch passed +1 javadoc 0m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 151 unchanged - 5 fixed = 151 total (was 156) +1 javadoc 0m 30s hadoop-yarn-common in the patch passed. +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 18s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 974 unchanged - 15 fixed = 974 total (was 989) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 13s hadoop-yarn-client in the patch passed. +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 13s hadoop-sls in the patch passed. +1 unit 0m 24s hadoop-yarn-api in the patch passed. +1 unit 2m 9s hadoop-yarn-common in the patch passed. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed. +1 unit 13m 8s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 36m 26s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 6m 21s hadoop-yarn-server-tests in the patch failed. -1 unit 7m 56s hadoop-yarn-client in the patch failed. +1 unit 9m 13s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 54s hadoop-sls in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 137m 45s Reason Tests Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811066/YARN-5221.004.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 38561428da44 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2ca7344 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12035/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12035/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12035/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Arun Suresh,

          A couple of comments, haven't reviewed test code yet:

          1) How to handle container version mismatch issue or other issues which cause update failure? Now in the patch some are reported to AM as exception, some are silently recorded in RM's log, should we add a new list to AllocateResponse to let client know about failed-to-update containers?

          2) org.apache.hadoop.yarn.server.resourcemanager.scheduler.Allocation: should we merge increase/decrease container list?

          3) getVersion of Container should be @Public/Unstable? Will it be used by end user? Probably it's better to make it to be long to avoid future changes. (Like we need sparsity in version number)

          4) For UpdateContainerRequest, should we document following behaviors:

          • Can we update multiple fields of container at the same time?
          • What happened if we send two different update request for the same container? (First one increased container size, and second one update execution type)

          5) Even though ContainerTokenIdentifier is evolving API, we can break it bylaw. But it's better to avoid changing the API as much as possible.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Arun Suresh , A couple of comments, haven't reviewed test code yet: 1) How to handle container version mismatch issue or other issues which cause update failure? Now in the patch some are reported to AM as exception, some are silently recorded in RM's log, should we add a new list to AllocateResponse to let client know about failed-to-update containers? 2) org.apache.hadoop.yarn.server.resourcemanager.scheduler.Allocation: should we merge increase/decrease container list? 3) getVersion of Container should be @Public/Unstable? Will it be used by end user? Probably it's better to make it to be long to avoid future changes. (Like we need sparsity in version number) 4) For UpdateContainerRequest, should we document following behaviors: Can we update multiple fields of container at the same time? What happened if we send two different update request for the same container? (First one increased container size, and second one update execution type) 5) Even though ContainerTokenIdentifier is evolving API, we can break it bylaw. But it's better to avoid changing the API as much as possible.
          Hide
          asuresh Arun Suresh added a comment -

          Thanks for the review Wangda Tan

          How to handle container version mismatch issue or other issues which cause update failure?

          In the patch, the checking is done in the ApplicationMasterService and it just logs the mismatch. I agree, let me update the AllocateResponse to include something like failed update requests (with a message giving the reason)

          org.apache.hadoop.yarn.server.resourcemanager.scheduler.Allocation: should we merge increase/decrease container list ?

          We could, but since that is not part of the API per se I was thinking that maybe its fine as it is.. we can probably file a follow-up JIRA

          I agree with the rest of your comments... will update the patch shortly addressing them.

          Show
          asuresh Arun Suresh added a comment - Thanks for the review Wangda Tan How to handle container version mismatch issue or other issues which cause update failure? In the patch, the checking is done in the ApplicationMasterService and it just logs the mismatch. I agree, let me update the AllocateResponse to include something like failed update requests (with a message giving the reason) org.apache.hadoop.yarn.server.resourcemanager.scheduler.Allocation: should we merge increase/decrease container list ? We could, but since that is not part of the API per se I was thinking that maybe its fine as it is.. we can probably file a follow-up JIRA I agree with the rest of your comments... will update the patch shortly addressing them.
          Hide
          asuresh Arun Suresh added a comment -

          Uploading patch addressing Wangda Tan's review comments.

          Please note a couple of changes:

          1. The container version is now plumbed all the way to the NMStateStore and NMConatinerStatus. This is needed for when RM failover happens, it needs to get the current version of the container as well.
          2. The current behavior is (I have documented this in UpdateContainerRequest class):
            1. Currently only either Resource or ExecutionType update can be requested in 1 update request.
            2. The AM has to wait for an earlier update container request to be satisfied by the RM before it can ask for another update. Essentially, updates have to be serializable.
          3. If the Update container request is not satisfiable (due to incorrect container version / or if there is already an outstanding update), it will be notified as an UpdateContainerError to the AM in the AllocateResponse. It will contain the original UpdateContainerRequest and the reason why it was not accepted.
          Show
          asuresh Arun Suresh added a comment - Uploading patch addressing Wangda Tan 's review comments. Please note a couple of changes: The container version is now plumbed all the way to the NMStateStore and NMConatinerStatus. This is needed for when RM failover happens, it needs to get the current version of the container as well. The current behavior is (I have documented this in UpdateContainerRequest class): Currently only either Resource or ExecutionType update can be requested in 1 update request. The AM has to wait for an earlier update container request to be satisfied by the RM before it can ask for another update. Essentially, updates have to be serializable. If the Update container request is not satisfiable (due to incorrect container version / or if there is already an outstanding update), it will be notified as an UpdateContainerError to the AM in the AllocateResponse. It will contain the original UpdateContainerRequest and the reason why it was not accepted.
          Hide
          asuresh Arun Suresh added a comment -

          Also, I have left the containerVersion as int for the time being. I understand it will be more future proof, but at the same time, I don't envision the user making 2147483647 number of updates.
          I can change it to long if really required after we sort out any other issues.

          Show
          asuresh Arun Suresh added a comment - Also, I have left the containerVersion as int for the time being. I understand it will be more future proof, but at the same time, I don't envision the user making 2147483647 number of updates. I can change it to long if really required after we sort out any other issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 40 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 6m 11s trunk passed
          +1 compile 6m 29s trunk passed
          +1 checkstyle 1m 54s trunk passed
          +1 mvnsite 3m 44s trunk passed
          +1 mvneclipse 2m 0s trunk passed
          +1 findbugs 6m 5s trunk passed
          +1 javadoc 2m 32s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 3m 16s the patch passed
          +1 compile 7m 0s the patch passed
          +1 cc 7m 0s the patch passed
          +1 javac 7m 0s the patch passed
          -1 checkstyle 1m 54s root: The patch generated 39 new + 2483 unchanged - 29 fixed = 2522 total (was 2512)
          +1 mvnsite 4m 34s the patch passed
          +1 mvneclipse 2m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 2 new + 152 unchanged - 4 fixed = 154 total (was 156)
          +1 javadoc 0m 34s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 17s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 20s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 974 unchanged - 15 fixed = 974 total (was 989)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 15s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 18s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 15s hadoop-sls in the patch passed.
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          -1 unit 2m 28s hadoop-yarn-common in the patch failed.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 42s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 34m 9s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 6m 22s hadoop-yarn-server-tests in the patch failed.
          -1 unit 8m 0s hadoop-yarn-client in the patch failed.
          +1 unit 8m 36s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 54s hadoop-sls in the patch passed.
          -1 asflicense 0m 21s The patch generated 1 ASF License warnings.
          138m 30s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.updateErrors; locked 55% of time Unsynchronized access at AllocateResponsePBImpl.java:55% of time Unsynchronized access at AllocateResponsePBImpl.java:[line 261]
          Failed junit tests hadoop.yarn.api.TestPBImplRecords
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.TestApplicationMasterService
            hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.client.cli.TestLogsCLI
            hadoop.yarn.client.api.impl.TestYarnClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812686/YARN-5221.005.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 880ac953d1d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 79a7289
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12114/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12114/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 40 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 6m 11s trunk passed +1 compile 6m 29s trunk passed +1 checkstyle 1m 54s trunk passed +1 mvnsite 3m 44s trunk passed +1 mvneclipse 2m 0s trunk passed +1 findbugs 6m 5s trunk passed +1 javadoc 2m 32s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 3m 16s the patch passed +1 compile 7m 0s the patch passed +1 cc 7m 0s the patch passed +1 javac 7m 0s the patch passed -1 checkstyle 1m 54s root: The patch generated 39 new + 2483 unchanged - 29 fixed = 2522 total (was 2512) +1 mvnsite 4m 34s the patch passed +1 mvneclipse 2m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 2 new + 152 unchanged - 4 fixed = 154 total (was 156) +1 javadoc 0m 34s hadoop-yarn-common in the patch passed. +1 javadoc 0m 17s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 20s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 974 unchanged - 15 fixed = 974 total (was 989) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 15s hadoop-yarn-client in the patch passed. +1 javadoc 0m 18s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 15s hadoop-sls in the patch passed. +1 unit 0m 31s hadoop-yarn-api in the patch passed. -1 unit 2m 28s hadoop-yarn-common in the patch failed. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed. +1 unit 13m 42s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 34m 9s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 6m 22s hadoop-yarn-server-tests in the patch failed. -1 unit 8m 0s hadoop-yarn-client in the patch failed. +1 unit 8m 36s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 54s hadoop-sls in the patch passed. -1 asflicense 0m 21s The patch generated 1 ASF License warnings. 138m 30s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.updateErrors; locked 55% of time Unsynchronized access at AllocateResponsePBImpl.java:55% of time Unsynchronized access at AllocateResponsePBImpl.java: [line 261] Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.client.cli.TestLogsCLI   hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812686/YARN-5221.005.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 880ac953d1d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 79a7289 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12114/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12114/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12114/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Updating patch to fix test-cases

          Show
          asuresh Arun Suresh added a comment - Updating patch to fix test-cases
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 41 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 6m 18s trunk passed
          +1 compile 6m 33s trunk passed
          +1 checkstyle 1m 54s trunk passed
          +1 mvnsite 3m 48s trunk passed
          +1 mvneclipse 2m 3s trunk passed
          +1 findbugs 5m 59s trunk passed
          +1 javadoc 2m 32s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 3m 2s the patch passed
          +1 compile 6m 30s the patch passed
          +1 cc 6m 30s the patch passed
          +1 javac 6m 30s the patch passed
          -1 checkstyle 1m 56s root: The patch generated 49 new + 2394 unchanged - 76 fixed = 2443 total (was 2470)
          +1 mvnsite 3m 48s the patch passed
          +1 mvneclipse 2m 5s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 7m 4s the patch passed
          -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 2 new + 152 unchanged - 4 fixed = 154 total (was 156)
          -1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 8 new + 969 unchanged - 20 fixed = 977 total (was 989)
          +1 unit 0m 24s hadoop-yarn-api in the patch passed.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed.
          +1 unit 0m 26s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 2s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 35m 37s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 6m 21s hadoop-yarn-server-tests in the patch failed.
          -1 unit 8m 11s hadoop-yarn-client in the patch failed.
          +1 unit 8m 38s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 53s hadoop-sls in the patch passed.
          -1 asflicense 0m 23s The patch generated 1 ASF License warnings.
          134m 50s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.client.api.impl.TestYarnClient
            hadoop.yarn.client.cli.TestLogsCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:85209cc
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12813386/YARN-5221.006.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux e61373fed256 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d328e66
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12128/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12128/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 41 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 18s trunk passed +1 compile 6m 33s trunk passed +1 checkstyle 1m 54s trunk passed +1 mvnsite 3m 48s trunk passed +1 mvneclipse 2m 3s trunk passed +1 findbugs 5m 59s trunk passed +1 javadoc 2m 32s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 3m 2s the patch passed +1 compile 6m 30s the patch passed +1 cc 6m 30s the patch passed +1 javac 6m 30s the patch passed -1 checkstyle 1m 56s root: The patch generated 49 new + 2394 unchanged - 76 fixed = 2443 total (was 2470) +1 mvnsite 3m 48s the patch passed +1 mvneclipse 2m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 7m 4s the patch passed -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 2 new + 152 unchanged - 4 fixed = 154 total (was 156) -1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 8 new + 969 unchanged - 20 fixed = 977 total (was 989) +1 unit 0m 24s hadoop-yarn-api in the patch passed. +1 unit 2m 9s hadoop-yarn-common in the patch passed. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed. +1 unit 13m 2s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 35m 37s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 6m 21s hadoop-yarn-server-tests in the patch failed. -1 unit 8m 11s hadoop-yarn-client in the patch failed. +1 unit 8m 38s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 53s hadoop-sls in the patch passed. -1 asflicense 0m 23s The patch generated 1 ASF License warnings. 134m 50s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.api.impl.TestYarnClient   hadoop.yarn.client.cli.TestLogsCLI Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12813386/YARN-5221.006.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux e61373fed256 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d328e66 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12128/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12128/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12128/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Fixing javadoc and checkstyles. TestCase errors are un-related

          Show
          asuresh Arun Suresh added a comment - Fixing javadoc and checkstyles. TestCase errors are un-related
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 28s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 41 new or modified test files.
          0 mvndep 0m 31s Maven dependency ordering for branch
          +1 mvninstall 6m 15s trunk passed
          +1 compile 6m 33s trunk passed
          +1 checkstyle 1m 55s trunk passed
          +1 mvnsite 3m 46s trunk passed
          +1 mvneclipse 2m 1s trunk passed
          +1 findbugs 5m 52s trunk passed
          +1 javadoc 2m 28s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 3m 3s the patch passed
          +1 compile 6m 29s the patch passed
          +1 cc 6m 29s the patch passed
          +1 javac 6m 29s the patch passed
          -1 checkstyle 1m 53s root: The patch generated 22 new + 2392 unchanged - 78 fixed = 2414 total (was 2470)
          +1 mvnsite 3m 45s the patch passed
          +1 mvneclipse 2m 3s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 7m 0s the patch passed
          +1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 152 unchanged - 4 fixed = 152 total (was 156)
          +1 javadoc 0m 26s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 15s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 969 unchanged - 20 fixed = 969 total (was 989)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 14s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 15s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 14s hadoop-sls in the patch passed.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed.
          -1 unit 12m 59s hadoop-yarn-server-nodemanager in the patch failed.
          +1 unit 35m 6s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 6m 22s hadoop-yarn-server-tests in the patch failed.
          -1 unit 8m 13s hadoop-yarn-client in the patch failed.
          +1 unit 8m 42s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 53s hadoop-sls in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          134m 13s



          Reason Tests
          Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.client.api.impl.TestYarnClient
            hadoop.yarn.client.cli.TestLogsCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:85209cc
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12813473/YARN-5221.007.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 30c69d0cadf3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 73615a7
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12129/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12129/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 41 new or modified test files. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 6m 15s trunk passed +1 compile 6m 33s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 3m 46s trunk passed +1 mvneclipse 2m 1s trunk passed +1 findbugs 5m 52s trunk passed +1 javadoc 2m 28s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 3m 3s the patch passed +1 compile 6m 29s the patch passed +1 cc 6m 29s the patch passed +1 javac 6m 29s the patch passed -1 checkstyle 1m 53s root: The patch generated 22 new + 2392 unchanged - 78 fixed = 2414 total (was 2470) +1 mvnsite 3m 45s the patch passed +1 mvneclipse 2m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 7m 0s the patch passed +1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 152 unchanged - 4 fixed = 152 total (was 156) +1 javadoc 0m 26s hadoop-yarn-common in the patch passed. +1 javadoc 0m 15s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 969 unchanged - 20 fixed = 969 total (was 989) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 14s hadoop-yarn-client in the patch passed. +1 javadoc 0m 15s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 14s hadoop-sls in the patch passed. +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 9s hadoop-yarn-common in the patch passed. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed. -1 unit 12m 59s hadoop-yarn-server-nodemanager in the patch failed. +1 unit 35m 6s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 6m 22s hadoop-yarn-server-tests in the patch failed. -1 unit 8m 13s hadoop-yarn-client in the patch failed. +1 unit 8m 42s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 53s hadoop-sls in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 134m 13s Reason Tests Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.api.impl.TestYarnClient   hadoop.yarn.client.cli.TestLogsCLI Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12813473/YARN-5221.007.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 30c69d0cadf3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 73615a7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12129/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12129/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks for update Arun Suresh.

          Patch generally looks good, my only comment is validateIncreaseDecreaseRequest dropped some previous diagnostic messages such as:

          260	            + (increase ? "increase" : "decrease") + " request"		
          261	            + ", requested virtual cores < 0"		
          262	            + ", or requested virtual cores > max configured"		
          263	            + ", requestedVirtualCores="		
          264	            + request.getCapability().getVirtualCores() + ", maxVirtualCores="		
          265	            + maximumAllocation.getVirtualCores());
          

          It's better to add them back to easier identify problems.

          And also, if this patch goes in, could you also update example of YARN-4175? Since YARN-4175 is the only public example to show how to use increase/decrease feature.

          And would like to get more reviews from other committers. (Karthik Kambatla).

          Thanks,

          Show
          leftnoteasy Wangda Tan added a comment - Thanks for update Arun Suresh . Patch generally looks good, my only comment is validateIncreaseDecreaseRequest dropped some previous diagnostic messages such as: 260 + (increase ? "increase" : "decrease" ) + " request" 261 + ", requested virtual cores < 0" 262 + ", or requested virtual cores > max configured" 263 + ", requestedVirtualCores=" 264 + request.getCapability().getVirtualCores() + ", maxVirtualCores=" 265 + maximumAllocation.getVirtualCores()); It's better to add them back to easier identify problems. And also, if this patch goes in, could you also update example of YARN-4175 ? Since YARN-4175 is the only public example to show how to use increase/decrease feature. And would like to get more reviews from other committers. ( Karthik Kambatla ). Thanks,
          Hide
          leftnoteasy Wangda Tan added a comment -

          Arun Suresh, could you update the patch? Since 2.8 release is closing..

          Show
          leftnoteasy Wangda Tan added a comment - Arun Suresh , could you update the patch? Since 2.8 release is closing..
          Hide
          asuresh Arun Suresh added a comment -

          Rebasing patch against trunk.

          Wangda Tan, regarding your comment, The diagnostic is not dropped. Instead of throwing an Exception, I am actually returning an UpdateError back to the AM.

          Show
          asuresh Arun Suresh added a comment - Rebasing patch against trunk. Wangda Tan , regarding your comment, The diagnostic is not dropped. Instead of throwing an Exception, I am actually returning an UpdateError back to the AM.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 41 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 8m 32s trunk passed
          +1 compile 8m 28s trunk passed
          +1 checkstyle 2m 6s trunk passed
          +1 mvnsite 4m 39s trunk passed
          +1 mvneclipse 2m 30s trunk passed
          +1 findbugs 7m 12s trunk passed
          +1 javadoc 2m 48s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 3m 45s the patch passed
          +1 compile 7m 43s the patch passed
          +1 cc 7m 43s the patch passed
          +1 javac 7m 43s the patch passed
          -1 checkstyle 2m 0s root: The patch generated 22 new + 2357 unchanged - 78 fixed = 2379 total (was 2435)
          +1 mvnsite 4m 37s the patch passed
          +1 mvneclipse 2m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 8m 48s the patch passed
          +1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 152 unchanged - 4 fixed = 152 total (was 156)
          +1 javadoc 0m 28s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 15s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 943 unchanged - 20 fixed = 943 total (was 963)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 14s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 13s hadoop-sls in the patch passed.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed.
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed.
          -1 unit 12m 57s hadoop-yarn-server-nodemanager in the patch failed.
          +1 unit 33m 1s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 4m 27s hadoop-yarn-server-tests in the patch failed.
          -1 unit 8m 17s hadoop-yarn-client in the patch failed.
          +1 unit 8m 49s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 54s hadoop-sls in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          142m 48s



          Reason Tests
          Failed junit tests hadoop.yarn.server.nodemanager.TestDirectoryCollection
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.client.api.impl.TestYarnClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820619/YARN-5221.008.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 9863e9eae982 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8d06bda
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12535/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12535/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 41 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 8m 32s trunk passed +1 compile 8m 28s trunk passed +1 checkstyle 2m 6s trunk passed +1 mvnsite 4m 39s trunk passed +1 mvneclipse 2m 30s trunk passed +1 findbugs 7m 12s trunk passed +1 javadoc 2m 48s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 45s the patch passed +1 compile 7m 43s the patch passed +1 cc 7m 43s the patch passed +1 javac 7m 43s the patch passed -1 checkstyle 2m 0s root: The patch generated 22 new + 2357 unchanged - 78 fixed = 2379 total (was 2435) +1 mvnsite 4m 37s the patch passed +1 mvneclipse 2m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 8m 48s the patch passed +1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 152 unchanged - 4 fixed = 152 total (was 156) +1 javadoc 0m 28s hadoop-yarn-common in the patch passed. +1 javadoc 0m 15s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 943 unchanged - 20 fixed = 943 total (was 963) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 14s hadoop-yarn-client in the patch passed. +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 13s hadoop-sls in the patch passed. +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 16s hadoop-yarn-common in the patch passed. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed. -1 unit 12m 57s hadoop-yarn-server-nodemanager in the patch failed. +1 unit 33m 1s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 4m 27s hadoop-yarn-server-tests in the patch failed. -1 unit 8m 17s hadoop-yarn-client in the patch failed. +1 unit 8m 49s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 54s hadoop-sls in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 142m 48s Reason Tests Failed junit tests hadoop.yarn.server.nodemanager.TestDirectoryCollection   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820619/YARN-5221.008.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 9863e9eae982 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8d06bda Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt https://builds.apache.org/job/PreCommit-YARN-Build/12535/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12535/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12535/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -
          Show
          asuresh Arun Suresh added a comment - ping.. Subru Krishnan , Karthik Kambatla , Wangda Tan ...
          Hide
          subru Subru Krishnan added a comment - - edited

          It's a rather substantial patch . I'll take a look at it and get back by Monday.

          From an initial pass, I feel it will help if we can split the patch:
          1. API changes to unify Container change requests.
          2. Backend changes to affect the unified API.
          3. NMStateStore and associated NMContainerStatus changes for RM failover.

          Thoughts Arun Suresh?

          Show
          subru Subru Krishnan added a comment - - edited It's a rather substantial patch . I'll take a look at it and get back by Monday. From an initial pass, I feel it will help if we can split the patch: 1. API changes to unify Container change requests. 2. Backend changes to affect the unified API. 3. NMStateStore and associated NMContainerStatus changes for RM failover. Thoughts Arun Suresh ?
          Hide
          subru Subru Krishnan added a comment -

          I looked at the patch. +1 from my side (pending Yetus as the reports seem to have expired), just a few minor comments:

          • I think it is better to retain the old constructor of ContainerTokenIdentifier and call the new one with implicit 0 version to avoid changes to MRApp and possibly other applications. This will also avoid changing existing tests that don't use container versioning.
          • Nit: will be good to call out in the javadocs of Container that versions are incremented as a side effect of update requests.
          • Is it possible to use enum in UpdateContainerRequest to strictly enforce only one aspect changes?
          • Nit: You can use @link instead of <code> in javadocs of UpdateContainerRequest as there's is direct compile dependency.

          A thought - can we defer splitting increase/decreaseRequests to the actual scheduler as now we will have to propagate every new changeable container attribute?

          Show
          subru Subru Krishnan added a comment - I looked at the patch. +1 from my side (pending Yetus as the reports seem to have expired), just a few minor comments: I think it is better to retain the old constructor of ContainerTokenIdentifier and call the new one with implicit 0 version to avoid changes to MRApp and possibly other applications. This will also avoid changing existing tests that don't use container versioning. Nit: will be good to call out in the javadocs of Container that versions are incremented as a side effect of update requests. Is it possible to use enum in UpdateContainerRequest to strictly enforce only one aspect changes? Nit: You can use @link instead of <code> in javadocs of UpdateContainerRequest as there's is direct compile dependency. A thought - can we defer splitting increase/decreaseRequests to the actual scheduler as now we will have to propagate every new changeable container attribute?
          Hide
          asuresh Arun Suresh added a comment -

          Thanks for the thoughtful review Subru Krishnan. Updating the patch to rebase with trunk and kick of jenkins.

          I have also updated it your suggestions, as part of which I have introduced an enum ContainerUpdateType used both in the AllocateRequest to limit the update to either a Container capability increase / decrease or ExecutionType.

          .. can we defer splitting increase/decreaseRequests to the actual Scheduler..

          I totally agree. I wanted this patch to be more about refactoring / fixing the user facing aspects of YARN-1651. I will raise another JIRA to refactor some of these internals.

          Show
          asuresh Arun Suresh added a comment - Thanks for the thoughtful review Subru Krishnan . Updating the patch to rebase with trunk and kick of jenkins. I have also updated it your suggestions, as part of which I have introduced an enum ContainerUpdateType used both in the AllocateRequest to limit the update to either a Container capability increase / decrease or ExecutionType. .. can we defer splitting increase/decreaseRequests to the actual Scheduler.. I totally agree. I wanted this patch to be more about refactoring / fixing the user facing aspects of YARN-1651 . I will raise another JIRA to refactor some of these internals.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 0m 42s Maven dependency ordering for branch
          +1 mvninstall 7m 3s trunk passed
          +1 compile 7m 26s trunk passed
          +1 checkstyle 1m 53s trunk passed
          +1 mvnsite 4m 35s trunk passed
          +1 mvneclipse 2m 42s trunk passed
          +1 findbugs 6m 38s trunk passed
          +1 javadoc 2m 53s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 3m 42s the patch passed
          +1 compile 7m 4s the patch passed
          +1 cc 7m 4s the patch passed
          +1 javac 7m 4s the patch passed
          -1 checkstyle 1m 54s root: The patch generated 21 new + 1900 unchanged - 76 fixed = 1921 total (was 1976)
          +1 mvnsite 4m 35s the patch passed
          +1 mvneclipse 2m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 8m 16s the patch passed
          +1 javadoc 0m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125)
          +1 javadoc 0m 28s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 15s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961)
          +1 javadoc 0m 12s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 15s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 javadoc 0m 17s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 14s hadoop-sls in the patch passed.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          +1 unit 2m 22s hadoop-yarn-common in the patch passed.
          +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 25s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 38m 0s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 4m 28s hadoop-yarn-server-tests in the patch failed.
          +1 unit 16m 5s hadoop-yarn-client in the patch passed.
          +1 unit 9m 35s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 56s hadoop-sls in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          162m 37s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825895/YARN-5221.009.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 3c4d5cd670c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 19c743c
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12913/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12913/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12913/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12913/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12913/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 7m 3s trunk passed +1 compile 7m 26s trunk passed +1 checkstyle 1m 53s trunk passed +1 mvnsite 4m 35s trunk passed +1 mvneclipse 2m 42s trunk passed +1 findbugs 6m 38s trunk passed +1 javadoc 2m 53s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 3m 42s the patch passed +1 compile 7m 4s the patch passed +1 cc 7m 4s the patch passed +1 javac 7m 4s the patch passed -1 checkstyle 1m 54s root: The patch generated 21 new + 1900 unchanged - 76 fixed = 1921 total (was 1976) +1 mvnsite 4m 35s the patch passed +1 mvneclipse 2m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 8m 16s the patch passed +1 javadoc 0m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125) +1 javadoc 0m 28s hadoop-yarn-common in the patch passed. +1 javadoc 0m 15s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961) +1 javadoc 0m 12s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 15s hadoop-yarn-client in the patch passed. +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed. +1 javadoc 0m 17s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 14s hadoop-sls in the patch passed. +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 22s hadoop-yarn-common in the patch passed. +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. +1 unit 13m 25s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 38m 0s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 4m 28s hadoop-yarn-server-tests in the patch failed. +1 unit 16m 5s hadoop-yarn-client in the patch passed. +1 unit 9m 35s hadoop-yarn-applications-distributedshell in the patch passed. +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 56s hadoop-sls in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 162m 37s Reason Tests Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825895/YARN-5221.009.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 3c4d5cd670c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19c743c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12913/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12913/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12913/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12913/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12913/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          The testcase errors are unrelated.

          Uploading a patch to fix 1 more checkstyle issue (unused import). The remaining are related to method length, method parameters and variables requiring getters and setters

          Will commit this (based on Subru Krishnan's +1) by end of Tomorrow if there are no more comments.

          Show
          asuresh Arun Suresh added a comment - The testcase errors are unrelated. Uploading a patch to fix 1 more checkstyle issue (unused import). The remaining are related to method length, method parameters and variables requiring getters and setters Will commit this (based on Subru Krishnan 's +1) by end of Tomorrow if there are no more comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 46s trunk passed
          +1 compile 6m 57s trunk passed
          +1 checkstyle 1m 51s trunk passed
          +1 mvnsite 4m 24s trunk passed
          +1 mvneclipse 2m 28s trunk passed
          +1 findbugs 6m 28s trunk passed
          +1 javadoc 2m 47s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 3m 30s the patch passed
          +1 compile 6m 51s the patch passed
          +1 cc 6m 51s the patch passed
          +1 javac 6m 51s the patch passed
          -1 checkstyle 1m 51s root: The patch generated 20 new + 1900 unchanged - 76 fixed = 1920 total (was 1976)
          +1 mvnsite 4m 35s the patch passed
          +1 mvneclipse 2m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 9m 17s the patch passed
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125)
          +1 javadoc 0m 28s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 18s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 20s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 16s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 javadoc 0m 18s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 15s hadoop-sls in the patch passed.
          +1 unit 0m 30s hadoop-yarn-api in the patch passed.
          +1 unit 2m 34s hadoop-yarn-common in the patch passed.
          +1 unit 0m 30s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 37s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 37m 45s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 4m 36s hadoop-yarn-server-tests in the patch failed.
          +1 unit 16m 31s hadoop-yarn-client in the patch passed.
          +1 unit 9m 21s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 56s hadoop-sls in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          163m 0s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825921/YARN-5221.010.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux c63afa853301 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c258171
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12918/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12918/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12918/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12918/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12918/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 46s trunk passed +1 compile 6m 57s trunk passed +1 checkstyle 1m 51s trunk passed +1 mvnsite 4m 24s trunk passed +1 mvneclipse 2m 28s trunk passed +1 findbugs 6m 28s trunk passed +1 javadoc 2m 47s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 3m 30s the patch passed +1 compile 6m 51s the patch passed +1 cc 6m 51s the patch passed +1 javac 6m 51s the patch passed -1 checkstyle 1m 51s root: The patch generated 20 new + 1900 unchanged - 76 fixed = 1920 total (was 1976) +1 mvnsite 4m 35s the patch passed +1 mvneclipse 2m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 9m 17s the patch passed +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125) +1 javadoc 0m 28s hadoop-yarn-common in the patch passed. +1 javadoc 0m 18s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 20s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 16s hadoop-yarn-client in the patch passed. +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed. +1 javadoc 0m 18s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 15s hadoop-sls in the patch passed. +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 2m 34s hadoop-yarn-common in the patch passed. +1 unit 0m 30s hadoop-yarn-server-common in the patch passed. +1 unit 13m 37s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 37m 45s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 4m 36s hadoop-yarn-server-tests in the patch failed. +1 unit 16m 31s hadoop-yarn-client in the patch passed. +1 unit 9m 21s hadoop-yarn-applications-distributedshell in the patch passed. +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 56s hadoop-sls in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 163m 0s Reason Tests Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825921/YARN-5221.010.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c63afa853301 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c258171 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12918/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12918/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12918/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12918/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12918/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Arun Suresh for addressing my feedback.

          I feel few of the checkstyle warnings can be fixed.

          When I was making a final pass on the patch, I realized that in RMServerUtils::validateAndSplitUpdateResourceRequests, we are only validating update requests within the current AllocateRequest but we should be checking against global outstanding update asks as the allocate protocol is asynchronous. I am fine with addressing this in a separate JIRA along with the refactoring work based on your comment above.

          Show
          subru Subru Krishnan added a comment - Thanks Arun Suresh for addressing my feedback. I feel few of the checkstyle warnings can be fixed. When I was making a final pass on the patch, I realized that in RMServerUtils::validateAndSplitUpdateResourceRequests , we are only validating update requests within the current AllocateRequest but we should be checking against global outstanding update asks as the allocate protocol is asynchronous. I am fine with addressing this in a separate JIRA along with the refactoring work based on your comment above .
          Hide
          leftnoteasy Wangda Tan added a comment - - edited

          Arun Suresh,

          Sorry for my late comment, some minor issues for annotations/javadocs, etc.

          UpdatedContainer:

          • Mark the whole class to Public/Unstable?

          ContainerUpdateType:

          • Add annotation to Public/unstable?
          • INCREASE_CAPABILITY or INCREASE_RESOURCE?

          AMRMClientAsync.AbstractCallbackHandler#onContainersResourceChanged:

          • Do you think we should remove this method and add a onContainersUpdated?
          • At least we should make this new method to Public/unstable since we could break it in the future.

          o.a.h.y.api.Container:

          • serVersion should be private/unstable, and should throw UnsupportedOperationException
          • Not caused by this patch, setAllocationRequestId should be private/unstable.

          NMLeveldbStateStoreService:

          • Not sure if the change will cause stored data compability issues while doing rolling upgrade. (New NM read old data)

          RMServerUtils.java:

          • Lots of unnecessary formatting changes, is it possible to revert these changes?
          Show
          leftnoteasy Wangda Tan added a comment - - edited Arun Suresh , Sorry for my late comment, some minor issues for annotations/javadocs, etc. UpdatedContainer: Mark the whole class to Public/Unstable? ContainerUpdateType: Add annotation to Public/unstable? INCREASE_CAPABILITY or INCREASE_RESOURCE? AMRMClientAsync.AbstractCallbackHandler#onContainersResourceChanged: Do you think we should remove this method and add a onContainersUpdated? At least we should make this new method to Public/unstable since we could break it in the future. o.a.h.y.api.Container: serVersion should be private/unstable, and should throw UnsupportedOperationException Not caused by this patch, setAllocationRequestId should be private/unstable. NMLeveldbStateStoreService: Not sure if the change will cause stored data compability issues while doing rolling upgrade. (New NM read old data) RMServerUtils.java: Lots of unnecessary formatting changes, is it possible to revert these changes?
          Hide
          asuresh Arun Suresh added a comment -

          Updating patch based on Subru Krishnan's and Wangda Tan's suggestions.

          Not sure if the change will cause stored data compability issues while doing rolling upgrade. (New NM read old data)

          So new NM will be able to read old data.. but not the other way around.

          Lots of unnecessary formatting changes, is it possible to revert these changes?

          Actually many of the formatting changes are due to fixing the existing code to the correct code-style If you dont mind, can we keep this as it is, since rolling that back to the wrong code style is a bit difficult...

          Show
          asuresh Arun Suresh added a comment - Updating patch based on Subru Krishnan 's and Wangda Tan 's suggestions. Not sure if the change will cause stored data compability issues while doing rolling upgrade. (New NM read old data) So new NM will be able to read old data.. but not the other way around. Lots of unnecessary formatting changes, is it possible to revert these changes? Actually many of the formatting changes are due to fixing the existing code to the correct code-style If you dont mind, can we keep this as it is, since rolling that back to the wrong code style is a bit difficult...
          Hide
          asuresh Arun Suresh added a comment -

          Also raised YARN-5580 to track Subru Krishnan's suggestion..

          Show
          asuresh Arun Suresh added a comment - Also raised YARN-5580 to track Subru Krishnan 's suggestion..
          Hide
          leftnoteasy Wangda Tan added a comment -

          Arun Suresh,

          So new NM will be able to read old data.. but not the other way around.

          That should be good enough.

          Actually many of the formatting changes are due to fixing the existing code to the correct code-style If you dont mind, can we keep this as it is, since rolling that back to the wrong code style is a bit difficult...

          Not all code style changes are required, because different people have different IDE style settings. But it is fine to keep these changes since conflict merge should be straightforward.

          And I can still see some of my changes are not addressed, could you double check my previous comment and let me know if you have any thoughts?

          Show
          leftnoteasy Wangda Tan added a comment - Arun Suresh , So new NM will be able to read old data.. but not the other way around. That should be good enough. Actually many of the formatting changes are due to fixing the existing code to the correct code-style If you dont mind, can we keep this as it is, since rolling that back to the wrong code style is a bit difficult... Not all code style changes are required, because different people have different IDE style settings. But it is fine to keep these changes since conflict merge should be straightforward. And I can still see some of my changes are not addressed, could you double check my previous comment and let me know if you have any thoughts?
          Hide
          asuresh Arun Suresh added a comment -

          Aah... missed the Container::setVersion comment...
          Uploading patch with fix...

          Show
          asuresh Arun Suresh added a comment - Aah... missed the Container::setVersion comment... Uploading patch with fix...
          Hide
          asuresh Arun Suresh added a comment -

          ... could you double check my previous comment and let me know if you have any thoughts

          You mean the Container::setVersion comment... just uploaded patch to fix it..

          Show
          asuresh Arun Suresh added a comment - ... could you double check my previous comment and let me know if you have any thoughts You mean the Container::setVersion comment... just uploaded patch to fix it..
          Hide
          leftnoteasy Wangda Tan added a comment -

          Arun Suresh,

          Not only setVersion , there're more unaddressed comments:

          1) UpdatedContainer:

          • Mark the whole class to Public/Unstable?

          2) AMRMClientAsync.AbstractCallbackHandler#onContainersUpdated:

          • Mark it to Public/Unstable?

          3) o.a.h.y.api.Container:

          • Not caused by this patch, setAllocationRequestId should be private/unstable.
          Show
          leftnoteasy Wangda Tan added a comment - Arun Suresh , Not only setVersion , there're more unaddressed comments: 1) UpdatedContainer: Mark the whole class to Public/Unstable? 2) AMRMClientAsync.AbstractCallbackHandler#onContainersUpdated: Mark it to Public/Unstable? 3) o.a.h.y.api.Container: Not caused by this patch, setAllocationRequestId should be private/unstable.
          Hide
          asuresh Arun Suresh added a comment - - edited

          Hmmm... not sure if you r looking at the correct version of the patch:

          UpdatedContainer: Mark the whole class to Public/Unstable?

          its marked as Public + Evolving (Think Evolving is better than Unstable ?)

          AMRMClientAsync.AbstractCallbackHandler#onContainersUpdated: Mark it to Public/Unstable?

          Its marked Unstable (Is public needed ? since it is a user facing interface in any case.. right ?)

          o.a.h.y.api.Container: Not caused by this patch, setAllocationRequestId should be private/unstable.

          It is currently evolving.. Think that should be fine right ? (My thinking is that Unstable => the method will outright change.. which is un-likely. Evolving => we might change the parameters/arguments/name etc.)

          Show
          asuresh Arun Suresh added a comment - - edited Hmmm... not sure if you r looking at the correct version of the patch: UpdatedContainer: Mark the whole class to Public/Unstable? its marked as Public + Evolving (Think Evolving is better than Unstable ?) AMRMClientAsync.AbstractCallbackHandler#onContainersUpdated: Mark it to Public/Unstable? Its marked Unstable (Is public needed ? since it is a user facing interface in any case.. right ?) o.a.h.y.api.Container: Not caused by this patch, setAllocationRequestId should be private/unstable. It is currently evolving.. Think that should be fine right ? (My thinking is that Unstable => the method will outright change.. which is un-likely. Evolving => we might change the parameters/arguments/name etc.)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 1m 45s Maven dependency ordering for branch
          +1 mvninstall 8m 51s trunk passed
          +1 compile 8m 41s trunk passed
          +1 checkstyle 1m 55s trunk passed
          +1 mvnsite 4m 42s trunk passed
          +1 mvneclipse 2m 35s trunk passed
          +1 findbugs 7m 7s trunk passed
          +1 javadoc 3m 3s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 3m 32s the patch passed
          +1 compile 6m 54s the patch passed
          +1 cc 6m 54s the patch passed
          +1 javac 6m 54s the patch passed
          -1 checkstyle 1m 52s root: The patch generated 11 new + 1900 unchanged - 76 fixed = 1911 total (was 1976)
          +1 mvnsite 4m 35s the patch passed
          +1 mvneclipse 2m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 9m 7s the patch passed
          +1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125)
          -1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 65 new + 4579 unchanged - 0 fixed = 4644 total (was 4579)
          +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed.
          -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 27 new + 941 unchanged - 20 fixed = 968 total (was 961)
          +1 javadoc 0m 12s hadoop-yarn-server-tests in the patch passed.
          -1 javadoc 0m 15s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client generated 8 new + 157 unchanged - 0 fixed = 165 total (was 157)
          -1 javadoc 0m 12s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
          +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed.
          -1 javadoc 0m 15s hadoop-tools_hadoop-sls generated 5 new + 23 unchanged - 0 fixed = 28 total (was 23)
          +1 unit 0m 27s hadoop-yarn-api in the patch passed.
          -1 unit 0m 20s hadoop-yarn-common in the patch failed.
          -1 unit 0m 18s hadoop-yarn-server-common in the patch failed.
          -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 0m 22s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 2m 32s hadoop-yarn-server-tests in the patch failed.
          -1 unit 0m 16s hadoop-yarn-client in the patch failed.
          -1 unit 0m 14s hadoop-yarn-applications-distributedshell in the patch failed.
          -1 unit 0m 22s hadoop-mapreduce-client-app in the patch failed.
          -1 unit 0m 15s hadoop-sls in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          78m 24s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.server.TestContainerManagerSecurity



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826092/YARN-5221.011.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 69d2c3f1d210 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8b57be1
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-tools_hadoop-sls.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12933/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12933/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 1m 45s Maven dependency ordering for branch +1 mvninstall 8m 51s trunk passed +1 compile 8m 41s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 4m 42s trunk passed +1 mvneclipse 2m 35s trunk passed +1 findbugs 7m 7s trunk passed +1 javadoc 3m 3s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 3m 32s the patch passed +1 compile 6m 54s the patch passed +1 cc 6m 54s the patch passed +1 javac 6m 54s the patch passed -1 checkstyle 1m 52s root: The patch generated 11 new + 1900 unchanged - 76 fixed = 1911 total (was 1976) +1 mvnsite 4m 35s the patch passed +1 mvneclipse 2m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 9m 7s the patch passed +1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125) -1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 65 new + 4579 unchanged - 0 fixed = 4644 total (was 4579) +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed. -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 27 new + 941 unchanged - 20 fixed = 968 total (was 961) +1 javadoc 0m 12s hadoop-yarn-server-tests in the patch passed. -1 javadoc 0m 15s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client generated 8 new + 157 unchanged - 0 fixed = 165 total (was 157) -1 javadoc 0m 12s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13) +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed. -1 javadoc 0m 15s hadoop-tools_hadoop-sls generated 5 new + 23 unchanged - 0 fixed = 28 total (was 23) +1 unit 0m 27s hadoop-yarn-api in the patch passed. -1 unit 0m 20s hadoop-yarn-common in the patch failed. -1 unit 0m 18s hadoop-yarn-server-common in the patch failed. -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 0m 22s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 2m 32s hadoop-yarn-server-tests in the patch failed. -1 unit 0m 16s hadoop-yarn-client in the patch failed. -1 unit 0m 14s hadoop-yarn-applications-distributedshell in the patch failed. -1 unit 0m 22s hadoop-mapreduce-client-app in the patch failed. -1 unit 0m 15s hadoop-sls in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 78m 24s Reason Tests Failed junit tests hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826092/YARN-5221.011.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 69d2c3f1d210 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8b57be1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/diff-javadoc-javadoc-hadoop-tools_hadoop-sls.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12933/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12933/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12933/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          its marked as Public + Evolving (Think Evolving is better than Unstable ?)

          In reality, we cannot break evolving API in minor releases (like, 2.x -> 2.(x+1)).

          Its marked Unstable (Is public needed ? since it is a user facing interface in any case.. right ?)

          Public and unstable need to come together.

          It is currently evolving.. Think that should be fine right ? (My thinking is that Unstable => the method will outright change.. which is un-likely. Evolving => we might change the parameters/arguments/name etc.)

          Same thing, in YARN, evolving is treated as "stable" in most cases. Even if we can change it bylaw.

          Show
          leftnoteasy Wangda Tan added a comment - its marked as Public + Evolving (Think Evolving is better than Unstable ?) In reality, we cannot break evolving API in minor releases (like, 2.x -> 2.(x+1)). Its marked Unstable (Is public needed ? since it is a user facing interface in any case.. right ?) Public and unstable need to come together. It is currently evolving.. Think that should be fine right ? (My thinking is that Unstable => the method will outright change.. which is un-likely. Evolving => we might change the parameters/arguments/name etc.) Same thing, in YARN, evolving is treated as "stable" in most cases. Even if we can change it bylaw.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 7m 50s trunk passed
          +1 compile 7m 11s trunk passed
          +1 checkstyle 1m 50s trunk passed
          +1 mvnsite 4m 25s trunk passed
          +1 mvneclipse 2m 27s trunk passed
          +1 findbugs 6m 25s trunk passed
          +1 javadoc 2m 45s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 3m 34s the patch passed
          +1 compile 8m 20s the patch passed
          +1 cc 8m 20s the patch passed
          +1 javac 8m 20s the patch passed
          -1 checkstyle 1m 55s root: The patch generated 11 new + 1900 unchanged - 76 fixed = 1911 total (was 1976)
          +1 mvnsite 5m 49s the patch passed
          +1 mvneclipse 2m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 9m 25s the patch passed
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125)
          +1 javadoc 0m 31s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 18s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 18s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 javadoc 0m 21s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 14s hadoop-sls in the patch passed.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed.
          +1 unit 2m 27s hadoop-yarn-common in the patch passed.
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 14s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 33m 47s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 4m 27s hadoop-yarn-server-tests in the patch failed.
          +1 unit 16m 7s hadoop-yarn-client in the patch passed.
          +1 unit 9m 13s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 unit 9m 17s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 1m 0s hadoop-sls in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          161m 20s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826094/YARN-5221.012.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 8d85c369d448 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8b57be1
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12934/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12934/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12934/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12934/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12934/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 7m 50s trunk passed +1 compile 7m 11s trunk passed +1 checkstyle 1m 50s trunk passed +1 mvnsite 4m 25s trunk passed +1 mvneclipse 2m 27s trunk passed +1 findbugs 6m 25s trunk passed +1 javadoc 2m 45s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 3m 34s the patch passed +1 compile 8m 20s the patch passed +1 cc 8m 20s the patch passed +1 javac 8m 20s the patch passed -1 checkstyle 1m 55s root: The patch generated 11 new + 1900 unchanged - 76 fixed = 1911 total (was 1976) +1 mvnsite 5m 49s the patch passed +1 mvneclipse 2m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 9m 25s the patch passed +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125) +1 javadoc 0m 31s hadoop-yarn-common in the patch passed. +1 javadoc 0m 18s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 17s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 18s hadoop-yarn-client in the patch passed. +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed. +1 javadoc 0m 21s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 14s hadoop-sls in the patch passed. +1 unit 0m 27s hadoop-yarn-api in the patch passed. +1 unit 2m 27s hadoop-yarn-common in the patch passed. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed. +1 unit 13m 14s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 33m 47s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 4m 27s hadoop-yarn-server-tests in the patch failed. +1 unit 16m 7s hadoop-yarn-client in the patch passed. +1 unit 9m 13s hadoop-yarn-applications-distributedshell in the patch passed. +1 unit 9m 17s hadoop-mapreduce-client-app in the patch passed. +1 unit 1m 0s hadoop-sls in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 161m 20s Reason Tests Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826094/YARN-5221.012.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 8d85c369d448 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8b57be1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12934/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12934/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12934/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12934/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12934/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Wangda Tan,

          Same thing, in YARN, evolving is treated as "stable" in most cases. Even if we can change it bylaw.

          Aah.. Thanks for clarifying

          Updating patch : changed the Evolving to Unstable.

          Show
          asuresh Arun Suresh added a comment - Wangda Tan , Same thing, in YARN, evolving is treated as "stable" in most cases. Even if we can change it bylaw. Aah.. Thanks for clarifying Updating patch : changed the Evolving to Unstable.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 58s trunk passed
          +1 compile 7m 3s trunk passed
          +1 checkstyle 1m 53s trunk passed
          +1 mvnsite 4m 28s trunk passed
          +1 mvneclipse 2m 30s trunk passed
          +1 findbugs 6m 37s trunk passed
          +1 javadoc 2m 51s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 3m 35s the patch passed
          +1 compile 7m 0s the patch passed
          +1 cc 7m 0s the patch passed
          +1 javac 7m 0s the patch passed
          -1 checkstyle 1m 51s root: The patch generated 11 new + 1900 unchanged - 76 fixed = 1911 total (was 1976)
          +1 mvnsite 4m 31s the patch passed
          +1 mvneclipse 2m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 7m 52s the patch passed
          +1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125)
          +1 javadoc 0m 28s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed.
          +1 javadoc 0m 18s hadoop-yarn-server-nodemanager in the patch passed.
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961)
          +1 javadoc 0m 12s hadoop-yarn-server-tests in the patch passed.
          +1 javadoc 0m 14s hadoop-yarn-client in the patch passed.
          +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed.
          +1 javadoc 0m 13s hadoop-sls in the patch passed.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          +1 unit 2m 18s hadoop-yarn-common in the patch passed.
          +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 20s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 34m 17s hadoop-yarn-server-resourcemanager in the patch passed.
          -1 unit 4m 29s hadoop-yarn-server-tests in the patch failed.
          +1 unit 16m 6s hadoop-yarn-client in the patch passed.
          +1 unit 8m 46s hadoop-yarn-applications-distributedshell in the patch passed.
          +1 unit 8m 47s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 0m 54s hadoop-sls in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          155m 25s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826182/YARN-5221.013.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux a95683b364d2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4bd45f5
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12943/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12943/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12943/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12943/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12943/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 58s trunk passed +1 compile 7m 3s trunk passed +1 checkstyle 1m 53s trunk passed +1 mvnsite 4m 28s trunk passed +1 mvneclipse 2m 30s trunk passed +1 findbugs 6m 37s trunk passed +1 javadoc 2m 51s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 3m 35s the patch passed +1 compile 7m 0s the patch passed +1 cc 7m 0s the patch passed +1 javac 7m 0s the patch passed -1 checkstyle 1m 51s root: The patch generated 11 new + 1900 unchanged - 76 fixed = 1911 total (was 1976) +1 mvnsite 4m 31s the patch passed +1 mvneclipse 2m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 7m 52s the patch passed +1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125) +1 javadoc 0m 28s hadoop-yarn-common in the patch passed. +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed. +1 javadoc 0m 18s hadoop-yarn-server-nodemanager in the patch passed. +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961) +1 javadoc 0m 12s hadoop-yarn-server-tests in the patch passed. +1 javadoc 0m 14s hadoop-yarn-client in the patch passed. +1 javadoc 0m 13s hadoop-yarn-applications-distributedshell in the patch passed. +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed. +1 javadoc 0m 13s hadoop-sls in the patch passed. +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 18s hadoop-yarn-common in the patch passed. +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. +1 unit 13m 20s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 34m 17s hadoop-yarn-server-resourcemanager in the patch passed. -1 unit 4m 29s hadoop-yarn-server-tests in the patch failed. +1 unit 16m 6s hadoop-yarn-client in the patch passed. +1 unit 8m 46s hadoop-yarn-applications-distributedshell in the patch passed. +1 unit 8m 47s hadoop-mapreduce-client-app in the patch passed. +1 unit 0m 54s hadoop-sls in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 155m 25s Reason Tests Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826182/YARN-5221.013.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux a95683b364d2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4bd45f5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12943/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12943/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12943/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12943/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12943/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Looks good, +1, thanks Arun Suresh.

          And if you plan to commit this patch to branches other than trunk, it's better to submit them to Jenkins before committing.

          Show
          leftnoteasy Wangda Tan added a comment - Looks good, +1, thanks Arun Suresh . And if you plan to commit this patch to branches other than trunk, it's better to submit them to Jenkins before committing.
          Hide
          asuresh Arun Suresh added a comment -

          Thanks for the reviews Wangda Tan and Subru Krishnan.
          Committed this to trunk... Will post a patch for branch-2 shortly and wait for jenkins before committing that and closing this JIRA.

          Show
          asuresh Arun Suresh added a comment - Thanks for the reviews Wangda Tan and Subru Krishnan . Committed this to trunk... Will post a patch for branch-2 shortly and wait for jenkins before committing that and closing this JIRA.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10377 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10377/)
          YARN-5221. Expose UpdateResourceRequest API to allow AM to request for (arun suresh: rev d6d9cff21b7b6141ed88359652cf22e8973c0661)

          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/UpdateContainerRequestPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMNullStateStoreService.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/rm/TestRMContainerAllocator.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateResponse.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerAllocator.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMStateStoreService.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerRequest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java
          • (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerResizing.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/AMRMClientAsync.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/proto/test_token.proto
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerUpdateType.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/ResourceSchedulerWrapper.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/ContainerTokenIdentifier.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/UpdatedContainerPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationCleanup.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/api/protocolrecords/TestProtocolRecords.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/NMContainerStatus.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateRequest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerResourceChangeRequest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/MockContainer.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeManagerResync.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/MockResourceManagerFacade.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoScheduler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/queuing/QueuingContainerManagerImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerError.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMContainerTokenSecretManager.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateRequestPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestIncreaseAllocationExpirer.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClientOnRMRestart.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerResourceChangeRequestPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockAM.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/UpdateContainerErrorPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/api/protocolrecords/TestRegisterNodeManagerRequest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedContainerChangeRequest.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/Container.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/local/TestLocalContainerAllocator.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServer.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdatedContainer.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/security/TestYARNTokenIdentifier.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/TestNMLeveldbStateStoreService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMMemoryStateStoreService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYarnClusterNodeUtilization.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10377 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10377/ ) YARN-5221 . Expose UpdateResourceRequest API to allow AM to request for (arun suresh: rev d6d9cff21b7b6141ed88359652cf22e8973c0661) (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/UpdateContainerRequestPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMNullStateStoreService.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/rm/TestRMContainerAllocator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateResponse.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/scheduler/OpportunisticContainerAllocator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMStateStoreService.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerResizing.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/AMRMClientAsync.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/proto/test_token.proto (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerUpdateType.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/ResourceSchedulerWrapper.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/ContainerTokenIdentifier.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/UpdatedContainerPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationCleanup.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/api/protocolrecords/TestProtocolRecords.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/NMContainerStatus.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerResourceChangeRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/MockContainer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeManagerResync.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/MockResourceManagerFacade.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/queuing/QueuingContainerManagerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdateContainerError.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMContainerTokenSecretManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateRequestPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestIncreaseAllocationExpirer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClientOnRMRestart.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerResourceChangeRequestPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockAM.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/UpdateContainerErrorPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/api/protocolrecords/TestRegisterNodeManagerRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedContainerChangeRequest.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/Container.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/local/TestLocalContainerAllocator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/UpdatedContainer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/security/TestYARNTokenIdentifier.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/TestNMLeveldbStateStoreService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMMemoryStateStoreService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYarnClusterNodeUtilization.java
          Hide
          asuresh Arun Suresh added a comment -

          Attaching patch to kick off jenkins on branch-2

          Show
          asuresh Arun Suresh added a comment - Attaching patch to kick off jenkins on branch-2
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 24m 7s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 1m 19s Maven dependency ordering for branch
          +1 mvninstall 8m 28s branch-2 passed
          +1 compile 6m 57s branch-2 passed with JDK v1.8.0_101
          +1 compile 7m 16s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 2m 9s branch-2 passed
          +1 mvnsite 4m 52s branch-2 passed
          +1 mvneclipse 2m 41s branch-2 passed
          +1 findbugs 9m 3s branch-2 passed
          +1 javadoc 3m 29s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 3m 49s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 4m 25s the patch passed
          +1 compile 6m 23s the patch passed with JDK v1.8.0_101
          +1 cc 6m 23s the patch passed
          +1 javac 6m 23s the patch passed
          +1 compile 7m 38s the patch passed with JDK v1.7.0_111
          -1 cc 7m 38s root-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 16 unchanged - 1 fixed = 17 total (was 17)
          +1 javac 7m 38s the patch passed
          -1 checkstyle 2m 5s root: The patch generated 10 new + 1808 unchanged - 76 fixed = 1818 total (was 1884)
          +1 mvnsite 4m 52s the patch passed
          +1 mvneclipse 2m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 10m 31s the patch passed
          +1 javadoc 0m 16s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125)
          +1 javadoc 0m 29s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 21s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961)
          +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 16s hadoop-yarn-client in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 11s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 13s hadoop-sls in the patch passed with JDK v1.8.0_101.
          +1 javadoc 3m 5s the patch passed with JDK v1.7.0_111
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
          +1 unit 13m 49s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101.
          +1 unit 45m 11s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_101.
          -1 unit 7m 20s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_101.
          +1 unit 16m 19s hadoop-yarn-client in the patch passed with JDK v1.8.0_101.
          +1 unit 7m 19s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101.
          +1 unit 8m 10s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_111.
          +1 unit 2m 26s hadoop-yarn-common in the patch passed with JDK v1.7.0_111.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111.
          +1 unit 13m 56s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111.
          +1 unit 38m 56s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_111.
          -1 unit 7m 5s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_111.
          +1 unit 16m 48s hadoop-yarn-client in the patch passed with JDK v1.7.0_111.
          +1 unit 7m 49s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.7.0_111.
          +1 unit 9m 30s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_111.
          +1 unit 1m 2s hadoop-sls in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          323m 27s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
          JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826277/YARN-5221-branch-2-v1.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 133e6723afbe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 56c9a96
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          cc https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/diff-compile-cc-root-jdk1.7.0_111.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12958/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12958/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 24m 7s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 1m 19s Maven dependency ordering for branch +1 mvninstall 8m 28s branch-2 passed +1 compile 6m 57s branch-2 passed with JDK v1.8.0_101 +1 compile 7m 16s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 2m 9s branch-2 passed +1 mvnsite 4m 52s branch-2 passed +1 mvneclipse 2m 41s branch-2 passed +1 findbugs 9m 3s branch-2 passed +1 javadoc 3m 29s branch-2 passed with JDK v1.8.0_101 +1 javadoc 3m 49s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 4m 25s the patch passed +1 compile 6m 23s the patch passed with JDK v1.8.0_101 +1 cc 6m 23s the patch passed +1 javac 6m 23s the patch passed +1 compile 7m 38s the patch passed with JDK v1.7.0_111 -1 cc 7m 38s root-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 16 unchanged - 1 fixed = 17 total (was 17) +1 javac 7m 38s the patch passed -1 checkstyle 2m 5s root: The patch generated 10 new + 1808 unchanged - 76 fixed = 1818 total (was 1884) +1 mvnsite 4m 52s the patch passed +1 mvneclipse 2m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 10m 31s the patch passed +1 javadoc 0m 16s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 123 unchanged - 2 fixed = 123 total (was 125) +1 javadoc 0m 29s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 16s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 21s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 941 unchanged - 20 fixed = 941 total (was 961) +1 javadoc 0m 11s hadoop-yarn-server-tests in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 16s hadoop-yarn-client in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 11s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 16s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 13s hadoop-sls in the patch passed with JDK v1.8.0_101. +1 javadoc 3m 5s the patch passed with JDK v1.7.0_111 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 unit 13m 49s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101. +1 unit 45m 11s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_101. -1 unit 7m 20s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_101. +1 unit 16m 19s hadoop-yarn-client in the patch passed with JDK v1.8.0_101. +1 unit 7m 19s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101. +1 unit 8m 10s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_101. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_101. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_111. +1 unit 2m 26s hadoop-yarn-common in the patch passed with JDK v1.7.0_111. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111. +1 unit 13m 56s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111. +1 unit 38m 56s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_111. -1 unit 7m 5s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_111. +1 unit 16m 48s hadoop-yarn-client in the patch passed with JDK v1.7.0_111. +1 unit 7m 49s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.7.0_111. +1 unit 9m 30s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_111. +1 unit 1m 2s hadoop-sls in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 323m 27s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826277/YARN-5221-branch-2-v1.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 133e6723afbe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 56c9a96 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 cc https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/diff-compile-cc-root-jdk1.7.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12958/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12958/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12958/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Committed this to branch-2.
          Uploading a patch to test this specifically against branch-2.8 as well

          Show
          asuresh Arun Suresh added a comment - Committed this to branch-2. Uploading a patch to test this specifically against branch-2.8 as well
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 28 new or modified test files.
          0 mvndep 0m 44s Maven dependency ordering for branch
          +1 mvninstall 6m 37s branch-2.8 passed
          +1 compile 5m 54s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 7m 33s branch-2.8 passed with JDK v1.7.0_111
          +1 checkstyle 1m 19s branch-2.8 passed
          +1 mvnsite 4m 45s branch-2.8 passed
          +1 mvneclipse 2m 29s branch-2.8 passed
          +1 findbugs 8m 4s branch-2.8 passed
          +1 javadoc 2m 40s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 3m 5s branch-2.8 passed with JDK v1.7.0_111
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 3m 44s the patch passed
          +1 compile 6m 2s the patch passed with JDK v1.8.0_101
          +1 cc 6m 2s the patch passed
          +1 javac 6m 2s the patch passed
          +1 compile 6m 58s the patch passed with JDK v1.7.0_111
          +1 cc 6m 58s the patch passed
          +1 javac 6m 58s the patch passed
          -1 checkstyle 1m 17s root: The patch generated 12 new + 925 unchanged - 70 fixed = 937 total (was 995)
          +1 mvnsite 4m 39s the patch passed
          +1 mvneclipse 2m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 9m 58s the patch passed
          +1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 149 unchanged - 7 fixed = 149 total (was 156)
          +1 javadoc 0m 27s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 14s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 16s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 973 unchanged - 20 fixed = 973 total (was 993)
          +1 javadoc 0m 10s hadoop-yarn-server-tests in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 13s hadoop-yarn-client in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 12s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 15s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_101.
          +1 javadoc 0m 12s hadoop-sls in the patch passed with JDK v1.8.0_101.
          +1 javadoc 3m 6s the patch passed with JDK v1.7.0_111
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 23s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
          +1 unit 9m 20s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101.
          -1 unit 74m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          -1 unit 7m 0s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_101.
          -1 unit 65m 59s hadoop-yarn-client in the patch failed with JDK v1.8.0_101.
          +1 unit 7m 27s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101.
          -1 unit 9m 59s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_101.
          +1 unit 1m 8s hadoop-sls in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_111.
          +1 unit 2m 33s hadoop-yarn-common in the patch passed with JDK v1.7.0_111.
          +1 unit 0m 28s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111.
          +1 unit 9m 49s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111.
          -1 unit 75m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_111.
          -1 unit 6m 58s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_111.
          -1 unit 66m 12s hadoop-yarn-client in the patch failed with JDK v1.7.0_111.
          +1 unit 7m 40s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.7.0_111.
          +1 unit 10m 1s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_111.
          +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          464m 21s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.app.job.impl.TestJobImpl
          JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826479/YARN-5221-branch-2.8-v1.patch
          JIRA Issue YARN-5221
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 20b3e501f784 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / ce902fc
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_111.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12972/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12972/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 17m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 28 new or modified test files. 0 mvndep 0m 44s Maven dependency ordering for branch +1 mvninstall 6m 37s branch-2.8 passed +1 compile 5m 54s branch-2.8 passed with JDK v1.8.0_101 +1 compile 7m 33s branch-2.8 passed with JDK v1.7.0_111 +1 checkstyle 1m 19s branch-2.8 passed +1 mvnsite 4m 45s branch-2.8 passed +1 mvneclipse 2m 29s branch-2.8 passed +1 findbugs 8m 4s branch-2.8 passed +1 javadoc 2m 40s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 3m 5s branch-2.8 passed with JDK v1.7.0_111 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 3m 44s the patch passed +1 compile 6m 2s the patch passed with JDK v1.8.0_101 +1 cc 6m 2s the patch passed +1 javac 6m 2s the patch passed +1 compile 6m 58s the patch passed with JDK v1.7.0_111 +1 cc 6m 58s the patch passed +1 javac 6m 58s the patch passed -1 checkstyle 1m 17s root: The patch generated 12 new + 925 unchanged - 70 fixed = 937 total (was 995) +1 mvnsite 4m 39s the patch passed +1 mvneclipse 2m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 9m 58s the patch passed +1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 149 unchanged - 7 fixed = 149 total (was 156) +1 javadoc 0m 27s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 14s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 16s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101 with JDK v1.8.0_101 generated 0 new + 973 unchanged - 20 fixed = 973 total (was 993) +1 javadoc 0m 10s hadoop-yarn-server-tests in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 13s hadoop-yarn-client in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 12s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 15s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_101. +1 javadoc 0m 12s hadoop-sls in the patch passed with JDK v1.8.0_101. +1 javadoc 3m 6s the patch passed with JDK v1.7.0_111 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 unit 0m 23s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 unit 9m 20s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101. -1 unit 74m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. -1 unit 7m 0s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_101. -1 unit 65m 59s hadoop-yarn-client in the patch failed with JDK v1.8.0_101. +1 unit 7m 27s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_101. -1 unit 9m 59s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_101. +1 unit 1m 8s hadoop-sls in the patch passed with JDK v1.8.0_101. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_111. +1 unit 2m 33s hadoop-yarn-common in the patch passed with JDK v1.7.0_111. +1 unit 0m 28s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_111. +1 unit 9m 49s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111. -1 unit 75m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_111. -1 unit 6m 58s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_111. -1 unit 66m 12s hadoop-yarn-client in the patch failed with JDK v1.7.0_111. +1 unit 7m 40s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.7.0_111. +1 unit 10m 1s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_111. +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 464m 21s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.app.job.impl.TestJobImpl JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826479/YARN-5221-branch-2.8-v1.patch JIRA Issue YARN-5221 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 20b3e501f784 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / ce902fc Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_111.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_111.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_111.txt https://builds.apache.org/job/PreCommit-YARN-Build/12972/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12972/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/12972/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          The failed tests run fine locally for me. Committing this to branch-2.8 shortly resolving this.

          Show
          asuresh Arun Suresh added a comment - The failed tests run fine locally for me. Committing this to branch-2.8 shortly resolving this.
          Hide
          andrew.wang Andrew Wang added a comment -

          Gentle reminder to please include the appropriate 3.0.0 fix version when committing to trunk, thanks! I also set 2.8.0 since I think the target version was set by mistake instead.

          Show
          andrew.wang Andrew Wang added a comment - Gentle reminder to please include the appropriate 3.0.0 fix version when committing to trunk, thanks! I also set 2.8.0 since I think the target version was set by mistake instead.
          Hide
          jlowe Jason Lowe added a comment -

          This broke rolling downgrades from 2.8 to 2.7. See YARN-5630 for details.

          Show
          jlowe Jason Lowe added a comment - This broke rolling downgrades from 2.8 to 2.7. See YARN-5630 for details.
          Hide
          jlowe Jason Lowe added a comment -

          The branch-2.8 patch also has an issue with UPDATE_EXECUTION_TYPE being present in the ContainerUpdateType but not the corresponding proto. See YARN-5632.

          Show
          jlowe Jason Lowe added a comment - The branch-2.8 patch also has an issue with UPDATE_EXECUTION_TYPE being present in the ContainerUpdateType but not the corresponding proto. See YARN-5632 .

            People

            • Assignee:
              asuresh Arun Suresh
              Reporter:
              asuresh Arun Suresh
            • Votes:
              0 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development