Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6792

Incorrect XML convertion in NodeIDsInfo and LabelsToNodesInfo

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      NodeIDsInfo contains a typo and there is a missing constructor in LabelsToNodesInfo. These bugs does not allow a correct conversation in XML of LabelsToNodesInfo.

      1. YARN-6792.v1.patch
        2 kB
        Giovanni Matteo Fumarola
      2. YARN-6792.v2.patch
        2 kB
        Giovanni Matteo Fumarola

        Issue Links

          Activity

          Hide
          sunilg Sunil G added a comment -

          I guess we need to add some more test cases here as well.

          Show
          sunilg Sunil G added a comment - I guess we need to add some more test cases here as well.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 15m 12s trunk passed
          +1 compile 0m 39s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 42s trunk passed
          +1 findbugs 1m 9s trunk passed
          +1 javadoc 0m 22s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 36s the patch passed
          +1 compile 0m 40s the patch passed
          +1 javac 0m 40s the patch passed
          +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
          +1 mvnsite 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 14s the patch passed
          +1 javadoc 0m 23s the patch passed
                Other Tests
          -1 unit 43m 46s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          67m 57s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6792
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876442/YARN-6792.v1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a16ac08fddfc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 09653ea
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16350/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16350/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16350/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 12s trunk passed +1 compile 0m 39s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 42s trunk passed +1 findbugs 1m 9s trunk passed +1 javadoc 0m 22s trunk passed       Patch Compile Tests +1 mvninstall 0m 36s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7) +1 mvnsite 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 14s the patch passed +1 javadoc 0m 23s the patch passed       Other Tests -1 unit 43m 46s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 67m 57s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6792 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876442/YARN-6792.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a16ac08fddfc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09653ea Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16350/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16350/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16350/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Sunil G, thanks for the feedback. I agree we should increase coverage of the Info/REST parts of YARN. As none of that is currently cover by tests, I propose to deal with this more systematically (not in this minor typo-fix patch). I have opened YARN-6817 for that. Are you ok with this?

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Sunil G , thanks for the feedback. I agree we should increase coverage of the Info/REST parts of YARN. As none of that is currently cover by tests, I propose to deal with this more systematically (not in this minor typo-fix patch). I have opened YARN-6817 for that. Are you ok with this?
          Hide
          sunilg Sunil G added a comment -

          Thanks Giovanni Matteo Fumarola. Makes sense to me as we can have a structured set of test cases to cover this in general. I am just marking these 2 jiras linked for a better traceability.

          A very minor nit. Could you place the new ctor above the getter in LabelsToNodesInfo. Barring that, I am +1 for the latest patch.

          Show
          sunilg Sunil G added a comment - Thanks Giovanni Matteo Fumarola . Makes sense to me as we can have a structured set of test cases to cover this in general. I am just marking these 2 jiras linked for a better traceability. A very minor nit. Could you place the new ctor above the getter in LabelsToNodesInfo. Barring that, I am +1 for the latest patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 13m 17s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 44m 2s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          65m 24s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6792
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877113/YARN-6792.v2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7779ccffa92c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b61ab85
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16421/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16421/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16421/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 17s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 33s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 44m 2s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 65m 24s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6792 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877113/YARN-6792.v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7779ccffa92c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b61ab85 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16421/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16421/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16421/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Sunil G thanks for the feedback - v2 addresses it.
          Yetus reported 2 failed tests not related to my patch.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Sunil G thanks for the feedback - v2 addresses it. Yetus reported 2 failed tests not related to my patch.
          Hide
          subru Subru Krishnan added a comment -

          Sunil G, Thanks for reviewing. Will you be committing or I can so that Giovanni Matteo Fumarola can be unblocked for YARN-5412.

          Show
          subru Subru Krishnan added a comment - Sunil G , Thanks for reviewing. Will you be committing or I can so that Giovanni Matteo Fumarola can be unblocked for YARN-5412 .
          Hide
          sunilg Sunil G added a comment -

          +1. Thanks Subru Krishnan. Yes, I will help to commit the same now.

          Show
          sunilg Sunil G added a comment - +1. Thanks Subru Krishnan . Yes, I will help to commit the same now.
          Hide
          sunilg Sunil G added a comment -

          Committed to trunk/branch-2. Thank you Giovanni Matteo Fumarola for the patch.

          Show
          sunilg Sunil G added a comment - Committed to trunk/branch-2. Thank you Giovanni Matteo Fumarola for the patch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12005 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12005/)
          YARN-6792. Incorrect XML convertion in NodeIDsInfo and (sunilg: rev 228ddaa31d812533b862576445494bc2cd8a2884)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12005 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12005/ ) YARN-6792 . Incorrect XML convertion in NodeIDsInfo and (sunilg: rev 228ddaa31d812533b862576445494bc2cd8a2884) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
          Hide
          subru Subru Krishnan added a comment -

          Thanks Sunil G for reviewing/committing and Giovanni Matteo Fumarola for identifying and fixing the issue!

          Show
          subru Subru Krishnan added a comment - Thanks Sunil G for reviewing/committing and Giovanni Matteo Fumarola for identifying and fixing the issue!
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Sunil G
          This issue is valid for 2.8 too. So i think we should merge to 2.8 too

          Show
          bibinchundatt Bibin A Chundatt added a comment - Sunil G This issue is valid for 2.8 too. So i think we should merge to 2.8 too

            People

            • Assignee:
              giovanni.fumarola Giovanni Matteo Fumarola
              Reporter:
              giovanni.fumarola Giovanni Matteo Fumarola
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development