Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6467

CSQueueMetrics needs to update the current metrics for default partition only

    Details

      Description

      As a followup to YARN-6195, we need to update existing metrics to only default Partition.

      1. YARN-6467.001.patch
        49 kB
        Manikandan R
      2. YARN-6467.001.patch
        3 kB
        Manikandan R
      3. YARN-6467.002.patch
        53 kB
        Manikandan R
      4. YARN-6467.003.patch
        54 kB
        Manikandan R
      5. YARN-6467.004.patch
        54 kB
        Manikandan R
      6. YARN-6467.005.patch
        55 kB
        Manikandan R
      7. YARN-6467.006.patch
        56 kB
        Manikandan R
      8. YARN-6467-branch-2.007.patch
        58 kB
        Manikandan R
      9. YARN-6467-branch-2.008.patch
        54 kB
        Manikandan R
      10. YARN-6467-branch-2.8.009.patch
        48 kB
        Manikandan R
      11. YARN-6467-branch-2.8.010.patch
        47 kB
        Manikandan R
      12. YARN-6467-branch-2.8.011.patch
        47 kB
        Manikandan R

        Issue Links

          Activity

          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R

          I am interested in working on this. Can I take it forward?

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R I am interested in working on this. Can I take it forward?
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Manikandan R for showing interest on this jira, Definitely you can take as i had just started with the fix!
          But hope you have gone through the YARN-6195 and have some idea about what needs to be done ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Manikandan R for showing interest on this jira, Definitely you can take as i had just started with the fix! But hope you have gone through the YARN-6195 and have some idea about what needs to be done ?
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R,

          Yes, I went through YARN-6195 changes and got some understanding on setting usedCapacity and AbsoluteUsedCapacity for default partition.

          CSQueueMetrics has few more metrics - AMResourceLimitMB, AMResourceLimitVCores, usedAMResourceMB & usedAMResourceVCores. These metrics are being set from LeafQueue.java. Similar to YARN-6195, we will need to ensure other metrics being set in LeafQueue.java happens only for default partition.

          Please validate and provide suggestions.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R , Yes, I went through YARN-6195 changes and got some understanding on setting usedCapacity and AbsoluteUsedCapacity for default partition. CSQueueMetrics has few more metrics - AMResourceLimitMB, AMResourceLimitVCores, usedAMResourceMB & usedAMResourceVCores. These metrics are being set from LeafQueue.java. Similar to YARN-6195 , we will need to ensure other metrics being set in LeafQueue.java happens only for default partition. Please validate and provide suggestions.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Manikandan R, yep as simple as that. Hope you could attach the patch for the same.

          Show
          Naganarasimha Naganarasimha G R added a comment - Manikandan R , yep as simple as that. Hope you could attach the patch for the same.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R,

          Attaching draft patch for review. Expecting test cases like TestLeafQueue#testAppAttemptMetrics to fail, but ran without any errors. Please validate.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R , Attaching draft patch for review. Expecting test cases like TestLeafQueue#testAppAttemptMetrics to fail, but ran without any errors. Please validate.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the patch Manikandan R,
          Currently you have finished for:

          • AMResourceLimitMB, AMResourceLimitVCores, (also for user)
          • usedAMResourceMB, usedAMResourceVCores (also for user)

          but IMO we need to still capture for allocatedMB, allocatedVCores, availableMB, availableVCores, pendingMB, pendingVCores, reservedMB, reservedVCores which are all label based. So once you correct for these i presume lot of other test cases should fail.

          Jason Lowe, I thought of segregating partition based queue metrics in a different jira so that this fix can be applied in specific to 2.8.1 and 2.7.4 and partition based queue metrics available in 2.9 and 3.0 alpha 3. Hope this approach is fine, thoughts ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Manikandan R , Currently you have finished for: AMResourceLimitMB, AMResourceLimitVCores, (also for user) usedAMResourceMB, usedAMResourceVCores (also for user) but IMO we need to still capture for allocatedMB, allocatedVCores, availableMB, availableVCores, pendingMB, pendingVCores, reservedMB, reservedVCores which are all label based. So once you correct for these i presume lot of other test cases should fail. Jason Lowe , I thought of segregating partition based queue metrics in a different jira so that this fix can be applied in specific to 2.8.1 and 2.7.4 and partition based queue metrics available in 2.9 and 3.0 alpha 3. Hope this approach is fine, thoughts ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 20s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 1m 1s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 46 unchanged - 0 fixed = 47 total (was 46)
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 39m 32s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          61m 46s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863856/YARN-6467.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e4348823d7c8 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / af8e984
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15664/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15664/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15664/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15664/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 20s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 1s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 46 unchanged - 0 fixed = 47 total (was 46) +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 39m 32s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 61m 46s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863856/YARN-6467.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e4348823d7c8 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af8e984 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15664/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15664/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15664/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15664/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          I thought of segregating partition based queue metrics in a different jira

          I'm totally OK with fixing the queue metrics so they only show the default partition in this jira, assuming those metrics aren't doing anything sane today in light of multiple partitions. We can defer adding the partition dimension to the queue metrics in a separate JIRA. I had already assumed that was the case based on this JIRA's title.

          Show
          jlowe Jason Lowe added a comment - I thought of segregating partition based queue metrics in a different jira I'm totally OK with fixing the queue metrics so they only show the default partition in this jira, assuming those metrics aren't doing anything sane today in light of multiple partitions. We can defer adding the partition dimension to the queue metrics in a separate JIRA. I had already assumed that was the case based on this JIRA's title.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          We can defer adding the partition dimension to the queue metrics in a separate JIRA. I had already assumed that was the case based on this JIRA's title.

          Thanks Jason Lowe, Me too started with the same intention so that we do not mix up new features with the existing and we can safely apply to lower versions, but on second thoughts as the current jira modifications were small so just wanted to confirm the same.

          Show
          Naganarasimha Naganarasimha G R added a comment - We can defer adding the partition dimension to the queue metrics in a separate JIRA. I had already assumed that was the case based on this JIRA's title. Thanks Jason Lowe , Me too started with the same intention so that we do not mix up new features with the existing and we can safely apply to lower versions, but on second thoughts as the current jira modifications were small so just wanted to confirm the same.
          Hide
          jhung Jonathan Hung added a comment -

          We are interested in having queue metrics for each partition. I created YARN-6492 for this task.

          Show
          jhung Jonathan Hung added a comment - We are interested in having queue metrics for each partition. I created YARN-6492 for this task.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Manikandan R, any update one this ? i forgot to assign the issue to your name, if you still plan to do it. Will assign it.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Manikandan R , any update one this ? i forgot to assign the issue to your name, if you still plan to do it. Will assign it.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R

          I am working on it, should be able to submit patch very soon. Please assign.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R I am working on it, should be able to submit patch very soon. Please assign.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R

          Modified almost all related methods in QueueMetrics.java & CSQueueMetrics.java to accept new "label" parameter and made changes in all required places to pass the same param as part of calling those methods. Few methods has been overloaded to provide backward compatibility for FairScheduler.java & FIFOScheduler.java (for ex, reserverResource() in QueueMetrics.java).

          Reg junits, currently am passing "default" label as hardcoded value in some places (for ex, TestQueueMetrics.java). Ideally, it can be enhanced to cover test cases for non default partitions as well once we start implementing label based metrics. Otherwise, passing proper values dynamically.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R Modified almost all related methods in QueueMetrics.java & CSQueueMetrics.java to accept new "label" parameter and made changes in all required places to pass the same param as part of calling those methods. Few methods has been overloaded to provide backward compatibility for FairScheduler.java & FIFOScheduler.java (for ex, reserverResource() in QueueMetrics.java). Reg junits, currently am passing "default" label as hardcoded value in some places (for ex, TestQueueMetrics.java). Ideally, it can be enhanced to cover test cases for non default partitions as well once we start implementing label based metrics. Otherwise, passing proper values dynamically.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 15m 10s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 1m 1s trunk passed
          +1 javadoc 0m 23s trunk passed
          +1 mvninstall 0m 34s the patch passed
          +1 compile 0m 33s the patch passed
          +1 javac 0m 33s the patch passed
          -0 checkstyle 0m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 33 new + 587 unchanged - 5 fixed = 620 total (was 592)
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          -1 whitespace 0m 0s The patch has 54 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 1m 7s the patch passed
          -1 javadoc 0m 20s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 40m 57s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          66m 2s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865786/YARN-6467.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 672749e74846 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 30fc580
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/whitespace-eol.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15781/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15781/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 15m 10s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 1s trunk passed +1 javadoc 0m 23s trunk passed +1 mvninstall 0m 34s the patch passed +1 compile 0m 33s the patch passed +1 javac 0m 33s the patch passed -0 checkstyle 0m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 33 new + 587 unchanged - 5 fixed = 620 total (was 592) +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 16s the patch passed -1 whitespace 0m 0s The patch has 54 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 7s the patch passed -1 javadoc 0m 20s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 40m 57s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 66m 2s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865786/YARN-6467.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 672749e74846 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 30fc580 Default Java 1.8.0_121 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15781/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15781/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15781/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Fixed checkstyle, whitespace & javadoc comments. Junit failures is not related to this patch. Attaching new patch with the changes.
          (On a separate note, my earlier patch name version no. was not correct, it should have been .002, not .001. However, jenkins picked up the recent patch and ran tests.)

          Show
          manirajv06@gmail.com Manikandan R added a comment - Fixed checkstyle, whitespace & javadoc comments. Junit failures is not related to this patch. Attaching new patch with the changes. (On a separate note, my earlier patch name version no. was not correct, it should have been .002, not .001. However, jenkins picked up the recent patch and ran tests.)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 13m 43s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 585 unchanged - 6 fixed = 587 total (was 591)
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 42m 48s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          65m 48s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865933/YARN-6467.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b918fe1c2c21 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b0f54ea
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15795/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15795/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15795/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15795/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 43s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 585 unchanged - 6 fixed = 587 total (was 591) +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 42m 48s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 65m 48s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865933/YARN-6467.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b918fe1c2c21 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0f54ea Default Java 1.8.0_121 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15795/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15795/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15795/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15795/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Manikandan R for incorporating the changes mentioned offline. This way it will make simpler to support metrics for multiple partitions YARN-6492 .
          Overall approach looks good but few nits in the patch is as follows

          1. QueueMetrics ln no 353 - 356: setAvailableResourcesToQueue(Resource) needs to call setAvailableResourcesToQueue(String label, Resource limit). Similarly take care if any other methods are overloaded.
          2. QueueMetrics : please modify label to partition throughout the class where ever added
          3. QueueMetrics ln no 512 - 521: releaseResources(String, Resource) eihter need to consider label, or may be removed if not used anywhere (check the history who added it)
          4. QueueMetrics : we need to capture what all we will capture at partition/queue/user level, if not it will be confusing. for example allocatedContainers and aggregateContainersAllocated, we need to relook whether its at partition level only. we can discuss more on it.
          5. QueueMetrics ln 341 -345 : overloaded method setAvailableResourcesToQueue can be called here.
          6. FiCaSchedulerApp ln no 573 : unnecessary new line
          7. FiCaSchedulerApp ln no 574 : it should be node.getPartition() though container has the same partition. in some narrow cases it might be wrong (partition sharing).
          8. FairScheduler ln no 1076 -1077 : changes not required

          Note:
          QueueMetrics : _decrPendingResources(int, Resource), _incrPendingResources(int, Resource) & _incrPendingResources needs to consider partition too when updating pendingMB abd pendingVcore. (add a note so that it can be handled in next jira)

          P.S. please check and confirm whether the checkstyle issues and test case failure is not related to your patch modifciations.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Manikandan R for incorporating the changes mentioned offline. This way it will make simpler to support metrics for multiple partitions YARN-6492 . Overall approach looks good but few nits in the patch is as follows QueueMetrics ln no 353 - 356: setAvailableResourcesToQueue(Resource) needs to call setAvailableResourcesToQueue(String label, Resource limit). Similarly take care if any other methods are overloaded. QueueMetrics : please modify label to partition throughout the class where ever added QueueMetrics ln no 512 - 521: releaseResources(String, Resource) eihter need to consider label, or may be removed if not used anywhere (check the history who added it) QueueMetrics : we need to capture what all we will capture at partition/queue/user level, if not it will be confusing. for example allocatedContainers and aggregateContainersAllocated , we need to relook whether its at partition level only. we can discuss more on it. QueueMetrics ln 341 -345 : overloaded method setAvailableResourcesToQueue can be called here. FiCaSchedulerApp ln no 573 : unnecessary new line FiCaSchedulerApp ln no 574 : it should be node.getPartition() though container has the same partition. in some narrow cases it might be wrong (partition sharing). FairScheduler ln no 1076 -1077 : changes not required Note: QueueMetrics : _decrPendingResources(int, Resource) , _incrPendingResources(int, Resource) & _incrPendingResources needs to consider partition too when updating pendingMB abd pendingVcore. (add a note so that it can be handled in next jira) P.S. please check and confirm whether the checkstyle issues and test case failure is not related to your patch modifciations.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Thanks Naganarasimha G R for review. Attaching .003.patch for changes.

          1. Taken care.
          2. Renamed in both QueueMetrics and CSQueueMetrics.
          3. Currently it not being used. Hence removed the method. It has been added as part of YARN-4538
          4. Metrics like allocatedContainers and aggregateContainersAllocated are being manipulated only based on partition check - meaning only for "default" partition. For that matter, even for other metrics like pendingMB, pendingVCores are also being modified in the same way. Do we need to capture these info in this JIRA for our future reference?
          5. Taken care as part on point no.1 . Aren't we referring the same?
          6,7,8: Taken care.

          Also verified that Checkstyle issues and Junit failures are not related to this patch.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Thanks Naganarasimha G R for review. Attaching .003.patch for changes. 1. Taken care. 2. Renamed in both QueueMetrics and CSQueueMetrics. 3. Currently it not being used. Hence removed the method. It has been added as part of YARN-4538 4. Metrics like allocatedContainers and aggregateContainersAllocated are being manipulated only based on partition check - meaning only for "default" partition. For that matter, even for other metrics like pendingMB, pendingVCores are also being modified in the same way. Do we need to capture these info in this JIRA for our future reference? 5. Taken care as part on point no.1 . Aren't we referring the same? 6,7,8: Taken care. Also verified that Checkstyle issues and Junit failures are not related to this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 13m 57s trunk passed
          +1 compile 0m 36s trunk passed
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 0m 40s trunk passed
          +1 findbugs 1m 7s trunk passed
          +1 javadoc 0m 22s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 32s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 584 unchanged - 6 fixed = 586 total (was 590)
          +1 mvnsite 0m 35s the patch passed
          -1 whitespace 0m 0s The patch has 60 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 1m 14s the patch passed
          +1 javadoc 0m 20s the patch passed
          +1 unit 39m 40s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          62m 50s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871184/YARN-6467.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 098e41fe5da7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 46f7e91
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16106/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16106/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16106/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16106/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 57s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 0m 40s trunk passed +1 findbugs 1m 7s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 32s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 584 unchanged - 6 fixed = 586 total (was 590) +1 mvnsite 0m 35s the patch passed -1 whitespace 0m 0s The patch has 60 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 14s the patch passed +1 javadoc 0m 20s the patch passed +1 unit 39m 40s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 62m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871184/YARN-6467.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 098e41fe5da7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 46f7e91 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16106/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16106/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16106/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16106/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Fixed checkstyle and whitespace issues.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Fixed checkstyle and whitespace issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 13m 8s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 57s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          +1 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 583 unchanged - 6 fixed = 583 total (was 589)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 39m 1s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          60m 43s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871196/YARN-6467.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux eb0c6825bd38 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 46f7e91
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16108/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16108/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16108/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 8s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed +1 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 583 unchanged - 6 fixed = 583 total (was 589) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 39m 1s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 60m 43s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871196/YARN-6467.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eb0c6825bd38 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 46f7e91 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16108/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16108/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16108/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the patch Manikandan R, latest patch looks good to me. As discussed offline please test in a live cluster and confirm with labels usage metrics is not getting updated and will wait for 2 days before committing the patch

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Manikandan R , latest patch looks good to me. As discussed offline please test in a live cluster and confirm with labels usage metrics is not getting updated and will wait for 2 days before committing the patch
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R Thanks for your review.

          Ran couple of tests in live setup and verified that below discussed metrics are updated only for "default" partition.
          Also made changes to kept these metrics under separate comment in QueueMetrics.java just for ease of reading. Attached the patch for the same.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R Thanks for your review. Ran couple of tests in live setup and verified that below discussed metrics are updated only for "default" partition. Also made changes to kept these metrics under separate comment in QueueMetrics.java just for ease of reading. Attached the patch for the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 13m 10s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 1m 2s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 536 unchanged - 14 fixed = 544 total (was 550)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 6s the patch passed
          +1 javadoc 0m 19s the patch passed
          -1 unit 39m 2s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          60m 33s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873392/YARN-6467.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1bf9edea1d2b 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6460df2
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16196/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16196/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16196/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16196/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 10s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 1m 2s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 536 unchanged - 14 fixed = 544 total (was 550) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 19s the patch passed -1 unit 39m 2s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 60m 33s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873392/YARN-6467.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1bf9edea1d2b 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6460df2 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16196/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16196/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16196/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16196/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Junit failures are not related to this patch. Fixed some related checkstyle errors. Attached patch for the same.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Junit failures are not related to this patch. Fixed some related checkstyle errors. Attached patch for the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 13m 24s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 530 unchanged - 20 fixed = 539 total (was 550)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 39m 0s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          60m 40s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873405/YARN-6467.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9148e01a95e2 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6460df2
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16197/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16197/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16197/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16197/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 24s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 530 unchanged - 20 fixed = 539 total (was 550) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 39m 0s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 60m 40s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873405/YARN-6467.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9148e01a95e2 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6460df2 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16197/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16197/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16197/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16197/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Manikandan R for the patch. Latest patch LGTM, will commit the patch later in the day if no more comments are there from others.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Manikandan R for the patch. Latest patch LGTM, will commit the patch later in the day if no more comments are there from others.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Manikandan R, committed the patch to trunk but cherrypick form trunk to branch-2 is not working, so you need to apply the patch on branch-2 and rectify the issue. could you do that so that i can continue committing to other branches.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Manikandan R , committed the patch to trunk but cherrypick form trunk to branch-2 is not working, so you need to apply the patch on branch-2 and rectify the issue. could you do that so that i can continue committing to other branches.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11885 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11885/)
          YARN-6467. CSQueueMetrics needs to update the current metrics for (naganarasimha_gr: rev e9c2aa1bc383cb08784846534415bf17667d6e41)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestNodeLabelContainerAllocation.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestQueueMetrics.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueueMetrics.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/QueueMetrics.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerApplicationAttempt.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/invariants/TestMetricsInvariantChecker.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueueUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11885 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11885/ ) YARN-6467 . CSQueueMetrics needs to update the current metrics for (naganarasimha_gr: rev e9c2aa1bc383cb08784846534415bf17667d6e41) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestNodeLabelContainerAllocation.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestQueueMetrics.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueueMetrics.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/QueueMetrics.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerApplicationAttempt.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/invariants/TestMetricsInvariantChecker.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueueUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R Applied the changes on branch-2 and attached patch as well.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R Applied the changes on branch-2 and attached patch as well.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          +1 mvninstall 8m 15s branch-2 passed
          +1 compile 0m 41s branch-2 passed with JDK v1.8.0_131
          +1 compile 0m 38s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 33s branch-2 passed
          +1 mvnsite 0m 45s branch-2 passed
          +1 findbugs 1m 29s branch-2 passed
          +1 javadoc 0m 27s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 29s branch-2 passed with JDK v1.7.0_131
          -1 mvninstall 0m 32s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 0m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131.
          -1 javac 0m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131.
          -1 compile 0m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          -1 javac 0m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          -0 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 546 unchanged - 20 fixed = 555 total (was 566)
          -1 mvnsite 0m 37s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 32s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 24s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 30s the patch passed with JDK v1.7.0_131
          -1 unit 0m 34s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          21m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873600/YARN-6467-branch-2.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0a2c2d6c7e0a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / b9bd72c
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16204/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16204/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 8m 15s branch-2 passed +1 compile 0m 41s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 38s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 33s branch-2 passed +1 mvnsite 0m 45s branch-2 passed +1 findbugs 1m 29s branch-2 passed +1 javadoc 0m 27s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 29s branch-2 passed with JDK v1.7.0_131 -1 mvninstall 0m 32s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 0m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131. -1 javac 0m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131. -1 compile 0m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. -1 javac 0m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. -0 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 546 unchanged - 20 fixed = 555 total (was 566) -1 mvnsite 0m 37s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 32s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 24s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 30s the patch passed with JDK v1.7.0_131 -1 unit 0m 34s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 21m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873600/YARN-6467-branch-2.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a2c2d6c7e0a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / b9bd72c Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16204/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16204/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16204/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Manikandan R, can you please check the patch ? Compilation itself is failing because of which other things are reported as failed.

          Show
          Naganarasimha Naganarasimha G R added a comment - Manikandan R , can you please check the patch ? Compilation itself is failing because of which other things are reported as failed.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Rectified patch and attached the same.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Rectified patch and attached the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 21m 51s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 10m 56s branch-2 passed
          +1 compile 0m 31s branch-2 passed with JDK v1.8.0_131
          +1 compile 0m 33s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 32s branch-2 passed
          +1 mvnsite 0m 41s branch-2 passed
          +1 findbugs 1m 15s branch-2 passed
          +1 javadoc 0m 24s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 28s branch-2 passed with JDK v1.7.0_131
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_131
          +1 javac 0m 30s the patch passed
          +1 compile 0m 32s the patch passed with JDK v1.7.0_131
          +1 javac 0m 32s the patch passed
          -0 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 544 unchanged - 20 fixed = 553 total (was 564)
          +1 mvnsite 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 23s the patch passed
          +1 javadoc 0m 22s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 23s the patch passed with JDK v1.7.0_131
          -1 unit 48m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          147m 4s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873802/YARN-6467-branch-2.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fd08cbf7dd17 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ba487ea
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16210/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16210/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16210/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16210/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 21m 51s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 10m 56s branch-2 passed +1 compile 0m 31s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 33s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 32s branch-2 passed +1 mvnsite 0m 41s branch-2 passed +1 findbugs 1m 15s branch-2 passed +1 javadoc 0m 24s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 28s branch-2 passed with JDK v1.7.0_131 +1 mvninstall 0m 33s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_131 +1 javac 0m 30s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_131 +1 javac 0m 32s the patch passed -0 checkstyle 0m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 544 unchanged - 20 fixed = 553 total (was 564) +1 mvnsite 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 22s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_131 -1 unit 48m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 147m 4s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873802/YARN-6467-branch-2.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fd08cbf7dd17 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ba487ea Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16210/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16210/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16210/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16210/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Naganarasimha G R As discussed, Attaching patch for branch 2.8 as well.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Naganarasimha G R As discussed, Attaching patch for branch 2.8 as well.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          -1 mvninstall 2m 0s root in branch-2.8 failed.
          -1 compile 0m 35s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_131.
          -1 compile 0m 8s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.7.0_131.
          +1 checkstyle 0m 8s branch-2.8 passed
          -1 mvnsite 0m 9s hadoop-yarn-server-resourcemanager in branch-2.8 failed.
          -1 findbugs 0m 8s hadoop-yarn-server-resourcemanager in branch-2.8 failed.
          -1 javadoc 0m 7s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_131.
          -1 javadoc 0m 8s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.7.0_131.
          -1 mvninstall 0m 7s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 0m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131.
          -1 javac 0m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131.
          -1 compile 0m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          -1 javac 0m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 checkstyle 0m 8s the patch passed
          -1 mvnsite 0m 9s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 9s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 javadoc 0m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131.
          -1 javadoc 0m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          -1 unit 0m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          6m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d946387
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874297/YARN-6467-branch-2.8.009.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 02f3ddb63a9f 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / fa69581
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16236/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16236/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. -1 mvninstall 2m 0s root in branch-2.8 failed. -1 compile 0m 35s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_131. -1 compile 0m 8s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.7.0_131. +1 checkstyle 0m 8s branch-2.8 passed -1 mvnsite 0m 9s hadoop-yarn-server-resourcemanager in branch-2.8 failed. -1 findbugs 0m 8s hadoop-yarn-server-resourcemanager in branch-2.8 failed. -1 javadoc 0m 7s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_131. -1 javadoc 0m 8s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.7.0_131. -1 mvninstall 0m 7s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 0m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131. -1 javac 0m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131. -1 compile 0m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. -1 javac 0m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 checkstyle 0m 8s the patch passed -1 mvnsite 0m 9s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 9s hadoop-yarn-server-resourcemanager in the patch failed. -1 javadoc 0m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_131. -1 javadoc 0m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. -1 unit 0m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 6m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:d946387 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874297/YARN-6467-branch-2.8.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 02f3ddb63a9f 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / fa69581 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16236/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16236/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16236/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 6m 47s branch-2.8 passed
          +1 compile 0m 30s branch-2.8 passed with JDK v1.8.0_131
          +1 compile 0m 32s branch-2.8 passed with JDK v1.7.0_131
          +1 checkstyle 0m 20s branch-2.8 passed
          +1 mvnsite 0m 39s branch-2.8 passed
          +1 findbugs 1m 12s branch-2.8 passed
          +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_131
          +1 javadoc 0m 24s branch-2.8 passed with JDK v1.7.0_131
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.8.0_131
          +1 javac 0m 28s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.7.0_131
          +1 javac 0m 30s the patch passed
          -0 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 11 new + 218 unchanged - 14 fixed = 229 total (was 232)
          +1 mvnsite 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131 with JDK v1.8.0_131 generated 1 new + 973 unchanged - 0 fixed = 974 total (was 973)
          +1 javadoc 0m 22s the patch passed with JDK v1.7.0_131
          -1 unit 75m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          167m 11s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Dead store to queueMetrics in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java:org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java:[line 279]
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d946387
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874297/YARN-6467-branch-2.8.009.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dcf1ec228527 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / bdbf737
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16243/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16243/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 47s branch-2.8 passed +1 compile 0m 30s branch-2.8 passed with JDK v1.8.0_131 +1 compile 0m 32s branch-2.8 passed with JDK v1.7.0_131 +1 checkstyle 0m 20s branch-2.8 passed +1 mvnsite 0m 39s branch-2.8 passed +1 findbugs 1m 12s branch-2.8 passed +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_131 +1 javadoc 0m 24s branch-2.8 passed with JDK v1.7.0_131 +1 mvninstall 0m 31s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_131 +1 javac 0m 28s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_131 +1 javac 0m 30s the patch passed -0 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 11 new + 218 unchanged - 14 fixed = 229 total (was 232) +1 mvnsite 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131 with JDK v1.8.0_131 generated 1 new + 973 unchanged - 0 fixed = 974 total (was 973) +1 javadoc 0m 22s the patch passed with JDK v1.7.0_131 -1 unit 75m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 167m 11s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Dead store to queueMetrics in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java:org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java: [line 279] JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:d946387 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874297/YARN-6467-branch-2.8.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dcf1ec228527 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / bdbf737 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16243/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16243/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16243/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Fixed checkstyle & javadoc issues. Attached patch for the same. Junit failures are not related to this patch.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Fixed checkstyle & javadoc issues. Attached patch for the same. Junit failures are not related to this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 6m 25s branch-2.8 passed
          +1 compile 0m 28s branch-2.8 passed with JDK v1.8.0_131
          +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_131
          +1 checkstyle 0m 20s branch-2.8 passed
          +1 mvnsite 0m 36s branch-2.8 passed
          +1 findbugs 1m 8s branch-2.8 passed
          +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_131
          +1 javadoc 0m 24s branch-2.8 passed with JDK v1.7.0_131
          +1 mvninstall 0m 30s the patch passed
          +1 compile 0m 25s the patch passed with JDK v1.8.0_131
          +1 javac 0m 25s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.7.0_131
          +1 javac 0m 29s the patch passed
          -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 10 new + 218 unchanged - 14 fixed = 228 total (was 232)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131 with JDK v1.8.0_131 generated 1 new + 973 unchanged - 0 fixed = 974 total (was 973)
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_131
          -1 unit 75m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          166m 11s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Dead store to queueMetrics in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java:org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java:[line 278]
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d946387
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874410/YARN-6467-branch-2.8.010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4f466f257fc0 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / bdbf737
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16245/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16245/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 25s branch-2.8 passed +1 compile 0m 28s branch-2.8 passed with JDK v1.8.0_131 +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_131 +1 checkstyle 0m 20s branch-2.8 passed +1 mvnsite 0m 36s branch-2.8 passed +1 findbugs 1m 8s branch-2.8 passed +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_131 +1 javadoc 0m 24s branch-2.8 passed with JDK v1.7.0_131 +1 mvninstall 0m 30s the patch passed +1 compile 0m 25s the patch passed with JDK v1.8.0_131 +1 javac 0m 25s the patch passed +1 compile 0m 29s the patch passed with JDK v1.7.0_131 +1 javac 0m 29s the patch passed -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 10 new + 218 unchanged - 14 fixed = 228 total (was 232) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 17s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131 with JDK v1.8.0_131 generated 1 new + 973 unchanged - 0 fixed = 974 total (was 973) +1 javadoc 0m 21s the patch passed with JDK v1.7.0_131 -1 unit 75m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 166m 11s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Dead store to queueMetrics in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java:org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueueUtils.updateQueueStatistics(ResourceCalculator, Resource, Resource, CSQueue, RMNodeLabelsManager, String) At CSQueueUtils.java: [line 278] JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:d946387 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874410/YARN-6467-branch-2.8.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4f466f257fc0 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / bdbf737 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_131.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16245/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16245/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16245/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment - - edited

          Hi Manikandan R, can you please check the Findbugs error and test case failures are they related to the patch ?

          Show
          Naganarasimha Naganarasimha G R added a comment - - edited Hi Manikandan R , can you please check the Findbugs error and test case failures are they related to the patch ?
          Hide
          manirajv06@gmail.com Manikandan R added a comment -

          Fixed findbugs error. Junit failures are not related to this patch.

          Show
          manirajv06@gmail.com Manikandan R added a comment - Fixed findbugs error. Junit failures are not related to this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 6m 41s branch-2.8 passed
          +1 compile 0m 32s branch-2.8 passed with JDK v1.8.0_131
          +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_131
          +1 checkstyle 0m 21s branch-2.8 passed
          +1 mvnsite 0m 37s branch-2.8 passed
          +1 findbugs 1m 8s branch-2.8 passed
          +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_131
          +1 javadoc 0m 24s branch-2.8 passed with JDK v1.7.0_131
          +1 mvninstall 0m 30s the patch passed
          +1 compile 0m 24s the patch passed with JDK v1.8.0_131
          +1 javac 0m 24s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.7.0_131
          +1 javac 0m 29s the patch passed
          -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 10 new + 218 unchanged - 14 fixed = 228 total (was 232)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 18s the patch passed
          +1 javadoc 0m 17s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_131
          -1 unit 75m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          166m 41s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d946387
          JIRA Issue YARN-6467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874805/YARN-6467-branch-2.8.011.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d0f02bb49b74 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 486dc3f
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16262/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16262/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16262/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16262/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 41s branch-2.8 passed +1 compile 0m 32s branch-2.8 passed with JDK v1.8.0_131 +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_131 +1 checkstyle 0m 21s branch-2.8 passed +1 mvnsite 0m 37s branch-2.8 passed +1 findbugs 1m 8s branch-2.8 passed +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_131 +1 javadoc 0m 24s branch-2.8 passed with JDK v1.7.0_131 +1 mvninstall 0m 30s the patch passed +1 compile 0m 24s the patch passed with JDK v1.8.0_131 +1 javac 0m 24s the patch passed +1 compile 0m 29s the patch passed with JDK v1.7.0_131 +1 javac 0m 29s the patch passed -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 10 new + 218 unchanged - 14 fixed = 228 total (was 232) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 18s the patch passed +1 javadoc 0m 17s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_131 -1 unit 75m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 166m 41s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:d946387 JIRA Issue YARN-6467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874805/YARN-6467-branch-2.8.011.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d0f02bb49b74 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 486dc3f Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16262/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16262/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16262/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16262/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the contribution Manikandan R. Have committed the patch to branch-2.8, branch-2 and trunk

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the contribution Manikandan R . Have committed the patch to branch-2.8, branch-2 and trunk
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          IIUC Naganarasimha Garla Fix version 2.8.2 need correction

          Show
          bibinchundatt Bibin A Chundatt added a comment - IIUC Naganarasimha Garla Fix version 2.8.2 need correction

            People

            • Assignee:
              manirajv06@gmail.com Manikandan R
              Reporter:
              Naganarasimha Naganarasimha G R
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development