Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
Description
Today user can specify a lot of YARN parameters (such as LogAggregationContext. i.e. all the fields in ApplicationSubmissionContext) when submit an app. The service REST API hasn't accounted for those so far. We need a way to allow users to specify those configs when submitting their service app. Basically, we probably need a separation of
1) configs for AM's own needs
2) configs for deployed services.
Attachments
Attachments
- YARN-6394.yarn-native-services.01.patch
- 38 kB
- Jian He
- YARN-6394.yarn-native-services.02.patch
- 45 kB
- Jian He
- YARN-6394.yarn-native-services.03.patch
- 52 kB
- Jian He
- YARN-6394.yarn-native-services.04.patch
- 53 kB
- Jian He
- YARN-6394.yarn-native-services.05.patch
- 68 kB
- Jian He
- YARN-6394.yarn-native-services.06.patch
- 73 kB
- Jian He
- YARN-6394.yarn-native-services.07.patch
- 78 kB
- Jian He
Issue Links
- is duplicated by
-
YARN-6422 Service REST API should have a way to specify YARN related params
- Resolved
Activity
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 21s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 1s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 1m 13s | Maven dependency ordering for branch |
+1 | mvninstall | 23m 45s | yarn-native-services passed |
+1 | compile | 14m 41s | yarn-native-services passed |
+1 | checkstyle | 1m 31s | yarn-native-services passed |
+1 | mvnsite | 2m 5s | yarn-native-services passed |
+1 | shadedclient | 16m 34s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 2m 2s | yarn-native-services passed |
+1 | javadoc | 1m 29s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 17s | Maven dependency ordering for patch |
+1 | mvninstall | 1m 17s | the patch passed |
+1 | compile | 9m 52s | the patch passed |
+1 | javac | 9m 52s | the patch passed |
-0 | checkstyle | 1m 39s | hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 115 unchanged - 5 fixed = 122 total (was 120) |
+1 | mvnsite | 2m 15s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 16m 9s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 2m 29s | the patch passed |
+1 | javadoc | 1m 21s | the patch passed |
Other Tests | |||
-1 | unit | 2m 58s | hadoop-yarn-services-core in the patch failed. |
+1 | unit | 0m 38s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 23s | hadoop-yarn-site in the patch passed. |
+1 | asflicense | 0m 49s | The patch does not generate ASF License warnings. |
109m 31s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.yarn.service.conf.TestAppJsonResolve |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12893647/YARN-6394.yarn-native-services.01.patch |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
uname | Linux b3c09839a1c9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / 16ecb9c |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18097/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
unit | https://builds.apache.org/job/PreCommit-YARN-Build/18097/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18097/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18097/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
The new patch renamed ConfigFile#props to properties and the ReadinessChecks#props to properties.
And instead of adding a new top-level field for am config, still use the Configuration#properties for the am configs
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 19m 41s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 1m 2s | Maven dependency ordering for branch |
+1 | mvninstall | 16m 15s | yarn-native-services passed |
+1 | compile | 11m 43s | yarn-native-services passed |
+1 | checkstyle | 1m 4s | yarn-native-services passed |
+1 | mvnsite | 1m 17s | yarn-native-services passed |
+1 | shadedclient | 12m 15s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 11s | yarn-native-services passed |
+1 | javadoc | 0m 53s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 11s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 44s | the patch passed |
+1 | compile | 6m 47s | the patch passed |
+1 | javac | 6m 47s | the patch passed |
-0 | checkstyle | 1m 1s | hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 115 unchanged - 5 fixed = 121 total (was 120) |
+1 | mvnsite | 1m 11s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 10m 54s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 25s | the patch passed |
+1 | javadoc | 0m 56s | the patch passed |
Other Tests | |||
+1 | unit | 2m 27s | hadoop-yarn-services-core in the patch passed. |
+1 | unit | 0m 26s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 17s | hadoop-yarn-site in the patch passed. |
+1 | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
97m 56s |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12893817/YARN-6394.yarn-native-services.02.patch |
Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle |
uname | Linux e7e656601344 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / 16ecb9c |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18119/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18119/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18119/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 16m 3s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 3m 31s | Maven dependency ordering for branch |
+1 | mvninstall | 16m 43s | yarn-native-services passed |
+1 | compile | 11m 55s | yarn-native-services passed |
+1 | checkstyle | 1m 9s | yarn-native-services passed |
+1 | mvnsite | 1m 25s | yarn-native-services passed |
+1 | shadedclient | 12m 29s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 23s | yarn-native-services passed |
+1 | javadoc | 0m 54s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 11s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 45s | the patch passed |
+1 | compile | 7m 5s | the patch passed |
+1 | javac | 7m 5s | the patch passed |
-0 | checkstyle | 1m 6s | hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 147 unchanged - 6 fixed = 153 total (was 153) |
+1 | mvnsite | 1m 10s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 10m 31s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 26s | the patch passed |
+1 | javadoc | 0m 50s | the patch passed |
Other Tests | |||
+1 | unit | 2m 42s | hadoop-yarn-services-core in the patch passed. |
+1 | unit | 0m 23s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 14s | hadoop-yarn-site in the patch passed. |
+1 | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
91m 33s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895036/YARN-6394.yarn-native-services.03.patch |
Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle |
uname | Linux c703bddea915 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / ea4df10 |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18269/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18269/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18269/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
- containersFailed is not incremented on Flex by user, because I feel this is user action, considering it as failed maybe not ideal.
- containersRunning inc/dec is moved from Component to ComponentInstance Started and Stopped transition. This is because when user flex a component, the container maybe not yet started, so the containersRunning may be not incremented yet, so below check is added in ComponentInstance#destroy to ensure only dec for ComponentInstance already at STARTED or READY state
if (getState() == STARTED || getState() == READY) { component.decRunningContainers(); }
Looks good overall. Comments on the new documentation:
- dest_file can be an absolute path or a relative path. If it's a relative path, the file will be located in the $PWD/conf directory (where $PWD is the container local directory)
- the example TEMPLATE file is actually an example of the ENV type; ENV is the type where you specify content in the properties. For the TEMPLATE type, you specify a src_file and the properties get substituted into the file contents.
- the other types should be listed as well, PROPERTIES, XML, and ENV
- should we mention src_file is only applicable for HADOOP_XML and TEMPLATE?
Forgot one:
- change the user and domain in the example to use the USER and DOMAIN variables (and make the user "devuser" or some such)
Thanks Billie for the review.
as discussed, removed ENV type, as TEMPLATE type can be used for the same purpose.
uploaded a new patch.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 20m 1s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 3m 21s | Maven dependency ordering for branch |
+1 | mvninstall | 14m 52s | yarn-native-services passed |
+1 | compile | 9m 49s | yarn-native-services passed |
+1 | checkstyle | 0m 52s | yarn-native-services passed |
+1 | mvnsite | 0m 56s | yarn-native-services passed |
+1 | shadedclient | 9m 59s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 0m 57s | yarn-native-services passed |
+1 | javadoc | 0m 37s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 8s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 34s | the patch passed |
+1 | compile | 5m 58s | the patch passed |
+1 | javac | 5m 58s | the patch passed |
-0 | checkstyle | 0m 52s | hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 148 unchanged - 6 fixed = 154 total (was 154) |
+1 | mvnsite | 0m 58s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 9m 12s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 10s | the patch passed |
+1 | javadoc | 0m 43s | the patch passed |
Other Tests | |||
+1 | unit | 2m 26s | hadoop-yarn-services-core in the patch passed. |
+1 | unit | 0m 25s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 16s | hadoop-yarn-site in the patch passed. |
+1 | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
84m 13s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895107/YARN-6394.yarn-native-services.04.patch |
Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle |
uname | Linux a3d87fe9f6ab 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / ea4df10 |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18278/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18278/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18278/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 21m 51s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 1m 3s | Maven dependency ordering for branch |
+1 | mvninstall | 14m 38s | yarn-native-services passed |
+1 | compile | 11m 4s | yarn-native-services passed |
+1 | checkstyle | 1m 2s | yarn-native-services passed |
+1 | mvnsite | 1m 14s | yarn-native-services passed |
+1 | shadedclient | 11m 20s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 7s | yarn-native-services passed |
+1 | javadoc | 0m 52s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 10s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 40s | the patch passed |
+1 | compile | 6m 28s | the patch passed |
+1 | javac | 6m 28s | the patch passed |
-0 | checkstyle | 0m 59s | hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 147 unchanged - 6 fixed = 153 total (was 153) |
+1 | mvnsite | 1m 7s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 9m 51s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site |
+1 | findbugs | 1m 19s | the patch passed |
+1 | javadoc | 0m 47s | the patch passed |
Other Tests | |||
+1 | unit | 2m 31s | hadoop-yarn-services-core in the patch passed. |
+1 | unit | 0m 23s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 15s | hadoop-yarn-site in the patch passed. |
+1 | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
88m 35s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895107/YARN-6394.yarn-native-services.04.patch |
Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle |
uname | Linux ffa1ece208f5 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / ea4df10 |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18282/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18282/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18282/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
- Fixed something related to updating the comp instance state in ATS - in certain cases, the state is not updated.
- few renaming changes in new YARN
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 15m 13s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 1m 10s | Maven dependency ordering for branch |
+1 | mvninstall | 15m 19s | yarn-native-services passed |
+1 | compile | 10m 5s | yarn-native-services passed |
+1 | checkstyle | 1m 7s | yarn-native-services passed |
+1 | mvnsite | 1m 30s | yarn-native-services passed |
+1 | shadedclient | 11m 34s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
+1 | findbugs | 0m 55s | yarn-native-services passed |
+1 | javadoc | 0m 43s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 10s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 48s | the patch passed |
+1 | compile | 6m 14s | the patch passed |
+1 | javac | 6m 14s | the patch passed |
-0 | checkstyle | 0m 59s | hadoop-yarn-project/hadoop-yarn: The patch generated 9 new + 165 unchanged - 8 fixed = 174 total (was 173) |
+1 | mvnsite | 1m 25s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 9m 41s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
+1 | findbugs | 1m 7s | the patch passed |
+1 | javadoc | 0m 40s | the patch passed |
Other Tests | |||
+1 | unit | 2m 17s | hadoop-yarn-services-core in the patch passed. |
+1 | unit | 0m 17s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 9s | hadoop-yarn-site in the patch passed. |
+1 | unit | 3m 5s | hadoop-yarn-ui in the patch passed. |
+1 | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
83m 33s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895292/YARN-6394.yarn-native-services.05.patch |
Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle |
uname | Linux 47ae80e8fb36 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / ea4df10 |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18294/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18294/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18294/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Uploaded a new patch which adds support for user to be able to specify log aggregation context
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
yarn-native-services Compile Tests | |||
0 | mvndep | 0m 53s | Maven dependency ordering for branch |
+1 | mvninstall | 13m 43s | yarn-native-services passed |
+1 | compile | 10m 3s | yarn-native-services passed |
+1 | checkstyle | 1m 0s | yarn-native-services passed |
+1 | mvnsite | 1m 31s | yarn-native-services passed |
+1 | shadedclient | 11m 31s | branch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
+1 | findbugs | 0m 54s | yarn-native-services passed |
+1 | javadoc | 0m 43s | yarn-native-services passed |
Patch Compile Tests | |||
0 | mvndep | 0m 10s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 46s | the patch passed |
+1 | compile | 5m 59s | the patch passed |
+1 | javac | 5m 59s | the patch passed |
-0 | checkstyle | 0m 56s | hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged - 8 fixed = 182 total (was 173) |
+1 | mvnsite | 1m 14s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 9m 27s | patch has no errors when building and testing our client artifacts. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
+1 | findbugs | 1m 8s | the patch passed |
+1 | javadoc | 0m 40s | the patch passed |
Other Tests | |||
+1 | unit | 2m 15s | hadoop-yarn-services-core in the patch passed. |
+1 | unit | 0m 18s | hadoop-yarn-services-api in the patch passed. |
+1 | unit | 0m 9s | hadoop-yarn-site in the patch passed. |
+1 | unit | 2m 57s | hadoop-yarn-ui in the patch passed. |
+1 | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
65m 44s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:0de40f0 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895528/YARN-6394.yarn-native-services.06.patch |
Optional Tests | asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle |
uname | Linux 745c80e51678 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | yarn-native-services / ea4df10 |
maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) |
Default Java | 1.8.0_151 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/18328/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18328/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18328/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
jianhe there are few references to props in Configurations.md. Please change them to properties.
+1 for patch 07. I think this is ready to commit since it only has a few changes in markdown files over the previous patch.
jianhe quick question on log aggregation - so for log include pattern (not rolling), are we expecting app owner to specify ".*" to upload all files?
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | patch | 0m 5s | |
Subsystem | Report/Notes |
---|---|
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895937/YARN-6394.yarn-native-services.07.patch |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18343/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
so for log include pattern (not rolling), are we expecting app owner to specify ".*" to upload all files?
No, that's the default value already.
message LogAggregationContextProto { optional string include_pattern = 1 [default = ".*"]; optional string exclude_pattern = 2 [default = ""]; optional string rolled_logs_include_pattern = 3 [default = ""]; optional string rolled_logs_exclude_pattern = 4 [default = ".*"];
My mistake, I committed before the build had finished and that's why the patch didn't apply.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13193/)
YARN-6394. Support specifying YARN related params in the service REST (jianhe: rev a6c4bd74b636d0715ffb4c1aca9ef4e49201aa02)
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/yarn-component-instance/info.hbs
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/timelineservice/ServiceTimelineEvent.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/provider/AbstractClientProvider.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceMaster.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/timelineservice/ServiceTimelinePublisher.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/ConfigFile.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/client/ServiceClient.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/provider/ProviderUtils.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceMetrics.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/yarn-service/Overview.md
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/conf/YarnServiceConf.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/ReadinessCheck.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/Component.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/conf/YarnServiceConstants.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/yarn-service/YarnServiceAPI.md
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/monitor/probe/MonitorUtils.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-app/components.js
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/main/resources/definition/YARN-Simplified-V1-API-Layer-For-Services.yaml
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/timelineservice/TestServiceTimelinePublisher.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/examples/httpd/httpd.json
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/conf/TestAppJsonResolve.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/resources/org/apache/hadoop/yarn/service/conf/examples/app-override.json
- (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/yarn-service/Configurations.md
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/Configuration.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/main/resources/definition/YARN-Services-Examples.md
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/examples/httpd-no-dns/httpd-no-dns.json
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceScheduler.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/ServiceApiConstants.java
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/components/metrics-table.hbs
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/yarn-service/Examples.md
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/yarn-component-instances/info.hbs
Changes include: