Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6300

NULL_UPDATE_REQUESTS is redundant in TestFairScheduler

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:

      Description

      The TestFairScheduler.NULL_UPDATE_REQUESTS field hides FairSchedulerTestBase.NULL_UPDATE_REQUESTS, which has the same value. The NULL_UPDATE_REQUESTS field should be removed from TestFairScheduler.

      While you're at it, maybe also remove the unused import.

      1. Selection_124.png
        14 kB
        Yuanbo Liu
      2. YARN-6300.001.patch
        2 kB
        Yuanbo Liu

        Activity

        Hide
        yuanbo Yuanbo Liu added a comment -

        upload v1 patch for this JIRA.

        Show
        yuanbo Yuanbo Liu added a comment - upload v1 patch for this JIRA.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 8s trunk passed
        +1 compile 0m 36s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 36s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 8s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 35s the patch passed
        +1 compile 0m 34s the patch passed
        +1 javac 0m 34s the patch passed
        +1 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 193 unchanged - 1 fixed = 193 total (was 194)
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 11s the patch passed
        +1 javadoc 0m 21s the patch passed
        +1 unit 42m 57s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        66m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6300
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856782/YARN-6300.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 84f2001d2eaa 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1eb8186
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15206/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15206/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 8s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 8s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 193 unchanged - 1 fixed = 193 total (was 194) +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 11s the patch passed +1 javadoc 0m 21s the patch passed +1 unit 42m 57s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 66m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6300 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856782/YARN-6300.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 84f2001d2eaa 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1eb8186 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15206/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15206/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Yuanbo Liu for the patch. +1 nonbinding.

        Show
        haibochen Haibo Chen added a comment - Thanks Yuanbo Liu for the patch. +1 nonbinding.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Haibo Chen Thanks for your review.

        Show
        yuanbo Yuanbo Liu added a comment - Haibo Chen Thanks for your review.
        Hide
        templedf Daniel Templeton added a comment -

        +1 LGTM. I'll commit when I get a chance.

        Show
        templedf Daniel Templeton added a comment - +1 LGTM. I'll commit when I get a chance.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Yuanbo Liu. Committed to trunk. The patch doesn't apply on branch-2, so if you want it pulled into 2.9.0, please post a branch-2 patch.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Yuanbo Liu . Committed to trunk. The patch doesn't apply on branch-2, so if you want it pulled into 2.9.0, please post a branch-2 patch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11380 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11380/)
        YARN-6300. NULL_UPDATE_REQUESTS is redundant in TestFairScheduler (templedf: rev 822a74f2ae955ea0893cc02fb36ceb49ceba8014)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11380 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11380/ ) YARN-6300 . NULL_UPDATE_REQUESTS is redundant in TestFairScheduler (templedf: rev 822a74f2ae955ea0893cc02fb36ceb49ceba8014) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java
        Hide
        yuanbo Yuanbo Liu added a comment -

        Daniel Templeton Thanks for your commit

        I've seen this patch in branch-2, so I guess I don't need to provide branch-2 patch any more, right?

        Show
        yuanbo Yuanbo Liu added a comment - Daniel Templeton Thanks for your commit I've seen this patch in branch-2, so I guess I don't need to provide branch-2 patch any more, right?
        Hide
        templedf Daniel Templeton added a comment -

        Yeah, I accidentally pushed it into branch-2, but I made it work.

        Show
        templedf Daniel Templeton added a comment - Yeah, I accidentally pushed it into branch-2, but I made it work.

          People

          • Assignee:
            yuanbo Yuanbo Liu
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development