[YARN-6297] TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed uploaded with that of files expected

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Labels: test
• Hadoop Flags: Reviewed
• Assignee: Haibo Chen
• Reporter: Haibo Chen
• Created: 07/Mar/17 19:20
• Updated: 08/Mar/17 18:52
• Resolved: 08/Mar/17 18:48

Description

Per YARN-6252

  private static void verifyFilesUploaded(Set<String> filesUploaded,
      Set<String> filesExpected) {
    final String errMsgPrefix = "The set of files uploaded are not the same " +
        "as expected";
    if(filesUploaded.size() != filesUploaded.size()) {
      fail(errMsgPrefix + ": actual size: " + filesUploaded.size() + " vs " +
          "expected size: " + filesExpected.size());
    }
    for(String file: filesExpected) {
      if(!filesUploaded.contains(file)) {
        fail(errMsgPrefix + ": expecting " + file);
      }
    }
  }

should check the number of files uploaded against the number of files expected.

Issue Links

• is related to: YARN-6252 Suspicious code fragments: comparing with itself