[YARN-6252] Suspicious code fragments: comparing with itself

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.0.0-alpha2
• Assignee: Haibo Chen
• Reporter: AppChecker
• Created: 28/Feb/17 22:15
• Updated: 07/Mar/17 19:24
• Resolved: 07/Mar/17 19:24

Description

Hi

1)
https://github.com/apache/hadoop/blob/235203dffda1482fb38762fde544c4dd9c3e1fa8/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ReservationId.java#L106

      return getId() > getId() ? 1 : getId() < getId() ? -1 : 0;

strangely, than getId() compare with itself
Probably It should be something like this:

      return this.getId() > other.getId() ? 1 : this.getId() < other.getId() ? -1 : 0;

2) https://github.com/apache/hadoop/blob/235203dffda1482fb38762fde544c4dd9c3e1fa8/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestAppLogAggregatorImpl.java#L260

    if(filesUploaded.size() != filesUploaded.size()) {
      fail(errMsgPrefix + ": actual size: " + filesUploaded.size() + " vs " +
          "expected size: " + filesExpected.size());
    }

filesUploaded.size() compare with it self
probably it should be:

    if(filesUploaded.size() != filesExpected.size()) {
      fail(errMsgPrefix + ": actual size: " + filesUploaded.size() + " vs " +
          "expected size: " + filesExpected.size());
    }

These possible defects found by static code analyzer AppChecker

Issue Links

• relates to: YARN-6296 ReservationId.compareTo ignores id when clustertimestamp is the same
• relates to: YARN-6297 TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed uploaded with that of files expected