Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha2
    • Fix Version/s: 2.8.0, 2.9.0, 3.0.0-alpha2
    • Component/s: resourcemanager
    • Labels:
      None

      Description

      Resource manager is unable to start in secure mode

      2017-01-08 14:27:29,917 INFO org.apache.hadoop.conf.Configuration: found resource hadoop-policy.xml at file:/opt/hadoop/release/hadoop-3.0.0-alpha2-SNAPSHOT/etc/hadoop/hadoop-policy.xml
      2017-01-08 14:27:29,918 INFO org.apache.hadoop.yarn.server.resourcemanager.AdminService: Refresh All
      java.lang.NullPointerException
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.refreshServiceAcls(AdminService.java:569)
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.refreshServiceAcls(AdminService.java:552)
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.refreshAll(AdminService.java:707)
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.transitionToActive(AdminService.java:302)
              at org.apache.hadoop.yarn.server.resourcemanager.ActiveStandbyElectorBasedElectorService.becomeActive(ActiveStandbyElectorBasedElectorService.java:142)
              at org.apache.hadoop.ha.ActiveStandbyElector.becomeActive(ActiveStandbyElector.java:888)
              at org.apache.hadoop.ha.ActiveStandbyElector.processResult(ActiveStandbyElector.java:467)
              at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:599)
              at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
      2017-01-08 14:27:29,919 ERROR org.apache.hadoop.yarn.server.resourcemanager.AdminService: RefreshAll failed so firing fatal event
      org.apache.hadoop.ha.ServiceFailedException
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.refreshAll(AdminService.java:712)
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.transitionToActive(AdminService.java:302)
              at org.apache.hadoop.yarn.server.resourcemanager.ActiveStandbyElectorBasedElectorService.becomeActive(ActiveStandbyElectorBasedElectorService.java:142)
              at org.apache.hadoop.ha.ActiveStandbyElector.becomeActive(ActiveStandbyElector.java:888)
              at org.apache.hadoop.ha.ActiveStandbyElector.processResult(ActiveStandbyElector.java:467)
              at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:599)
              at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
      2017-01-08 14:27:29,920 INFO org.apache.hadoop.ipc.Server: Starting Socket Reader #1 for port 8033
      2017-01-08 14:27:29,948 WARN org.apache.hadoop.ha.ActiveStandbyElector: Exception handling the winning of election
      org.apache.hadoop.ha.ServiceFailedException: RM could not transition to Active
              at org.apache.hadoop.yarn.server.resourcemanager.ActiveStandbyElectorBasedElectorService.becomeActive(ActiveStandbyElectorBasedElectorService.java:144)
              at org.apache.hadoop.ha.ActiveStandbyElector.becomeActive(ActiveStandbyElector.java:888)
              at org.apache.hadoop.ha.ActiveStandbyElector.processResult(ActiveStandbyElector.java:467)
              at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:599)
              at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
      Caused by: org.apache.hadoop.ha.ServiceFailedException: Error on refreshAll during transition to Active
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.transitionToActive(AdminService.java:311)
              at org.apache.hadoop.yarn.server.resourcemanager.ActiveStandbyElectorBasedElectorService.becomeActive(ActiveStandbyElectorBasedElectorService.java:142)
              ... 4 more
      Caused by: org.apache.hadoop.ha.ServiceFailedException
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.refreshAll(AdminService.java:712)
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.transitionToActive(AdminService.java:302)
              ... 5 more
      
      

      ResourceManager services are added in following order

      1. EmbeddedElector
      2. AdminService

      During resource manager service start() .EmbeddedElector starts first and invokes AdminService#refreshAll() but AdminService#serviceStart() happens after ActiveStandbyElectorBasedElectorService service start is complete. So AdminService#server will be null which causes AdminService#refreshAll() to fail

            if (getConfig().getBoolean(
                CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
                false)) {
              refreshServiceAcls();
            }
      
      1. hadoop-secureuser-resourcemanager-vm1.log
        564 kB
        Bibin A Chundatt
      2. YARN-6072.01.patch
        3 kB
        Ajith S
      3. YARN-6072.01.branch-2.patch
        3 kB
        Ajith S
      4. YARN-6072.02.patch
        3 kB
        Ajith S
      5. YARN-6072.01.branch-2.8.patch
        3 kB
        Ajith S
      6. YARN-6072.03.patch
        3 kB
        Ajith S
      7. YARN-6072.03.branch-2.8.patch
        3 kB
        Ajith S

        Issue Links

          Activity

          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Zhe Zhang

          does branch-2.7 have the issue?

          Not applicable for 2.7

          Show
          bibinchundatt Bibin A Chundatt added a comment - Zhe Zhang does branch-2.7 have the issue? Not applicable for 2.7
          Hide
          zhz Zhe Zhang added a comment -

          Thanks for the fix Ajith S Bibin A Chundatt Naganarasimha G R. Quick questions: 1) is this issue valid only when RM HA is used? 2) does branch-2.7 have the issue?

          Show
          zhz Zhe Zhang added a comment - Thanks for the fix Ajith S Bibin A Chundatt Naganarasimha G R . Quick questions: 1) is this issue valid only when RM HA is used? 2) does branch-2.7 have the issue?
          Hide
          Naganarasimha Naganarasimha G R added a comment - - edited

          Thanks for the contributions Ajith S and Bibin A Chundatt for testing and raising the issue in detail. Thanks for additional reviews from Junping Du, Jian He & Karthik Kambatla.
          Committed the patch to branch-2.8, branch-2 and trunk !

          Show
          Naganarasimha Naganarasimha G R added a comment - - edited Thanks for the contributions Ajith S and Bibin A Chundatt for testing and raising the issue in detail. Thanks for additional reviews from Junping Du , Jian He & Karthik Kambatla . Committed the patch to branch-2.8, branch-2 and trunk !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11112 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11112/)
          YARN-6072. RM unable to start in secure mode. Contributed by Ajith S. (naganarasimha_gr: rev a6b06f71797ad1ed9edbcef279bcf7d9e569f955)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11112 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11112/ ) YARN-6072 . RM unable to start in secure mode. Contributed by Ajith S. (naganarasimha_gr: rev a6b06f71797ad1ed9edbcef279bcf7d9e569f955) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Junping Du,Jian He and Karthik Kambatla for confirming. Committing the patch now !

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Junping Du , Jian He and Karthik Kambatla for confirming. Committing the patch now !
          Hide
          jianhe Jian He added a comment -

          looks good to me, +1

          Show
          jianhe Jian He added a comment - looks good to me, +1
          Hide
          djp Junping Du added a comment -

          I believe latest patch already incorporate Jian's comments above. Naganarasimha G R, would you go ahead to do the honor?

          Show
          djp Junping Du added a comment - I believe latest patch already incorporate Jian's comments above. Naganarasimha G R , would you go ahead to do the honor?
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Jian He any more comments or shall i go ahead ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Jian He any more comments or shall i go ahead ?
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Test case failures seems to be unrelated to the patch modifications, I think all of us agree with modifications, hence will commit it shortly !

          Show
          Naganarasimha Naganarasimha G R added a comment - Test case failures seems to be unrelated to the patch modifications, I think all of us agree with modifications, hence will commit it shortly !
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 45s branch-2.8 passed
          +1 compile 0m 29s branch-2.8 passed with JDK v1.8.0_111
          +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 19s branch-2.8 passed
          +1 mvnsite 0m 37s branch-2.8 passed
          +1 mvneclipse 0m 17s branch-2.8 passed
          +1 findbugs 1m 12s branch-2.8 passed
          +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_111
          +1 javadoc 0m 23s branch-2.8 passed with JDK v1.7.0_121
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.8.0_111
          +1 javac 0m 26s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.7.0_121
          +1 javac 0m 29s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 35s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 20s the patch passed
          +1 javadoc 0m 19s the patch passed with JDK v1.8.0_111
          +1 javadoc 0m 22s the patch passed with JDK v1.7.0_121
          -1 unit 74m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          166m 10s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-6072
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846743/YARN-6072.03.branch-2.8.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 17ded226dff4 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / dbac88b
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14637/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14637/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14637/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 45s branch-2.8 passed +1 compile 0m 29s branch-2.8 passed with JDK v1.8.0_111 +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 19s branch-2.8 passed +1 mvnsite 0m 37s branch-2.8 passed +1 mvneclipse 0m 17s branch-2.8 passed +1 findbugs 1m 12s branch-2.8 passed +1 javadoc 0m 20s branch-2.8 passed with JDK v1.8.0_111 +1 javadoc 0m 23s branch-2.8 passed with JDK v1.7.0_121 +1 mvninstall 0m 32s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_111 +1 javac 0m 26s the patch passed +1 compile 0m 29s the patch passed with JDK v1.7.0_121 +1 javac 0m 29s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 20s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_121 -1 unit 74m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 166m 10s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-6072 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846743/YARN-6072.03.branch-2.8.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 17ded226dff4 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / dbac88b Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14637/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14637/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14637/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          The patch looks good. +1, pending Jenkins.

          Show
          kasha Karthik Kambatla added a comment - The patch looks good. +1, pending Jenkins.
          Hide
          djp Junping Du added a comment -

          Latest patch LGTM too. Thanks Ajith S for quickly addressing our comments and Naga for review.
          +1 pending on Jenkins (exclude known UT failures).

          Show
          djp Junping Du added a comment - Latest patch LGTM too. Thanks Ajith S for quickly addressing our comments and Naga for review. +1 pending on Jenkins (exclude known UT failures).
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the patch Ajith S,
          Approach seems good enough as we need to ensure only verifyAndSetConfiguration before login as per YARN-2805 moving initialization of elector after Admin service would avoid additional null check.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Ajith S , Approach seems good enough as we need to ensure only verifyAndSetConfiguration before login as per YARN-2805 moving initialization of elector after Admin service would avoid additional null check.
          Hide
          ajithshetty Ajith S added a comment -

          Thanks for the comments Junping Du Jian He Naganarasimha Garla and Bibin A Chundatt
          I have considered all the comments and reworked on the patch. Please review

          Show
          ajithshetty Ajith S added a comment - Thanks for the comments Junping Du Jian He Naganarasimha Garla and Bibin A Chundatt I have considered all the comments and reworked on the patch. Please review
          Hide
          djp Junping Du added a comment -

          // Set HA configuration should be done before login

          This is added in YARN-2805. We should set HA related configuration before login.

          I think current fix should work fine for non-HA case. However, I think addIfService() mostly used for judging if services but not checking null. If we don't explicit check null or put any comments. I suspect later comers could replace it to addService() in refactor work (because it is obviously a service here). So, it should be better to add null check or some comments here. Also, we should mention in comments why we are re-order the sequence here as what YARN-2805 did.

          Show
          djp Junping Du added a comment - // Set HA configuration should be done before login This is added in YARN-2805 . We should set HA related configuration before login. I think current fix should work fine for non-HA case. However, I think addIfService() mostly used for judging if services but not checking null. If we don't explicit check null or put any comments. I suspect later comers could replace it to addService() in refactor work (because it is obviously a service here). So, it should be better to add null check or some comments here. Also, we should mention in comments why we are re-order the sequence here as what YARN-2805 did.
          Hide
          jianhe Jian He added a comment -

          // Set HA configuration should be done before login

          I don't know why this comment is added. In my understanding, it should at least be fine to move "add admin service" before "add elector service".

          Hmm yes but additionally we get the log trace too,

          Yes, I know. I meant it can be such as: new ServiceFailedException("RefreshAll operation failed ", ex);

          Anyway, based on your explanation, the current patch is also fine to me. these comments are minor.

          Show
          jianhe Jian He added a comment - // Set HA configuration should be done before login I don't know why this comment is added. In my understanding, it should at least be fine to move "add admin service" before "add elector service". Hmm yes but additionally we get the log trace too, Yes, I know. I meant it can be such as: new ServiceFailedException("RefreshAll operation failed ", ex); Anyway, based on your explanation, the current patch is also fine to me. these comments are minor.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Jian He,

          If HA is not enabled, this call will be adding 'null' elector

          offline we had discussed on the same but inside addIfService there is instanceOf check and passing null fails thus not adding it as service.

          I think we can either move the entire elector creation code after add admin service, or move add admin service before adding elector.

          Actually we were not sure what were the steps which needs to be done before login (and why ?) based on the comment "// Set HA configuration should be done before login" so to be on the safer side we just pushed adding of the Elector service only below the adminService. So if you can give more inputs on it we can correct it.

          I think, the ex.getMessage will just be duplicated in the log trace

          Hmm yes but additionally we get the log trace too, though current issue is a code error NPE trace was not coming hence we added.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Jian He , If HA is not enabled, this call will be adding 'null' elector offline we had discussed on the same but inside addIfService there is instanceOf check and passing null fails thus not adding it as service. I think we can either move the entire elector creation code after add admin service, or move add admin service before adding elector. Actually we were not sure what were the steps which needs to be done before login (and why ?) based on the comment "// Set HA configuration should be done before login" so to be on the safer side we just pushed adding of the Elector service only below the adminService. So if you can give more inputs on it we can correct it. I think, the ex.getMessage will just be duplicated in the log trace Hmm yes but additionally we get the log trace too, though current issue is a code error NPE trace was not coming hence we added.
          Hide
          jianhe Jian He added a comment -
          • If HA is not enabled, this call will be adding 'null' elector ? I think we can either move the entire elector creation code after add admin service, or move add admin service before adding elector.
                // elector to be added post adminservice
                addIfService(elector);
            
          • I think, the ex.getMessage will just be duplicated in the log trace ? In addition to add the ex variable, may be replace ex.getMessage() with a more meaningful message for current call only
                  throw new ServiceFailedException(ex.getMessage(), ex);
            
          Show
          jianhe Jian He added a comment - If HA is not enabled, this call will be adding 'null' elector ? I think we can either move the entire elector creation code after add admin service, or move add admin service before adding elector. // elector to be added post adminservice addIfService(elector); I think, the ex.getMessage will just be duplicated in the log trace ? In addition to add the ex variable, may be replace ex.getMessage() with a more meaningful message for current call only throw new ServiceFailedException(ex.getMessage(), ex);
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Ajith S for validating, I think rerun is not required as test case failures are not related to the patch.
          Will wait for the Jian He, Junping Du and Karthik Kambatla's comments before committing !

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Ajith S for validating, I think rerun is not required as test case failures are not related to the patch. Will wait for the Jian He , Junping Du and Karthik Kambatla 's comments before committing !
          Hide
          ajithshetty Ajith S added a comment -

          These test failure on latest patch looks unrelated. Can someone please retrigger this.?

          Show
          ajithshetty Ajith S added a comment - These test failure on latest patch looks unrelated. Can someone please retrigger this.?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 19s branch-2.8 passed
          +1 compile 0m 35s branch-2.8 passed with JDK v1.8.0_111
          +1 compile 0m 34s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 20s branch-2.8 passed
          +1 mvnsite 0m 42s branch-2.8 passed
          +1 mvneclipse 0m 20s branch-2.8 passed
          +1 findbugs 1m 15s branch-2.8 passed
          +1 javadoc 0m 22s branch-2.8 passed with JDK v1.8.0_111
          +1 javadoc 0m 25s branch-2.8 passed with JDK v1.7.0_121
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.8.0_111
          +1 javac 0m 28s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.7.0_121
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 37s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 28s the patch passed
          +1 javadoc 0m 19s the patch passed with JDK v1.8.0_111
          +1 javadoc 0m 24s the patch passed with JDK v1.7.0_121
          -1 unit 78m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          176m 8s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerLazyPreemption
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-6072
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846527/YARN-6072.01.branch-2.8.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 21a63d0daf1c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / f5e837e
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14619/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14619/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14619/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 19s branch-2.8 passed +1 compile 0m 35s branch-2.8 passed with JDK v1.8.0_111 +1 compile 0m 34s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 20s branch-2.8 passed +1 mvnsite 0m 42s branch-2.8 passed +1 mvneclipse 0m 20s branch-2.8 passed +1 findbugs 1m 15s branch-2.8 passed +1 javadoc 0m 22s branch-2.8 passed with JDK v1.8.0_111 +1 javadoc 0m 25s branch-2.8 passed with JDK v1.7.0_121 +1 mvninstall 0m 33s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_111 +1 javac 0m 28s the patch passed +1 compile 0m 31s the patch passed with JDK v1.7.0_121 +1 javac 0m 31s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 37s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 28s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_121 -1 unit 78m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 176m 8s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerLazyPreemption   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-6072 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846527/YARN-6072.01.branch-2.8.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 21a63d0daf1c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / f5e837e Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14619/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14619/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14619/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          +1 LGTM ...

          Show
          Naganarasimha Naganarasimha G R added a comment - +1 LGTM ...
          Hide
          ajithshetty Ajith S added a comment -

          handled checkstyle issue and updated

          Show
          ajithshetty Ajith S added a comment - handled checkstyle issue and updated
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 28s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 1s branch-2 passed
          +1 compile 0m 30s branch-2 passed with JDK v1.8.0_111
          +1 compile 0m 32s branch-2 passed with JDK v1.7.0_121
          +1 checkstyle 0m 25s branch-2 passed
          +1 mvnsite 0m 39s branch-2 passed
          +1 mvneclipse 0m 18s branch-2 passed
          +1 findbugs 1m 15s branch-2 passed
          +1 javadoc 0m 24s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 0m 24s branch-2 passed with JDK v1.7.0_121
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.8.0_111
          +1 javac 0m 28s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.7.0_121
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 20s the patch passed
          +1 javadoc 0m 19s the patch passed with JDK v1.8.0_111
          +1 javadoc 0m 23s the patch passed with JDK v1.7.0_121
          +1 unit 39m 23s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_121.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          96m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue YARN-6072
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846499/YARN-6072.01.branch-2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 82244effb998 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 74bf9c6
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14618/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14618/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 1s branch-2 passed +1 compile 0m 30s branch-2 passed with JDK v1.8.0_111 +1 compile 0m 32s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 25s branch-2 passed +1 mvnsite 0m 39s branch-2 passed +1 mvneclipse 0m 18s branch-2 passed +1 findbugs 1m 15s branch-2 passed +1 javadoc 0m 24s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 24s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 33s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_111 +1 javac 0m 28s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_121 +1 javac 0m 30s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 20s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_121 +1 unit 39m 23s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 96m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6072 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846499/YARN-6072.01.branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 82244effb998 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 74bf9c6 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14618/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14618/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 25s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 1m 6s trunk passed
          +1 javadoc 0m 22s trunk passed
          +1 mvninstall 0m 34s the patch passed
          +1 compile 0m 34s the patch passed
          +1 javac 0m 34s the patch passed
          -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 75 unchanged - 0 fixed = 76 total (was 75)
          +1 mvnsite 0m 35s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 1m 9s the patch passed
          +1 javadoc 0m 20s the patch passed
          +1 unit 40m 52s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          63m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6072
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846492/YARN-6072.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a3c667d13668 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 945db55
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14616/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14616/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14616/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14616/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 25s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 34s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 75 unchanged - 0 fixed = 76 total (was 75) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 9s the patch passed +1 javadoc 0m 20s the patch passed +1 unit 40m 52s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 63m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6072 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846492/YARN-6072.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a3c667d13668 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 945db55 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14616/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/14616/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14616/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/14616/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajithshetty Ajith S added a comment -

          attaching patch for trunk. will update for branch 2 and 2.8 shortly

          Show
          ajithshetty Ajith S added a comment - attaching patch for trunk. will update for branch 2 and 2.8 shortly
          Hide
          djp Junping Du added a comment -

          Jian He's comments are pretty persuasive. I will wait this issue get resolved before kicking off 2.8.0 RC.
          Ajith S, as Karthik Kambatla mentioned above, please let us know your plan and we can help to take over if you have other priorities. Thanks!

          Show
          djp Junping Du added a comment - Jian He 's comments are pretty persuasive. I will wait this issue get resolved before kicking off 2.8.0 RC. Ajith S , as Karthik Kambatla mentioned above, please let us know your plan and we can help to take over if you have other priorities. Thanks!
          Hide
          kasha Karthik Kambatla added a comment - - edited

          My vote would be to play it safe and fix it in 2.8.0. I am happy to review the changes.

          Ajith S - if you are unable to get to this in the next couple of days, please let me know so I can pick it up.

          Show
          kasha Karthik Kambatla added a comment - - edited My vote would be to play it safe and fix it in 2.8.0. I am happy to review the changes. Ajith S - if you are unable to get to this in the next couple of days, please let me know so I can pick it up.
          Hide
          jianhe Jian He added a comment -

          YARN-5709 actually affected the sequence of start. Before YARN-5709, ActiveStandbyElector is created inside AdminService, so it is guaranteed that the server variable is instantiated before ActiveStandbyElector is started. After YARN-5709, this is not the case any more.

          Show
          jianhe Jian He added a comment - YARN-5709 actually affected the sequence of start. Before YARN-5709 , ActiveStandbyElector is created inside AdminService, so it is guaranteed that the server variable is instantiated before ActiveStandbyElector is started. After YARN-5709 , this is not the case any more.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          +1 to unblock for 2.8.0

          Show
          Naganarasimha Naganarasimha G R added a comment - +1 to unblock for 2.8.0
          Hide
          djp Junping Du added a comment -

          YARN-5333 and YARN-5988 are not available in 2.8.0. So issue shouldn't happen in 2.8.0

          I see. Sounds like YARN-5333 is the root cause. However, someone said YARN-5709 could be related, but from my quick check, it doesn't affect sequence of service start. Karthik Kambatla and Jian He, can you confirm YARN-5709 is not related? If so, we can drop 2.8.0 from affected version and target version to unblock our 2.8.0 RC.

          Show
          djp Junping Du added a comment - YARN-5333 and YARN-5988 are not available in 2.8.0. So issue shouldn't happen in 2.8.0 I see. Sounds like YARN-5333 is the root cause. However, someone said YARN-5709 could be related, but from my quick check, it doesn't affect sequence of service start. Karthik Kambatla and Jian He , can you confirm YARN-5709 is not related? If so, we can drop 2.8.0 from affected version and target version to unblock our 2.8.0 RC.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          +1 from my side too. Tried the same on my local cluster seems to be working fine.

          Ajith S
          In addition to changing order please do update logging and exception thrown. Currently we are losing trace.

          @@ -708,7 +708,7 @@ void refreshAll() throws ServiceFailedException {
                 }
                 refreshClusterMaxPriority();
               } catch (Exception ex) {
          +     LOG.error(ex);
          -      throw new ServiceFailedException(ex.getMessage());
          +      throw new ServiceFailedException(ex.getMessage(), ex);
               }
          
          
          Show
          bibinchundatt Bibin A Chundatt added a comment - +1 from my side too. Tried the same on my local cluster seems to be working fine. Ajith S In addition to changing order please do update logging and exception thrown. Currently we are losing trace. @@ -708,7 +708,7 @@ void refreshAll() throws ServiceFailedException { } refreshClusterMaxPriority(); } catch (Exception ex) { + LOG.error(ex); - throw new ServiceFailedException(ex.getMessage()); + throw new ServiceFailedException(ex.getMessage(), ex); }
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Yeah i too meant the same hence mentioned not exactly a blocker for 2.8.0

          Show
          Naganarasimha Naganarasimha G R added a comment - Yeah i too meant the same hence mentioned not exactly a blocker for 2.8.0
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          I do not see any major impact flipping ElectorService and AdminService. I am +1 for flipping the service.

          Show
          rohithsharma Rohith Sharma K S added a comment - I do not see any major impact flipping ElectorService and AdminService. I am +1 for flipping the service.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Naganarasimha Garla
          YARN-5333 and YARN-5988 are not available in 2.8.0. So issue shouldn't happen in 2.8.0

          Show
          bibinchundatt Bibin A Chundatt added a comment - Naganarasimha Garla YARN-5333 and YARN-5988 are not available in 2.8.0. So issue shouldn't happen in 2.8.0
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for raising the issue Bibin A Chundatt,
          I think reordering of the addition of services (AdminService & EmbeddedElector) should solve it but just note that "verifyAndSetConfiguration" should be done before login. so if just ensure addIfService(elector) is after addService(adminService) in ResourceManager.init should be sufficient to avoid the race condition mentioned by Bibin A Chundatt.
          Also the probability of occurrence of this issue in 2.8 is little less as the AdminService.refreshAll is called after rm.transitionToActive() so not exactly a blocker for 2.8 but better to fix.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for raising the issue Bibin A Chundatt , I think reordering of the addition of services (AdminService & EmbeddedElector) should solve it but just note that "verifyAndSetConfiguration" should be done before login. so if just ensure addIfService(elector) is after addService(adminService) in ResourceManager.init should be sufficient to avoid the race condition mentioned by Bibin A Chundatt . Also the probability of occurrence of this issue in 2.8 is little less as the AdminService.refreshAll is called after rm.transitionToActive() so not exactly a blocker for 2.8 but better to fix.
          Hide
          sunilg Sunil G added a comment -
          Show
          sunilg Sunil G added a comment - + Karthik Kambatla Jian He too.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Attaching logs for the same

          cc Rohith Sharma K S Naganarasimha Garla Ajith S

          Show
          bibinchundatt Bibin A Chundatt added a comment - Attaching logs for the same cc Rohith Sharma K S Naganarasimha Garla Ajith S

            People

            • Assignee:
              ajithshetty Ajith S
              Reporter:
              bibinchundatt Bibin A Chundatt
            • Votes:
              0 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development