Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5709

Cleanup leader election configs and pluggability

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: resourcemanager
    • Labels:
      None

      Description

      While reviewing YARN-5677 and YARN-5694, I noticed we could make the curator-based election code cleaner. It is nicer to get this fixed in 2.8 before we ship it, but this can be done at a later time as well.

      1. By EmbeddedElector, we meant it was running as part of the RM daemon. Since the Curator-based elector is also running embedded, I feel the code should be checking for !curatorBased instead of isEmbeddedElector
      2. LeaderElectorService should probably be named CuratorBasedEmbeddedElectorService or some such.
      3. The code that initializes the elector should be at the same place irrespective of whether it is curator-based or not.
      4. We seem to be caching the CuratorFramework instance in RM. It makes more sense for it to be in RMContext. If others are okay with it, we might even be better of having RMContext#getCurator() method to lazily create the curator framework and then cache it.
      1. yarn-5709.1.patch
        52 kB
        Karthik Kambatla
      2. yarn-5709.2.patch
        40 kB
        Karthik Kambatla
      3. yarn-5709.3.patch
        40 kB
        Karthik Kambatla
      4. yarn-5709.4.patch
        43 kB
        Karthik Kambatla
      5. yarn-5709-branch-2.8.01.patch
        64 kB
        Jian He
      6. yarn-5709-branch-2.8.02.patch
        64 kB
        Jian He
      7. yarn-5709-branch-2.8.03.patch
        64 kB
        Daniel Templeton
      8. yarn-5709-branch-2.8.patch
        42 kB
        Karthik Kambatla
      9. yarn-5709-wip.2.patch
        61 kB
        Karthik Kambatla

        Issue Links

          Activity

          Hide
          djp Junping Du added a comment -

          Hi Daniel Templeton, any progress on this issue? If not, shall we downgrade it to major and defer to 2.9 given this is just refactor effort?

          Show
          djp Junping Du added a comment - Hi Daniel Templeton , any progress on this issue? If not, shall we downgrade it to major and defer to 2.9 given this is just refactor effort?
          Hide
          templedf Daniel Templeton added a comment -

          I was actually just about to start work on it today. It's something that Karthik Kambatla really wanted to get in before the confusing naming gets any more entrenched.

          Show
          templedf Daniel Templeton added a comment - I was actually just about to start work on it today. It's something that Karthik Kambatla really wanted to get in before the confusing naming gets any more entrenched.
          Hide
          djp Junping Du added a comment -

          Sure. Thanks for update, Daniel. CC Jian He in case he want to review this code also.

          Show
          djp Junping Du added a comment - Sure. Thanks for update, Daniel. CC Jian He in case he want to review this code also.
          Hide
          jianhe Jian He added a comment -

          When I had offline discussion with Xuan Gong, the ultimate goal is to remove the old EmbeddedElectorService, as we saw the hadoop common's elector implementation kept on having issues one after another in our internal stress testing. We wanted to just replace that with curator implementation. After all, there's no point maintaining two.

          I feel the code should be checking for !curatorBased instead of isEmbeddedElector

          which code is this ?

          The code that initializes the elector should be at the same place irrespective of whether it is curator-based or not.

          Does this mean CuratorLeaderElector initialization should be inside the AdminService ? I don't think it needs to be the case even for the old EmbeddedElectorService too, if you look at the implementation, there's no dependency between the EmbeddedElectorService and AdminService at all.

          Show
          jianhe Jian He added a comment - When I had offline discussion with Xuan Gong , the ultimate goal is to remove the old EmbeddedElectorService, as we saw the hadoop common's elector implementation kept on having issues one after another in our internal stress testing. We wanted to just replace that with curator implementation. After all, there's no point maintaining two. I feel the code should be checking for !curatorBased instead of isEmbeddedElector which code is this ? The code that initializes the elector should be at the same place irrespective of whether it is curator-based or not. Does this mean CuratorLeaderElector initialization should be inside the AdminService ? I don't think it needs to be the case even for the old EmbeddedElectorService too, if you look at the implementation, there's no dependency between the EmbeddedElectorService and AdminService at all.
          Hide
          kasha Karthik Kambatla added a comment -

          Junping Du - I was really hoping to clean up the configs in 2.8.0. The current naming is very confusing, at least to me. Has been a while since I looked at it.

          Will follow up on this with more clear explanations and likely a patch this week. Daniel Templeton - okay if I pick this up?

          Show
          kasha Karthik Kambatla added a comment - Junping Du - I was really hoping to clean up the configs in 2.8.0. The current naming is very confusing, at least to me. Has been a while since I looked at it. Will follow up on this with more clear explanations and likely a patch this week. Daniel Templeton - okay if I pick this up?
          Hide
          kasha Karthik Kambatla added a comment - - edited

          My primary concern with the current 2.8.0 code is confusing configs. The reason we called the existing leader election and the corresponding config embedded was because we wanted to highlight it is embedded in the RM. The plan, at the time, was to add ZKFC-based leader election as well. We should likely leave that config (yarn.resourcemanager.ha.automatic-failover.embedded) alone unless we make a decision that we will not add ZKFC-type of leader election that runs in a different process.

          the ultimate goal is to remove the old EmbeddedElectorService

          We are in agreement here. I am comfortable with ripping out the current implementation of EmbeddedElectorService in 2.8.0 and replacing it with the curator-based implementation.

          Any reason we are not replacing the implementation? Do we just want to be safe and have a workaround in case the curator-based elector turns out to broken? If that is the case, the config that determines the implementation should be removed in a subsequent release and accordingly be called out @Unstable. We should likely not list it in yarn-default.xml.

          don't think it needs to be the case even for the old EmbeddedElectorService too, if you look at the implementation, there's no dependency between the EmbeddedElectorService and AdminService at all.

          I see your point.

          On the dependency front, EmbeddedElectorService does not depend on AdminService. However, if we were to implement a ZKFC-based elector, that would have to depend on the AdminService to affect any transitions at all. I believe Bikas has recommended we keep the same code path irrespective of whether leader election is embedded. I see merit to that argument.

          If we do decide on moving the initialization, we should move it for both implementations and not just one. Implementation-based initialization points is confusing for any new person looking at the code. Even for those looking at it after a while (like me).

          Show
          kasha Karthik Kambatla added a comment - - edited My primary concern with the current 2.8.0 code is confusing configs. The reason we called the existing leader election and the corresponding config embedded was because we wanted to highlight it is embedded in the RM. The plan, at the time, was to add ZKFC-based leader election as well. We should likely leave that config ( yarn.resourcemanager.ha.automatic-failover.embedded ) alone unless we make a decision that we will not add ZKFC-type of leader election that runs in a different process. the ultimate goal is to remove the old EmbeddedElectorService We are in agreement here. I am comfortable with ripping out the current implementation of EmbeddedElectorService in 2.8.0 and replacing it with the curator-based implementation. Any reason we are not replacing the implementation? Do we just want to be safe and have a workaround in case the curator-based elector turns out to broken? If that is the case, the config that determines the implementation should be removed in a subsequent release and accordingly be called out @Unstable. We should likely not list it in yarn-default.xml. don't think it needs to be the case even for the old EmbeddedElectorService too, if you look at the implementation, there's no dependency between the EmbeddedElectorService and AdminService at all. I see your point. On the dependency front, EmbeddedElectorService does not depend on AdminService. However, if we were to implement a ZKFC-based elector, that would have to depend on the AdminService to affect any transitions at all. I believe Bikas has recommended we keep the same code path irrespective of whether leader election is embedded. I see merit to that argument. If we do decide on moving the initialization, we should move it for both implementations and not just one. Implementation-based initialization points is confusing for any new person looking at the code. Even for those looking at it after a while (like me).
          Hide
          jianhe Jian He added a comment -

          yarn.resourcemanager.ha.automatic-failover.embedded

          For the original hadoop-common's elector, I agree we should keep using this config, otherwise, it's incompatible.
          But for the curator-based implementation. I feel we can avoid this config. One less config is one step easier to config HA. This config looks like a placeholder for future implementation only, which can never be set to false as of now. IMHO, instead, a ZK-FC-based-elector config can be added later if it's really implemented in the future.

          Any reason we are not replacing the implementation? Do we just want to be safe and have a workaround in case the curator-based elector turns out to broken?

          Yeah, just intends to be safe.

          If that is the case, the config that determines the implementation should be removed in a subsequent release and accordingly be called out @Unstable. We should likely not list it in yarn-default.xml.

          agree

          If we do decide on moving the initialization, we should move it for both implementations and not just one.

          Agree we can move both.

          However, if we were to implement a ZKFC-based elector, that would have to depend on the AdminService to affect any transitions at all. I believe Bikas has recommended we keep the same code path irrespective of whether leader election is embedded. I see merit to that argument.

          Didn't actually get the argument about keeping the same code path... If EmbeddedElectorService is moved outside of AdminService, it still uses the same code path. EmbeddedElectorService -> AdminService -> transitionToActive/Standby. For ZKFC-based elector, it's the same. IIUC, whether EmbeddedElectorService is initialized inside AdminService or outside does not affect reusing the same code path. And conceptually EmbeddedElectorService does not look like a sub-service of AdminService..

          Show
          jianhe Jian He added a comment - yarn.resourcemanager.ha.automatic-failover.embedded For the original hadoop-common's elector, I agree we should keep using this config, otherwise, it's incompatible. But for the curator-based implementation. I feel we can avoid this config. One less config is one step easier to config HA. This config looks like a placeholder for future implementation only, which can never be set to false as of now. IMHO, instead, a ZK-FC-based-elector config can be added later if it's really implemented in the future. Any reason we are not replacing the implementation? Do we just want to be safe and have a workaround in case the curator-based elector turns out to broken? Yeah, just intends to be safe. If that is the case, the config that determines the implementation should be removed in a subsequent release and accordingly be called out @Unstable. We should likely not list it in yarn-default.xml. agree If we do decide on moving the initialization, we should move it for both implementations and not just one. Agree we can move both. However, if we were to implement a ZKFC-based elector, that would have to depend on the AdminService to affect any transitions at all. I believe Bikas has recommended we keep the same code path irrespective of whether leader election is embedded. I see merit to that argument. Didn't actually get the argument about keeping the same code path... If EmbeddedElectorService is moved outside of AdminService, it still uses the same code path. EmbeddedElectorService -> AdminService -> transitionToActive/Standby. For ZKFC-based elector, it's the same. IIUC, whether EmbeddedElectorService is initialized inside AdminService or outside does not affect reusing the same code path. And conceptually EmbeddedElectorService does not look like a sub-service of AdminService..
          Hide
          kasha Karthik Kambatla added a comment -

          For the original hadoop-common's elector, I agree we should keep using this config, otherwise, it's incompatible.

          yarn.resourcemanager.ha.automatic-failover.embedded only says the leader election is embedded. It does not say anything about the actual implementation of it. It just happened to be ActiveStandbyElector. Now, we are replacing it with the curator-based one. No?

          Show
          kasha Karthik Kambatla added a comment - For the original hadoop-common's elector, I agree we should keep using this config, otherwise, it's incompatible. yarn.resourcemanager.ha.automatic-failover.embedded only says the leader election is embedded. It does not say anything about the actual implementation of it. It just happened to be ActiveStandbyElector. Now, we are replacing it with the curator-based one. No?
          Hide
          jianhe Jian He added a comment -

          yeah... I mean.. if we already have an explicit config (curator-based-elector-enabled), then we don't require a separate yarn.resourcemanager.ha.automatic-failover.embedded config, as curator-based-elector-enabled implied it is embedded.

          Show
          jianhe Jian He added a comment - yeah... I mean.. if we already have an explicit config (curator-based-elector-enabled), then we don't require a separate yarn.resourcemanager.ha.automatic-failover.embedded config, as curator-based-elector-enabled implied it is embedded.
          Hide
          kasha Karthik Kambatla added a comment -

          The patch posted here captures my intention. Jian He - what do you think?

          Show
          kasha Karthik Kambatla added a comment - The patch posted here captures my intention. Jian He - what do you think?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 51s Maven dependency ordering for branch
          +1 mvninstall 8m 14s trunk passed
          +1 compile 5m 12s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 44s trunk passed
          +1 findbugs 2m 26s trunk passed
          +1 javadoc 0m 53s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 6s the patch passed
          +1 compile 5m 9s the patch passed
          -1 javac 5m 9s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 10 new + 339 unchanged - 7 fixed = 349 total (was 346)
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 32s the patch passed
          -1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 913 unchanged - 0 fixed = 915 total (was 913)
          +1 unit 0m 32s hadoop-yarn-api in the patch passed.
          -1 unit 40m 16s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          82m 31s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.TestLeaderElectorService
            hadoop.yarn.server.resourcemanager.TestRMRestart
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMHA
            org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842073/yarn-5709.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a36c94086a4e 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a7288da
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14201/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14201/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 8m 14s trunk passed +1 compile 5m 12s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 44s trunk passed +1 findbugs 2m 26s trunk passed +1 javadoc 0m 53s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 5m 9s the patch passed -1 javac 5m 9s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 10 new + 339 unchanged - 7 fixed = 349 total (was 346) +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 32s the patch passed -1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 913 unchanged - 0 fixed = 915 total (was 913) +1 unit 0m 32s hadoop-yarn-api in the patch passed. -1 unit 40m 16s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 82m 31s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.TestLeaderElectorService   hadoop.yarn.server.resourcemanager.TestRMRestart Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMHA   org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842073/yarn-5709.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a36c94086a4e 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a7288da Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14201/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14201/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14201/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          Updated patch fixes some of the unit tests. It is still work in progress - one of the TestRMHA tests fails. Will continue looking into it.

          Jian He - would still appreciate a cursory look at the approach and if that looks reasonable to you.

          Show
          kasha Karthik Kambatla added a comment - Updated patch fixes some of the unit tests. It is still work in progress - one of the TestRMHA tests fails. Will continue looking into it. Jian He - would still appreciate a cursory look at the approach and if that looks reasonable to you.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 6m 56s trunk passed
          +1 compile 5m 12s trunk passed
          +1 checkstyle 0m 49s trunk passed
          +1 mvnsite 1m 22s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 2m 15s trunk passed
          +1 javadoc 0m 51s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 4m 36s the patch passed
          -1 javac 4m 36s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 12 new + 370 unchanged - 8 fixed = 382 total (was 378)
          +1 mvnsite 1m 14s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 29s the patch passed
          -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 913 unchanged - 0 fixed = 915 total (was 913)
          +1 unit 0m 30s hadoop-yarn-api in the patch passed.
          -1 unit 42m 30s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          81m 54s



          Reason Tests
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands
            org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842192/yarn-5709-wip.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 17868ed092d3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ab923a5
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14210/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14210/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 6m 56s trunk passed +1 compile 5m 12s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 22s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 15s trunk passed +1 javadoc 0m 51s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 4m 36s the patch passed -1 javac 4m 36s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 12 new + 370 unchanged - 8 fixed = 382 total (was 378) +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 29s the patch passed -1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 913 unchanged - 0 fixed = 915 total (was 913) +1 unit 0m 30s hadoop-yarn-api in the patch passed. -1 unit 42m 30s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 81m 54s Reason Tests Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands   org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842192/yarn-5709-wip.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 17868ed092d3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ab923a5 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14210/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14210/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14210/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          yeah, looks good to me overall
          should CURATOR_LEADER_ELECTOR in YarnConfiguration be marked as Private instead of Deprecated ?

          Show
          jianhe Jian He added a comment - yeah, looks good to me overall should CURATOR_LEADER_ELECTOR in YarnConfiguration be marked as Private instead of Deprecated ?
          Hide
          kasha Karthik Kambatla added a comment -

          Since it is a config that users should be able to use, I thought @Public was more appropriate than @Private. The deprecation is to convey our intention that this config would be removed soon.

          Show
          kasha Karthik Kambatla added a comment - Since it is a config that users should be able to use, I thought @Public was more appropriate than @Private. The deprecation is to convey our intention that this config would be removed soon.
          Hide
          jianhe Jian He added a comment -

          i see, sounds good to me.

          Show
          jianhe Jian He added a comment - i see, sounds good to me.
          Hide
          kasha Karthik Kambatla added a comment -

          Patch v2 should take care of javadoc, checkstyle warnings, and unit test failures.

          Only TestRMHA and TestZKRMStateStore had real failures, others were all passing for me locally. Let us see how the next run goes.

          Show
          kasha Karthik Kambatla added a comment - Patch v2 should take care of javadoc, checkstyle warnings, and unit test failures. Only TestRMHA and TestZKRMStateStore had real failures, others were all passing for me locally. Let us see how the next run goes.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 7m 53s trunk passed
          +1 compile 4m 50s trunk passed
          +1 checkstyle 0m 49s trunk passed
          +1 mvnsite 1m 27s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 2m 36s trunk passed
          +1 javadoc 0m 52s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 7s the patch passed
          +1 compile 4m 52s the patch passed
          -1 javac 4m 52s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 368 unchanged - 9 fixed = 375 total (was 377)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 40s the patch passed
          +1 javadoc 0m 49s the patch passed
          +1 unit 0m 28s hadoop-yarn-api in the patch passed.
          +1 unit 39m 52s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          80m 45s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842237/yarn-5709.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f163f3e9b9b5 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 72fe546
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14213/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14213/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14213/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14213/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 7m 53s trunk passed +1 compile 4m 50s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 2m 36s trunk passed +1 javadoc 0m 52s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 7s the patch passed +1 compile 4m 52s the patch passed -1 javac 4m 52s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 47s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 368 unchanged - 9 fixed = 375 total (was 377) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 40s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 0m 28s hadoop-yarn-api in the patch passed. +1 unit 39m 52s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 80m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842237/yarn-5709.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f163f3e9b9b5 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 72fe546 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14213/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14213/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14213/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14213/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 9m 4s trunk passed
          +1 compile 6m 26s trunk passed
          +1 checkstyle 0m 55s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 2m 16s trunk passed
          +1 javadoc 0m 51s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 55s the patch passed
          +1 compile 5m 10s the patch passed
          -1 javac 5m 10s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 369 unchanged - 9 fixed = 376 total (was 378)
          +1 mvnsite 1m 23s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 39s the patch passed
          +1 javadoc 0m 49s the patch passed
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          -1 unit 43m 34s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          87m 33s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842237/yarn-5709.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux addaeefdbd14 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 72fe546
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14212/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14212/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14212/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14212/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14212/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 9m 4s trunk passed +1 compile 6m 26s trunk passed +1 checkstyle 0m 55s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 2m 16s trunk passed +1 javadoc 0m 51s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 5m 10s the patch passed -1 javac 5m 10s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 369 unchanged - 9 fixed = 376 total (was 378) +1 mvnsite 1m 23s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 39s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. -1 unit 43m 34s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 87m 33s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842237/yarn-5709.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux addaeefdbd14 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 72fe546 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14212/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14212/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14212/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14212/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14212/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -
          • Updated patch (v3) fixes pertinent checkstyle issues.
          • The test failure (TestRMRestart) is flaky - I believe YARN-5548 is looking to fix it.
          • The javac warnings are unrelated.

          I believe the code is ready for review. Jian He - can you take a closer look?

          Show
          kasha Karthik Kambatla added a comment - Updated patch (v3) fixes pertinent checkstyle issues. The test failure (TestRMRestart) is flaky - I believe YARN-5548 is looking to fix it. The javac warnings are unrelated. I believe the code is ready for review. Jian He - can you take a closer look?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 7m 43s trunk passed
          +1 compile 5m 5s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 2m 13s trunk passed
          +1 javadoc 0m 52s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 4m 36s the patch passed
          -1 javac 4m 36s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 369 unchanged - 9 fixed = 372 total (was 378)
          +1 mvnsite 1m 14s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 26s the patch passed
          +1 javadoc 0m 49s the patch passed
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          +1 unit 42m 40s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          82m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842270/yarn-5709.3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5d6111197037 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f54afdb
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14220/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14220/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14220/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14220/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 7m 43s trunk passed +1 compile 5m 5s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 0m 52s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 4m 36s the patch passed -1 javac 4m 36s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 369 unchanged - 9 fixed = 372 total (was 378) +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 26s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 42m 40s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 82m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842270/yarn-5709.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5d6111197037 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f54afdb Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14220/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14220/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14220/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14220/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          thanks Karthik for the refactoring, it indeed looks cleaner ! minor comment only:
          could AdminService#getHAZookeeperConnectionState logic be moved into EmbeddedElector itself ? and the caller can directly call EmbeddedElector, so that AdminService#getHAZookeeperConnectionState can be removed
          No need to do in this jira.. I still wonder whether we need the AUTO_FAILOVER_EMBEDDED config, because there's currently no implementation for AUTO_FAILOVER_EMBEDDED to be false. User must not modify this config for configuring HA, which defeats the purpose of a config. If we indeed have a implementation for non-embedded mode (IMHO, this is less likely), a new config can be added for it... thoughts?

          Show
          jianhe Jian He added a comment - thanks Karthik for the refactoring, it indeed looks cleaner ! minor comment only: could AdminService#getHAZookeeperConnectionState logic be moved into EmbeddedElector itself ? and the caller can directly call EmbeddedElector, so that AdminService#getHAZookeeperConnectionState can be removed No need to do in this jira.. I still wonder whether we need the AUTO_FAILOVER_EMBEDDED config, because there's currently no implementation for AUTO_FAILOVER_EMBEDDED to be false. User must not modify this config for configuring HA, which defeats the purpose of a config. If we indeed have a implementation for non-embedded mode (IMHO, this is less likely), a new config can be added for it... thoughts?
          Hide
          kasha Karthik Kambatla added a comment -

          We can't directly call the method on EmbeddedElector as it can be null, and that was the reason I let it be. You are right though, AdminService is not the place for that method. It was hard to pick between RMContext and RM itself given the callers, but I ended up picking RMContext as it corresponds to state information of the RM that we have traditionally used RMContext for.

          Regarding deprecating the config for embedded, let us follow up on the other JIRA Daniel Templeton is working on.

          Show
          kasha Karthik Kambatla added a comment - We can't directly call the method on EmbeddedElector as it can be null, and that was the reason I let it be. You are right though, AdminService is not the place for that method. It was hard to pick between RMContext and RM itself given the callers, but I ended up picking RMContext as it corresponds to state information of the RM that we have traditionally used RMContext for. Regarding deprecating the config for embedded, let us follow up on the other JIRA Daniel Templeton is working on.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 55s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 4m 54s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 1m 18s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 2m 18s trunk passed
          +1 javadoc 1m 1s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 3s the patch passed
          +1 compile 4m 38s the patch passed
          -1 javac 4m 38s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 386 unchanged - 9 fixed = 389 total (was 395)
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 58s the patch passed
          +1 javadoc 0m 51s the patch passed
          +1 unit 0m 34s hadoop-yarn-api in the patch passed.
          -1 unit 43m 43s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          84m 52s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842620/yarn-5709.4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0f9f8e8cc52d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5bd7dec
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14245/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14245/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14245/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14245/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14245/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 55s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 4m 54s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 1m 18s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 2m 18s trunk passed +1 javadoc 1m 1s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 3s the patch passed +1 compile 4m 38s the patch passed -1 javac 4m 38s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 386 unchanged - 9 fixed = 389 total (was 395) +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 58s the patch passed +1 javadoc 0m 51s the patch passed +1 unit 0m 34s hadoop-yarn-api in the patch passed. -1 unit 43m 43s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 84m 52s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842620/yarn-5709.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0f9f8e8cc52d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5bd7dec Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14245/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14245/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14245/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14245/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14245/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 12s Maven dependency ordering for branch
          +1 mvninstall 8m 40s trunk passed
          +1 compile 6m 30s trunk passed
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 1m 33s trunk passed
          +1 mvneclipse 0m 45s trunk passed
          +1 findbugs 2m 48s trunk passed
          +1 javadoc 1m 5s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 5m 54s the patch passed
          -1 javac 5m 54s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
          -0 checkstyle 0m 58s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 387 unchanged - 9 fixed = 390 total (was 396)
          +1 mvnsite 1m 33s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 12s the patch passed
          +1 javadoc 1m 8s the patch passed
          +1 unit 0m 38s hadoop-yarn-api in the patch passed.
          +1 unit 47m 16s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          94m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842620/yarn-5709.4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux cc705f51bf3f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5bd7dec
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14244/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14244/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14244/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14244/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 8m 40s trunk passed +1 compile 6m 30s trunk passed +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 2m 48s trunk passed +1 javadoc 1m 5s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 5m 54s the patch passed -1 javac 5m 54s hadoop-yarn-project_hadoop-yarn generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) -0 checkstyle 0m 58s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 387 unchanged - 9 fixed = 390 total (was 396) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 12s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 0m 38s hadoop-yarn-api in the patch passed. +1 unit 47m 16s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 94m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842620/yarn-5709.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cc705f51bf3f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5bd7dec Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/14244/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14244/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14244/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14244/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          +1, committing

          Show
          jianhe Jian He added a comment - +1, committing
          Hide
          jianhe Jian He added a comment -

          branch-2, and trunk is committed.

          Unfortunately, there seems quite some conflicts with branch-2.8, it's probably missing jiras like YARN-5677.
          Karthik Kambatla, should we backport them ?

          Show
          jianhe Jian He added a comment - branch-2, and trunk is committed. Unfortunately, there seems quite some conflicts with branch-2.8, it's probably missing jiras like YARN-5677 . Karthik Kambatla , should we backport them ?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10982 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10982/)
          YARN-5709. Cleanup leader election configs and pluggability. Contribtued (jianhe: rev a6410a542e59acd9827457df4a257a843f785c29)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestLeaderElectorService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterInfo.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/LeaderElectorService.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ActiveStandbyElectorBasedElectorService.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/EmbeddedElector.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/CuratorBasedElectorService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
          • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/EmbeddedElectorService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10982 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10982/ ) YARN-5709 . Cleanup leader election configs and pluggability. Contribtued (jianhe: rev a6410a542e59acd9827457df4a257a843f785c29) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestLeaderElectorService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterInfo.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/LeaderElectorService.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ActiveStandbyElectorBasedElectorService.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/EmbeddedElector.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/CuratorBasedElectorService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/EmbeddedElectorService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
          Hide
          kasha Karthik Kambatla added a comment -

          I just pushed YARN-5677 to branch-2.8, but just realized YARN-4438 (Curator based leader election) and others did not actually make it to branch-2.8.

          Jian He I am in favor of pushing all of them in 2.8.0. What do you think?

          Show
          kasha Karthik Kambatla added a comment - I just pushed YARN-5677 to branch-2.8, but just realized YARN-4438 (Curator based leader election) and others did not actually make it to branch-2.8. Jian He I am in favor of pushing all of them in 2.8.0. What do you think?
          Hide
          jianhe Jian He added a comment -

          oh,, ok. Sounds good to me, given that those do not affect existing code.

          Show
          jianhe Jian He added a comment - oh,, ok. Sounds good to me, given that those do not affect existing code.
          Hide
          kasha Karthik Kambatla added a comment -

          Jian He - I didn't quite get that. Are you suggested we include curator-based-election in 2.8.0 or leave it out?

          Show
          kasha Karthik Kambatla added a comment - Jian He - I didn't quite get that. Are you suggested we include curator-based-election in 2.8.0 or leave it out?
          Hide
          jianhe Jian He added a comment -

          I agree with what you suggested, include it.

          Show
          jianhe Jian He added a comment - I agree with what you suggested, include it.
          Hide
          djp Junping Du added a comment -

          Sounds like we already make consensus here.
          Hi Karthik Kambatla, I have backport YARN-4438 to branch-2.8, but still many conflicts when applying YARN-5709. Do we still want it to show up in 2.8 release? If so, can you do the backport ASAP?

          Show
          djp Junping Du added a comment - Sounds like we already make consensus here. Hi Karthik Kambatla , I have backport YARN-4438 to branch-2.8, but still many conflicts when applying YARN-5709 . Do we still want it to show up in 2.8 release? If so, can you do the backport ASAP?
          Hide
          djp Junping Du added a comment -

          Karthik Kambatla (or Karthik Kambatla), do you have plan to backport this issue to branch-2.8 before this weekend? I am planning to kick of release build around that timeline.

          Show
          djp Junping Du added a comment - Karthik Kambatla (or Karthik Kambatla ), do you have plan to backport this issue to branch-2.8 before this weekend? I am planning to kick of release build around that timeline.
          Hide
          kasha Karthik Kambatla added a comment -

          Will take a look later today or tomorrow.

          Show
          kasha Karthik Kambatla added a comment - Will take a look later today or tomorrow.
          Hide
          djp Junping Du added a comment -

          Hi Karthik Kambatla, do you get chance to look at it recently? If not, I am OK to defer it to next release given arguably this refactor work doesn't belongs to real blocker for release.

          Show
          djp Junping Du added a comment - Hi Karthik Kambatla , do you get chance to look at it recently? If not, I am OK to defer it to next release given arguably this refactor work doesn't belongs to real blocker for release.
          Hide
          kasha Karthik Kambatla added a comment -

          Sorry for dropping the ball on this. I ll take a look at it today. If I don't get to it, we should likely revert YARN-4438 from branch-2.8.

          Show
          kasha Karthik Kambatla added a comment - Sorry for dropping the ball on this. I ll take a look at it today. If I don't get to it, we should likely revert YARN-4438 from branch-2.8.
          Hide
          djp Junping Du added a comment -

          Sure. Sounds good to me.

          Show
          djp Junping Du added a comment - Sure. Sounds good to me.
          Hide
          kasha Karthik Kambatla added a comment -

          Posting a branch-2.8 patch to address some of the conflicts. Didn't think it was appropriate to pull in changes that were causing these conflicts.

          Show
          kasha Karthik Kambatla added a comment - Posting a branch-2.8 patch to address some of the conflicts. Didn't think it was appropriate to pull in changes that were causing these conflicts.
          Hide
          kasha Karthik Kambatla added a comment -

          The precommit build seems to be having issues doing a "git clean -xdf"

          Show
          kasha Karthik Kambatla added a comment - The precommit build seems to be having issues doing a "git clean -xdf"
          Hide
          djp Junping Du added a comment -

          I noticed the same issue in other JIRAs and filed an infra ticket: INFRA-13141 but have get any respond yet.

          Show
          djp Junping Du added a comment - I noticed the same issue in other JIRAs and filed an infra ticket: INFRA-13141 but have get any respond yet.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 55s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 2m 26s Maven dependency ordering for branch
          +1 mvninstall 7m 41s branch-2.8 passed
          +1 compile 1m 57s branch-2.8 passed with JDK v1.8.0_111
          +1 compile 2m 21s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 38s branch-2.8 passed
          +1 mvnsite 1m 12s branch-2.8 passed
          +1 mvneclipse 0m 31s branch-2.8 passed
          +1 findbugs 2m 20s branch-2.8 passed
          -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111.
          +1 javadoc 0m 44s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 1m 59s the patch passed with JDK v1.8.0_111
          -1 javac 1m 59s hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111 with JDK v1.8.0_111 generated 2 new + 39 unchanged - 0 fixed = 41 total (was 39)
          +1 compile 2m 17s the patch passed with JDK v1.7.0_121
          -1 javac 2m 17s hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121 with JDK v1.7.0_121 generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48)
          -0 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 321 unchanged - 9 fixed = 325 total (was 330)
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 48s the patch passed
          -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111.
          +1 javadoc 0m 42s the patch passed with JDK v1.7.0_121
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
          -1 unit 73m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          201m 10s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844161/yarn-5709-branch-2.8.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d38a5f9ca5ab 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / ae053df
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14424/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14424/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 55s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 2m 26s Maven dependency ordering for branch +1 mvninstall 7m 41s branch-2.8 passed +1 compile 1m 57s branch-2.8 passed with JDK v1.8.0_111 +1 compile 2m 21s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 38s branch-2.8 passed +1 mvnsite 1m 12s branch-2.8 passed +1 mvneclipse 0m 31s branch-2.8 passed +1 findbugs 2m 20s branch-2.8 passed -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111. +1 javadoc 0m 44s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 1m 59s the patch passed with JDK v1.8.0_111 -1 javac 1m 59s hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111 with JDK v1.8.0_111 generated 2 new + 39 unchanged - 0 fixed = 41 total (was 39) +1 compile 2m 17s the patch passed with JDK v1.7.0_121 -1 javac 2m 17s hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121 with JDK v1.7.0_121 generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48) -0 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 321 unchanged - 9 fixed = 325 total (was 330) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 48s the patch passed -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111. +1 javadoc 0m 42s the patch passed with JDK v1.7.0_121 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 73m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 201m 10s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844161/yarn-5709-branch-2.8.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d38a5f9ca5ab 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / ae053df Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_111.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_121.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14424/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14424/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14424/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          I fixed the javac warnings, javadoc warnings seems be existing.

          Show
          jianhe Jian He added a comment - I fixed the javac warnings, javadoc warnings seems be existing.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 41s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 2m 23s Maven dependency ordering for branch
          +1 mvninstall 7m 10s branch-2.8 passed
          +1 compile 1m 49s branch-2.8 passed with JDK v1.8.0_111
          +1 compile 2m 10s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 37s branch-2.8 passed
          +1 mvnsite 1m 5s branch-2.8 passed
          +1 mvneclipse 0m 30s branch-2.8 passed
          +1 findbugs 2m 22s branch-2.8 passed
          -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111.
          +1 javadoc 0m 43s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 55s the patch passed
          +1 compile 1m 46s the patch passed with JDK v1.8.0_111
          +1 javac 1m 46s the patch passed
          +1 compile 2m 10s the patch passed with JDK v1.7.0_121
          +1 javac 2m 10s the patch passed
          -0 checkstyle 0m 36s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 322 unchanged - 9 fixed = 326 total (was 331)
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 43s the patch passed
          -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111.
          +1 javadoc 0m 41s the patch passed with JDK v1.7.0_121
          +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
          -1 unit 74m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          200m 40s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844480/yarn-5709-branch-2.8.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 48571b6f1c41 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 8e4479d
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14447/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14447/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 41s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 2m 23s Maven dependency ordering for branch +1 mvninstall 7m 10s branch-2.8 passed +1 compile 1m 49s branch-2.8 passed with JDK v1.8.0_111 +1 compile 2m 10s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 37s branch-2.8 passed +1 mvnsite 1m 5s branch-2.8 passed +1 mvneclipse 0m 30s branch-2.8 passed +1 findbugs 2m 22s branch-2.8 passed -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111. +1 javadoc 0m 43s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 1m 46s the patch passed with JDK v1.8.0_111 +1 javac 1m 46s the patch passed +1 compile 2m 10s the patch passed with JDK v1.7.0_121 +1 javac 2m 10s the patch passed -0 checkstyle 0m 36s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 322 unchanged - 9 fixed = 326 total (was 331) +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 43s the patch passed -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111. +1 javadoc 0m 41s the patch passed with JDK v1.7.0_121 +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 74m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 200m 40s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844480/yarn-5709-branch-2.8.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 48571b6f1c41 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 8e4479d Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14447/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14447/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14447/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 2m 31s Maven dependency ordering for branch
          +1 mvninstall 8m 33s branch-2.8 passed
          +1 compile 2m 20s branch-2.8 passed with JDK v1.8.0_111
          +1 compile 2m 37s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 45s branch-2.8 passed
          +1 mvnsite 1m 21s branch-2.8 passed
          +1 mvneclipse 0m 35s branch-2.8 passed
          +1 findbugs 2m 45s branch-2.8 passed
          -1 javadoc 0m 26s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111.
          +1 javadoc 0m 49s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 4s the patch passed
          +1 compile 2m 10s the patch passed with JDK v1.8.0_111
          +1 javac 2m 10s the patch passed
          +1 compile 2m 40s the patch passed with JDK v1.7.0_121
          +1 javac 2m 40s the patch passed
          -0 checkstyle 0m 41s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 321 unchanged - 9 fixed = 325 total (was 330)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 12s the patch passed
          -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111.
          +1 javadoc 0m 45s the patch passed with JDK v1.7.0_121
          +1 unit 0m 29s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
          -1 unit 74m 56s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          193m 49s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844814/yarn-5709-branch-2.8.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux efdd2f4df64f 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 0caa114
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14478/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14478/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 2m 31s Maven dependency ordering for branch +1 mvninstall 8m 33s branch-2.8 passed +1 compile 2m 20s branch-2.8 passed with JDK v1.8.0_111 +1 compile 2m 37s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 45s branch-2.8 passed +1 mvnsite 1m 21s branch-2.8 passed +1 mvneclipse 0m 35s branch-2.8 passed +1 findbugs 2m 45s branch-2.8 passed -1 javadoc 0m 26s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111. +1 javadoc 0m 49s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 2m 10s the patch passed with JDK v1.8.0_111 +1 javac 2m 10s the patch passed +1 compile 2m 40s the patch passed with JDK v1.7.0_121 +1 javac 2m 40s the patch passed -0 checkstyle 0m 41s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 321 unchanged - 9 fixed = 325 total (was 330) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 12s the patch passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111. +1 javadoc 0m 45s the patch passed with JDK v1.7.0_121 +1 unit 0m 29s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 74m 56s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 193m 49s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844814/yarn-5709-branch-2.8.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux efdd2f4df64f 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 0caa114 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14478/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14478/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14478/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          I'm not sure which part of the patch is causing javadoc failure, Daniel Templeton, Karthik Kambatla, any clue?

          Show
          jianhe Jian He added a comment - I'm not sure which part of the patch is causing javadoc failure, Daniel Templeton , Karthik Kambatla , any clue?
          Hide
          templedf Daniel Templeton added a comment -

          Hmmm... Looks like ActiveStandbyElectorBasedElectorService.serviceStop() has a javadoc comment inside the method, which is wrong. Building the javadoc with and without the patch, though, I see no difference in the warnings and errors.

          Incidentally, the @SuppressWarnings(value = "unchecked") shouldn't be needed on ActiveStandbyElectorBasedElectorService. notifyFatalError() now that YARN-4457 is in.

          Show
          templedf Daniel Templeton added a comment - Hmmm... Looks like ActiveStandbyElectorBasedElectorService.serviceStop() has a javadoc comment inside the method, which is wrong. Building the javadoc with and without the patch, though, I see no difference in the warnings and errors. Incidentally, the @SuppressWarnings(value = "unchecked") shouldn't be needed on ActiveStandbyElectorBasedElectorService. notifyFatalError() now that YARN-4457 is in.
          Hide
          jianhe Jian He added a comment -

          Could you re-submit the patch with your change and retry ?

          Show
          jianhe Jian He added a comment - Could you re-submit the patch with your change and retry ?
          Hide
          templedf Daniel Templeton added a comment -

          Forgot we were talking about branch-2.8, so the suppress warnings is still needed. In this patch I unjavadoced the comment. It passes test-patch for me. We'll see.

          Show
          templedf Daniel Templeton added a comment - Forgot we were talking about branch-2.8, so the suppress warnings is still needed. In this patch I unjavadoced the comment. It passes test-patch for me. We'll see.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 27s Maven dependency ordering for branch
          +1 mvninstall 7m 28s branch-2.8 passed
          +1 compile 2m 19s branch-2.8 passed with JDK v1.8.0_111
          +1 compile 2m 29s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 38s branch-2.8 passed
          +1 mvnsite 1m 8s branch-2.8 passed
          +1 mvneclipse 0m 29s branch-2.8 passed
          +1 findbugs 2m 32s branch-2.8 passed
          -1 javadoc 0m 26s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111.
          +1 javadoc 0m 48s branch-2.8 passed with JDK v1.7.0_121
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 0s the patch passed
          +1 compile 2m 8s the patch passed with JDK v1.8.0_111
          +1 javac 2m 8s the patch passed
          +1 compile 2m 35s the patch passed with JDK v1.7.0_121
          +1 javac 2m 35s the patch passed
          -0 checkstyle 0m 41s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 321 unchanged - 9 fixed = 325 total (was 330)
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 1s the patch passed
          -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111.
          +1 javadoc 0m 47s the patch passed with JDK v1.7.0_121
          +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_121.
          -1 unit 74m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          190m 8s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue YARN-5709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844987/yarn-5709-branch-2.8.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4339e9754e94 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / e253633
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14485/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14485/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 7m 28s branch-2.8 passed +1 compile 2m 19s branch-2.8 passed with JDK v1.8.0_111 +1 compile 2m 29s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 38s branch-2.8 passed +1 mvnsite 1m 8s branch-2.8 passed +1 mvneclipse 0m 29s branch-2.8 passed +1 findbugs 2m 32s branch-2.8 passed -1 javadoc 0m 26s hadoop-yarn-server-resourcemanager in branch-2.8 failed with JDK v1.8.0_111. +1 javadoc 0m 48s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 2m 8s the patch passed with JDK v1.8.0_111 +1 javac 2m 8s the patch passed +1 compile 2m 35s the patch passed with JDK v1.7.0_121 +1 javac 2m 35s the patch passed -0 checkstyle 0m 41s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 321 unchanged - 9 fixed = 325 total (was 330) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 1s the patch passed -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_111. +1 javadoc 0m 47s the patch passed with JDK v1.7.0_121 +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_121. -1 unit 74m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 190m 8s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue YARN-5709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844987/yarn-5709-branch-2.8.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4339e9754e94 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / e253633 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_111.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14485/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14485/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14485/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Interesting...Why these javadoc warnings only against jdk v1.8?

          Show
          djp Junping Du added a comment - Interesting...Why these javadoc warnings only against jdk v1.8?
          Hide
          templedf Daniel Templeton added a comment -

          It looks to me what's happening is that Yetus isn't managing to tell the difference between old failures and new failures with Java 8. I wonder if any other JIRAs are seeing this...

          Show
          templedf Daniel Templeton added a comment - It looks to me what's happening is that Yetus isn't managing to tell the difference between old failures and new failures with Java 8. I wonder if any other JIRAs are seeing this...
          Hide
          djp Junping Du added a comment -

          The good news is I checked all classes affected in changes - no one shows related javadoc error in javadoc warning log. I saw many JDK8 related warnings to indicate some deprecated usage on existing UI elements so I suspect this warning most likely to belongs to old failures. I am OK to ignore this JDK 8 only warning report.

          Show
          djp Junping Du added a comment - The good news is I checked all classes affected in changes - no one shows related javadoc error in javadoc warning log. I saw many JDK8 related warnings to indicate some deprecated usage on existing UI elements so I suspect this warning most likely to belongs to old failures. I am OK to ignore this JDK 8 only warning report.
          Hide
          jianhe Jian He added a comment -

          ok, looks like so, I'll commit this then

          Show
          jianhe Jian He added a comment - ok, looks like so, I'll commit this then
          Hide
          djp Junping Du added a comment -

          Thanks Jian He!

          Show
          djp Junping Du added a comment - Thanks Jian He !
          Hide
          djp Junping Du added a comment -

          The javadoc error is caused by YARN-4567. Wangda Tan just identify this and just backport to branch-2.8.

          Show
          djp Junping Du added a comment - The javadoc error is caused by YARN-4567 . Wangda Tan just identify this and just backport to branch-2.8.
          Hide
          jianhe Jian He added a comment -

          Committed to branch-2.8

          Thanks, Karthik Kambatla, Daniel Templeton, Junping Du !

          Show
          jianhe Jian He added a comment - Committed to branch-2.8 Thanks, Karthik Kambatla , Daniel Templeton , Junping Du !
          Hide
          sunilg Sunil G added a comment -

          Looks like EmbeddedElector is started earlier to AdminService and causing failure as mentioned in YARN-6072.

          Show
          sunilg Sunil G added a comment - Looks like EmbeddedElector is started earlier to AdminService and causing failure as mentioned in YARN-6072 .

            People

            • Assignee:
              kasha Karthik Kambatla
              Reporter:
              kasha Karthik Kambatla
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development