Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
3.0.0-alpha1
-
None
-
Reviewed
Description
We removed public modifier of AllocationFileLoaderService.Listener in YARN-4997 since it trigger a findbugs warning. However it breaks Hive code in FairSchedulerShim.
AllocationFileLoaderService allocsLoader = new AllocationFileLoaderService(); allocsLoader.init(conf); allocsLoader.setReloadListener(new AllocationFileLoaderService.Listener() { @Override public void onReload(AllocationConfiguration allocs) { allocConf.set(allocs); } }); try { allocsLoader.reloadAllocations(); } catch (Exception ex) { throw new IOException("Failed to load queue allocations", ex); } if (allocConf.get() == null) { allocConf.set(new AllocationConfiguration(conf)); } QueuePlacementPolicy queuePolicy = allocConf.get().getPlacementPolicy(); if (queuePolicy != null) { requestedQueue = queuePolicy.assignAppToQueue(requestedQueue, userName);
As a result we should set the modifier back to public.
Attachments
Attachments
Issue Links
- duplicates
-
YARN-5992 revert the visibility of interface AllocationFileLoaderService.Listener to public for outside usage
-
- Resolved
-
- is duplicated by
-
YARN-5992 revert the visibility of interface AllocationFileLoaderService.Listener to public for outside usage
-
- Resolved
-
- relates to
-
YARN-4997 Update fair scheduler to use pluggable auth provider
-
- Resolved
-