[YARN-6000] Make AllocationFileLoaderService.Listener public

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.9.0, 3.0.0-alpha2
• Component/s: fairscheduler, yarn
• Hadoop Flags: Reviewed
• Assignee: Tao Jie
• Reporter: Tao Jie
• Created: 14/Dec/16 02:12
• Updated: 26/Jan/17 22:12
• Resolved: 23/Dec/16 19:43

Description

We removed public modifier of AllocationFileLoaderService.Listener in YARN-4997 since it trigger a findbugs warning. However it breaks Hive code in FairSchedulerShim.

AllocationFileLoaderService allocsLoader = new AllocationFileLoaderService();
    allocsLoader.init(conf);
    allocsLoader.setReloadListener(new AllocationFileLoaderService.Listener() {
      @Override
      public void onReload(AllocationConfiguration allocs) {
        allocConf.set(allocs);
      }
    });
    try {
      allocsLoader.reloadAllocations();
    } catch (Exception ex) {
      throw new IOException("Failed to load queue allocations", ex);
    }
    if (allocConf.get() == null) {
      allocConf.set(new AllocationConfiguration(conf));
    }
    QueuePlacementPolicy queuePolicy = allocConf.get().getPlacementPolicy();
    if (queuePolicy != null) {
      requestedQueue = queuePolicy.assignAppToQueue(requestedQueue, userName);

As a result we should set the modifier back to public.

Issue Links

• duplicates: YARN-5992 revert the visibility of interface AllocationFileLoaderService.Listener to public for outside usage
• is duplicated by: YARN-5992 revert the visibility of interface AllocationFileLoaderService.Listener to public for outside usage
• relates to: YARN-4997 Update fair scheduler to use pluggable auth provider