Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5834

TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The function is TestNodeStatusUpdater#testNMRMConnectionConf()
      I believe the connectionWaitMs references below were meant to be nmRmConnectionWaitMs.

          conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
              nmRmConnectionWaitMs);
      conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
              connectionWaitMs);
      ...
            long t = System.currentTimeMillis();
            long duration = t - waitStartTime;
            boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) &&
                (duration < (*connectionWaitMs* + delta));
      
            if(!waitTimeValid) {
              // throw exception if NM doesn't retry long enough
              throw new Exception("NM should have tried re-connecting to RM during " +
                "period of at least " + *connectionWaitMs* + " ms, but " +
                "stopped retrying within " + (*connectionWaitMs* + delta) +
                " ms: " + e, e);
            }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lichangleo Chang Li
                Reporter:
                miklos.szegedi@cloudera.com Miklos Szegedi
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: