[YARN-5834] TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha2
• Hadoop Flags: Reviewed
• Assignee: Chang Li
• Reporter: Miklos Szegedi
• Created: 04/Nov/16 01:03
• Updated: 10/Nov/16 22:21
• Resolved: 10/Nov/16 22:17

Description

The function is TestNodeStatusUpdater#testNMRMConnectionConf()
I believe the connectionWaitMs references below were meant to be nmRmConnectionWaitMs.

    conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
        nmRmConnectionWaitMs);
conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
        connectionWaitMs);
...
      long t = System.currentTimeMillis();
      long duration = t - waitStartTime;
      boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) &&
          (duration < (*connectionWaitMs* + delta));

      if(!waitTimeValid) {
        // throw exception if NM doesn't retry long enough
        throw new Exception("NM should have tried re-connecting to RM during " +
          "period of at least " + *connectionWaitMs* + " ms, but " +
          "stopped retrying within " + (*connectionWaitMs* + delta) +
          " ms: " + e, e);
      }

Issue Links

• is broken by: YARN-4132 Separate configs for nodemanager to resourcemanager connection timeout and retries