Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5834

TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The function is TestNodeStatusUpdater#testNMRMConnectionConf()
      I believe the connectionWaitMs references below were meant to be nmRmConnectionWaitMs.

          conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
              nmRmConnectionWaitMs);
      conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
              connectionWaitMs);
      ...
            long t = System.currentTimeMillis();
            long duration = t - waitStartTime;
            boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) &&
                (duration < (*connectionWaitMs* + delta));
      
            if(!waitTimeValid) {
              // throw exception if NM doesn't retry long enough
              throw new Exception("NM should have tried re-connecting to RM during " +
                "period of at least " + *connectionWaitMs* + " ms, but " +
                "stopped retrying within " + (*connectionWaitMs* + delta) +
                " ms: " + e, e);
            }
      

        Issue Links

          Activity

          Hide
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment -

          Chang Li, could you please look at this bug, if the description is correct?

          Show
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment - Chang Li , could you please look at this bug, if the description is correct?
          Hide
          lichangleo Chang Li added a comment -

          Thanks for reporting. Yes it's meant to be nmRmConnectionWaitMs. Provide branch-2 patch since this test does not exist in trunk

          Show
          lichangleo Chang Li added a comment - Thanks for reporting. Yes it's meant to be nmRmConnectionWaitMs. Provide branch-2 patch since this test does not exist in trunk
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 52s branch-2 passed
          +1 compile 0m 25s branch-2 passed with JDK v1.8.0_101
          +1 compile 0m 27s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 21s branch-2 passed
          +1 mvnsite 0m 31s branch-2 passed
          +1 mvneclipse 0m 15s branch-2 passed
          +1 findbugs 0m 54s branch-2 passed
          +1 javadoc 0m 18s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 0m 19s branch-2 passed with JDK v1.7.0_111
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.8.0_101
          +1 javac 0m 26s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.7.0_111
          +1 javac 0m 28s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 29s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_101
          +1 javadoc 0m 17s the patch passed with JDK v1.7.0_111
          +1 unit 15m 36s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          47m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue YARN-5834
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838319/YARN-5834-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 87018bab2daf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / f7b2542
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13857/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13857/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 52s branch-2 passed +1 compile 0m 25s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 27s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 21s branch-2 passed +1 mvnsite 0m 31s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 0m 54s branch-2 passed +1 javadoc 0m 18s branch-2 passed with JDK v1.8.0_101 +1 javadoc 0m 19s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 25s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_101 +1 javac 0m 26s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_111 +1 javac 0m 28s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_111 +1 unit 15m 36s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 47m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-5834 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838319/YARN-5834-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 87018bab2daf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / f7b2542 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13857/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13857/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment -

          +1 non-binding. Thank you, Chang Li! The change looks good to me.

          Show
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment - +1 non-binding. Thank you, Chang Li ! The change looks good to me.
          Hide
          kasha Karthik Kambatla added a comment -

          +1. Checking this in..

          Show
          kasha Karthik Kambatla added a comment - +1. Checking this in..
          Hide
          kasha Karthik Kambatla added a comment -

          Just committed this to trunk and branch-2.

          Thanks Miklos Szegedi for reporting this and Chang Li for promptly fixing it.

          Show
          kasha Karthik Kambatla added a comment - Just committed this to trunk and branch-2. Thanks Miklos Szegedi for reporting this and Chang Li for promptly fixing it.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10814 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10814/)
          YARN-5834. TestNodeStatusUpdater.testNMRMConnectionConf compares (kasha: rev 3a98419532687e4362ffc26abbc1264232820db7)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10814 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10814/ ) YARN-5834 . TestNodeStatusUpdater.testNMRMConnectionConf compares (kasha: rev 3a98419532687e4362ffc26abbc1264232820db7) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java

            People

            • Assignee:
              lichangleo Chang Li
              Reporter:
              miklos.szegedi@cloudera.com Miklos Szegedi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development