Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4132

Separate configs for nodemanager to resourcemanager connection timeout and retries

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Being part of the cluster, nodemanagers should try very hard (and possibly never give up) to connect to a resourcemanager. Minimally we should have a separate config to set how aggressively a nodemanager will connect to the RM separate from what clients will do.

      1. YARN-4132.patch
        7 kB
        Chang Li
      2. YARN-4132.2.patch
        7 kB
        Chang Li
      3. YARN-4132.3.patch
        14 kB
        Chang Li
      4. YARN-4132.4.patch
        14 kB
        Chang Li
      5. YARN-4132.5.patch
        15 kB
        Chang Li
      6. YARN-4132.6.patch
        11 kB
        Chang Li
      7. YARN-4132.6.2.patch
        11 kB
        Chang Li
      8. YARN-4132.7.patch
        12 kB
        Chang Li

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #640 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/640/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #640 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/640/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2577 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2577/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2577 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2577/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2660 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2660/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2660 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2660/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #728 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/728/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #728 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/728/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1450 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1450/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1450 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1450/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #718 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/718/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #718 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/718/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8881 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8881/)
          YARN-4132. Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8881 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8881/ ) YARN-4132 . Separate configs for nodemanager to resourcemanager (jlowe: rev 4ac6799d4a8b071e0d367c2d709e84d8ea06942d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ServerRMProxy.java
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Chang for the contribution and to Junping for additional review! I committed this to trunk and branch-2.

          Show
          jlowe Jason Lowe added a comment - Thanks to Chang for the contribution and to Junping for additional review! I committed this to trunk and branch-2.
          Hide
          jlowe Jason Lowe added a comment -

          +1 latest patch lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 latest patch lgtm. Committing this.
          Hide
          lichangleo Chang Li added a comment -

          TestWebApp is tracked by YARN-4379, not related to my change. Jason Lowe, please help review the updated patch, thanks!

          Show
          lichangleo Chang Li added a comment - TestWebApp is tracked by YARN-4379 , not related to my change. Jason Lowe , please help review the updated patch, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 46s trunk passed
          +1 compile 3m 0s trunk passed with JDK v1.8.0_66
          +1 compile 2m 50s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 2m 25s trunk passed
          +1 mvneclipse 1m 11s trunk passed
          -1 findbugs 1m 45s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 2m 29s trunk passed with JDK v1.8.0_66
          +1 javadoc 5m 9s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 13s the patch passed
          +1 compile 2m 59s the patch passed with JDK v1.8.0_66
          +1 javac 2m 59s the patch passed
          +1 compile 2m 48s the patch passed with JDK v1.7.0_85
          +1 javac 2m 48s the patch passed
          -1 checkstyle 0m 35s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 217, now 216).
          +1 mvnsite 2m 21s the patch passed
          +1 mvneclipse 1m 5s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 6m 33s the patch passed
          +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 51s the patch passed with JDK v1.7.0_85
          +1 unit 0m 35s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          -1 unit 2m 36s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 34s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66.
          +1 unit 10m 6s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          -1 unit 2m 31s hadoop-yarn-common in the patch failed with JDK v1.7.0_85.
          +1 unit 0m 34s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_85.
          -1 unit 9m 57s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 35s Patch does not generate ASF License warnings.
          89m 13s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.webapp.TestWebApp
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.webapp.TestWebApp
            hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773604/YARN-4132.7.patch
          JIRA Issue YARN-4132
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 1ea3f28e65e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4539131
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9752/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9752/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 46s trunk passed +1 compile 3m 0s trunk passed with JDK v1.8.0_66 +1 compile 2m 50s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 35s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 1m 11s trunk passed -1 findbugs 1m 45s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 2m 29s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 9s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 13s the patch passed +1 compile 2m 59s the patch passed with JDK v1.8.0_66 +1 javac 2m 59s the patch passed +1 compile 2m 48s the patch passed with JDK v1.7.0_85 +1 javac 2m 48s the patch passed -1 checkstyle 0m 35s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 217, now 216). +1 mvnsite 2m 21s the patch passed +1 mvneclipse 1m 5s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 6m 33s the patch passed +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 51s the patch passed with JDK v1.7.0_85 +1 unit 0m 35s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 2m 36s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. +1 unit 0m 34s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66. +1 unit 10m 6s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. -1 unit 2m 31s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. +1 unit 0m 34s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_85. -1 unit 9m 57s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 35s Patch does not generate ASF License warnings. 89m 13s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.webapp.TestWebApp JDK v1.7.0_85 Failed junit tests hadoop.yarn.webapp.TestWebApp   hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773604/YARN-4132.7.patch JIRA Issue YARN-4132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 1ea3f28e65e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4539131 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9752/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9752/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9752/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          Thanks Jason Lowe for further review! have updated .7 patch accordingly

          Show
          lichangleo Chang Li added a comment - Thanks Jason Lowe for further review! have updated .7 patch accordingly
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch! I think we're close.

          • The property docs should mention the fallback if unspecified, otherwise it's confusing to have no specified value in yarn-default
          • The new createRetryPolicy method simply can be private and therefore doesn't need the decorators indicating it is
          • Nit: new createRetryPolicy overload should have Configuration as first parameter for consistency with existing method.
          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! I think we're close. The property docs should mention the fallback if unspecified, otherwise it's confusing to have no specified value in yarn-default The new createRetryPolicy method simply can be private and therefore doesn't need the decorators indicating it is Nit: new createRetryPolicy overload should have Configuration as first parameter for consistency with existing method.
          Hide
          lichangleo Chang Li added a comment -

          The failed on unit test is just flaky, not related to my change. Please help review the latest patch Jason Lowe

          Show
          lichangleo Chang Li added a comment - The failed on unit test is just flaky, not related to my change. Please help review the latest patch Jason Lowe
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 13s trunk passed
          +1 compile 0m 54s trunk passed with JDK v1.8.0_60
          +1 compile 0m 50s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 47s trunk passed
          +1 mvneclipse 0m 52s trunk passed
          -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 1m 55s trunk passed with JDK v1.8.0_60
          +1 javadoc 4m 25s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 40s the patch passed
          +1 compile 0m 56s the patch passed with JDK v1.8.0_60
          +1 javac 0m 56s the patch passed
          +1 compile 0m 51s the patch passed with JDK v1.7.0_79
          +1 javac 0m 51s the patch passed
          -1 checkstyle 0m 27s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 218, now 217).
          +1 mvnsite 1m 42s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 8s the patch passed
          +1 javadoc 1m 48s the patch passed with JDK v1.8.0_60
          +1 javadoc 4m 36s the patch passed with JDK v1.7.0_79
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_60.
          +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 26s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60.
          -1 unit 9m 20s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_60.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_79.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79.
          +1 unit 9m 14s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          63m 33s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.yarn.server.nodemanager.TestNodeStatusUpdater



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772037/YARN-4132.6.2.patch
          JIRA Issue YARN-4132
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 262e95da1e3e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 7ff280f
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_60.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9677/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 228MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9677/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 13s trunk passed +1 compile 0m 54s trunk passed with JDK v1.8.0_60 +1 compile 0m 50s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 47s trunk passed +1 mvneclipse 0m 52s trunk passed -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 1m 55s trunk passed with JDK v1.8.0_60 +1 javadoc 4m 25s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 40s the patch passed +1 compile 0m 56s the patch passed with JDK v1.8.0_60 +1 javac 0m 56s the patch passed +1 compile 0m 51s the patch passed with JDK v1.7.0_79 +1 javac 0m 51s the patch passed -1 checkstyle 0m 27s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 218, now 217). +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 52s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 8s the patch passed +1 javadoc 1m 48s the patch passed with JDK v1.8.0_60 +1 javadoc 4m 36s the patch passed with JDK v1.7.0_79 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_60. +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_60. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60. -1 unit 9m 20s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_60. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_79. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_79. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79. +1 unit 9m 14s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 63m 33s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.yarn.server.nodemanager.TestNodeStatusUpdater Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772037/YARN-4132.6.2.patch JIRA Issue YARN-4132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 262e95da1e3e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 7ff280f findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9677/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9677/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9677/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          .6.2 patch fix whitespace

          Show
          lichangleo Chang Li added a comment - .6.2 patch fix whitespace
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 24s trunk passed
          +1 compile 0m 58s trunk passed with JDK v1.8.0_60
          +1 compile 0m 54s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 52s trunk passed
          -1 findbugs 1m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 2m 3s trunk passed with JDK v1.8.0_60
          +1 javadoc 4m 39s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 44s the patch passed
          +1 compile 0m 59s the patch passed with JDK v1.8.0_60
          +1 javac 0m 59s the patch passed
          +1 compile 0m 53s the patch passed with JDK v1.7.0_79
          +1 javac 0m 53s the patch passed
          -1 checkstyle 0m 29s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 217, now 216).
          +1 mvnsite 1m 47s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 22s the patch passed
          +1 javadoc 2m 2s the patch passed with JDK v1.8.0_60
          +1 javadoc 4m 36s the patch passed with JDK v1.7.0_79
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_60.
          +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60.
          +1 unit 9m 9s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_79.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79.
          +1 unit 9m 21s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          65m 27s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772013/YARN-4132.6.patch
          JIRA Issue YARN-4132
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux e8cd147bc064 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 06a7031
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9674/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9674/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9674/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9674/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 229MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9674/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 24s trunk passed +1 compile 0m 58s trunk passed with JDK v1.8.0_60 +1 compile 0m 54s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 52s trunk passed -1 findbugs 1m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 2m 3s trunk passed with JDK v1.8.0_60 +1 javadoc 4m 39s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 44s the patch passed +1 compile 0m 59s the patch passed with JDK v1.8.0_60 +1 javac 0m 59s the patch passed +1 compile 0m 53s the patch passed with JDK v1.7.0_79 +1 javac 0m 53s the patch passed -1 checkstyle 0m 29s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 217, now 216). +1 mvnsite 1m 47s the patch passed +1 mvneclipse 0m 52s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 22s the patch passed +1 javadoc 2m 2s the patch passed with JDK v1.8.0_60 +1 javadoc 4m 36s the patch passed with JDK v1.7.0_79 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_60. +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.8.0_60. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60. +1 unit 9m 9s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_79. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_79. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79. +1 unit 9m 21s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 65m 27s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772013/YARN-4132.6.patch JIRA Issue YARN-4132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux e8cd147bc064 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 06a7031 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9674/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9674/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9674/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9674/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 229MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9674/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          Thanks Jason Lowe for review and good suggestion! Have update patch accordingly.

          Show
          lichangleo Chang Li added a comment - Thanks Jason Lowe for review and good suggestion! Have update patch accordingly.
          Hide
          jlowe Jason Lowe added a comment -

          Patch doesn't build. Other comments:

          Do we need to get rid of the old RMProxy.createRetryPolicy(conf) method? We can just leave that around to reduce code churn on the patch and have it implemented in terms of the new createRetryPolicy method.

          Similarly for maximum backwards compatibility we could leave around an RMProxy.createRMProxy method that doesn't take the extra values and calls the old createRetryPolicy method. A new private utility method, like createRMProxy(conf, protocol, instance, retryPolicy) could be added to factor out the common code between the two createRMProxy methods.

          "to connection to RM" should be "to connect to the RM" in the property descriptions in yarn-default.xml.

          Show
          jlowe Jason Lowe added a comment - Patch doesn't build. Other comments: Do we need to get rid of the old RMProxy.createRetryPolicy(conf) method? We can just leave that around to reduce code churn on the patch and have it implemented in terms of the new createRetryPolicy method. Similarly for maximum backwards compatibility we could leave around an RMProxy.createRMProxy method that doesn't take the extra values and calls the old createRetryPolicy method. A new private utility method, like createRMProxy(conf, protocol, instance, retryPolicy) could be added to factor out the common code between the two createRMProxy methods. "to connection to RM" should be "to connect to the RM" in the property descriptions in yarn-default.xml.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 9s trunk passed
          +1 compile 0m 49s trunk passed with JDK v1.8.0_66
          +1 compile 0m 48s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 27s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 1s trunk passed with JDK v1.7.0_85
          -1 mvninstall 0m 15s hadoop-yarn-server-common in the patch failed.
          -1 mvninstall 0m 20s hadoop-yarn-server-nodemanager in the patch failed.
          -1 compile 0m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 javac 0m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 compile 0m 31s hadoop-yarn in the patch failed with JDK v1.7.0_85.
          -1 javac 0m 31s hadoop-yarn in the patch failed with JDK v1.7.0_85.
          -1 checkstyle 0m 26s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 221, now 220).
          +1 mvneclipse 0m 49s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 0m 16s hadoop-yarn-server-common in the patch failed.
          -1 findbugs 0m 18s hadoop-yarn-server-nodemanager in the patch failed.
          +1 javadoc 1m 42s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 0s the patch passed with JDK v1.7.0_85
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 50s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 0m 14s hadoop-yarn-server-common in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 20s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          -1 unit 0m 15s hadoop-yarn-server-common in the patch failed with JDK v1.7.0_85.
          -1 unit 0m 23s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          36m 21s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-11
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771761/YARN-4132.5.patch
          JIRA Issue YARN-4132
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml
          uname Linux 93ee372fba9c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-72645f4/precommit/personality/hadoop.sh
          git revision trunk / 6351d3f
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_85.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9660/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 226MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9660/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 9s trunk passed +1 compile 0m 49s trunk passed with JDK v1.8.0_66 +1 compile 0m 48s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 27s trunk passed +1 mvneclipse 0m 50s trunk passed -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 1s trunk passed with JDK v1.7.0_85 -1 mvninstall 0m 15s hadoop-yarn-server-common in the patch failed. -1 mvninstall 0m 20s hadoop-yarn-server-nodemanager in the patch failed. -1 compile 0m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 javac 0m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 compile 0m 31s hadoop-yarn in the patch failed with JDK v1.7.0_85. -1 javac 0m 31s hadoop-yarn in the patch failed with JDK v1.7.0_85. -1 checkstyle 0m 26s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 221, now 220). +1 mvneclipse 0m 49s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 0m 16s hadoop-yarn-server-common in the patch failed. -1 findbugs 0m 18s hadoop-yarn-server-nodemanager in the patch failed. +1 javadoc 1m 42s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 0s the patch passed with JDK v1.7.0_85 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 50s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 0m 14s hadoop-yarn-server-common in the patch failed with JDK v1.8.0_66. -1 unit 0m 20s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. -1 unit 0m 15s hadoop-yarn-server-common in the patch failed with JDK v1.7.0_85. -1 unit 0m 23s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 36m 21s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-11 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771761/YARN-4132.5.patch JIRA Issue YARN-4132 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml uname Linux 93ee372fba9c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-72645f4/precommit/personality/hadoop.sh git revision trunk / 6351d3f findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_85.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9660/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9660/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9660/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          Thanks Jason Lowe for review! .5 patch only has one createRMProxy which takes two additional inputs of retry time and retry interval. ServerRMProxy and ClientRMProxy pass those two inputs according to different values in conf.
          Conf naming is fixed. Test is also tuned down to around 4 seconds.

          Show
          lichangleo Chang Li added a comment - Thanks Jason Lowe for review! .5 patch only has one createRMProxy which takes two additional inputs of retry time and retry interval. ServerRMProxy and ClientRMProxy pass those two inputs according to different values in conf. Conf naming is fixed. Test is also tuned down to around 4 seconds.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch, Chang!

          createRMProxy(conf, protocol, instance) should be implemented in terms of createRMProxy(retryTime, retryInterval, conf, protocol, instance) rather than copying the code. It can do the conf lookups to get the retry values and call the other. Then I don't see a need to check for -1 values.

          ".rm." should be ".resourcemanager.". There's already precedent in the nodemanager.resourcemanager.minimum.version property. Similarly "retry.ms" should be "retry-interval.ms" to be consistent with the existing resourcemanager properties.

          The added test take a long time to run for just one test (around 25 seconds), please tune down the retry intervals.

          Style nit: usually extra parameters for a function overload of an existing function are passed at the end of the other form. Not a must-fix.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch, Chang! createRMProxy(conf, protocol, instance) should be implemented in terms of createRMProxy(retryTime, retryInterval, conf, protocol, instance) rather than copying the code. It can do the conf lookups to get the retry values and call the other. Then I don't see a need to check for -1 values. ".rm." should be ".resourcemanager.". There's already precedent in the nodemanager.resourcemanager.minimum.version property. Similarly "retry.ms" should be "retry-interval.ms" to be consistent with the existing resourcemanager properties. The added test take a long time to run for just one test (around 25 seconds), please tune down the retry intervals. Style nit: usually extra parameters for a function overload of an existing function are passed at the end of the other form. Not a must-fix.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 21s trunk passed
          +1 compile 0m 54s trunk passed with JDK v1.8.0_60
          +1 compile 0m 49s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 24s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk cannot run convertXmlToText from findbugs
          +1 javadoc 1m 41s trunk passed with JDK v1.8.0_60
          +1 javadoc 4m 8s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 33s the patch passed
          +1 compile 0m 49s the patch passed with JDK v1.8.0_60
          +1 javac 0m 49s the patch passed
          +1 compile 0m 47s the patch passed with JDK v1.7.0_79
          +1 javac 0m 47s the patch passed
          -1 checkstyle 0m 24s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 247, now 247).
          +1 mvneclipse 0m 50s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 53s the patch passed
          +1 javadoc 1m 39s the patch passed with JDK v1.8.0_60
          +1 javadoc 4m 12s the patch passed with JDK v1.7.0_79
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 50s hadoop-yarn-common in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60.
          +1 unit 8m 45s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_79.
          +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79.
          +1 unit 9m 14s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          56m 54s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-31
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769876/YARN-4132.4.patch
          JIRA Issue YARN-4132
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml
          uname Linux b9b54e7dd944 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / b24fe06
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9607/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9607/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9607/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9607/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 21s trunk passed +1 compile 0m 54s trunk passed with JDK v1.8.0_60 +1 compile 0m 49s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 24s trunk passed +1 mvneclipse 0m 50s trunk passed -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk cannot run convertXmlToText from findbugs +1 javadoc 1m 41s trunk passed with JDK v1.8.0_60 +1 javadoc 4m 8s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 33s the patch passed +1 compile 0m 49s the patch passed with JDK v1.8.0_60 +1 javac 0m 49s the patch passed +1 compile 0m 47s the patch passed with JDK v1.7.0_79 +1 javac 0m 47s the patch passed -1 checkstyle 0m 24s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 247, now 247). +1 mvneclipse 0m 50s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 53s the patch passed +1 javadoc 1m 39s the patch passed with JDK v1.8.0_60 +1 javadoc 4m 12s the patch passed with JDK v1.7.0_79 +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_60. +1 unit 1m 50s hadoop-yarn-common in the patch passed with JDK v1.8.0_60. +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60. +1 unit 8m 45s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_79. +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.7.0_79. +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79. +1 unit 9m 14s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 56m 54s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-31 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769876/YARN-4132.4.patch JIRA Issue YARN-4132 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml uname Linux b9b54e7dd944 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / b24fe06 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9607/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9607/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9607/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9607/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          update .4 patch to fix checkstyle and broken unit test

          Show
          lichangleo Chang Li added a comment - update .4 patch to fix checkstyle and broken unit test
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 16s trunk passed
          +1 compile 0m 48s trunk passed with JDK v1.8.0_60
          +1 compile 0m 46s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 26s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk cannot run convertXmlToText from findbugs
          +1 javadoc 1m 40s trunk passed with JDK v1.8.0_60
          +1 javadoc 4m 13s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 33s the patch passed
          +1 compile 0m 52s the patch passed with JDK v1.8.0_60
          +1 javac 0m 52s the patch passed
          +1 compile 0m 47s the patch passed with JDK v1.7.0_79
          +1 javac 0m 47s the patch passed
          -1 checkstyle 0m 25s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 247, now 248).
          +1 mvneclipse 0m 48s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 1m 41s the patch passed with JDK v1.8.0_60
          +1 javadoc 4m 15s the patch passed with JDK v1.7.0_79
          -1 unit 0m 20s hadoop-yarn-api in the patch failed with JDK v1.8.0_60.
          +1 unit 1m 46s hadoop-yarn-common in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 20s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60.
          +1 unit 8m 42s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60.
          -1 unit 0m 21s hadoop-yarn-api in the patch failed with JDK v1.7.0_79.
          +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 23s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79.
          +1 unit 9m 11s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          56m 24s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields
            hadoop.yarn.conf.TestYarnConfigurationFields



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-29
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769623/YARN-4132.3.patch
          JIRA Issue YARN-4132
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml
          uname Linux 68f2f7b4bbf1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-c3a2069/precommit/personality/hadoop.sh
          git revision trunk / c293c58
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9603/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 226MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9603/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 16s trunk passed +1 compile 0m 48s trunk passed with JDK v1.8.0_60 +1 compile 0m 46s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 26s trunk passed +1 mvneclipse 0m 47s trunk passed -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk cannot run convertXmlToText from findbugs +1 javadoc 1m 40s trunk passed with JDK v1.8.0_60 +1 javadoc 4m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 33s the patch passed +1 compile 0m 52s the patch passed with JDK v1.8.0_60 +1 javac 0m 52s the patch passed +1 compile 0m 47s the patch passed with JDK v1.7.0_79 +1 javac 0m 47s the patch passed -1 checkstyle 0m 25s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 247, now 248). +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 41s the patch passed with JDK v1.8.0_60 +1 javadoc 4m 15s the patch passed with JDK v1.7.0_79 -1 unit 0m 20s hadoop-yarn-api in the patch failed with JDK v1.8.0_60. +1 unit 1m 46s hadoop-yarn-common in the patch passed with JDK v1.8.0_60. +1 unit 0m 20s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_60. +1 unit 8m 42s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60. -1 unit 0m 21s hadoop-yarn-api in the patch failed with JDK v1.7.0_79. +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.7.0_79. +1 unit 0m 23s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_79. +1 unit 9m 11s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 56m 24s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields   hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-29 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769623/YARN-4132.3.patch JIRA Issue YARN-4132 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml uname Linux 68f2f7b4bbf1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-c3a2069/precommit/personality/hadoop.sh git revision trunk / c293c58 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9603/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9603/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9603/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          Thanks Junping Du for review and proposal!
          have updated .3 patch which let createRetryPolicy take additional parameters of retryWaitTime and retryInterval, and only use default conf if these two parameters if not set. I also create a new function call of createRMProxy which take these two additional parameters. I didn't overwrite the existing createRMProxy because otherwise I need to update many of the function's caller.
          Could you help review the latest patch? Thanks!

          Show
          lichangleo Chang Li added a comment - Thanks Junping Du for review and proposal! have updated .3 patch which let createRetryPolicy take additional parameters of retryWaitTime and retryInterval, and only use default conf if these two parameters if not set. I also create a new function call of createRMProxy which take these two additional parameters. I didn't overwrite the existing createRMProxy because otherwise I need to update many of the function's caller. Could you help review the latest patch? Thanks!
          Hide
          djp Junping Du added a comment -

          Thanks for bring out the problem, Chang Li!
          I agree that we may want different retry times, intervals (or even retry policy) for different consumer of RMProxy. However, the current patch way - have a separated property which override a general property in config at runtime sounds a little tricky here. We should think if there are some better way, e.g. passing the parameters in creating RMProxy which will take these parameters as priority in creating retry policies before taking property in config as default values. Thoughts?

          Show
          djp Junping Du added a comment - Thanks for bring out the problem, Chang Li ! I agree that we may want different retry times, intervals (or even retry policy) for different consumer of RMProxy. However, the current patch way - have a separated property which override a general property in config at runtime sounds a little tricky here. We should think if there are some better way, e.g. passing the parameters in creating RMProxy which will take these parameters as priority in creating retry policies before taking property in config as default values. Thoughts?
          Hide
          lichangleo Chang Li added a comment -

          Jason Lowe please help review the latest patch. Thanks!

          Show
          lichangleo Chang Li added a comment - Jason Lowe please help review the latest patch. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 52s There were no new javac warning messages.
          +1 javadoc 10m 1s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 52s The applied patch generated 1 new checkstyle issues (total was 211, now 211).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.
          +1 yarn tests 7m 55s Tests passed in hadoop-yarn-server-nodemanager.
              56m 39s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754730/YARN-4132.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d9c1fab
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9043/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9043/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 52s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 52s The applied patch generated 1 new checkstyle issues (total was 211, now 211). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common. +1 yarn tests 7m 55s Tests passed in hadoop-yarn-server-nodemanager.     56m 39s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754730/YARN-4132.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d9c1fab checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9043/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9043/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9043/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          fixed broken test in TestYarnConfigurationFields. The other broken tests are not related to my changes(seem to be caused by network problem on testing platform). Those tests all pass on my .2 patch on my local machine.

          Show
          lichangleo Chang Li added a comment - fixed broken test in TestYarnConfigurationFields. The other broken tests are not related to my changes(seem to be caused by network problem on testing platform). Those tests all pass on my .2 patch on my local machine.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 56s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 59s There were no new javac warning messages.
          +1 javadoc 9m 56s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 23s The applied patch generated 3 new checkstyle issues (total was 211, now 213).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 2m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 0m 22s Tests failed in hadoop-yarn-api.
          -1 yarn tests 6m 52s Tests failed in hadoop-yarn-server-nodemanager.
              49m 56s  



          Reason Tests
          Failed unit tests hadoop.yarn.conf.TestYarnConfigurationFields
            hadoop.yarn.server.nodemanager.TestNodeStatusUpdater
            hadoop.yarn.server.nodemanager.TestNodeManagerShutdown
            hadoop.yarn.server.nodemanager.containermanager.TestNMProxy



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754710/YARN-4132.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 970daaa
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9041/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9041/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9041/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9041/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9041/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 56s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 59s There were no new javac warning messages. +1 javadoc 9m 56s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 23s The applied patch generated 3 new checkstyle issues (total was 211, now 213). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 0m 22s Tests failed in hadoop-yarn-api. -1 yarn tests 6m 52s Tests failed in hadoop-yarn-server-nodemanager.     49m 56s   Reason Tests Failed unit tests hadoop.yarn.conf.TestYarnConfigurationFields   hadoop.yarn.server.nodemanager.TestNodeStatusUpdater   hadoop.yarn.server.nodemanager.TestNodeManagerShutdown   hadoop.yarn.server.nodemanager.containermanager.TestNMProxy Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754710/YARN-4132.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 970daaa checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9041/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9041/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9041/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9041/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9041/console This message was automatically generated.

            People

            • Assignee:
              lichangleo Chang Li
              Reporter:
              lichangleo Chang Li
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development