Details

    • Hadoop Flags:
      Reviewed

      Description

      The current set of policies require some machinery to (re)initialize based on changes in the SubClusterPolicyConfiguration. This JIRA tracks the effort to hide much of that behind a simple RouterPolicyFacade, making lifecycle and usage of the policies easier to consumers.

      1. YARN-5634-YARN-2915.01.patch
        11 kB
        Carlo Curino
      2. YARN-5634-YARN-2915.02.patch
        36 kB
        Carlo Curino
      3. YARN-5634-YARN-2915.03.patch
        41 kB
        Carlo Curino
      4. YARN-5634-YARN-2915.04.patch
        43 kB
        Carlo Curino
      5. YARN-5634-YARN-2915.05.patch
        40 kB
        Carlo Curino
      6. YARN-5634-YARN-2915.06.patch
        39 kB
        Carlo Curino
      7. YARN-5634-YARN-2915.07.patch
        39 kB
        Carlo Curino
      8. YARN-5634-YARN-2915.08.patch
        40 kB
        Carlo Curino

        Issue Links

          Activity

          Hide
          curino Carlo Curino added a comment -

          Initial patch, depends on all other policies patches (so likely not going to make Jenkins happy). I mark as patch-available to attract eyeballs for reviewing. Giovanni Matteo Fumarola since you are writing the code that will use this in the Router, please check it out at your earliest convenience.

          Show
          curino Carlo Curino added a comment - Initial patch, depends on all other policies patches (so likely not going to make Jenkins happy). I mark as patch-available to attract eyeballs for reviewing. Giovanni Matteo Fumarola since you are writing the code that will use this in the Router, please check it out at your earliest convenience.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 40s YARN-2915 passed
          +1 compile 0m 21s YARN-2915 passed
          +1 checkstyle 0m 13s YARN-2915 passed
          +1 mvnsite 0m 23s YARN-2915 passed
          +1 mvneclipse 0m 12s YARN-2915 passed
          +1 findbugs 0m 42s YARN-2915 passed
          +1 javadoc 0m 16s YARN-2915 passed
          -1 mvninstall 0m 15s hadoop-yarn-server-common in the patch failed.
          -1 compile 0m 16s hadoop-yarn-server-common in the patch failed.
          -1 javac 0m 16s hadoop-yarn-server-common in the patch failed.
          -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
          -1 mvnsite 0m 17s hadoop-yarn-server-common in the patch failed.
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 12s hadoop-yarn-server-common in the patch failed.
          -1 javadoc 0m 13s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 3 new + 160 unchanged - 0 fixed = 163 total (was 160)
          -1 unit 0m 16s hadoop-yarn-server-common in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          11m 41s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827867/YARN-5634-YARN-2915.01.patch
          JIRA Issue YARN-5634
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2848c8daed26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / 302d206
          Default Java 1.8.0_101
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13069/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13069/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 40s YARN-2915 passed +1 compile 0m 21s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 12s YARN-2915 passed +1 findbugs 0m 42s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed -1 mvninstall 0m 15s hadoop-yarn-server-common in the patch failed. -1 compile 0m 16s hadoop-yarn-server-common in the patch failed. -1 javac 0m 16s hadoop-yarn-server-common in the patch failed. -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) -1 mvnsite 0m 17s hadoop-yarn-server-common in the patch failed. +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 12s hadoop-yarn-server-common in the patch failed. -1 javadoc 0m 13s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 3 new + 160 unchanged - 0 fixed = 163 total (was 160) -1 unit 0m 16s hadoop-yarn-server-common in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 11m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827867/YARN-5634-YARN-2915.01.patch JIRA Issue YARN-5634 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2848c8daed26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 302d206 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13069/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13069/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13069/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          curino Carlo Curino added a comment -

          The current patch is rebased after YARN-5391 got in. I also extended the test coverage (spotted and fixed a potential, though not likely, NPE in FederationStateStoreFacade) and added a PriorityBroadcastPolicyManager to experiment with simple and different router policies.

          Show
          curino Carlo Curino added a comment - The current patch is rebased after YARN-5391 got in. I also extended the test coverage (spotted and fixed a potential, though not likely, NPE in FederationStateStoreFacade) and added a PriorityBroadcastPolicyManager to experiment with simple and different router policies.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 3m 31s Maven dependency ordering for branch
          +1 mvninstall 8m 30s YARN-2915 passed
          +1 compile 6m 28s YARN-2915 passed
          +1 checkstyle 0m 51s YARN-2915 passed
          +1 mvnsite 1m 11s YARN-2915 passed
          +1 mvneclipse 0m 45s YARN-2915 passed
          +1 findbugs 2m 3s YARN-2915 passed
          +1 javadoc 0m 55s YARN-2915 passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 44s the patch passed
          +1 compile 4m 46s the patch passed
          +1 javac 4m 46s the patch passed
          -0 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 221 unchanged - 0 fixed = 224 total (was 221)
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 0m 52s the patch passed
          -1 unit 0m 35s hadoop-yarn-api in the patch failed.
          +1 unit 1m 6s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          46m 46s



          Reason Tests
          Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838089/YARN-5634-YARN-2915.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7b14a772c968 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / c3a5672
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13835/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13835/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13835/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13835/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 3m 31s Maven dependency ordering for branch +1 mvninstall 8m 30s YARN-2915 passed +1 compile 6m 28s YARN-2915 passed +1 checkstyle 0m 51s YARN-2915 passed +1 mvnsite 1m 11s YARN-2915 passed +1 mvneclipse 0m 45s YARN-2915 passed +1 findbugs 2m 3s YARN-2915 passed +1 javadoc 0m 55s YARN-2915 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 4m 46s the patch passed +1 javac 4m 46s the patch passed -0 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 221 unchanged - 0 fixed = 224 total (was 221) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 0m 35s hadoop-yarn-api in the patch failed. +1 unit 1m 6s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 46m 46s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838089/YARN-5634-YARN-2915.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7b14a772c968 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / c3a5672 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13835/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13835/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13835/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13835/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Carlo Curino for the patch. I looked at it, please find my comments below.

          General note:

          • It looks like you have the intellij formatting set rather than the Hadoop standard. For e.g. : Unnecessary change to imports in FederationStateStoreFacade. I feel this is the root cause for the checkstyle warnings too.

          YarnConfiguration

          • For every new config, you need to add corresponding default in yarn-default.xml or exclusions in TestYarnConfigurationFields. I prefer the latter for these configs.
          • I don't think we need DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS (can we avoid FEDERATION_POLICY_MANAGER_PARAMS itself) in the interest of trying to limit the configuration explosion.

          RouterPolicyFacade

          •   String defaultPolicyParamString = conf.get(YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS); 

            should be

             String defaultPolicyParamString = conf.get(YarnConfiguration.FEDERATION_POLICY_MANAGER_PARAMS, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS); 
          • Please use Charset.defaultCharset() instead of hard-coding (also existing usages like in WeightedPolicyInfo.
          • I feel it's better if we add the the fallbackPolicyManager to the cache during initialization so that we can avoid costly fallbackPolicyManager::getRouterPolicy in every invocation of getHomeSubcluster.
          • We should have a warning log with context that we were not able to retrieve the policy configuration for the input queue.
          • The if clause can be rephrased as
             cachedConfs.containsKey(queue) && !cachedConfs.get(queue).equals(configuration) 

            .

          FederationStateStoreFacade

          • We should specify for what queue, we got null from StateStore and possibly log it.

          TestFederationPolicyFacade

          • Overall the coverage is nice! The only feedback is it took me quite some time to figure out how the configuration was getting updated in testConfigurationUpdate. IIUC, it's done implicitly through FederationPoliciesTestUtil::initFacade? If so, can we do it explicitly as that will help considerably in readability and moreover none of the other tests use it and might even be a undesirable side-effect.
          • Nit: can we rename testgetHomeSubcluster to testGetHomeSubcluster and move it up to the first test.
          Show
          subru Subru Krishnan added a comment - Thanks Carlo Curino for the patch. I looked at it, please find my comments below. General note: It looks like you have the intellij formatting set rather than the Hadoop standard. For e.g. : Unnecessary change to imports in FederationStateStoreFacade . I feel this is the root cause for the checkstyle warnings too. YarnConfiguration For every new config, you need to add corresponding default in yarn-default.xml or exclusions in TestYarnConfigurationFields . I prefer the latter for these configs. I don't think we need DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS (can we avoid FEDERATION_POLICY_MANAGER_PARAMS itself) in the interest of trying to limit the configuration explosion. RouterPolicyFacade String defaultPolicyParamString = conf.get(YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS); should be String defaultPolicyParamString = conf.get(YarnConfiguration.FEDERATION_POLICY_MANAGER_PARAMS, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER_PARAMS); Please use Charset.defaultCharset() instead of hard-coding (also existing usages like in WeightedPolicyInfo . I feel it's better if we add the the fallbackPolicyManager to the cache during initialization so that we can avoid costly fallbackPolicyManager::getRouterPolicy in every invocation of getHomeSubcluster . We should have a warning log with context that we were not able to retrieve the policy configuration for the input queue. The if clause can be rephrased as cachedConfs.containsKey(queue) && !cachedConfs.get(queue).equals(configuration) . FederationStateStoreFacade We should specify for what queue , we got null from StateStore and possibly log it. TestFederationPolicyFacade Overall the coverage is nice! The only feedback is it took me quite some time to figure out how the configuration was getting updated in testConfigurationUpdate . IIUC, it's done implicitly through FederationPoliciesTestUtil::initFacade ? If so, can we do it explicitly as that will help considerably in readability and moreover none of the other tests use it and might even be a undesirable side-effect. Nit: can we rename testgetHomeSubcluster to testGetHomeSubcluster and move it up to the first test.
          Hide
          curino Carlo Curino added a comment -

          Subru Krishnan thanks for the prompt feedback. I addressed most of your points, and discuss the rest below.

          YarnConfiguration

          • I think having initialization params for the policy will be useful (while the current choice of default does not strictly needs params, I don't like hardcoding a null or empty buffer there, as a change of default should be limited to changes in YarnConfiguration).

          RouterPolicyFacade

          • I am explicitly avoiding the Charset.defaultCharset(), as this might depend on OS/VM conf, and since the serialize/deserialize will happen on separate machines, I want to avoid misaligned defaults which could means we need to redeploy code to fix bugs on a live cluster (for example if we go from a UniformRandomRouterPolicy to a WeightedRandomRouterPolicy and we realize the VMs have different defaultCharset).
          • I don't think the if rewrite proposed matches the semantics we need. We need to initialize both in case a queue is not been cached before, or if the cached copy is different. Am I missing something?

          TestFederationPolicyFacade

          • I am not sure I follow what you are proposing (as it is minor I will ask you offline).
          Show
          curino Carlo Curino added a comment - Subru Krishnan thanks for the prompt feedback. I addressed most of your points, and discuss the rest below. YarnConfiguration I think having initialization params for the policy will be useful (while the current choice of default does not strictly needs params, I don't like hardcoding a null or empty buffer there, as a change of default should be limited to changes in YarnConfiguration). RouterPolicyFacade I am explicitly avoiding the Charset.defaultCharset(), as this might depend on OS/VM conf, and since the serialize/deserialize will happen on separate machines, I want to avoid misaligned defaults which could means we need to redeploy code to fix bugs on a live cluster (for example if we go from a UniformRandomRouterPolicy to a WeightedRandomRouterPolicy and we realize the VMs have different defaultCharset). I don't think the if rewrite proposed matches the semantics we need. We need to initialize both in case a queue is not been cached before, or if the cached copy is different. Am I missing something? TestFederationPolicyFacade I am not sure I follow what you are proposing (as it is minor I will ask you offline).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 3m 2s Maven dependency ordering for branch
          +1 mvninstall 8m 24s YARN-2915 passed
          -1 compile 5m 20s hadoop-yarn in YARN-2915 failed.
          +1 checkstyle 0m 50s YARN-2915 passed
          +1 mvnsite 1m 10s YARN-2915 passed
          +1 mvneclipse 0m 44s YARN-2915 passed
          +1 findbugs 2m 17s YARN-2915 passed
          +1 javadoc 0m 51s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 52s the patch passed
          -1 compile 4m 26s hadoop-yarn in the patch failed.
          -1 javac 4m 26s hadoop-yarn in the patch failed.
          -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 227 unchanged - 0 fixed = 229 total (was 227)
          +1 mvnsite 1m 11s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 45s the patch passed
          +1 javadoc 0m 50s the patch passed
          +1 unit 0m 38s hadoop-yarn-api in the patch passed.
          -1 unit 1m 10s hadoop-yarn-server-common in the patch failed.
          +1 asflicense 0m 46s The patch does not generate ASF License warnings.
          45m 18s



          Reason Tests
          Failed junit tests hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838472/YARN-5634-YARN-2915.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8586c13d77b0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / c3a5672
          Default Java 1.8.0_111
          compile https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13867/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13867/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 3m 2s Maven dependency ordering for branch +1 mvninstall 8m 24s YARN-2915 passed -1 compile 5m 20s hadoop-yarn in YARN-2915 failed. +1 checkstyle 0m 50s YARN-2915 passed +1 mvnsite 1m 10s YARN-2915 passed +1 mvneclipse 0m 44s YARN-2915 passed +1 findbugs 2m 17s YARN-2915 passed +1 javadoc 0m 51s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 52s the patch passed -1 compile 4m 26s hadoop-yarn in the patch failed. -1 javac 4m 26s hadoop-yarn in the patch failed. -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 227 unchanged - 0 fixed = 229 total (was 227) +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 45s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 0m 38s hadoop-yarn-api in the patch passed. -1 unit 1m 10s hadoop-yarn-server-common in the patch failed. +1 asflicense 0m 46s The patch does not generate ASF License warnings. 45m 18s Reason Tests Failed junit tests hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838472/YARN-5634-YARN-2915.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8586c13d77b0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / c3a5672 Default Java 1.8.0_111 compile https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13867/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13867/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13867/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          curino Carlo Curino added a comment -

          Rebasing, fixing checkstyles, and Charset issues.

          Show
          curino Carlo Curino added a comment - Rebasing, fixing checkstyles, and Charset issues.
          Hide
          curino Carlo Curino added a comment -

          BTW the suggestion of moving fallbackPolicyManager was very good, as it cleaned up and simplified the code a bit.

          Show
          curino Carlo Curino added a comment - BTW the suggestion of moving fallbackPolicyManager was very good, as it cleaned up and simplified the code a bit.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 3m 5s Maven dependency ordering for branch
          +1 mvninstall 8m 32s YARN-2915 passed
          -1 compile 5m 26s hadoop-yarn in YARN-2915 failed.
          +1 checkstyle 0m 52s YARN-2915 passed
          +1 mvnsite 1m 15s YARN-2915 passed
          +1 mvneclipse 0m 47s YARN-2915 passed
          +1 findbugs 2m 9s YARN-2915 passed
          +1 javadoc 0m 54s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          -1 compile 4m 1s hadoop-yarn in the patch failed.
          -1 javac 4m 1s hadoop-yarn in the patch failed.
          +1 checkstyle 0m 50s the patch passed
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 0m 53s the patch passed
          +1 unit 0m 36s hadoop-yarn-api in the patch passed.
          +1 unit 1m 6s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          44m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838600/YARN-5634-YARN-2915.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9df3d44e76ec 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / c3a5672
          Default Java 1.8.0_101
          compile https://builds.apache.org/job/PreCommit-YARN-Build/13879/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/13879/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/13879/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13879/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13879/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 3m 5s Maven dependency ordering for branch +1 mvninstall 8m 32s YARN-2915 passed -1 compile 5m 26s hadoop-yarn in YARN-2915 failed. +1 checkstyle 0m 52s YARN-2915 passed +1 mvnsite 1m 15s YARN-2915 passed +1 mvneclipse 0m 47s YARN-2915 passed +1 findbugs 2m 9s YARN-2915 passed +1 javadoc 0m 54s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed -1 compile 4m 1s hadoop-yarn in the patch failed. -1 javac 4m 1s hadoop-yarn in the patch failed. +1 checkstyle 0m 50s the patch passed +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 0m 36s hadoop-yarn-api in the patch passed. +1 unit 1m 6s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 44m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838600/YARN-5634-YARN-2915.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9df3d44e76ec 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / c3a5672 Default Java 1.8.0_101 compile https://builds.apache.org/job/PreCommit-YARN-Build/13879/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/13879/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/13879/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13879/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13879/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 50s Maven dependency ordering for branch
          +1 mvninstall 8m 3s YARN-2915 passed
          +1 compile 5m 5s YARN-2915 passed
          +1 checkstyle 0m 48s YARN-2915 passed
          +1 mvnsite 1m 2s YARN-2915 passed
          +1 mvneclipse 0m 37s YARN-2915 passed
          +1 findbugs 1m 57s YARN-2915 passed
          +1 javadoc 0m 47s YARN-2915 passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 43s the patch passed
          +1 compile 4m 42s the patch passed
          +1 javac 4m 42s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 10s the patch passed
          +1 javadoc 0m 44s the patch passed
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          +1 unit 1m 2s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          40m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838600/YARN-5634-YARN-2915.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux be99f513fcd8 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / e38a4a4
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13880/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13880/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 50s Maven dependency ordering for branch +1 mvninstall 8m 3s YARN-2915 passed +1 compile 5m 5s YARN-2915 passed +1 checkstyle 0m 48s YARN-2915 passed +1 mvnsite 1m 2s YARN-2915 passed +1 mvneclipse 0m 37s YARN-2915 passed +1 findbugs 1m 57s YARN-2915 passed +1 javadoc 0m 47s YARN-2915 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 4m 42s the patch passed +1 javac 4m 42s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 1m 2s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 40m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838600/YARN-5634-YARN-2915.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux be99f513fcd8 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / e38a4a4 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13880/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13880/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          curino Carlo Curino added a comment -

          Switched to MemoryFederationStateStore for the tests. Code is easier to read, and a tid cleaner.

          Show
          curino Carlo Curino added a comment - Switched to MemoryFederationStateStore for the tests. Code is easier to read, and a tid cleaner.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 36s Maven dependency ordering for branch
          +1 mvninstall 8m 3s YARN-2915 passed
          +1 compile 5m 33s YARN-2915 passed
          +1 checkstyle 0m 53s YARN-2915 passed
          +1 mvnsite 1m 8s YARN-2915 passed
          +1 mvneclipse 0m 38s YARN-2915 passed
          +1 findbugs 1m 58s YARN-2915 passed
          +1 javadoc 0m 47s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 46s the patch passed
          +1 compile 4m 56s the patch passed
          +1 javac 4m 56s the patch passed
          -0 checkstyle 0m 46s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 227 unchanged - 0 fixed = 230 total (was 227)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 0m 44s the patch passed
          +1 unit 0m 30s hadoop-yarn-api in the patch passed.
          +1 unit 1m 4s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          41m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838636/YARN-5634-YARN-2915.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 07db620b69ff 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / e38a4a4
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13882/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13882/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13882/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 8m 3s YARN-2915 passed +1 compile 5m 33s YARN-2915 passed +1 checkstyle 0m 53s YARN-2915 passed +1 mvnsite 1m 8s YARN-2915 passed +1 mvneclipse 0m 38s YARN-2915 passed +1 findbugs 1m 58s YARN-2915 passed +1 javadoc 0m 47s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 46s the patch passed +1 compile 4m 56s the patch passed +1 javac 4m 56s the patch passed -0 checkstyle 0m 46s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 227 unchanged - 0 fixed = 230 total (was 227) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 1m 4s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 41m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838636/YARN-5634-YARN-2915.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 07db620b69ff 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / e38a4a4 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13882/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13882/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13882/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          curino Carlo Curino added a comment -

          One more round of checkstyles...

          Show
          curino Carlo Curino added a comment - One more round of checkstyles...
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 45s YARN-2915 passed
          +1 compile 5m 0s YARN-2915 passed
          +1 checkstyle 0m 47s YARN-2915 passed
          +1 mvnsite 1m 2s YARN-2915 passed
          +1 mvneclipse 0m 36s YARN-2915 passed
          +1 findbugs 1m 57s YARN-2915 passed
          +1 javadoc 0m 47s YARN-2915 passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 44s the patch passed
          +1 compile 4m 38s the patch passed
          +1 javac 4m 38s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 12s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 0m 32s hadoop-yarn-api in the patch passed.
          +1 unit 1m 2s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          38m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838832/YARN-5634-YARN-2915.06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c0e4b0c3f471 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / e38a4a4
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13905/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13905/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 45s YARN-2915 passed +1 compile 5m 0s YARN-2915 passed +1 checkstyle 0m 47s YARN-2915 passed +1 mvnsite 1m 2s YARN-2915 passed +1 mvneclipse 0m 36s YARN-2915 passed +1 findbugs 1m 57s YARN-2915 passed +1 javadoc 0m 47s YARN-2915 passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 4m 38s the patch passed +1 javac 4m 38s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 12s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 1m 2s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 38m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838832/YARN-5634-YARN-2915.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c0e4b0c3f471 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / e38a4a4 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13905/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13905/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Carlo Curino for addressing my feedback. The latest patch LGTM. I have one concern though - we should synchronize RouterPolicyFacade::singlePolicyReinit.

          Show
          subru Subru Krishnan added a comment - Thanks Carlo Curino for addressing my feedback. The latest patch LGTM. I have one concern though - we should synchronize RouterPolicyFacade::singlePolicyReinit .
          Hide
          curino Carlo Curino added a comment -

          Subru Krishnan per our offline discussion we can't use ReentrantReadWriteLock as we need to escalate read to write locks, so I am retaining the caching a reference mechanism (so that getHomeSubcluster() operates on a snapshot of the ConcurrentHashMap). To further tighten this I am putting the two put within a synchronized block (and reset()) so that we don't risk ghost-updates (very unlikely, but not impossible).

          Show
          curino Carlo Curino added a comment - Subru Krishnan per our offline discussion we can't use ReentrantReadWriteLock as we need to escalate read to write locks, so I am retaining the caching a reference mechanism (so that getHomeSubcluster() operates on a snapshot of the ConcurrentHashMap). To further tighten this I am putting the two put within a synchronized block (and reset() ) so that we don't risk ghost-updates (very unlikely, but not impossible).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 19m 32s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 11m 45s YARN-2915 passed
          +1 compile 5m 4s YARN-2915 passed
          +1 checkstyle 0m 48s YARN-2915 passed
          +1 mvnsite 1m 6s YARN-2915 passed
          +1 mvneclipse 0m 40s YARN-2915 passed
          +1 findbugs 2m 10s YARN-2915 passed
          +1 javadoc 0m 48s YARN-2915 passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 44s the patch passed
          +1 compile 4m 41s the patch passed
          +1 javac 4m 41s the patch passed
          +1 checkstyle 0m 47s the patch passed
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 51s the patch passed
          +1 unit 0m 36s hadoop-yarn-api in the patch passed.
          +1 unit 1m 12s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          63m 59s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
            Inconsistent synchronization of org.apache.hadoop.yarn.server.federation.policies.RouterPolicyFacade.globalConfMap; locked 75% of time Unsynchronized access at RouterPolicyFacade.java:75% of time Unsynchronized access at RouterPolicyFacade.java:[line 126]
            Inconsistent synchronization of org.apache.hadoop.yarn.server.federation.policies.RouterPolicyFacade.globalPolicyMap; locked 75% of time Unsynchronized access at RouterPolicyFacade.java:75% of time Unsynchronized access at RouterPolicyFacade.java:[line 127]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839256/YARN-5634-YARN-2915.07.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 82ac84d18c24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / e38a4a4
          Default Java 1.8.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13947/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13947/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13947/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 19m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 11m 45s YARN-2915 passed +1 compile 5m 4s YARN-2915 passed +1 checkstyle 0m 48s YARN-2915 passed +1 mvnsite 1m 6s YARN-2915 passed +1 mvneclipse 0m 40s YARN-2915 passed +1 findbugs 2m 10s YARN-2915 passed +1 javadoc 0m 48s YARN-2915 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 4m 41s the patch passed +1 javac 4m 41s the patch passed +1 checkstyle 0m 47s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 51s the patch passed +1 unit 0m 36s hadoop-yarn-api in the patch passed. +1 unit 1m 12s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 63m 59s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common   Inconsistent synchronization of org.apache.hadoop.yarn.server.federation.policies.RouterPolicyFacade.globalConfMap; locked 75% of time Unsynchronized access at RouterPolicyFacade.java:75% of time Unsynchronized access at RouterPolicyFacade.java: [line 126]   Inconsistent synchronization of org.apache.hadoop.yarn.server.federation.policies.RouterPolicyFacade.globalPolicyMap; locked 75% of time Unsynchronized access at RouterPolicyFacade.java:75% of time Unsynchronized access at RouterPolicyFacade.java: [line 127] Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839256/YARN-5634-YARN-2915.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 82ac84d18c24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / e38a4a4 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13947/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13947/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13947/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          curino Carlo Curino added a comment -

          I think the findbug is not a problem, as we are doing synchronization only to achieve atomicity across the Maps, while individual put/get conflicts are taken care by the ConcurrentHashMap implementation, and the use of a local reference allows us to complete an invocation of getHomeSubcluster() even if reset() was called (and scheduled) mid-execution.

          Show
          curino Carlo Curino added a comment - I think the findbug is not a problem, as we are doing synchronization only to achieve atomicity across the Maps, while individual put/get conflicts are taken care by the ConcurrentHashMap implementation, and the use of a local reference allows us to complete an invocation of getHomeSubcluster() even if reset() was called (and scheduled) mid-execution.
          Hide
          subru Subru Krishnan added a comment -

          I agree, can you add a findbugs exclusion.

          Show
          subru Subru Krishnan added a comment - I agree, can you add a findbugs exclusion.
          Hide
          curino Carlo Curino added a comment -

          I have just done so in the .08.patch uploaded, let's see if yetus is happy.

          Show
          curino Carlo Curino added a comment - I have just done so in the .08.patch uploaded, let's see if yetus is happy.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 4m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 12m 25s YARN-2915 passed
          +1 compile 11m 41s YARN-2915 passed
          +1 checkstyle 2m 24s YARN-2915 passed
          +1 mvnsite 5m 15s YARN-2915 passed
          +1 mvneclipse 0m 58s YARN-2915 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 48s YARN-2915 passed
          +1 javadoc 2m 2s YARN-2915 passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 3m 5s the patch passed
          +1 compile 4m 33s the patch passed
          +1 javac 4m 33s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvnsite 3m 54s the patch passed
          +1 mvneclipse 0m 54s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 1m 58s the patch passed
          -1 unit 64m 38s hadoop-yarn in the patch failed.
          +1 unit 0m 30s hadoop-yarn-api in the patch passed.
          +1 unit 1m 2s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          132m 39s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestTokenClientRMService



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839277/YARN-5634-YARN-2915.08.patch
          Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
          uname Linux 308e4aa93cf4 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-2915 / e38a4a4
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13950/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13950/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 4m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 12m 25s YARN-2915 passed +1 compile 11m 41s YARN-2915 passed +1 checkstyle 2m 24s YARN-2915 passed +1 mvnsite 5m 15s YARN-2915 passed +1 mvneclipse 0m 58s YARN-2915 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 48s YARN-2915 passed +1 javadoc 2m 2s YARN-2915 passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 3m 5s the patch passed +1 compile 4m 33s the patch passed +1 javac 4m 33s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 3m 54s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 56s the patch passed +1 javadoc 1m 58s the patch passed -1 unit 64m 38s hadoop-yarn in the patch failed. +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 1m 2s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 132m 39s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestTokenClientRMService Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839277/YARN-5634-YARN-2915.08.patch Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 308e4aa93cf4 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / e38a4a4 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/13950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13950/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13950/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Carlo Curino for the updated patch. The test case failure looks unrelated so will be committing this shortly.

          Show
          subru Subru Krishnan added a comment - Thanks Carlo Curino for the updated patch. The test case failure looks unrelated so will be committing this shortly.
          Hide
          subru Subru Krishnan added a comment -

          I just committed this to branch YARN-2915. Thanks Carlo Curino!

          Show
          subru Subru Krishnan added a comment - I just committed this to branch YARN-2915 . Thanks Carlo Curino !
          Hide
          curino Carlo Curino added a comment -

          Thanks Subru Krishnan for reviewing and committing.

          Show
          curino Carlo Curino added a comment - Thanks Subru Krishnan for reviewing and committing.

            People

            • Assignee:
              curino Carlo Curino
              Reporter:
              curino Carlo Curino
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development