Details

    • Hadoop Flags:
      Reviewed
    1. YARN-5391.01.patch
      40 kB
      Carlo Curino
    2. YARN-5391.02.patch
      40 kB
      Carlo Curino
    3. YARN-5391.03.patch
      40 kB
      Carlo Curino
    4. YARN-5391-YARN-2915.04.patch
      40 kB
      Carlo Curino
    5. YARN-5391-YARN-2915.05.patch
      30 kB
      Carlo Curino
    6. YARN-5391-YARN-2915.06.patch
      32 kB
      Carlo Curino
    7. YARN-5391-YARN-2915.07.patch
      31 kB
      Carlo Curino

      Issue Links

        Activity

        Hide
        curino Carlo Curino added a comment -

        This patch provides implementation of 2 FederationPolicy:

        1. a simple stateless/low-configuration policy that uses UniformRandomRouterPolicy for the router and BroadcastAMRMProxyPolicy for the amrmproxy.
        2. a policy that combines a ProbabilisticRouterFederationPolicy and a LocalityMulticastAMRMProxyFederationPolicy.

        In this patch, we also have general classes to serialize and deserialize an arbitrarily "weighted" policy.

        Show
        curino Carlo Curino added a comment - This patch provides implementation of 2 FederationPolicy : a simple stateless/low-configuration policy that uses UniformRandomRouterPolicy for the router and BroadcastAMRMProxyPolicy for the amrmproxy. a policy that combines a ProbabilisticRouterFederationPolicy and a LocalityMulticastAMRMProxyFederationPolicy . In this patch, we also have general classes to serialize and deserialize an arbitrarily "weighted" policy.
        Hide
        curino Carlo Curino added a comment -

        Rebased

        Show
        curino Carlo Curino added a comment - Rebased
        Hide
        curino Carlo Curino added a comment -

        (renaming to target branch for Jenkins)

        Show
        curino Carlo Curino added a comment - (renaming to target branch for Jenkins)
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 7m 49s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 39s trunk passed
        +1 javadoc 0m 15s trunk passed
        -1 mvninstall 0m 14s hadoop-yarn-server-common in the patch failed.
        -1 compile 0m 13s hadoop-yarn-server-common in the patch failed.
        -1 javac 0m 13s hadoop-yarn-server-common in the patch failed.
        -1 checkstyle 0m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)
        -1 mvnsite 0m 14s hadoop-yarn-server-common in the patch failed.
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 13s hadoop-yarn-server-common in the patch failed.
        -1 javadoc 0m 13s hadoop-yarn-server-common in the patch failed.
        -1 unit 0m 14s hadoop-yarn-server-common in the patch failed.
        -1 asflicense 0m 19s The patch generated 1 ASF License warnings.
        12m 39s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823091/YARN-5391.03.patch
        JIRA Issue YARN-5391
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 55671fd5ae85 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e83be44
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12733/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12733/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 7m 49s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 15s trunk passed -1 mvninstall 0m 14s hadoop-yarn-server-common in the patch failed. -1 compile 0m 13s hadoop-yarn-server-common in the patch failed. -1 javac 0m 13s hadoop-yarn-server-common in the patch failed. -1 checkstyle 0m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0) -1 mvnsite 0m 14s hadoop-yarn-server-common in the patch failed. +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 13s hadoop-yarn-server-common in the patch failed. -1 javadoc 0m 13s hadoop-yarn-server-common in the patch failed. -1 unit 0m 14s hadoop-yarn-server-common in the patch failed. -1 asflicense 0m 19s The patch generated 1 ASF License warnings. 12m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823091/YARN-5391.03.patch JIRA Issue YARN-5391 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 55671fd5ae85 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e83be44 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12733/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12733/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12733/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 8m 10s YARN-2915 passed
        +1 compile 0m 27s YARN-2915 passed
        +1 checkstyle 0m 21s YARN-2915 passed
        +1 mvnsite 0m 30s YARN-2915 passed
        +1 mvneclipse 0m 15s YARN-2915 passed
        +1 findbugs 0m 57s YARN-2915 passed
        +1 javadoc 0m 21s YARN-2915 passed
        -1 mvninstall 0m 18s hadoop-yarn-server-common in the patch failed.
        -1 compile 0m 20s hadoop-yarn-server-common in the patch failed.
        -1 javac 0m 20s hadoop-yarn-server-common in the patch failed.
        -1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)
        -1 mvnsite 0m 20s hadoop-yarn-server-common in the patch failed.
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 19s hadoop-yarn-server-common in the patch failed.
        -1 javadoc 0m 16s hadoop-yarn-server-common in the patch failed.
        -1 unit 0m 17s hadoop-yarn-server-common in the patch failed.
        -1 asflicense 0m 17s The patch generated 1 ASF License warnings.
        14m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823159/YARN-5391-YARN-2915.04.patch
        JIRA Issue YARN-5391
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 73be77d00d7a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / b689f55
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12737/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12737/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 8m 10s YARN-2915 passed +1 compile 0m 27s YARN-2915 passed +1 checkstyle 0m 21s YARN-2915 passed +1 mvnsite 0m 30s YARN-2915 passed +1 mvneclipse 0m 15s YARN-2915 passed +1 findbugs 0m 57s YARN-2915 passed +1 javadoc 0m 21s YARN-2915 passed -1 mvninstall 0m 18s hadoop-yarn-server-common in the patch failed. -1 compile 0m 20s hadoop-yarn-server-common in the patch failed. -1 javac 0m 20s hadoop-yarn-server-common in the patch failed. -1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0) -1 mvnsite 0m 20s hadoop-yarn-server-common in the patch failed. +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 19s hadoop-yarn-server-common in the patch failed. -1 javadoc 0m 16s hadoop-yarn-server-common in the patch failed. -1 unit 0m 17s hadoop-yarn-server-common in the patch failed. -1 asflicense 0m 17s The patch generated 1 ASF License warnings. 14m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823159/YARN-5391-YARN-2915.04.patch JIRA Issue YARN-5391 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 73be77d00d7a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12737/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12737/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12737/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        curino Carlo Curino added a comment -

        Much of the errors are because this depends on YARN-5323, YARN-5324, YARN-5325 (compiles and run when all combined).

        Show
        curino Carlo Curino added a comment - Much of the errors are because this depends on YARN-5323 , YARN-5324 , YARN-5325 (compiles and run when all combined).
        Hide
        curino Carlo Curino added a comment -

        Initial (rough) version of the patch, rebased after YARN-5325 commit. Likely need some polish.

        Show
        curino Carlo Curino added a comment - Initial (rough) version of the patch, rebased after YARN-5325 commit. Likely need some polish.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 8m 15s YARN-2915 passed
        +1 compile 0m 24s YARN-2915 passed
        +1 checkstyle 0m 17s YARN-2915 passed
        +1 mvnsite 0m 27s YARN-2915 passed
        +1 mvneclipse 0m 14s YARN-2915 passed
        +1 findbugs 0m 51s YARN-2915 passed
        +1 javadoc 0m 18s YARN-2915 passed
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 22s the patch passed
        +1 javac 0m 22s the patch passed
        -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0)
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 57s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 0m 16s the patch passed
        +1 unit 1m 2s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        15m 43s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
          Call to Class<?>.equals(String) in org.apache.hadoop.yarn.server.federation.policies.BasePolicyManager.internalPolicyGetter(FederationPolicyInitializationContext, ConfigurableFederationPolicy, String) At BasePolicyManager.java:ConfigurableFederationPolicy, String) At BasePolicyManager.java:[line 136]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833462/YARN-5391-YARN-2915.05.patch
        JIRA Issue YARN-5391
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 522e6c33f977 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / def8211
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13400/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13400/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13400/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13400/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 8m 15s YARN-2915 passed +1 compile 0m 24s YARN-2915 passed +1 checkstyle 0m 17s YARN-2915 passed +1 mvnsite 0m 27s YARN-2915 passed +1 mvneclipse 0m 14s YARN-2915 passed +1 findbugs 0m 51s YARN-2915 passed +1 javadoc 0m 18s YARN-2915 passed +1 mvninstall 0m 23s the patch passed +1 compile 0m 22s the patch passed +1 javac 0m 22s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 57s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 16s the patch passed +1 unit 1m 2s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 15m 43s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common   Call to Class<?>.equals(String) in org.apache.hadoop.yarn.server.federation.policies.BasePolicyManager.internalPolicyGetter(FederationPolicyInitializationContext, ConfigurableFederationPolicy, String) At BasePolicyManager.java:ConfigurableFederationPolicy, String) At BasePolicyManager.java: [line 136] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833462/YARN-5391-YARN-2915.05.patch JIRA Issue YARN-5391 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 522e6c33f977 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / def8211 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13400/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13400/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13400/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13400/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        curino Carlo Curino added a comment -

        I reorganized a bit the test code (more shared with usual Base class trick, and larger coverage). Let's see what Yetus has to say, but it is otherwise ok to review, Subru Krishnan I know you were looking at it, if you can post your take on it would be great.

        Show
        curino Carlo Curino added a comment - I reorganized a bit the test code (more shared with usual Base class trick, and larger coverage). Let's see what Yetus has to say, but it is otherwise ok to review, Subru Krishnan I know you were looking at it, if you can post your take on it would be great.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 12m 27s YARN-2915 passed
        +1 compile 0m 26s YARN-2915 passed
        +1 checkstyle 0m 18s YARN-2915 passed
        +1 mvnsite 0m 32s YARN-2915 passed
        +1 mvneclipse 0m 17s YARN-2915 passed
        +1 findbugs 0m 56s YARN-2915 passed
        +1 javadoc 0m 24s YARN-2915 passed
        +1 mvninstall 0m 28s the patch passed
        +1 compile 0m 25s the patch passed
        +1 javac 0m 25s the patch passed
        -0 checkstyle 0m 13s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
        +1 mvnsite 0m 29s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 59s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 1m 7s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        21m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5391
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835893/YARN-5391-YARN-2915.06.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8cf63f39007c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 116eb1d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13653/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13653/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13653/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 12m 27s YARN-2915 passed +1 compile 0m 26s YARN-2915 passed +1 checkstyle 0m 18s YARN-2915 passed +1 mvnsite 0m 32s YARN-2915 passed +1 mvneclipse 0m 17s YARN-2915 passed +1 findbugs 0m 56s YARN-2915 passed +1 javadoc 0m 24s YARN-2915 passed +1 mvninstall 0m 28s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed -0 checkstyle 0m 13s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 59s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 1m 7s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 21m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5391 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835893/YARN-5391-YARN-2915.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8cf63f39007c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 116eb1d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13653/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13653/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13653/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        subru Subru Krishnan added a comment -

        Thanks Carlo Curino for the updated patch. It looks good, have a few minor comments below:

        • We should log exceptions before throwing in BasePolicyManager. Also, does it make more sense to simply return the old instance instead?
        • I don't understand why the get/setRouter/AMRMFederationPolicy() are public in BasePolicyManager? If that's intentional, shouldn't they be in FederationPolicyManager interface?
        • The policy context is being validated in both BasePolicyManager::getAMRMPolicy and BasePolicyManager::internalPolicyGetter.
        • We should rename Base* classes to Abstract*.
        • Suggestion: might be easier if ProbabilisticMulticastPolicyManager is renamed to WeightedMulticastPolicyManager ?
        • Why do we have get/setWeightedPolicyInfo methods as public as they are specific to the particular ProbabilisticMulticastPolicyManager implementation?

        There are few checkstyle warnings which I feel can be fixed.

        Show
        subru Subru Krishnan added a comment - Thanks Carlo Curino for the updated patch. It looks good, have a few minor comments below: We should log exceptions before throwing in BasePolicyManager . Also, does it make more sense to simply return the old instance instead? I don't understand why the get/setRouter/AMRMFederationPolicy() are public in BasePolicyManager ? If that's intentional, shouldn't they be in FederationPolicyManager interface? The policy context is being validated in both BasePolicyManager::getAMRMPolicy and BasePolicyManager::internalPolicyGetter . We should rename Base * classes to Abstract *. Suggestion: might be easier if ProbabilisticMulticastPolicyManager is renamed to WeightedMulticastPolicyManager ? Why do we have get/setWeightedPolicyInfo methods as public as they are specific to the particular ProbabilisticMulticastPolicyManager implementation? There are few checkstyle warnings which I feel can be fixed.
        Hide
        curino Carlo Curino added a comment -

        Thanks Subru Krishnan I believe I addressed your comments.

        Show
        curino Carlo Curino added a comment - Thanks Subru Krishnan I believe I addressed your comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 13m 2s YARN-2915 passed
        +1 compile 0m 27s YARN-2915 passed
        +1 checkstyle 0m 17s YARN-2915 passed
        +1 mvnsite 0m 33s YARN-2915 passed
        +1 mvneclipse 0m 16s YARN-2915 passed
        +1 findbugs 0m 59s YARN-2915 passed
        +1 javadoc 0m 22s YARN-2915 passed
        +1 mvninstall 0m 29s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 13s the patch passed
        +1 javadoc 0m 21s the patch passed
        +1 unit 1m 20s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        23m 10s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5391
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835934/YARN-5391-YARN-2915.07.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cacf9a5c12fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 116eb1d
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13710/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13710/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 2s YARN-2915 passed +1 compile 0m 27s YARN-2915 passed +1 checkstyle 0m 17s YARN-2915 passed +1 mvnsite 0m 33s YARN-2915 passed +1 mvneclipse 0m 16s YARN-2915 passed +1 findbugs 0m 59s YARN-2915 passed +1 javadoc 0m 22s YARN-2915 passed +1 mvninstall 0m 29s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 13s the patch passed +1 javadoc 0m 21s the patch passed +1 unit 1m 20s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 23m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5391 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835934/YARN-5391-YARN-2915.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cacf9a5c12fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 116eb1d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13710/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13710/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        subru Subru Krishnan added a comment -

        Thanks Carlo Curino. +1 on the latest patch.

        Show
        subru Subru Krishnan added a comment - Thanks Carlo Curino . +1 on the latest patch.
        Hide
        subru Subru Krishnan added a comment -

        I just committed this to branch YARN-2195. Thanks Carlo Curino for the contribution.

        Show
        subru Subru Krishnan added a comment - I just committed this to branch YARN-2195 . Thanks Carlo Curino for the contribution.
        Hide
        curino Carlo Curino added a comment -

        Thanks Subru Krishnan for prompt reviewing and commit.

        Show
        curino Carlo Curino added a comment - Thanks Subru Krishnan for prompt reviewing and commit.

          People

          • Assignee:
            curino Carlo Curino
            Reporter:
            curino Carlo Curino
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development