Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5632

UPDATE_EXECUTION_TYPE causes UpdateContainerRequestPBImpl to throw

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Component/s: api
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In branch-2.8 UPDATE_EXECUTION_TYPE is a valid enum in the ContainerUpdateType enum but it is missing from the corresponding ContainerUpdateTypeProto. This causes the conversion to throw an exception when trying to convert from the enum to the proto.

        Issue Links

          Activity

          Hide
          jlowe Jason Lowe added a comment -

          Looks like this was missed in the branch-2.8 patch for YARN-5221. Occasionally TestPBImplRecords will fail as a result if it happens to roll the bad enum as a random value:

          org.apache.hadoop.yarn.api.TestPBImplRecords  Time elapsed: 0.671 sec  <<< ERROR!
          java.lang.reflect.InvocationTargetException: null
          	at java.lang.Enum.valueOf(Enum.java:238)
          	at org.apache.hadoop.yarn.proto.YarnServiceProtos$ContainerUpdateTypeProto.valueOf(YarnServiceProtos.java:14)
          	at org.apache.hadoop.yarn.api.records.impl.pb.ProtoUtils.convertToProtoFormat(ProtoUtils.java:301)
          	at org.apache.hadoop.yarn.api.records.impl.pb.UpdateContainerRequestPBImpl.setContainerUpdateType(UpdateContainerRequestPBImpl.java:135)
          	at org.apache.hadoop.yarn.api.records.UpdateContainerRequest.newInstance(UpdateContainerRequest.java:56)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:497)
          	at org.apache.hadoop.yarn.api.TestPBImplRecords.generateByNewInstance(TestPBImplRecords.java:451)
          	at org.apache.hadoop.yarn.api.TestPBImplRecords.setup(TestPBImplRecords.java:484)
          
          Show
          jlowe Jason Lowe added a comment - Looks like this was missed in the branch-2.8 patch for YARN-5221 . Occasionally TestPBImplRecords will fail as a result if it happens to roll the bad enum as a random value: org.apache.hadoop.yarn.api.TestPBImplRecords Time elapsed: 0.671 sec <<< ERROR! java.lang.reflect.InvocationTargetException: null at java.lang.Enum.valueOf(Enum.java:238) at org.apache.hadoop.yarn.proto.YarnServiceProtos$ContainerUpdateTypeProto.valueOf(YarnServiceProtos.java:14) at org.apache.hadoop.yarn.api.records.impl.pb.ProtoUtils.convertToProtoFormat(ProtoUtils.java:301) at org.apache.hadoop.yarn.api.records.impl.pb.UpdateContainerRequestPBImpl.setContainerUpdateType(UpdateContainerRequestPBImpl.java:135) at org.apache.hadoop.yarn.api.records.UpdateContainerRequest.newInstance(UpdateContainerRequest.java:56) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.apache.hadoop.yarn.api.TestPBImplRecords.generateByNewInstance(TestPBImplRecords.java:451) at org.apache.hadoop.yarn.api.TestPBImplRecords.setup(TestPBImplRecords.java:484)
          Hide
          jlowe Jason Lowe added a comment -

          Looks like the most straightforward fix is to remove the extra enumeration value since there appears to be no code in 2.8 to support it if specified.

          Show
          jlowe Jason Lowe added a comment - Looks like the most straightforward fix is to remove the extra enumeration value since there appears to be no code in 2.8 to support it if specified.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 19s branch-2.8 passed
          +1 compile 0m 22s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 0m 24s branch-2.8 passed with JDK v1.7.0_111
          +1 checkstyle 0m 14s branch-2.8 passed
          +1 mvnsite 0m 28s branch-2.8 passed
          +1 mvneclipse 0m 13s branch-2.8 passed
          +1 findbugs 1m 13s branch-2.8 passed
          +1 javadoc 0m 19s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 0m 19s branch-2.8 passed with JDK v1.7.0_111
          +1 mvninstall 0m 24s the patch passed
          +1 compile 0m 19s the patch passed with JDK v1.8.0_101
          +1 javac 0m 19s the patch passed
          +1 compile 0m 22s the patch passed with JDK v1.7.0_111
          +1 javac 0m 22s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 mvnsite 0m 26s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 25s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_101
          +1 javadoc 0m 17s the patch passed with JDK v1.7.0_111
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          16m 4s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827776/YARN-5632-branch-2.8.001.patch
          JIRA Issue YARN-5632
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0bb1fe01e5ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 4b9845b
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13062/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13062/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 19s branch-2.8 passed +1 compile 0m 22s branch-2.8 passed with JDK v1.8.0_101 +1 compile 0m 24s branch-2.8 passed with JDK v1.7.0_111 +1 checkstyle 0m 14s branch-2.8 passed +1 mvnsite 0m 28s branch-2.8 passed +1 mvneclipse 0m 13s branch-2.8 passed +1 findbugs 1m 13s branch-2.8 passed +1 javadoc 0m 19s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 0m 19s branch-2.8 passed with JDK v1.7.0_111 +1 mvninstall 0m 24s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_101 +1 javac 0m 19s the patch passed +1 compile 0m 22s the patch passed with JDK v1.7.0_111 +1 javac 0m 22s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_111 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 16m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827776/YARN-5632-branch-2.8.001.patch JIRA Issue YARN-5632 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0bb1fe01e5ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 4b9845b Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13062/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api Console output https://builds.apache.org/job/PreCommit-YARN-Build/13062/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          +1. Thanks for tracking this down.

          Show
          asuresh Arun Suresh added a comment - +1. Thanks for tracking this down.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the review, Arun! Committing this.

          Show
          jlowe Jason Lowe added a comment - Thanks for the review, Arun! Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          I committed this to branch-2.8.

          Show
          jlowe Jason Lowe added a comment - I committed this to branch-2.8.

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development