Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5567

Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      Prior to this fix, the NodeManager will ignore any non-zero exit code for any script in the yarn.nodemanager.health-checker.script.path property. With this change, any syntax errors in the health checking script will get flagged as an error in the same fashion (likely exit code 1) that the script detecting a health issue.
      Show
      Prior to this fix, the NodeManager will ignore any non-zero exit code for any script in the yarn.nodemanager.health-checker.script.path property. With this change, any syntax errors in the health checking script will get flagged as an error in the same fashion (likely exit code 1) that the script detecting a health issue.

      Description

      In case of FAILED_WITH_EXIT_CODE, health status should be false.

            case FAILED_WITH_EXIT_CODE:
              setHealthStatus(true, "", now);
              break;
      

      should be

            case FAILED_WITH_EXIT_CODE:
              setHealthStatus(false, "", now);
              break;
      

        Attachments

        1. YARN-5567.001.patch
          3 kB
          Yufei Gu

          Issue Links

            Activity

              People

              • Assignee:
                yufeigu Yufei Gu
                Reporter:
                yufeigu Yufei Gu
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: