[YARN-5567] Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus - ASF JIRA

XML

Word

Printable

JSON

Hadoop Flags:

Incompatible change, Reviewed
Release Note:

Hide
Prior to this fix, the NodeManager will ignore any non-zero exit code for any script in the yarn.nodemanager.health-checker.script.path property. With this change, any syntax errors in the health checking script will get flagged as an error in the same fashion (likely exit code 1) that the script detecting a health issue.

Show
Prior to this fix, the NodeManager will ignore any non-zero exit code for any script in the yarn.nodemanager.health-checker.script.path property. With this change, any syntax errors in the health checking script will get flagged as an error in the same fashion (likely exit code 1) that the script detecting a health issue.

In case of FAILED_WITH_EXIT_CODE, health status should be false.

      case FAILED_WITH_EXIT_CODE:
        setHealthStatus(true, "", now);
        break;

should be

      case FAILED_WITH_EXIT_CODE:
        setHealthStatus(false, "", now);
        break;

is related to

YARN-6715 Fix documentation about NodeHealthScriptRunner

relates to

YARN-5595 Update documentation and Javadoc to match change to NodeHealthScriptRunner#reportHealthStatus