Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5430

Return container's ip and host from NM ContainerStatus call

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      In YARN-4757, we introduced a DNS mechanism for containers. That's based on the assumption that we can get the container's ip and host information and store it in the registry-service. This jira aims to get the container's ip and host from the NM, primarily docker container

      1. YARN-5430-branch-2.patch
        34 kB
        Jian He
      2. YARN-5430.9.patch
        33 kB
        Jian He
      3. YARN-5430.9.branch-2.patch
        34 kB
        Jian He
      4. YARN-5430.8.patch
        33 kB
        Jian He
      5. YARN-5430.7.patch
        33 kB
        Jian He
      6. YARN-5430.6.patch
        34 kB
        Jian He
      7. YARN-5430.5.patch
        33 kB
        Jian He
      8. YARN-5430.4.patch
        33 kB
        Jian He
      9. YARN-5430.3.patch
        25 kB
        Jian He
      10. YARN-5430.2.patch
        27 kB
        Jian He
      11. YARN-5430.1.patch
        48 kB
        Jian He

        Issue Links

          Activity

          Hide
          jianhe Jian He added a comment -

          What the patch does:

          • For docker container: container-executable runs the docker inspect (which already runs today to get the pid) to get the hostname and ip address. NM stores that in container status to let app query.
          • For regular container: simply return local host ip and address.
          Show
          jianhe Jian He added a comment - What the patch does: For docker container: container-executable runs the docker inspect (which already runs today to get the pid) to get the hostname and ip address. NM stores that in container status to let app query. For regular container: simply return local host ip and address.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s YARN-5430 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820127/YARN-5430.1.patch
          JIRA Issue YARN-5430
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12500/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s YARN-5430 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820127/YARN-5430.1.patch JIRA Issue YARN-5430 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12500/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s YARN-5430 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820141/YARN-5430.2.patch
          JIRA Issue YARN-5430
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12502/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-5430 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820141/YARN-5430.2.patch JIRA Issue YARN-5430 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12502/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 31s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 24m 51s Maven dependency ordering for branch
          +1 mvninstall 59m 8s trunk passed
          +1 compile 3m 11s trunk passed
          +1 checkstyle 0m 52s trunk passed
          +1 mvnsite 1m 56s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          +1 findbugs 3m 27s trunk passed
          +1 javadoc 1m 19s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 34s the patch passed
          +1 compile 3m 6s the patch passed
          +1 cc 3m 6s the patch passed
          +1 javac 3m 6s the patch passed
          -1 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 235 unchanged - 3 fixed = 241 total (was 238)
          +1 mvnsite 1m 49s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          -1 whitespace 0m 0s The patch 1 line(s) with tabs.
          -1 findbugs 1m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
          -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 2 new + 255 unchanged - 0 fixed = 257 total (was 255)
          +1 unit 0m 30s hadoop-yarn-api in the patch passed.
          +1 unit 2m 46s hadoop-yarn-common in the patch passed.
          -1 unit 14m 1s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          128m 19s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            Inconsistent synchronization of org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl.builder; locked 76% of time Unsynchronized access at ContainerStatusPBImpl.java:76% of time Unsynchronized access at ContainerStatusPBImpl.java:[line 230]
            Inconsistent synchronization of org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl.proto; locked 84% of time Unsynchronized access at ContainerStatusPBImpl.java:84% of time Unsynchronized access at ContainerStatusPBImpl.java:[line 216]
            Inconsistent synchronization of org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl.viaProto; locked 85% of time Unsynchronized access at ContainerStatusPBImpl.java:85% of time Unsynchronized access at ContainerStatusPBImpl.java:[line 216]
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
            Exception is caught when Exception is not thrown in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.readIpAndHost(Path) At DockerLinuxContainerRuntime.java:is not thrown in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.readIpAndHost(Path) At DockerLinuxContainerRuntime.java:[line 538]
          Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.nodemanager.TestDirectoryCollection



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820153/YARN-5430.1.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 93df2d594390 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7cac765
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12503/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12503/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 24m 51s Maven dependency ordering for branch +1 mvninstall 59m 8s trunk passed +1 compile 3m 11s trunk passed +1 checkstyle 0m 52s trunk passed +1 mvnsite 1m 56s trunk passed +1 mvneclipse 0m 47s trunk passed +1 findbugs 3m 27s trunk passed +1 javadoc 1m 19s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 34s the patch passed +1 compile 3m 6s the patch passed +1 cc 3m 6s the patch passed +1 javac 3m 6s the patch passed -1 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 235 unchanged - 3 fixed = 241 total (was 238) +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 39s the patch passed -1 whitespace 0m 0s The patch 1 line(s) with tabs. -1 findbugs 1m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 2 new + 255 unchanged - 0 fixed = 257 total (was 255) +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 2m 46s hadoop-yarn-common in the patch passed. -1 unit 14m 1s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 128m 19s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Inconsistent synchronization of org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl.builder; locked 76% of time Unsynchronized access at ContainerStatusPBImpl.java:76% of time Unsynchronized access at ContainerStatusPBImpl.java: [line 230]   Inconsistent synchronization of org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl.proto; locked 84% of time Unsynchronized access at ContainerStatusPBImpl.java:84% of time Unsynchronized access at ContainerStatusPBImpl.java: [line 216]   Inconsistent synchronization of org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl.viaProto; locked 85% of time Unsynchronized access at ContainerStatusPBImpl.java:85% of time Unsynchronized access at ContainerStatusPBImpl.java: [line 216] FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   Exception is caught when Exception is not thrown in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.readIpAndHost(Path) At DockerLinuxContainerRuntime.java:is not thrown in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.readIpAndHost(Path) At DockerLinuxContainerRuntime.java: [line 538] Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.nodemanager.TestDirectoryCollection Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820153/YARN-5430.1.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 93df2d594390 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7cac765 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12503/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12503/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12503/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 56s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 2m 18s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 29s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          +1 findbugs 2m 46s trunk passed
          +1 javadoc 1m 3s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 17s the patch passed
          +1 compile 2m 34s the patch passed
          +1 cc 2m 34s the patch passed
          +1 javac 2m 34s the patch passed
          -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 160 unchanged - 1 fixed = 176 total (was 161)
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 59s the patch passed
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          -1 unit 2m 19s hadoop-yarn-common in the patch failed.
          -1 unit 13m 8s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          44m 36s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
            Format-string method String.format(String, Object[]) called with format string "Shell execution failed:with format string "Shell execution failed: ExitCode = %s Stderr: %s Stdout: %s Command:" wants 3 arguments but is given 4 in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor.executePrivilegedOperation(List, PrivilegedOperation, File, Map, boolean, boolean) At PrivilegedOperationExecutor.java:[line 160]
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat
            hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.TestDockerInspectCommand



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821612/YARN-5430.2.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux db13836f7775 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7fc70c6
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12611/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12611/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 56s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 2m 18s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 2m 46s trunk passed +1 javadoc 1m 3s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 2m 34s the patch passed +1 cc 2m 34s the patch passed +1 javac 2m 34s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 160 unchanged - 1 fixed = 176 total (was 161) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 59s the patch passed +1 unit 0m 25s hadoop-yarn-api in the patch passed. -1 unit 2m 19s hadoop-yarn-common in the patch failed. -1 unit 13m 8s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 44m 36s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   Format-string method String.format(String, Object[]) called with format string "Shell execution failed:with format string "Shell execution failed: ExitCode = %s Stderr: %s Stdout: %s Command:" wants 3 arguments but is given 4 in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor.executePrivilegedOperation(List, PrivilegedOperation, File, Map, boolean, boolean) At PrivilegedOperationExecutor.java: [line 160] Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat   hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.TestDockerInspectCommand Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821612/YARN-5430.2.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux db13836f7775 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7fc70c6 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12611/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12611/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12611/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 4s Maven dependency ordering for branch
          +1 mvninstall 7m 57s trunk passed
          +1 compile 2m 36s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 1m 35s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 2m 50s trunk passed
          +1 javadoc 1m 0s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 9s the patch passed
          +1 compile 2m 17s the patch passed
          +1 cc 2m 17s the patch passed
          +1 javac 2m 17s the patch passed
          -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 163 unchanged - 1 fixed = 164 total (was 164)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 55s the patch passed
          +1 javadoc 1m 2s the patch passed
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          -1 unit 2m 21s hadoop-yarn-common in the patch failed.
          -1 unit 13m 24s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          46m 22s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat
            hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821773/YARN-5430.3.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 5d0274cc2ef3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b913677
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12622/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12622/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 4s Maven dependency ordering for branch +1 mvninstall 7m 57s trunk passed +1 compile 2m 36s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 1m 35s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 2m 50s trunk passed +1 javadoc 1m 0s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 9s the patch passed +1 compile 2m 17s the patch passed +1 cc 2m 17s the patch passed +1 javac 2m 17s the patch passed -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 163 unchanged - 1 fixed = 164 total (was 164) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 55s the patch passed +1 javadoc 1m 2s the patch passed +1 unit 0m 25s hadoop-yarn-api in the patch passed. -1 unit 2m 21s hadoop-yarn-common in the patch failed. -1 unit 13m 24s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 46m 22s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat   hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821773/YARN-5430.3.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 5d0274cc2ef3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b913677 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12622/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12622/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12622/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment - - edited

          Thanks for the patch Jian He!

          1)

          +  @Private
          +  @Unstable
          +  public abstract void setIp(String ip);
          +
          

          We can’t return just one ip. In the non-docker scenario, multiple ips for a host are common and Docker itself has support for multiple ips for a container. We don’t currently support that but it’ll probably be required for us to support soon. Similarly we should change getIpAndHost and split them up into getIps and getHost calls.

          2)

          +  optional string ip = 7;
          +  optional string host = 8;
          

          Instead of named variables - can we make this a bit more generic and add support for a simple list of string->list? Then the next time we need to send a new variable, we don’t need to mess around with the protobuf pieces. Something like

          message StringListMapProto {
            required string key = 1;
            optional repeated string value = 2;
          }
          

          and in ContainerStatusProto

          optional repeated StringListMapProto attributes_map = 7;
          

          3)

          +  public String[] getIpAndHost(Container container) {
          +    return null;
          +  }
          

          The default implementation shouldn’t return null. We should return the host name and ip.

          4)

          +  public void setIpAndHost(String[] ipAndHost) {
          +    this.ip = ipAndHost[0];
          +    this.host = ipAndHost[1];
          +  }
          

          This may become a problem if the size of the array is more than 2(multiple ips)

          5)

          +  @Override
          +  public String[] getIpAndHost(Container container) {
          +    String[] ipAndHost = new String[2];
          +    try {
          +      InetAddress address = InetAddress.getLocalHost();
          +      ipAndHost[0] = address.getHostAddress();
          +      ipAndHost[1] = address.getHostName();
          +    } catch (UnknownHostException e) {
          +      LOG.error("Unable to get Local hostname and ip for " + container
          +          .getContainerId());
          +    }
          +    return ipAndHost;
          +  }
           }
          

          Instead of this, we should just use NetUtils.getLocalHostname() and NetUtils.getIPs. we’ll have to modify getIps() because today it expects a subnet and we want all ips irrespective of subnet.

          6)

          +      LOG.info("Docker inspect output for " + containerId + ": " + output);
          

          Change log level to debug?

          7)

          +    // Be sure to not use space in the argument, otherwise the
          +    // extract_values_delim method in container-executor binary
          +    // cannot parse the arguments correctly.
          +    super.addCommandArguments("--format='{{range.NetworkSettings.Networks}}"
          +        + "{{.IPAddress}}{{end}},{{.Config.Hostname}}'");
          +    super.addCommandArguments(containerName);
          +    return this;
          

          Ugh. This is an ugly one. I thought there needed to be a space between range and NetworkSettings because the code passed is meant to be a go template. Use this instead -

          --format '{{range(.NetworkSettings.Networks)}}{{.IPAddress}},{{end}}{{.Config.Hostname}}'

          . The output will look like -

          172.17.0.2,192.168.127.128,c399439fbda9

          8)

          +  if (docker_binary == NULL) {
          +    docker_binary = "docker";
          +  }
          

          Can we make this a common function - the same code is in launch_docker_container_as_user?

          Show
          vvasudev Varun Vasudev added a comment - - edited Thanks for the patch Jian He ! 1) + @Private + @Unstable + public abstract void setIp( String ip); + We can’t return just one ip. In the non-docker scenario, multiple ips for a host are common and Docker itself has support for multiple ips for a container. We don’t currently support that but it’ll probably be required for us to support soon. Similarly we should change getIpAndHost and split them up into getIps and getHost calls. 2) + optional string ip = 7; + optional string host = 8; Instead of named variables - can we make this a bit more generic and add support for a simple list of string->list? Then the next time we need to send a new variable, we don’t need to mess around with the protobuf pieces. Something like message StringListMapProto { required string key = 1; optional repeated string value = 2; } and in ContainerStatusProto optional repeated StringListMapProto attributes_map = 7; 3) + public String [] getIpAndHost(Container container) { + return null ; + } The default implementation shouldn’t return null. We should return the host name and ip. 4) + public void setIpAndHost( String [] ipAndHost) { + this .ip = ipAndHost[0]; + this .host = ipAndHost[1]; + } This may become a problem if the size of the array is more than 2(multiple ips) 5) + @Override + public String [] getIpAndHost(Container container) { + String [] ipAndHost = new String [2]; + try { + InetAddress address = InetAddress.getLocalHost(); + ipAndHost[0] = address.getHostAddress(); + ipAndHost[1] = address.getHostName(); + } catch (UnknownHostException e) { + LOG.error( "Unable to get Local hostname and ip for " + container + .getContainerId()); + } + return ipAndHost; + } } Instead of this, we should just use NetUtils.getLocalHostname() and NetUtils.getIPs. we’ll have to modify getIps() because today it expects a subnet and we want all ips irrespective of subnet. 6) + LOG.info( "Docker inspect output for " + containerId + ": " + output); Change log level to debug? 7) + // Be sure to not use space in the argument, otherwise the + // extract_values_delim method in container-executor binary + // cannot parse the arguments correctly. + super .addCommandArguments( "--format='{{range.NetworkSettings.Networks}}" + + "{{.IPAddress}}{{end}},{{.Config.Hostname}}'" ); + super .addCommandArguments(containerName); + return this ; Ugh. This is an ugly one. I thought there needed to be a space between range and NetworkSettings because the code passed is meant to be a go template. Use this instead - --format '{{range(.NetworkSettings.Networks)}}{{.IPAddress}},{{end}}{{.Config.Hostname}}' . The output will look like - 172.17.0.2,192.168.127.128,c399439fbda9 8) + if (docker_binary == NULL) { + docker_binary = "docker" ; + } Can we make this a common function - the same code is in launch_docker_container_as_user?
          Hide
          jianhe Jian He added a comment -

          Similarly we should change getIpAndHost and split them up into getIps and getHost calls.

          Separating this means we need to make two separate calls into container-executor binary and invoke the docker command which is additional cost. I'd like to keep this as a single call.

          Instead of this, we should just use NetUtils.getLocalHostname() and NetUtils.getIPs

          This method will return all internal-facing IPs, including loopback ip which will be meaningless to the user. I think we can return the localhost ip for now, as the ip info is anyways not much useful for non-docker container currently.

          Change log level to debug?

          I'd like to keep as info which is useful for debugging. This is only a single line output.

          Show
          jianhe Jian He added a comment - Similarly we should change getIpAndHost and split them up into getIps and getHost calls. Separating this means we need to make two separate calls into container-executor binary and invoke the docker command which is additional cost. I'd like to keep this as a single call. Instead of this, we should just use NetUtils.getLocalHostname() and NetUtils.getIPs This method will return all internal-facing IPs, including loopback ip which will be meaningless to the user. I think we can return the localhost ip for now, as the ip info is anyways not much useful for non-docker container currently. Change log level to debug? I'd like to keep as info which is useful for debugging. This is only a single line output.
          Hide
          jianhe Jian He added a comment -

          Thanks for the review, Varun ! fixed other comments, uploaded a new patch

          Show
          jianhe Jian He added a comment - Thanks for the review, Varun ! fixed other comments, uploaded a new patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 7m 10s trunk passed
          +1 compile 2m 30s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 53s trunk passed
          +1 mvneclipse 0m 52s trunk passed
          +1 findbugs 3m 25s trunk passed
          +1 javadoc 1m 18s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 32s the patch passed
          -1 compile 0m 56s hadoop-yarn in the patch failed.
          -1 cc 0m 56s hadoop-yarn in the patch failed.
          -1 javac 0m 56s hadoop-yarn in the patch failed.
          -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 166 unchanged - 2 fixed = 174 total (was 168)
          +1 mvnsite 1m 42s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 42s the patch passed
          +1 javadoc 1m 12s the patch passed
          +1 unit 0m 24s hadoop-yarn-api in the patch passed.
          -1 unit 2m 19s hadoop-yarn-common in the patch failed.
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed.
          -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          33m 41s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822226/YARN-5430.4.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux c32f7c700547 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 18d9e6e
          Default Java 1.8.0_101
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          cc https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12655/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12655/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 10s trunk passed +1 compile 2m 30s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 53s trunk passed +1 mvneclipse 0m 52s trunk passed +1 findbugs 3m 25s trunk passed +1 javadoc 1m 18s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed -1 compile 0m 56s hadoop-yarn in the patch failed. -1 cc 0m 56s hadoop-yarn in the patch failed. -1 javac 0m 56s hadoop-yarn in the patch failed. -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 166 unchanged - 2 fixed = 174 total (was 168) +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 42s the patch passed +1 javadoc 1m 12s the patch passed +1 unit 0m 24s hadoop-yarn-api in the patch passed. -1 unit 2m 19s hadoop-yarn-common in the patch failed. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed. -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 33m 41s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822226/YARN-5430.4.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c32f7c700547 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 18d9e6e Default Java 1.8.0_101 findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt cc https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12655/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12655/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12655/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s YARN-5430 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822230/YARN-5430.4.patch
          JIRA Issue YARN-5430
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12666/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-5430 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822230/YARN-5430.4.patch JIRA Issue YARN-5430 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12666/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 58s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 2m 26s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 55s trunk passed
          +1 mvneclipse 0m 53s trunk passed
          +1 findbugs 3m 21s trunk passed
          +1 javadoc 1m 20s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          -1 compile 0m 57s hadoop-yarn in the patch failed.
          -1 cc 0m 57s hadoop-yarn in the patch failed.
          -1 javac 0m 57s hadoop-yarn in the patch failed.
          -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 166 unchanged - 2 fixed = 174 total (was 168)
          +1 mvnsite 1m 44s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 42s the patch passed
          +1 javadoc 1m 14s the patch passed
          +1 unit 0m 24s hadoop-yarn-api in the patch passed.
          -1 unit 2m 18s hadoop-yarn-common in the patch failed.
          +1 unit 0m 26s hadoop-yarn-server-common in the patch passed.
          -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          34m 23s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822504/YARN-5430.4.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 16a8dd1f6d96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d3af47
          Default Java 1.8.0_101
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          cc https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12667/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12667/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 58s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 2m 26s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 55s trunk passed +1 mvneclipse 0m 53s trunk passed +1 findbugs 3m 21s trunk passed +1 javadoc 1m 20s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed -1 compile 0m 57s hadoop-yarn in the patch failed. -1 cc 0m 57s hadoop-yarn in the patch failed. -1 javac 0m 57s hadoop-yarn in the patch failed. -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 166 unchanged - 2 fixed = 174 total (was 168) +1 mvnsite 1m 44s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 42s the patch passed +1 javadoc 1m 14s the patch passed +1 unit 0m 24s hadoop-yarn-api in the patch passed. -1 unit 2m 18s hadoop-yarn-common in the patch failed. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed. -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 34m 23s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822504/YARN-5430.4.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 16a8dd1f6d96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d3af47 Default Java 1.8.0_101 findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt cc https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12667/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12667/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12667/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 2m 17s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 45s trunk passed
          +1 mvneclipse 0m 51s trunk passed
          +1 findbugs 3m 10s trunk passed
          +1 javadoc 1m 16s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 2m 15s the patch passed
          +1 cc 2m 15s the patch passed
          +1 javac 2m 15s the patch passed
          -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 166 unchanged - 2 fixed = 174 total (was 168)
          +1 mvnsite 1m 36s the patch passed
          +1 mvneclipse 0m 44s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 32s the patch passed
          +1 javadoc 1m 8s the patch passed
          +1 unit 0m 22s hadoop-yarn-api in the patch passed.
          -1 unit 2m 15s hadoop-yarn-common in the patch failed.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed.
          -1 unit 13m 4s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          45m 57s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat
            hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.TestDockerInspectCommand



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822509/YARN-5430.5.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 618ff66f4513 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d3af47
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12669/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12669/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 2m 17s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 45s trunk passed +1 mvneclipse 0m 51s trunk passed +1 findbugs 3m 10s trunk passed +1 javadoc 1m 16s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 2m 15s the patch passed +1 cc 2m 15s the patch passed +1 javac 2m 15s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 166 unchanged - 2 fixed = 174 total (was 168) +1 mvnsite 1m 36s the patch passed +1 mvneclipse 0m 44s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 32s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 0m 22s hadoop-yarn-api in the patch passed. -1 unit 2m 15s hadoop-yarn-common in the patch failed. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed. -1 unit 13m 4s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 45m 57s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat   hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.TestDockerInspectCommand Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822509/YARN-5430.5.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 618ff66f4513 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d3af47 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/12669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12669/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12669/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the patch Jian He.
          1)
          Can you please address the failing unit test?

          2)

          +  // LinuxContainerExecutor overrides this method and behaves differently.
          +  public String[] getIpAndHost(Container container) {
          +    String[] ipAndHost = new String[2];
          +    try {
          +      InetAddress address = InetAddress.getLocalHost();
          +      ipAndHost[0] = address.getHostAddress();
          +      ipAndHost[1] = address.getHostName();
          +    } catch (UnknownHostException e) {
          +      LOG.error("Unable to get Local hostname and ip for " + container
          +          .getContainerId());
          +    }
          +    return ipAndHost;
          +  }
          

          and

          +
          +  // Return the host and ip of the container
          +  String[] getIpAndHost(Container container);
          

          Can you please a Javadoc about returning a comma separated list of ips as part of the return array? Also it looks like DefaultLinuxContainerRuntime.java has the same code as ContainerExecutor - any chance we can create a common function?

          3)
          Can you please address the checkstyle issues caught by Jenkins?

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the patch Jian He . 1) Can you please address the failing unit test? 2) + // LinuxContainerExecutor overrides this method and behaves differently. + public String [] getIpAndHost(Container container) { + String [] ipAndHost = new String [2]; + try { + InetAddress address = InetAddress.getLocalHost(); + ipAndHost[0] = address.getHostAddress(); + ipAndHost[1] = address.getHostName(); + } catch (UnknownHostException e) { + LOG.error( "Unable to get Local hostname and ip for " + container + .getContainerId()); + } + return ipAndHost; + } and + + // Return the host and ip of the container + String [] getIpAndHost(Container container); Can you please a Javadoc about returning a comma separated list of ips as part of the return array? Also it looks like DefaultLinuxContainerRuntime.java has the same code as ContainerExecutor - any chance we can create a common function? 3) Can you please address the checkstyle issues caught by Jenkins?
          Hide
          jianhe Jian He added a comment -

          Varun, thanks for the review. I uploaded a new one.

          Show
          jianhe Jian He added a comment - Varun, thanks for the review. I uploaded a new one.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 2m 17s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 51s trunk passed
          +1 findbugs 3m 6s trunk passed
          +1 javadoc 1m 15s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 26s the patch passed
          -1 compile 0m 52s hadoop-yarn in the patch failed.
          -1 cc 0m 52s hadoop-yarn in the patch failed.
          -1 javac 0m 52s hadoop-yarn in the patch failed.
          -1 checkstyle 0m 36s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 167 unchanged - 2 fixed = 171 total (was 169)
          +1 mvnsite 1m 35s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 30s the patch passed
          +1 javadoc 1m 4s the patch passed
          +1 unit 0m 21s hadoop-yarn-api in the patch passed.
          -1 unit 2m 14s hadoop-yarn-common in the patch failed.
          +1 unit 0m 24s hadoop-yarn-server-common in the patch passed.
          -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          31m 24s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822964/YARN-5430.6.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux c55ae94cebaf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d00d3ad
          Default Java 1.8.0_101
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          cc https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12717/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12717/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 2m 17s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 51s trunk passed +1 findbugs 3m 6s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 26s the patch passed -1 compile 0m 52s hadoop-yarn in the patch failed. -1 cc 0m 52s hadoop-yarn in the patch failed. -1 javac 0m 52s hadoop-yarn in the patch failed. -1 checkstyle 0m 36s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 167 unchanged - 2 fixed = 171 total (was 169) +1 mvnsite 1m 35s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 30s the patch passed +1 javadoc 1m 4s the patch passed +1 unit 0m 21s hadoop-yarn-api in the patch passed. -1 unit 2m 14s hadoop-yarn-common in the patch failed. +1 unit 0m 24s hadoop-yarn-server-common in the patch passed. -1 unit 0m 18s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 31m 24s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822964/YARN-5430.6.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c55ae94cebaf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d00d3ad Default Java 1.8.0_101 findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt cc https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12717/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12717/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12717/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 6m 39s trunk passed
          +1 compile 2m 17s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 45s trunk passed
          +1 mvneclipse 0m 52s trunk passed
          +1 findbugs 3m 11s trunk passed
          +1 javadoc 1m 17s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 26s the patch passed
          +1 compile 2m 15s the patch passed
          +1 cc 2m 15s the patch passed
          +1 javac 2m 15s the patch passed
          -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 166 unchanged - 2 fixed = 170 total (was 168)
          +1 mvnsite 1m 37s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 34s the patch passed
          +1 javadoc 1m 8s the patch passed
          +1 unit 0m 23s hadoop-yarn-api in the patch passed.
          -1 unit 2m 16s hadoop-yarn-common in the patch failed.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 9s hadoop-yarn-server-nodemanager in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          46m 9s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822980/YARN-5430.7.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 529ec5538890 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d00d3ad
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12720/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12720/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 6m 39s trunk passed +1 compile 2m 17s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 45s trunk passed +1 mvneclipse 0m 52s trunk passed +1 findbugs 3m 11s trunk passed +1 javadoc 1m 17s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 26s the patch passed +1 compile 2m 15s the patch passed +1 cc 2m 15s the patch passed +1 javac 2m 15s the patch passed -1 checkstyle 0m 37s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 166 unchanged - 2 fixed = 170 total (was 168) +1 mvnsite 1m 37s the patch passed +1 mvneclipse 0m 43s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 34s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 0m 23s hadoop-yarn-api in the patch passed. -1 unit 2m 16s hadoop-yarn-common in the patch failed. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed. +1 unit 13m 9s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 46m 9s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822980/YARN-5430.7.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 529ec5538890 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d00d3ad Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12720/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12720/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12720/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          Fixing checkstyles

          Show
          jianhe Jian He added a comment - Fixing checkstyles
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 58s trunk passed
          +1 compile 2m 26s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 3m 34s trunk passed
          +1 javadoc 1m 20s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 29s the patch passed
          +1 compile 2m 18s the patch passed
          +1 cc 2m 18s the patch passed
          +1 javac 2m 18s the patch passed
          -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 166 unchanged - 2 fixed = 167 total (was 168)
          +1 mvnsite 1m 40s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 42s the patch passed
          +1 javadoc 1m 8s the patch passed
          +1 unit 0m 23s hadoop-yarn-api in the patch passed.
          -1 unit 2m 16s hadoop-yarn-common in the patch failed.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 18s hadoop-yarn-server-nodemanager in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          47m 50s



          Reason Tests
          Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823074/YARN-5430.8.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux d9d29fcaf2af 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d00d3ad
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12725/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12725/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12725/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12725/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12725/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 58s trunk passed +1 compile 2m 26s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 3m 34s trunk passed +1 javadoc 1m 20s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 2m 18s the patch passed +1 cc 2m 18s the patch passed +1 javac 2m 18s the patch passed -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 166 unchanged - 2 fixed = 167 total (was 168) +1 mvnsite 1m 40s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 42s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 0m 23s hadoop-yarn-api in the patch passed. -1 unit 2m 16s hadoop-yarn-common in the patch failed. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed. +1 unit 13m 18s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 47m 50s Reason Tests Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogFormat Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823074/YARN-5430.8.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux d9d29fcaf2af 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d00d3ad Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12725/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12725/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12725/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12725/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12725/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          The remaining warnings are not related to this patch.

          Show
          jianhe Jian He added a comment - The remaining warnings are not related to this patch.
          Hide
          vvasudev Varun Vasudev added a comment -

          +1 for the latest patch. I'll commit it tomorrow if no one objects.

          Show
          vvasudev Varun Vasudev added a comment - +1 for the latest patch. I'll commit it tomorrow if no one objects.
          Hide
          billie.rinaldi Billie Rinaldi added a comment -

          +1, the patch looks good to me.

          Show
          billie.rinaldi Billie Rinaldi added a comment - +1, the patch looks good to me.
          Hide
          vvasudev Varun Vasudev added a comment -

          The cherry pick doesn't apply cleanly on branch-2. Jian He - can you please upload a version for branch-2? Thanks!

          Show
          vvasudev Varun Vasudev added a comment - The cherry pick doesn't apply cleanly on branch-2. Jian He - can you please upload a version for branch-2? Thanks!
          Hide
          jianhe Jian He added a comment -

          uploaded branch-2 patch

          Show
          jianhe Jian He added a comment - uploaded branch-2 patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 48s Maven dependency ordering for branch
          +1 mvninstall 7m 16s branch-2 passed
          +1 compile 2m 18s branch-2 passed with JDK v1.8.0_101
          +1 compile 2m 23s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 41s branch-2 passed
          +1 mvnsite 1m 57s branch-2 passed
          +1 mvneclipse 0m 56s branch-2 passed
          +1 findbugs 3m 59s branch-2 passed
          +1 javadoc 1m 14s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 28s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 35s the patch passed
          +1 compile 1m 49s the patch passed with JDK v1.8.0_101
          +1 cc 1m 49s the patch passed
          +1 javac 1m 49s the patch passed
          +1 compile 2m 10s the patch passed with JDK v1.7.0_101
          +1 cc 2m 10s the patch passed
          +1 javac 2m 10s the patch passed
          -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 166 unchanged - 2 fixed = 167 total (was 168)
          +1 mvnsite 1m 49s the patch passed
          +1 mvneclipse 0m 48s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 1m 9s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 33s the patch passed with JDK v1.7.0_101
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
          -1 unit 13m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_101.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 28s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101.
          +1 unit 14m 22s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          76m 2s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824283/YARN-5430-branch-2.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 0ec7a018df4c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 07d5ab1
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12823/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12823/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 7m 16s branch-2 passed +1 compile 2m 18s branch-2 passed with JDK v1.8.0_101 +1 compile 2m 23s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 41s branch-2 passed +1 mvnsite 1m 57s branch-2 passed +1 mvneclipse 0m 56s branch-2 passed +1 findbugs 3m 59s branch-2 passed +1 javadoc 1m 14s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 28s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 1m 49s the patch passed with JDK v1.8.0_101 +1 cc 1m 49s the patch passed +1 javac 1m 49s the patch passed +1 compile 2m 10s the patch passed with JDK v1.7.0_101 +1 cc 2m 10s the patch passed +1 javac 2m 10s the patch passed -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 166 unchanged - 2 fixed = 167 total (was 168) +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 48s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 33s the patch passed with JDK v1.7.0_101 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. -1 unit 13m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_101. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 28s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101. +1 unit 14m 22s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 76m 2s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824283/YARN-5430-branch-2.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 0ec7a018df4c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 07d5ab1 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12823/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12823/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12823/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          billie.rinaldi Billie Rinaldi added a comment -

          I have started trying this out with a patch I am working on for YARN-5505. It looks like the IP is not populated immediately, which is okay; I can retry getting the container status until the IP exists. When the IP doesn’t exist yet, getIPs throws an NPE on ContainerStatusPBImpl line 283. It seems like it would be better for it to return null in this case rather than throwing an exception. Another issue is that it looks like the hostname returned by getHost has a newline at the end. Perhaps this should be trimmed off in DockerLinuxContainerRuntime.getIpAndHost.

          Show
          billie.rinaldi Billie Rinaldi added a comment - I have started trying this out with a patch I am working on for YARN-5505 . It looks like the IP is not populated immediately, which is okay; I can retry getting the container status until the IP exists. When the IP doesn’t exist yet, getIPs throws an NPE on ContainerStatusPBImpl line 283. It seems like it would be better for it to return null in this case rather than throwing an exception. Another issue is that it looks like the hostname returned by getHost has a newline at the end. Perhaps this should be trimmed off in DockerLinuxContainerRuntime.getIpAndHost.
          Hide
          jianhe Jian He added a comment -

          Thanks Billie, I've fixed the issues in the latest patch.

          Show
          jianhe Jian He added a comment - Thanks Billie, I've fixed the issues in the latest patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 6m 51s branch-2 passed
          +1 compile 1m 51s branch-2 passed with JDK v1.8.0_101
          +1 compile 2m 13s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 41s branch-2 passed
          +1 mvnsite 1m 54s branch-2 passed
          +1 mvneclipse 0m 55s branch-2 passed
          +1 findbugs 3m 59s branch-2 passed
          +1 javadoc 1m 15s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 27s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 35s the patch passed
          +1 compile 1m 48s the patch passed with JDK v1.8.0_101
          +1 cc 1m 48s the patch passed
          +1 javac 1m 48s the patch passed
          +1 compile 2m 11s the patch passed with JDK v1.7.0_101
          +1 cc 2m 11s the patch passed
          +1 javac 2m 11s the patch passed
          -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 166 unchanged - 2 fixed = 168 total (was 168)
          +1 mvnsite 1m 47s the patch passed
          +1 mvneclipse 0m 47s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 41s the patch passed
          -1 javadoc 0m 14s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101 with JDK v1.8.0_101 generated 2 new + 240 unchanged - 0 fixed = 242 total (was 240)
          +1 javadoc 1m 21s the patch passed with JDK v1.7.0_101
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101.
          +1 unit 13m 13s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 32s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101.
          +1 unit 14m 10s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          73m 53s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825230/YARN-5430.9.branch-2.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 63da116dfa1d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 2321b73
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12874/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12874/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12874/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12874/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 6m 51s branch-2 passed +1 compile 1m 51s branch-2 passed with JDK v1.8.0_101 +1 compile 2m 13s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 41s branch-2 passed +1 mvnsite 1m 54s branch-2 passed +1 mvneclipse 0m 55s branch-2 passed +1 findbugs 3m 59s branch-2 passed +1 javadoc 1m 15s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 27s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 1m 48s the patch passed with JDK v1.8.0_101 +1 cc 1m 48s the patch passed +1 javac 1m 48s the patch passed +1 compile 2m 11s the patch passed with JDK v1.7.0_101 +1 cc 2m 11s the patch passed +1 javac 2m 11s the patch passed -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 166 unchanged - 2 fixed = 168 total (was 168) +1 mvnsite 1m 47s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 41s the patch passed -1 javadoc 0m 14s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101 with JDK v1.8.0_101 generated 2 new + 240 unchanged - 0 fixed = 242 total (was 240) +1 javadoc 1m 21s the patch passed with JDK v1.7.0_101 +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_101. +1 unit 13m 13s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_101. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 32s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101. +1 unit 14m 10s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 73m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825230/YARN-5430.9.branch-2.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 63da116dfa1d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2321b73 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12874/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12874/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12874/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12874/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 7m 6s trunk passed
          +1 compile 2m 28s trunk passed
          +1 checkstyle 0m 40s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 51s trunk passed
          +1 findbugs 3m 17s trunk passed
          +1 javadoc 1m 17s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 31s the patch passed
          +1 compile 2m 17s the patch passed
          +1 cc 2m 17s the patch passed
          +1 javac 2m 17s the patch passed
          -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 165 unchanged - 2 fixed = 167 total (was 167)
          +1 mvnsite 1m 39s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 32s the patch passed
          -1 javadoc 0m 15s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 2 new + 240 unchanged - 0 fixed = 242 total (was 240)
          +1 unit 0m 23s hadoop-yarn-api in the patch passed.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 15s hadoop-yarn-server-nodemanager in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          47m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825262/YARN-5430.9.patch
          JIRA Issue YARN-5430
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux a7c19b9f178a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 092b4d5
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12875/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12875/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12875/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12875/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 7m 6s trunk passed +1 compile 2m 28s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 51s trunk passed +1 findbugs 3m 17s trunk passed +1 javadoc 1m 17s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 2m 17s the patch passed +1 cc 2m 17s the patch passed +1 javac 2m 17s the patch passed -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 165 unchanged - 2 fixed = 167 total (was 167) +1 mvnsite 1m 39s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 32s the patch passed -1 javadoc 0m 15s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 2 new + 240 unchanged - 0 fixed = 242 total (was 240) +1 unit 0m 23s hadoop-yarn-api in the patch passed. +1 unit 2m 16s hadoop-yarn-common in the patch passed. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed. +1 unit 13m 15s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 47m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825262/YARN-5430.9.patch JIRA Issue YARN-5430 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux a7c19b9f178a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 092b4d5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12875/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12875/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12875/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12875/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the latest patch Jian He. Looks good to me. Billie Rinaldi - can you confirm that the latest patch fixes the issue for you?

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the latest patch Jian He . Looks good to me. Billie Rinaldi - can you confirm that the latest patch fixes the issue for you?
          Hide
          vvasudev Varun Vasudev added a comment -

          +1 for the latest patch. I'll commit it unless someone objects.

          Show
          vvasudev Varun Vasudev added a comment - +1 for the latest patch. I'll commit it unless someone objects.
          Hide
          billie.rinaldi Billie Rinaldi added a comment -

          +1, this fixes the issues I was seeing.

          Show
          billie.rinaldi Billie Rinaldi added a comment - +1, this fixes the issues I was seeing.
          Hide
          vvasudev Varun Vasudev added a comment -

          Committed to trunk and branch-2. Thanks Jian He for the patch and Billie Rinaldi for the review help!

          Show
          vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks Jian He for the patch and Billie Rinaldi for the review help!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10352 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10352/)
          YARN-5430. Return container's ip and host from NM ContainerStatus call. (vvasudev: rev bfb4d950596d6198e473045dac6eb36c685b0319)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/runtime/ContainerRuntime.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/Container.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/PrivilegedOperationExecutor.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DefaultLinuxContainerRuntime.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DelegatingLinuxContainerRuntime.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/api/protocolrecords/TestProtocolRecords.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerInspectCommand.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerInspectCommand.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/MockContainer.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerStatus.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerStatusPBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10352 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10352/ ) YARN-5430 . Return container's ip and host from NM ContainerStatus call. (vvasudev: rev bfb4d950596d6198e473045dac6eb36c685b0319) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/runtime/ContainerRuntime.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/Container.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/PrivilegedOperationExecutor.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DefaultLinuxContainerRuntime.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DelegatingLinuxContainerRuntime.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/api/protocolrecords/TestProtocolRecords.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerInspectCommand.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerInspectCommand.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/MockContainer.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerStatus.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerStatusPBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
          Hide
          gsaha Gour Saha added a comment -

          Jian He can this return the docker image name used to create a container?

          Show
          gsaha Gour Saha added a comment - Jian He can this return the docker image name used to create a container?

            People

            • Assignee:
              jianhe Jian He
              Reporter:
              jianhe Jian He
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development