Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4837

User facing aspects of 'AM blacklisting' feature need fixing

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Was reviewing the user-facing aspects that we are releasing as part of 2.8.0.

      Looking at the 'AM blacklisting feature', I see several things to be fixed before we release it in 2.8.0.

      1. YARN-4837-20160515.txt
        102 kB
        Vinod Kumar Vavilapalli
      2. YARN-4837-20160520.1.txt
        122 kB
        Vinod Kumar Vavilapalli
      3. YARN-4837-20160520.txt
        120 kB
        Vinod Kumar Vavilapalli
      4. YARN-4837-20160527.txt
        119 kB
        Vinod Kumar Vavilapalli
      5. YARN-4837-20160604.txt
        121 kB
        Vinod Kumar Vavilapalli
      6. YARN-4837-branch-2.005.patch
        122 kB
        Wangda Tan
      7. YARN-4837-branch-2.8.1.txt
        115 kB
        Vinod Kumar Vavilapalli
      8. YARN-4837-branch-2.8.txt
        115 kB
        Vinod Kumar Vavilapalli

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Here are my concerns

          • First up the feature isn't 'AM blacklisting' - we are not blacklisting AMs. The goal is for the system to not schedule AMs on faulty nodes. The right solution is to identify why we keep launching on bad-nodes instead of marking them unhealthy - but I can see why a blacklist threshold is useful when we simply don't know.
          • The configurations are all named yarn.am.blacklisting even though they should be under a yarn.resourcemanager hierarchy
          • We just blindly add a node to the app's blacklist even if we just hit one AM failure. And the error / exit-code doesn't matter at all.
          • Irrespective of all that, I actually don't see why we should already expose this to end-users i.e the whole premise of YARN-4389. Why should an app specifically care "the number of nodes YARN blacklists for my AM container launch"?

          I'm digging into the feature more for a careful look.

          /cc

          While we discuss this, I think we should take the private feature before 2.8.0 goes out.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Here are my concerns First up the feature isn't 'AM blacklisting' - we are not blacklisting AMs. The goal is for the system to not schedule AMs on faulty nodes. The right solution is to identify why we keep launching on bad-nodes instead of marking them unhealthy - but I can see why a blacklist threshold is useful when we simply don't know . The configurations are all named yarn.am.blacklisting even though they should be under a yarn.resourcemanager hierarchy We just blindly add a node to the app's blacklist even if we just hit one AM failure. And the error / exit-code doesn't matter at all. Irrespective of all that, I actually don't see why we should already expose this to end-users i.e the whole premise of YARN-4389 . Why should an app specifically care "the number of nodes YARN blacklists for my AM container launch"? I'm digging into the feature more for a careful look. /cc Anubhav Dhoot , Jason Lowe , Karthik Kambatla who were involved with YARN-2005 for the naming changes Sunil G / Junping Du who worked on YARN-4389 . While we discuss this, I think we should take the private feature before 2.8.0 goes out.
          Hide
          djp Junping Du added a comment -

          Thanks for calling it out, Vinod Kumar Vavilapalli! I also feel uncomfortable on existing AM blacklisting mechanism (agree that name is a bit confusing ).
          Put some thoughts (and design) on YARN-4576 before. May be we should check how to consolidate these JIRAs?

          Show
          djp Junping Du added a comment - Thanks for calling it out, Vinod Kumar Vavilapalli ! I also feel uncomfortable on existing AM blacklisting mechanism (agree that name is a bit confusing ). Put some thoughts (and design) on YARN-4576 before. May be we should check how to consolidate these JIRAs?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Adding to discussion about AM blacklisting, there are few corner cases where application can get hanged forever. Especially after blacklisting some nodes, if other nodes removed from the cluster. In such cases, there is no mechanism such that to remove blacklisted nodes for AM. See YARN-4685 for one of the scenario.

          Show
          rohithsharma Rohith Sharma K S added a comment - Adding to discussion about AM blacklisting, there are few corner cases where application can get hanged forever. Especially after blacklisting some nodes, if other nodes removed from the cluster. In such cases, there is no mechanism such that to remove blacklisted nodes for AM. See YARN-4685 for one of the scenario.
          Hide
          sunilg Sunil G added a comment -

          Thanks Vinod Kumar Vavilapalli for pitching in.

          YARN-2005 blacklists nodes if AM container launch failed due to DISK_FAILED. And after YARN-4284, blacklisting for am-container-failure is made for all container failure except PREEMPTED. There were few discussion on usecase aspects for this change.

          If blacklisting (am container failure) feature is enabled in cluster level, all applications will be forced to comply the blacklisting rule. YARN-4389 had also an option to disable this feature from application end. Also it could control the threshold if its too strict (and vice versa). Yes, agreeing to your point and its early for user to take blacklisting decisions w/o having much needed/useful information. But by seeing the current aggressive nature, this change was helping in skipping this feature.

          Agreeing that this has to be a controllable feature without causing problems in a busy cluster. I think may be a time based purging solution can be ideal to allow same app to use the node again.

          Show
          sunilg Sunil G added a comment - Thanks Vinod Kumar Vavilapalli for pitching in. YARN-2005 blacklists nodes if AM container launch failed due to DISK_FAILED. And after YARN-4284 , blacklisting for am-container-failure is made for all container failure except PREEMPTED. There were few discussion on usecase aspects for this change. If blacklisting (am container failure) feature is enabled in cluster level, all applications will be forced to comply the blacklisting rule. YARN-4389 had also an option to disable this feature from application end. Also it could control the threshold if its too strict (and vice versa). Yes, agreeing to your point and its early for user to take blacklisting decisions w/o having much needed/useful information. But by seeing the current aggressive nature, this change was helping in skipping this feature. Agreeing that this has to be a controllable feature without causing problems in a busy cluster. I think may be a time based purging solution can be ideal to allow same app to use the node again.
          Hide
          sjlee0 Sangjin Lee added a comment -

          I just wanted to add my 2 cents to the discussion, specifically about YARN-4284 where we broadened the cause for blacklisting a node for an AM purpose.

          AMs repeatedly getting assigned to the same node in spite of failures is one of the most frequent complaints from our users ("why did our AMs keep landing on that bad node, causing our jobs to fail?"). If a node is having a "soft" failure that doesn't quite trip itself over to an unhealthy state, that's the worst possible case. Since the node is still healthy and appears to have a lot of available capacity, the chance that it still gets the next attempt is quite high; i.e. we have node-affinity. And since this is AM, the consequence is much more severe than when a container landed on that node.

          Oftentimes, the cause for this soft failure situation is varied, and trying to come up with a precise set of exit codes that meet this criteria isn't straightforward. There are even error codes like INVALID which we see quite often (see my previous comment). I know it could blacklist the node for the app for reasons such as the app's configuration error (false positives). However, the reason we could afford to go broad is this blacklisting is per-app. The only downside there is to get assigned to another node.

          We have a number of large busy clusters, and we're using this with success and with little downside.

          That said, I do recognize that this could be a problem if yarn.resourcemanager.am.max-attempts is larger than the size of the cluster.

          Show
          sjlee0 Sangjin Lee added a comment - I just wanted to add my 2 cents to the discussion, specifically about YARN-4284 where we broadened the cause for blacklisting a node for an AM purpose. AMs repeatedly getting assigned to the same node in spite of failures is one of the most frequent complaints from our users ("why did our AMs keep landing on that bad node, causing our jobs to fail?"). If a node is having a "soft" failure that doesn't quite trip itself over to an unhealthy state, that's the worst possible case. Since the node is still healthy and appears to have a lot of available capacity, the chance that it still gets the next attempt is quite high; i.e. we have node-affinity. And since this is AM, the consequence is much more severe than when a container landed on that node. Oftentimes, the cause for this soft failure situation is varied, and trying to come up with a precise set of exit codes that meet this criteria isn't straightforward. There are even error codes like INVALID which we see quite often (see my previous comment ). I know it could blacklist the node for the app for reasons such as the app's configuration error (false positives). However, the reason we could afford to go broad is this blacklisting is per-app . The only downside there is to get assigned to another node. We have a number of large busy clusters, and we're using this with success and with little downside. That said, I do recognize that this could be a problem if yarn.resourcemanager.am.max-attempts is larger than the size of the cluster.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Sunil G and Sangjin Lee,

          Appreciate your feedback.

          • Yes, AMs going to 'bad' nodes again and again and failing is a real problem. There are multiple reasons as to why this happens.
            • It is true we cannot enumerate all the reasons.
            • It is also true that we have some reasons that we can already deal with explicitly.
          • The primary reason for this JIRA is that I actually don't believe that users need explicit control today on how the AM scheduling on faults (i.e Sunil G's agreement above - "agreeing to your point and its early for user to take blacklisting decisions w/o having much needed/useful information")
          • Like I also mentioned, it is misnamed too. So, let me just call it AM-container-scheduling for the time being.

          Modified proposal

          So how about we

          • Completely keep AM-container-scheduling inside the ResourceManager and don't expose any user-APIs to skip-nodes
          • Explicitly treat known exit-codes:
            DISKS_FAILED node is already unhealthy, no need for any skipping nodes
            PREEMPTED, KILLED_BY_RESOURCEMANAGER, KILLED_AFTER_APP_COMPLETION Not the app or the system's fault, it's by design, no need for skipping nodes
            KILLED_EXCEEDED_VMEM, KILLED_EXCEEDED_PMEM No point in skipping the node as it's not the system's fault
            KILLED_BY_APPMASTER Cannot happen for AM container
            All other non-zero codes Need some action
          • And book-keep all other failure cases and do soft-skipping only on the server-side. By this I refer to something similar to node->rack locality progression - avoid this node for a few scheduling opportunities and then come back to it after waiting out enough time. This way no node gets locked out, nor does any app get stuck.

          If we just do this, we will take care of our most important problem - apps getting affected due to AMs going repeatedly to the same places. And we also (a) won't force our users to already make these decisions without really understanding how and (b) won't introduce the bad problems of 'blacklisting' that exists today - for e.g YARN-4685.

          2.8.0

          Even if we don't yet reach the consensus on the above or a similar proposal, I feel strongly that we should remove these user-facing configs / APIs from 2.8.0.

          Thoughts?

          /cc Varun Vasudev, Jian He, Tan, Wangda who may not be looking at this.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Sunil G and Sangjin Lee , Appreciate your feedback. Yes, AMs going to 'bad' nodes again and again and failing is a real problem. There are multiple reasons as to why this happens. It is true we cannot enumerate all the reasons. It is also true that we have some reasons that we can already deal with explicitly. The primary reason for this JIRA is that I actually don't believe that users need explicit control today on how the AM scheduling on faults (i.e Sunil G 's agreement above - "agreeing to your point and its early for user to take blacklisting decisions w/o having much needed/useful information") Like I also mentioned, it is misnamed too. So, let me just call it AM-container-scheduling for the time being. Modified proposal So how about we Completely keep AM-container-scheduling inside the ResourceManager and don't expose any user-APIs to skip-nodes Explicitly treat known exit-codes: DISKS_FAILED node is already unhealthy, no need for any skipping nodes PREEMPTED, KILLED_BY_RESOURCEMANAGER, KILLED_AFTER_APP_COMPLETION Not the app or the system's fault, it's by design, no need for skipping nodes KILLED_EXCEEDED_VMEM, KILLED_EXCEEDED_PMEM No point in skipping the node as it's not the system's fault KILLED_BY_APPMASTER Cannot happen for AM container All other non-zero codes Need some action And book-keep all other failure cases and do soft-skipping only on the server-side. By this I refer to something similar to node->rack locality progression - avoid this node for a few scheduling opportunities and then come back to it after waiting out enough time. This way no node gets locked out, nor does any app get stuck. If we just do this, we will take care of our most important problem - apps getting affected due to AMs going repeatedly to the same places. And we also (a) won't force our users to already make these decisions without really understanding how and (b) won't introduce the bad problems of 'blacklisting' that exists today - for e.g YARN-4685 . 2.8.0 Even if we don't yet reach the consensus on the above or a similar proposal, I feel strongly that we should remove these user-facing configs / APIs from 2.8.0. Thoughts? /cc Varun Vasudev , Jian He , Tan, Wangda who may not be looking at this.
          Hide
          kasha Karthik Kambatla added a comment -

          I am in favor of making these changes if it improves usability by making all this handling transparent.

          Show
          kasha Karthik Kambatla added a comment - I am in favor of making these changes if it improves usability by making all this handling transparent.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Yes, Vinod Kumar Vavilapalli, I agree with the direction you laid out.

          Show
          sjlee0 Sangjin Lee added a comment - Yes, Vinod Kumar Vavilapalli , I agree with the direction you laid out.
          Hide
          djp Junping Du added a comment -

          Hi Vinod Kumar Vavilapalli, did you see my comments at YARN-4576 (https://issues.apache.org/jira/browse/YARN-4576?focusedCommentId=15201559&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15201559)?
          +1 on "explicitly treat known exit-codes" which is exactly the same as previous proposal in YARN-4576. However, the different is:
          "DISKS_FAILED" shouldn't be skipped for the reason I mentioned in YARN-4576. Also, we cannot simply judge system innocent when hitting memory issues.
          Also, hide all AM scheduling info/preference from application doesn't make sense in long time: AM can ask for resources for its running containers in the beginning, but application cannot ask how to place its AM even today which is sad to me.
          YARN-4685 is something fixable and much better than the age without blacklist (we do see AM keep launching on bad nodes repeatedly and get stuck in many cases). We just need to go ahead to fix YARN-4685.

          Show
          djp Junping Du added a comment - Hi Vinod Kumar Vavilapalli , did you see my comments at YARN-4576 ( https://issues.apache.org/jira/browse/YARN-4576?focusedCommentId=15201559&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15201559)? +1 on "explicitly treat known exit-codes" which is exactly the same as previous proposal in YARN-4576 . However, the different is: "DISKS_FAILED" shouldn't be skipped for the reason I mentioned in YARN-4576 . Also, we cannot simply judge system innocent when hitting memory issues. Also, hide all AM scheduling info/preference from application doesn't make sense in long time: AM can ask for resources for its running containers in the beginning, but application cannot ask how to place its AM even today which is sad to me. YARN-4685 is something fixable and much better than the age without blacklist (we do see AM keep launching on bad nodes repeatedly and get stuck in many cases). We just need to go ahead to fix YARN-4685 .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          "DISKS_FAILED" shouldn't be skipped for the reason I mentioned in YARN-4576. Also, we cannot simply judge system innocent when hitting memory issues.

          As Varun Vasudev pointed out here on YARN-4576, the right solution is to have the RM detect bouncing nodes and then not to allocate new containers to bouncing nodes until they stabilize.

          Also, hide all AM scheduling info/preference from application doesn't make sense in long time: AM can ask for resources for its running containers in the beginning, but application cannot ask how to place its AM even today which is sad to me.

          My earlier comment came out a little inaccurate when I said about "hiding AM-container-scheduling inside the RM". What I really meant is that any automatic scheduling decision coming out of system failures/events should be hidden from end-users - just like preemption-handling! We already have ResourceRequest as part of AM-launch-context. No reason why we cannot have more such things. However, this is different from RM automatically ruling out nodes as was done at YARN-2005 and related JIRAs.

          YARN-4685 is something fixable and much better than the age without blacklist (we do see AM keep launching on bad nodes repeatedly and get stuck in many cases). We just need to go ahead to fix YARN-4685.

          YARN-4685 happened because of an inappropriate solution to a real problem - we should pause going down this route till we figure out the right solution.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - "DISKS_FAILED" shouldn't be skipped for the reason I mentioned in YARN-4576 . Also, we cannot simply judge system innocent when hitting memory issues. As Varun Vasudev pointed out here on YARN-4576 , the right solution is to have the RM detect bouncing nodes and then not to allocate new containers to bouncing nodes until they stabilize. Also, hide all AM scheduling info/preference from application doesn't make sense in long time: AM can ask for resources for its running containers in the beginning, but application cannot ask how to place its AM even today which is sad to me. My earlier comment came out a little inaccurate when I said about "hiding AM-container-scheduling inside the RM". What I really meant is that any automatic scheduling decision coming out of system failures/events should be hidden from end-users - just like preemption-handling! We already have ResourceRequest as part of AM-launch-context. No reason why we cannot have more such things. However, this is different from RM automatically ruling out nodes as was done at YARN-2005 and related JIRAs. YARN-4685 is something fixable and much better than the age without blacklist (we do see AM keep launching on bad nodes repeatedly and get stuck in many cases). We just need to go ahead to fix YARN-4685 . YARN-4685 happened because of an inappropriate solution to a real problem - we should pause going down this route till we figure out the right solution.
          Hide
          jianhe Jian He added a comment -

          so, I think we should mark the public APIs to be private/unstable till we get the solution. thoughts ?

          Show
          jianhe Jian He added a comment - so, I think we should mark the public APIs to be private/unstable till we get the solution. thoughts ?
          Hide
          djp Junping Du added a comment -

          Sounds good to me. We can mark it to be private first.

          Show
          djp Junping Du added a comment - Sounds good to me. We can mark it to be private first.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          This must go into 2.8.0, marking so..

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - This must go into 2.8.0, marking so..
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Here's a (longish) patch that addresses some of my proposal above

          • This still doesn't solve the other bugs like YARN-4685 that can happen with the blacklisting logic. There are a bunch of UI bugs too (callers of BlacklistManager.getBlacklistUpdates() only look at the additions), sigh.
          • Renamed the configuration names, but marked all the new configurations private till we figure the rest of the story with the bugs.
          • Removed the user facing APIs and related classes: AMBlackListingRequest, AMBlackListingRequestPBImpl.java, BlacklistUpdates.java (instead using ResourceBlacklistRequest directly), AMBlackListingRequestInfo.java
          • Removed the references to above from ApplicationSubmissionContext, yarn_protos.proto, ApplicationSubmissionContextPBImpl.java, RMAppImpl.java, ApplicationSubmissionContextInfo.java
          • The above two essentially revert YARN-4389.
          • Changed RMAppAttemptImpl to explicitly encode container exit-statuses in deciding when to blacklist nodes
          • Made a bunch of internal renames to better reflect what they are doing.
          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Here's a (longish) patch that addresses some of my proposal above This still doesn't solve the other bugs like YARN-4685 that can happen with the blacklisting logic. There are a bunch of UI bugs too (callers of BlacklistManager.getBlacklistUpdates() only look at the additions), sigh. Renamed the configuration names, but marked all the new configurations private till we figure the rest of the story with the bugs. Removed the user facing APIs and related classes: AMBlackListingRequest, AMBlackListingRequestPBImpl.java, BlacklistUpdates.java (instead using ResourceBlacklistRequest directly), AMBlackListingRequestInfo.java Removed the references to above from ApplicationSubmissionContext, yarn_protos.proto, ApplicationSubmissionContextPBImpl.java, RMAppImpl.java, ApplicationSubmissionContextInfo.java The above two essentially revert YARN-4389 . Changed RMAppAttemptImpl to explicitly encode container exit-statuses in deciding when to blacklist nodes Made a bunch of internal renames to better reflect what they are doing.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
          0 mvndep 0m 58s Maven dependency ordering for branch
          +1 mvninstall 6m 46s trunk passed
          +1 compile 2m 12s trunk passed with JDK v1.8.0_91
          +1 compile 2m 19s trunk passed with JDK v1.7.0_101
          +1 checkstyle 0m 57s trunk passed
          +1 mvnsite 1m 32s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 35s trunk passed with JDK v1.8.0_91
          +1 javadoc 3m 58s trunk passed with JDK v1.7.0_101
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 1m 53s the patch passed with JDK v1.8.0_91
          +1 cc 1m 53s the patch passed
          +1 javac 1m 53s the patch passed
          +1 compile 2m 7s the patch passed with JDK v1.7.0_101
          +1 cc 2m 7s the patch passed
          +1 javac 2m 7s the patch passed
          -1 checkstyle 0m 55s hadoop-yarn-project/hadoop-yarn: patch generated 23 new + 1488 unchanged - 17 fixed = 1511 total (was 1505)
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 5s the patch passed
          +1 javadoc 2m 57s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_91 with JDK v1.8.0_91 generated 0 new + 5385 unchanged - 21 fixed = 5385 total (was 5406)
          +1 javadoc 0m 37s hadoop-yarn-api in the patch passed with JDK v1.8.0_91.
          +1 javadoc 0m 26s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_91.
          +1 javadoc 3m 56s the patch passed with JDK v1.7.0_101
          -1 unit 0m 20s hadoop-yarn-api in the patch failed with JDK v1.8.0_91.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          -1 unit 34m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_91.
          -1 unit 0m 23s hadoop-yarn-api in the patch failed with JDK v1.7.0_101.
          +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          -1 unit 35m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          119m 23s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields
            hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804088/YARN-4837-20160515.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 41166206924e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7be53b6
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11474/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11474/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. 0 mvndep 0m 58s Maven dependency ordering for branch +1 mvninstall 6m 46s trunk passed +1 compile 2m 12s trunk passed with JDK v1.8.0_91 +1 compile 2m 19s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 57s trunk passed +1 mvnsite 1m 32s trunk passed +1 mvneclipse 0m 38s trunk passed -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 35s trunk passed with JDK v1.8.0_91 +1 javadoc 3m 58s trunk passed with JDK v1.7.0_101 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 53s the patch passed with JDK v1.8.0_91 +1 cc 1m 53s the patch passed +1 javac 1m 53s the patch passed +1 compile 2m 7s the patch passed with JDK v1.7.0_101 +1 cc 2m 7s the patch passed +1 javac 2m 7s the patch passed -1 checkstyle 0m 55s hadoop-yarn-project/hadoop-yarn: patch generated 23 new + 1488 unchanged - 17 fixed = 1511 total (was 1505) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 37s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 5s the patch passed +1 javadoc 2m 57s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_91 with JDK v1.8.0_91 generated 0 new + 5385 unchanged - 21 fixed = 5385 total (was 5406) +1 javadoc 0m 37s hadoop-yarn-api in the patch passed with JDK v1.8.0_91. +1 javadoc 0m 26s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch passed with JDK v1.8.0_91. +1 javadoc 3m 56s the patch passed with JDK v1.7.0_101 -1 unit 0m 20s hadoop-yarn-api in the patch failed with JDK v1.8.0_91. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. -1 unit 34m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_91. -1 unit 0m 23s hadoop-yarn-api in the patch failed with JDK v1.7.0_101. +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. -1 unit 35m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 119m 23s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_101 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields   hadoop.yarn.server.resourcemanager.TestContainerResourceUsage   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804088/YARN-4837-20160515.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 41166206924e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7be53b6 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/11474/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11474/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/11474/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks Vinod Kumar Vavilapalli for working on the patch!!. Overall approach reasonable to me, and going through patch more on depth.
          One suggestion is can default value for threshold reduce to less than 50%? May be reasonable value is 20% or 10% so that probability of occurring issues like YARN-4685 can be reduced.

          public static final float DEFAULT_AM_SCHEDULING_NODE_BLACKLISTING_DISABLE_THRESHOLD =
          0.8f;
          
          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks Vinod Kumar Vavilapalli for working on the patch!!. Overall approach reasonable to me, and going through patch more on depth. One suggestion is can default value for threshold reduce to less than 50%? May be reasonable value is 20% or 10% so that probability of occurring issues like YARN-4685 can be reduced. public static final float DEFAULT_AM_SCHEDULING_NODE_BLACKLISTING_DISABLE_THRESHOLD = 0.8f;
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          After going through patch, apart from below nit, rest of all looks fine to me.
          1. In AppSchedulingInfo#updateBlacklistedPlaces if-block can be written as changed = blacklist.removeAll(blacklistRemovals)
          2. I am little bit confused with naming convention for blacklist with placesBlacklist. Can it be changed? And is there any plan to support blacklist racks in the future? Just thought from the comment in AppSchedulingInfo from the patch

           // Set of places (nodes / racks) blacklisted by the system. Today, this only
          79	  // has places blacklisted for AM containers.
          80	  private final Set<String> placesBlacklistedBySystem = new HashSet<>();
          81	  private Set<String> placesBlacklistedByApp = new HashSet<>();
          
          Show
          rohithsharma Rohith Sharma K S added a comment - After going through patch, apart from below nit, rest of all looks fine to me. 1. In AppSchedulingInfo#updateBlacklistedPlaces if-block can be written as changed = blacklist.removeAll(blacklistRemovals) 2. I am little bit confused with naming convention for blacklist with placesBlacklist . Can it be changed? And is there any plan to support blacklist racks in the future? Just thought from the comment in AppSchedulingInfo from the patch // Set of places (nodes / racks) blacklisted by the system. Today, this only 79 // has places blacklisted for AM containers. 80 private final Set< String > placesBlacklistedBySystem = new HashSet<>(); 81 private Set< String > placesBlacklistedByApp = new HashSet<>();
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Vinod Kumar Vavilapalli, patch generally looks good to me, minor comments:

          1) Should we disable am-blacklisting by default?
          2) Javadocs and method name is not matched:

            /**
             * RM is updating blacklist for AM containers.
             * @param blacklistAdditions resources to be added to the amBlacklist
             * @param blacklistRemovals resources to be added to the amBlacklist
             */
            public void updatePlacesBlacklistedBySystem(
          

          One is updating for AM containers and the other one is update by system.

          3) Similarily, it's better to add a simple explanation why updatePlacesBlackedBySystem is called when isWaitingForAMContainer == true.

            public synchronized void updateBlacklist(List<String> blacklistAdditions,
                List<String> blacklistRemovals) {
              if (!isStopped) {
                if (isWaitingForAMContainer()) {
                  // The request is for the AM-container, so update the corresponding
                  // blacklists
                  this.appSchedulingInfo.updatePlacesBlacklistedBySystem(
          

          4) RMAppAttemptBlock.java:

                ._("Nodes skipped for AM launches:", rmBlackListedNodes);
          
          

          Update it to be: "Nodes blacklisted by system?

          5) Similiarily, AppAttemptInfo.java
          nodesSkippedForAMLaunches -> nodesBlacklistedBySystem?

          6) ResourceBlacklistRequest -> (Resource)Place(ment)BlacklistRequest?

          7) It's better to add a test for shouldCountTowardsNodeBlacklisting changes – it's important to make sure no regression happens to the behavior.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Vinod Kumar Vavilapalli , patch generally looks good to me, minor comments: 1) Should we disable am-blacklisting by default? 2) Javadocs and method name is not matched: /** * RM is updating blacklist for AM containers. * @param blacklistAdditions resources to be added to the amBlacklist * @param blacklistRemovals resources to be added to the amBlacklist */ public void updatePlacesBlacklistedBySystem( One is updating for AM containers and the other one is update by system. 3) Similarily, it's better to add a simple explanation why updatePlacesBlackedBySystem is called when isWaitingForAMContainer == true. public synchronized void updateBlacklist(List< String > blacklistAdditions, List< String > blacklistRemovals) { if (!isStopped) { if (isWaitingForAMContainer()) { // The request is for the AM-container, so update the corresponding // blacklists this .appSchedulingInfo.updatePlacesBlacklistedBySystem( 4) RMAppAttemptBlock.java: ._( "Nodes skipped for AM launches:" , rmBlackListedNodes); Update it to be: "Nodes blacklisted by system? 5) Similiarily, AppAttemptInfo.java nodesSkippedForAMLaunches -> nodesBlacklistedBySystem? 6) ResourceBlacklistRequest -> (Resource)Place(ment)BlacklistRequest? 7) It's better to add a test for shouldCountTowardsNodeBlacklisting changes – it's important to make sure no regression happens to the behavior.
          Hide
          sunilg Sunil G added a comment -

          HI Vinod Kumar Vavilapalli
          One minor nit:
          1. yarn.resourcemanager.am-scheduling.node-blacklisting-enabled and yarn.resourcemanager.am-scheduling.node-blacklisting-disable-threshold to be added in yarn-default.xml.

          Show
          sunilg Sunil G added a comment - HI Vinod Kumar Vavilapalli One minor nit: 1. yarn.resourcemanager.am-scheduling.node-blacklisting-enabled and yarn.resourcemanager.am-scheduling.node-blacklisting-disable-threshold to be added in yarn-default.xml .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Here's an updated patch with fixes and new test.

          Rohith Sharma K S

          One suggestion is can default value for threshold reduce to less than 50%?

          1) Should we disable am-blacklisting by default?

          I would like to tackle both of these as part of YARN-4685 so that others also can see.

          2. I am little bit confused with naming convention for blacklist with placesBlacklist. And is there any plan to support blacklist racks in the future?

          Yes, that's the idea. In other parts of the code, this list gets passed along to filter both nodes and racks.

          Wangda Tan
          Regarding renames, I've included the ones you pointed out. There are lot more to be done, but I deliberately avoided them given the current size of the patch.

          Addressed other comments.

          6) ResourceBlacklistRequest -> (Resource)Place(ment)BlacklistRequest?

          This is public API, cannot rename it now.

          Created a new TestNodeBlacklistingOnAMFailures, moved existing tests from TestAMRestart to this new class file. testAMBlacklistPreventsRestartOnSameNodeForMinicluster() is a bogus test, removed it.

          Sunil G

          1. yarn.resourcemanager.am-scheduling.node-blacklisting-enabled and yarn.resourcemanager.am-scheduling.node-blacklisting-disable-threshold to be added in yarn-default.xml.

          Again, I deliberately deleted them for now. I'd like to discuss their re-addition as part of the outcome for YARN-4685.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Here's an updated patch with fixes and new test. Rohith Sharma K S One suggestion is can default value for threshold reduce to less than 50%? 1) Should we disable am-blacklisting by default? I would like to tackle both of these as part of YARN-4685 so that others also can see. 2. I am little bit confused with naming convention for blacklist with placesBlacklist. And is there any plan to support blacklist racks in the future? Yes, that's the idea. In other parts of the code, this list gets passed along to filter both nodes and racks. Wangda Tan Regarding renames, I've included the ones you pointed out. There are lot more to be done, but I deliberately avoided them given the current size of the patch. Addressed other comments. 6) ResourceBlacklistRequest -> (Resource)Place(ment)BlacklistRequest? This is public API, cannot rename it now. Created a new TestNodeBlacklistingOnAMFailures, moved existing tests from TestAMRestart to this new class file. testAMBlacklistPreventsRestartOnSameNodeForMinicluster() is a bogus test, removed it. Sunil G 1. yarn.resourcemanager.am-scheduling.node-blacklisting-enabled and yarn.resourcemanager.am-scheduling.node-blacklisting-disable-threshold to be added in yarn-default.xml. Again, I deliberately deleted them for now. I'd like to discuss their re-addition as part of the outcome for YARN-4685 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 45s trunk passed
          +1 compile 2m 14s trunk passed
          +1 checkstyle 0m 59s trunk passed
          +1 mvnsite 1m 33s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          +1 findbugs 3m 0s trunk passed
          +1 javadoc 1m 34s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 19s the patch passed
          +1 compile 2m 6s the patch passed
          +1 cc 2m 6s the patch passed
          +1 javac 2m 6s the patch passed
          -1 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: patch generated 11 new + 1494 unchanged - 17 fixed = 1505 total (was 1511)
          +1 mvnsite 1m 26s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 3m 19s the patch passed
          +1 javadoc 2m 53s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 5385 unchanged - 21 fixed = 5385 total (was 5406)
          +1 javadoc 0m 39s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 29s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed.
          -1 unit 37m 20s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          69m 38s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt
            hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805380/YARN-4837-20160520.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux a98748acaca4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 500e946
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11604/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11604/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 45s trunk passed +1 compile 2m 14s trunk passed +1 checkstyle 0m 59s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 3m 0s trunk passed +1 javadoc 1m 34s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 2m 6s the patch passed +1 cc 2m 6s the patch passed +1 javac 2m 6s the patch passed -1 checkstyle 0m 53s hadoop-yarn-project/hadoop-yarn: patch generated 11 new + 1494 unchanged - 17 fixed = 1505 total (was 1511) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 19s the patch passed +1 javadoc 2m 53s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 5385 unchanged - 21 fixed = 5385 total (was 5406) +1 javadoc 0m 39s hadoop-yarn-api in the patch passed. +1 javadoc 0m 29s hadoop-yarn-common in the patch passed. +1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 24s hadoop-yarn-api in the patch passed. +1 unit 2m 15s hadoop-yarn-common in the patch passed. -1 unit 37m 20s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 69m 38s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt   hadoop.yarn.server.resourcemanager.TestContainerResourceUsage   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805380/YARN-4837-20160520.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux a98748acaca4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 500e946 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11604/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11604/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/11604/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Updated patch fixing the checkstyle issues and the two tests broken by the patch - TestAppSchedulingInfo & TestFSAppAttempt.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Updated patch fixing the checkstyle issues and the two tests broken by the patch - TestAppSchedulingInfo & TestFSAppAttempt.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          0 patch 0m 3s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 5m 58s trunk passed
          +1 compile 1m 53s trunk passed
          +1 checkstyle 0m 53s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 33s trunk passed
          +1 findbugs 2m 37s trunk passed
          +1 javadoc 1m 27s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 11s the patch passed
          +1 compile 2m 1s the patch passed
          +1 cc 2m 1s the patch passed
          +1 javac 2m 1s the patch passed
          -1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 1494 unchanged - 17 fixed = 1495 total (was 1511)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 3s the patch passed
          +1 javadoc 2m 40s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 5385 unchanged - 21 fixed = 5385 total (was 5406)
          +1 javadoc 0m 36s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 27s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 0m 22s hadoop-yarn-api in the patch passed.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed.
          -1 unit 33m 59s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 16s Patch does not generate ASF License warnings.
          63m 26s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805400/YARN-4837-20160520.1.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 2f23d4f6904b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 500e946
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11606/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11606/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11606/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11606/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11606/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. 0 patch 0m 3s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 5m 58s trunk passed +1 compile 1m 53s trunk passed +1 checkstyle 0m 53s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 33s trunk passed +1 findbugs 2m 37s trunk passed +1 javadoc 1m 27s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 11s the patch passed +1 compile 2m 1s the patch passed +1 cc 2m 1s the patch passed +1 javac 2m 1s the patch passed -1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 1494 unchanged - 17 fixed = 1495 total (was 1511) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 3s the patch passed +1 javadoc 2m 40s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 5385 unchanged - 21 fixed = 5385 total (was 5406) +1 javadoc 0m 36s hadoop-yarn-api in the patch passed. +1 javadoc 0m 27s hadoop-yarn-common in the patch passed. +1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 22s hadoop-yarn-api in the patch passed. +1 unit 2m 9s hadoop-yarn-common in the patch passed. -1 unit 33m 59s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 63m 26s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestContainerResourceUsage   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805400/YARN-4837-20160520.1.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 2f23d4f6904b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 500e946 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11606/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11606/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11606/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11606/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/11606/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          latest patch looks good to me. And I will upload patch with these changes in YARN-4685

          Show
          rohithsharma Rohith Sharma K S added a comment - latest patch looks good to me. And I will upload patch with these changes in YARN-4685
          Hide
          leftnoteasy Wangda Tan added a comment -

          Patch LGTM, +1. Thanks Vinod Kumar Vavilapalli

          Show
          leftnoteasy Wangda Tan added a comment - Patch LGTM, +1. Thanks Vinod Kumar Vavilapalli
          Hide
          sunilg Sunil G added a comment -

          Sorry for replying late. Thanks Vinod Kumar Vavilapalli for the clarifications. Latest patch looks good to me.

          Show
          sunilg Sunil G added a comment - Sorry for replying late. Thanks Vinod Kumar Vavilapalli for the clarifications. Latest patch looks good to me.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Wangda Tan / Vinod Kumar Vavilapalli can I go ahead and commit it? I think we may need to rebase to branch-2 and branch-2.8

          Show
          rohithsharma Rohith Sharma K S added a comment - Wangda Tan / Vinod Kumar Vavilapalli can I go ahead and commit it? I think we may need to rebase to branch-2 and branch-2.8
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Looks like need to rebase for trunk too!! Some files are getting conflicts.

          Show
          rohithsharma Rohith Sharma K S added a comment - Looks like need to rebase for trunk too!! Some files are getting conflicts.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Updated patch fixing the conflicts.

          Can't fix the checkstyle warning - Method length is 174 lines, and the test-failures are unrelated.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Updated patch fixing the conflicts. Can't fix the checkstyle warning - Method length is 174 lines, and the test-failures are unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 5m 59s trunk passed
          +1 compile 1m 55s trunk passed
          +1 checkstyle 0m 53s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          +1 findbugs 2m 41s trunk passed
          +1 javadoc 1m 26s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 12s the patch passed
          +1 compile 1m 53s the patch passed
          +1 cc 1m 53s the patch passed
          +1 javac 1m 53s the patch passed
          -1 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: patch generated 11 new + 1485 unchanged - 17 fixed = 1496 total (was 1502)
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 2m 57s the patch passed
          +1 javadoc 2m 34s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 5402 unchanged - 21 fixed = 5402 total (was 5423)
          +1 javadoc 0m 36s hadoop-yarn-api in the patch passed.
          +1 javadoc 0m 26s hadoop-yarn-common in the patch passed.
          +1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 0m 21s hadoop-yarn-api in the patch passed.
          +1 unit 2m 5s hadoop-yarn-common in the patch passed.
          -1 unit 34m 57s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 16s Patch does not generate ASF License warnings.
          63m 58s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt
            hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806717/YARN-4837-20160527.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 6940f217cc0e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5ea6fd8
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11738/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11738/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 5m 59s trunk passed +1 compile 1m 55s trunk passed +1 checkstyle 0m 53s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 2m 41s trunk passed +1 javadoc 1m 26s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 1m 53s the patch passed +1 cc 1m 53s the patch passed +1 javac 1m 53s the patch passed -1 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: patch generated 11 new + 1485 unchanged - 17 fixed = 1496 total (was 1502) +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 28s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 57s the patch passed +1 javadoc 2m 34s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api generated 0 new + 5402 unchanged - 21 fixed = 5402 total (was 5423) +1 javadoc 0m 36s hadoop-yarn-api in the patch passed. +1 javadoc 0m 26s hadoop-yarn-common in the patch passed. +1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 21s hadoop-yarn-api in the patch passed. +1 unit 2m 5s hadoop-yarn-common in the patch passed. -1 unit 34m 57s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 63m 58s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt   hadoop.yarn.server.resourcemanager.scheduler.TestAppSchedulingInfo Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806717/YARN-4837-20160527.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 6940f217cc0e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5ea6fd8 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11738/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11738/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/11738/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          Thanks for working on this, Vinod. Quickly skimmed through the patch. It is definitely more maintainable, thanks again for the cleanup.

          Just one nit:

          RMAppAttemptImpl#shouldCountTowardsNodeBlacklisting: For ContainerExitStatus.DISKS_FAILED, doesn't that mean at least one disk failed? And, the NM can continue running with remaining disks right? Is the idea that even if we schedule it to the same node, the NM wouldn't give the same local directory? If yes, should we clarify the comment accordingly?

          Show
          kasha Karthik Kambatla added a comment - Thanks for working on this, Vinod. Quickly skimmed through the patch. It is definitely more maintainable, thanks again for the cleanup. Just one nit: RMAppAttemptImpl#shouldCountTowardsNodeBlacklisting: For ContainerExitStatus.DISKS_FAILED, doesn't that mean at least one disk failed? And, the NM can continue running with remaining disks right? Is the idea that even if we schedule it to the same node, the NM wouldn't give the same local directory? If yes, should we clarify the comment accordingly?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Updated patch against the latest trunk.

          Karthik Kambatla

          RMAppAttemptImpl#shouldCountTowardsNodeBlacklisting: For ContainerExitStatus.DISKS_FAILED, doesn't that mean at least one disk failed? And, the NM can continue running with remaining disks right? Is the idea that even if we schedule it to the same node, the NM wouldn't give the same local directory? If yes, should we clarify the comment accordingly?

          No, a container is marked with tContainerExitStatus.DISKS_FAILED means that the node is already be marked unhealthy given that most of the disks failed. So, no more containers will be scheduled on that node.

          Edited the comment for more clarity to reflect the same.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Updated patch against the latest trunk. Karthik Kambatla RMAppAttemptImpl#shouldCountTowardsNodeBlacklisting: For ContainerExitStatus.DISKS_FAILED, doesn't that mean at least one disk failed? And, the NM can continue running with remaining disks right? Is the idea that even if we schedule it to the same node, the NM wouldn't give the same local directory? If yes, should we clarify the comment accordingly? No, a container is marked with tContainerExitStatus.DISKS_FAILED means that the node is already be marked unhealthy given that most of the disks failed. So, no more containers will be scheduled on that node. Edited the comment for more clarity to reflect the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 7m 26s trunk passed
          +1 compile 2m 25s trunk passed
          +1 checkstyle 0m 56s trunk passed
          +1 mvnsite 1m 31s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 2s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 13s the patch passed
          +1 compile 1m 52s the patch passed
          +1 cc 1m 52s the patch passed
          +1 javac 1m 52s the patch passed
          -1 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 1489 unchanged - 17 fixed = 1490 total (was 1506)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 2m 59s the patch passed
          +1 javadoc 0m 56s the patch passed
          +1 unit 0m 21s hadoop-yarn-api in the patch passed.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed.
          -1 unit 35m 7s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          65m 52s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808197/YARN-4837-20160604.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 6836bf892850 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 106234d
          Default Java 1.8.0_91
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11846/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11846/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 7m 26s trunk passed +1 compile 2m 25s trunk passed +1 checkstyle 0m 56s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 32s trunk passed -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 2s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 13s the patch passed +1 compile 1m 52s the patch passed +1 cc 1m 52s the patch passed +1 javac 1m 52s the patch passed -1 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 1489 unchanged - 17 fixed = 1490 total (was 1506) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 59s the patch passed +1 javadoc 0m 56s the patch passed +1 unit 0m 21s hadoop-yarn-api in the patch passed. +1 unit 2m 7s hadoop-yarn-common in the patch passed. -1 unit 35m 7s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 65m 52s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808197/YARN-4837-20160604.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 6836bf892850 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 106234d Default Java 1.8.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11846/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11846/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/11846/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          +1 to latest patch, findbugs warning is not related. Will commit this patch in 24h if no objections.

          Show
          leftnoteasy Wangda Tan added a comment - +1 to latest patch, findbugs warning is not related. Will commit this patch in 24h if no objections.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committing this patch now. Findbug warning should cause by YARN-5180, already commented on the JIRA.

          Show
          leftnoteasy Wangda Tan added a comment - Committing this patch now. Findbug warning should cause by YARN-5180 , already commented on the JIRA.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached patch to branch-2 to trigger Jenkins build.

          Show
          leftnoteasy Wangda Tan added a comment - Attached patch to branch-2 to trigger Jenkins build.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9923 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9923/)
          YARN-4837. User facing aspects of 'AM blacklisting' feature need fixing. (wangda: rev 620325e81696fca140195b74929ed9eda2d5eb16)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/DisabledBlacklistManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/AMBlackListingRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/RegularContainerAllocator.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/SimpleBlacklistManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/BlacklistUpdates.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/TestBlacklistManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/AMBlackListingRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/BlacklistManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerAppUtils.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestAppSchedulingInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppAttemptBlock.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFSAppAttempt.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AMBlackListingRequestInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestNodeBlacklistingOnAMFailures.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ApplicationSubmissionContextInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/TestAMRestart.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9923 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9923/ ) YARN-4837 . User facing aspects of 'AM blacklisting' feature need fixing. (wangda: rev 620325e81696fca140195b74929ed9eda2d5eb16) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/DisabledBlacklistManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/AMBlackListingRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/RegularContainerAllocator.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/FifoScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/SimpleBlacklistManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/BlacklistUpdates.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/TestBlacklistManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/AMBlackListingRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/BlacklistManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerAppUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestAppSchedulingInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppAttemptBlock.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFSAppAttempt.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AMBlackListingRequestInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestNodeBlacklistingOnAMFailures.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ApplicationSubmissionContextInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/TestAMRestart.java
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed the patch to trunk, will commit to branch-2/branch-2.8 once get +1 from Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Committed the patch to trunk, will commit to branch-2/branch-2.8 once get +1 from Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 2m 2s Maven dependency ordering for branch
          +1 mvninstall 7m 43s branch-2 passed
          +1 compile 1m 54s branch-2 passed with JDK v1.8.0_74
          +1 compile 2m 9s branch-2 passed with JDK v1.7.0_95
          +1 checkstyle 0m 59s branch-2 passed
          +1 mvnsite 1m 35s branch-2 passed
          +1 mvneclipse 0m 50s branch-2 passed
          -1 findbugs 1m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in branch-2 has 1 extant Findbugs warnings.
          +1 javadoc 1m 7s branch-2 passed with JDK v1.8.0_74
          +1 javadoc 1m 14s branch-2 passed with JDK v1.7.0_95
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 19s the patch passed
          +1 compile 1m 46s the patch passed with JDK v1.8.0_74
          +1 cc 1m 46s the patch passed
          +1 javac 1m 46s the patch passed
          +1 compile 2m 8s the patch passed with JDK v1.7.0_95
          +1 cc 2m 8s the patch passed
          +1 javac 2m 8s the patch passed
          -1 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 1493 unchanged - 17 fixed = 1494 total (was 1510)
          +1 mvnsite 1m 26s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 1s the patch passed
          +1 javadoc 0m 59s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_74.
          +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
          -1 unit 36m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 39m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          121m 21s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808771/YARN-4837-branch-2.005.patch
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 5e931b326875 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 8b34040
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11890/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11890/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 2m 2s Maven dependency ordering for branch +1 mvninstall 7m 43s branch-2 passed +1 compile 1m 54s branch-2 passed with JDK v1.8.0_74 +1 compile 2m 9s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 0m 59s branch-2 passed +1 mvnsite 1m 35s branch-2 passed +1 mvneclipse 0m 50s branch-2 passed -1 findbugs 1m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 7s branch-2 passed with JDK v1.8.0_74 +1 javadoc 1m 14s branch-2 passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 1m 46s the patch passed with JDK v1.8.0_74 +1 cc 1m 46s the patch passed +1 javac 1m 46s the patch passed +1 compile 2m 8s the patch passed with JDK v1.7.0_95 +1 cc 2m 8s the patch passed +1 javac 2m 8s the patch passed -1 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 1493 unchanged - 17 fixed = 1494 total (was 1510) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 1s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_74. +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. -1 unit 36m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 39m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 121m 21s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808771/YARN-4837-branch-2.005.patch JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 5e931b326875 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 8b34040 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/11890/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11890/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/11890/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to branch-2 as well

          Show
          leftnoteasy Wangda Tan added a comment - Committed to branch-2 as well
          Hide
          sjlee0 Sangjin Lee added a comment -

          Wangda Tan should this JIRA be resolved then?

          Show
          sjlee0 Sangjin Lee added a comment - Wangda Tan should this JIRA be resolved then?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          This JIRA target version is branch-2.8 which is not yet committed to target version.

          Wangda Tan does branch-2 patch can be applied to branch-2.8 or should do rebase?

          Show
          rohithsharma Rohith Sharma K S added a comment - This JIRA target version is branch-2.8 which is not yet committed to target version. Wangda Tan does branch-2 patch can be applied to branch-2.8 or should do rebase?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Uploading a 2.8 patch - fixing conflicts, test-issues etc.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Uploading a 2.8 patch - fixing conflicts, test-issues etc.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          0 patch 0m 5s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 30s Maven dependency ordering for branch
          +1 mvninstall 6m 48s branch-2.8 passed
          +1 compile 1m 56s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 2m 18s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 46s branch-2.8 passed
          +1 mvnsite 1m 40s branch-2.8 passed
          +1 mvneclipse 0m 45s branch-2.8 passed
          +1 findbugs 3m 33s branch-2.8 passed
          +1 javadoc 1m 6s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 1m 16s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 23s the patch passed
          +1 compile 1m 54s the patch passed with JDK v1.8.0_101
          +1 cc 1m 54s the patch passed
          +1 javac 1m 54s the patch passed
          +1 compile 2m 16s the patch passed with JDK v1.7.0_101
          +1 cc 2m 16s the patch passed
          +1 javac 2m 16s the patch passed
          -1 checkstyle 0m 43s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 947 unchanged - 10 fixed = 953 total (was 957)
          +1 mvnsite 1m 33s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 7s the patch passed
          -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101 with JDK v1.7.0_101 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          -1 unit 74m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 26s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          -1 unit 76m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          194m 20s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824440/YARN-4837-branch-2.8.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 21c0a5558a2c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 5b49bca
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12824/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12824/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. 0 patch 0m 5s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 6m 48s branch-2.8 passed +1 compile 1m 56s branch-2.8 passed with JDK v1.8.0_101 +1 compile 2m 18s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 46s branch-2.8 passed +1 mvnsite 1m 40s branch-2.8 passed +1 mvneclipse 0m 45s branch-2.8 passed +1 findbugs 3m 33s branch-2.8 passed +1 javadoc 1m 6s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 1m 16s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 1m 54s the patch passed with JDK v1.8.0_101 +1 cc 1m 54s the patch passed +1 javac 1m 54s the patch passed +1 compile 2m 16s the patch passed with JDK v1.7.0_101 +1 cc 2m 16s the patch passed +1 javac 2m 16s the patch passed -1 checkstyle 0m 43s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 947 unchanged - 10 fixed = 953 total (was 957) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 7s the patch passed -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101 with JDK v1.7.0_101 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. -1 unit 74m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 26s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. -1 unit 76m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 194m 20s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824440/YARN-4837-branch-2.8.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 21c0a5558a2c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 5b49bca Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12824/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12824/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 21s Maven dependency ordering for branch
          +1 mvninstall 6m 59s branch-2.8 passed
          +1 compile 2m 11s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 2m 24s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 46s branch-2.8 passed
          +1 mvnsite 1m 42s branch-2.8 passed
          +1 mvneclipse 0m 43s branch-2.8 passed
          +1 findbugs 3m 29s branch-2.8 passed
          +1 javadoc 1m 4s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 1m 15s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 1m 54s the patch passed with JDK v1.8.0_101
          +1 cc 1m 54s the patch passed
          +1 javac 1m 54s the patch passed
          +1 compile 2m 14s the patch passed with JDK v1.7.0_101
          +1 cc 2m 14s the patch passed
          +1 javac 2m 14s the patch passed
          -1 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 947 unchanged - 10 fixed = 953 total (was 957)
          +1 mvnsite 1m 33s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 4s the patch passed
          -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101 with JDK v1.7.0_101 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          -1 unit 73m 49s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 31s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          -1 unit 76m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          193m 26s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824440/YARN-4837-branch-2.8.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 40de035c8a38 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 5d91f9f
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12827/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12827/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 6m 59s branch-2.8 passed +1 compile 2m 11s branch-2.8 passed with JDK v1.8.0_101 +1 compile 2m 24s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 46s branch-2.8 passed +1 mvnsite 1m 42s branch-2.8 passed +1 mvneclipse 0m 43s branch-2.8 passed +1 findbugs 3m 29s branch-2.8 passed +1 javadoc 1m 4s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 1m 15s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 54s the patch passed with JDK v1.8.0_101 +1 cc 1m 54s the patch passed +1 javac 1m 54s the patch passed +1 compile 2m 14s the patch passed with JDK v1.7.0_101 +1 cc 2m 14s the patch passed +1 javac 2m 14s the patch passed -1 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 947 unchanged - 10 fixed = 953 total (was 957) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 4s the patch passed -1 javadoc 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. -1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101 with JDK v1.7.0_101 generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. -1 unit 73m 49s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 31s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. -1 unit 76m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 193m 26s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824440/YARN-4837-branch-2.8.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 40de035c8a38 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 5d91f9f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12827/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12827/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Updated patch fixing the javadoc issue.

          And checkstyles issues that can be addressed.

          The unit test failures are unrelated, pass on my local box and are tracked at YARN-5208 / HADOOP-12687.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Updated patch fixing the javadoc issue. And checkstyles issues that can be addressed. The unit test failures are unrelated, pass on my local box and are tracked at YARN-5208 / HADOOP-12687 .
          Hide
          leftnoteasy Wangda Tan added a comment -

          Given my previous +1 for the patch, committed to branch-2.8, thanks Vinod Kumar Vavilapalli and all folks for reviews!

          Show
          leftnoteasy Wangda Tan added a comment - Given my previous +1 for the patch, committed to branch-2.8, thanks Vinod Kumar Vavilapalli and all folks for reviews!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 6m 32s branch-2.8 passed
          +1 compile 1m 51s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 2m 11s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 45s branch-2.8 passed
          +1 mvnsite 1m 38s branch-2.8 passed
          +1 mvneclipse 0m 45s branch-2.8 passed
          +1 findbugs 3m 25s branch-2.8 passed
          +1 javadoc 1m 3s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 1m 14s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 25s the patch passed
          +1 compile 2m 15s the patch passed with JDK v1.8.0_101
          +1 cc 2m 15s the patch passed
          +1 javac 2m 15s the patch passed
          +1 compile 2m 24s the patch passed with JDK v1.7.0_101
          +1 cc 2m 24s the patch passed
          +1 javac 2m 24s the patch passed
          -1 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 5 new + 947 unchanged - 10 fixed = 952 total (was 957)
          +1 mvnsite 1m 40s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 20s the patch passed
          +1 javadoc 1m 1s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 10s the patch passed with JDK v1.7.0_101
          +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_101.
          +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_101.
          -1 unit 74m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          -1 unit 75m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          192m 12s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824592/YARN-4837-branch-2.8.1.txt
          JIRA Issue YARN-4837
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux c68f9c2a4aee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 4f3df8e
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12837/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12837/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 32s branch-2.8 passed +1 compile 1m 51s branch-2.8 passed with JDK v1.8.0_101 +1 compile 2m 11s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 45s branch-2.8 passed +1 mvnsite 1m 38s branch-2.8 passed +1 mvneclipse 0m 45s branch-2.8 passed +1 findbugs 3m 25s branch-2.8 passed +1 javadoc 1m 3s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 1m 14s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 25s the patch passed +1 compile 2m 15s the patch passed with JDK v1.8.0_101 +1 cc 2m 15s the patch passed +1 javac 2m 15s the patch passed +1 compile 2m 24s the patch passed with JDK v1.7.0_101 +1 cc 2m 24s the patch passed +1 javac 2m 24s the patch passed -1 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 5 new + 947 unchanged - 10 fixed = 952 total (was 957) +1 mvnsite 1m 40s the patch passed +1 mvneclipse 0m 38s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 20s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_101 +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_101. +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_101. -1 unit 74m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. -1 unit 75m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 192m 12s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824592/YARN-4837-branch-2.8.1.txt JIRA Issue YARN-4837 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux c68f9c2a4aee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 4f3df8e Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12837/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12837/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12837/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              vinodkv Vinod Kumar Vavilapalli
              Reporter:
              vinodkv Vinod Kumar Vavilapalli
            • Votes:
              0 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development