Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4389

"yarn.am.blacklisting.enabled" and "yarn.am.blacklisting.disable-failure-threshold" should be app specific rather than a setting for whole YARN cluster

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: applications
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      "yarn.am.blacklisting.enabled" and "yarn.am.blacklisting.disable-failure-threshold" should be application specific rather than a setting in cluster level, or we should't maintain amBlacklistingEnabled and blacklistDisableThreshold in per rmApp level. We should allow each am to override this config, i.e. via submissionContext.

      1. 0001-YARN-4389.patch
        20 kB
        Sunil G
      2. 0002-YARN-4389.patch
        21 kB
        Sunil G
      3. 0003-YARN-4389.patch
        20 kB
        Sunil G
      4. 0004-YARN-4389.patch
        20 kB
        Sunil G
      5. 0005-YARN-4389.patch
        20 kB
        Sunil G
      6. 0006-YARN-4389.patch
        21 kB
        Sunil G
      7. 0007-YARN-4389.patch
        21 kB
        Sunil G
      8. 0008-YARN-4389.patch
        21 kB
        Sunil G
      9. 0009-YARN-4389.patch
        24 kB
        Sunil G
      10. 0009-YARN-4389-branch-2.patch
        24 kB
        Sunil G

        Issue Links

          Activity

          Hide
          sunilg Sunil G added a comment -

          Yes, +1 for this approach.
          It make more sense to have this per app level.

          Show
          sunilg Sunil G added a comment - Yes, +1 for this approach. It make more sense to have this per app level.
          Hide
          sunilg Sunil G added a comment -

          One more doubt here, I do not feel we need to deprecate or remove "yarn.am.blacklisting.enabled" and "yarn.am.blacklisting.disable-failure-threshold". It can be kept, and we can also override if we specify via submission context. This will satisfy both cases, will this approach be fine Junping Du

          Show
          sunilg Sunil G added a comment - One more doubt here, I do not feel we need to deprecate or remove "yarn.am.blacklisting.enabled" and "yarn.am.blacklisting.disable-failure-threshold". It can be kept, and we can also override if we specify via submission context. This will satisfy both cases, will this approach be fine Junping Du
          Hide
          djp Junping Du added a comment -

          Yes. This is what I was thinking and proposing in description.

          Show
          djp Junping Du added a comment - Yes. This is what I was thinking and proposing in description.
          Hide
          sunilg Sunil G added a comment -

          Yes, missed the last statement. Thanks for confirming.

          Show
          sunilg Sunil G added a comment - Yes, missed the last statement. Thanks for confirming.
          Hide
          sunilg Sunil G added a comment -

          I could give a hand here if you haven't started.

          Show
          sunilg Sunil G added a comment - I could give a hand here if you haven't started.
          Hide
          djp Junping Du added a comment -

          Sure. Please feel free to take it and I will help on review and commit.

          Show
          djp Junping Du added a comment - Sure. Please feel free to take it and I will help on review and commit.
          Hide
          sunilg Sunil G added a comment -

          Hi Junping Du
          Attaching an initial version of patch. Kindly help to check the same.
          once this ticket is reviewed, I will raise a mapreduce ticket to pass this information from RM side.

          Show
          sunilg Sunil G added a comment - Hi Junping Du Attaching an initial version of patch. Kindly help to check the same. once this ticket is reviewed, I will raise a mapreduce ticket to pass this information from RM side.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 44s trunk passed
          +1 compile 2m 18s trunk passed with JDK v1.8.0_66
          +1 compile 2m 27s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 4m 21s trunk passed
          +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 5s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 41s the patch passed
          +1 compile 2m 18s the patch passed with JDK v1.8.0_66
          +1 cc 2m 18s the patch passed
          +1 javac 2m 18s the patch passed
          +1 compile 2m 28s the patch passed with JDK v1.7.0_85
          +1 cc 2m 28s the patch passed
          +1 javac 2m 28s the patch passed
          -1 checkstyle 0m 31s Patch generated 7 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 160, now 167).
          +1 mvnsite 1m 52s the patch passed
          +1 mvneclipse 0m 48s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 0s the patch passed
          -1 javadoc 0m 48s hadoop-yarn-api in the patch failed with JDK v1.8.0_66.
          -1 javadoc 8m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 0, now 1).
          +1 javadoc 4m 25s the patch passed with JDK v1.7.0_85
          +1 unit 0m 37s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          -1 unit 2m 29s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
          -1 unit 66m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 28s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          -1 unit 2m 45s hadoop-yarn-common in the patch failed with JDK v1.7.0_85.
          -1 unit 66m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          189m 42s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.api.TestPBImplRecords
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.api.TestPBImplRecords
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774333/0001-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 3c0ed871e3d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 177975e
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9793/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9793/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 44s trunk passed +1 compile 2m 18s trunk passed with JDK v1.8.0_66 +1 compile 2m 27s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 4m 21s trunk passed +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 5s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 41s the patch passed +1 compile 2m 18s the patch passed with JDK v1.8.0_66 +1 cc 2m 18s the patch passed +1 javac 2m 18s the patch passed +1 compile 2m 28s the patch passed with JDK v1.7.0_85 +1 cc 2m 28s the patch passed +1 javac 2m 28s the patch passed -1 checkstyle 0m 31s Patch generated 7 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 160, now 167). +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 0s the patch passed -1 javadoc 0m 48s hadoop-yarn-api in the patch failed with JDK v1.8.0_66. -1 javadoc 8m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 0, now 1). +1 javadoc 4m 25s the patch passed with JDK v1.7.0_85 +1 unit 0m 37s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 2m 29s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. -1 unit 66m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 28s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. -1 unit 2m 45s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. -1 unit 66m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 189m 42s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_85 Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774333/0001-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 3c0ed871e3d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 177975e findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9793/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9793/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9793/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Attaching an updated patch correcting test case failures. Also fixed few checkstyle and javadoc problems.
          Junping Du Could you please help to review the patch.

          Show
          sunilg Sunil G added a comment - Attaching an updated patch correcting test case failures. Also fixed few checkstyle and javadoc problems. Junping Du Could you please help to review the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 59s trunk passed
          +1 compile 2m 1s trunk passed with JDK v1.8.0_66
          +1 compile 2m 15s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 41s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 4m 2s trunk passed
          +1 javadoc 1m 32s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 55s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 37s the patch passed
          +1 compile 2m 6s the patch passed with JDK v1.8.0_66
          +1 cc 2m 6s the patch passed
          +1 javac 2m 6s the patch passed
          +1 compile 2m 18s the patch passed with JDK v1.7.0_85
          +1 cc 2m 18s the patch passed
          +1 javac 2m 18s the patch passed
          -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 160, now 165).
          +1 mvnsite 1m 40s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 40s the patch passed
          +1 javadoc 1m 35s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 57s the patch passed with JDK v1.7.0_85
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          -1 unit 65m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          181m 6s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775335/0002-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux e86db9312e17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 53e3bf7
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9840/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9840/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 59s trunk passed +1 compile 2m 1s trunk passed with JDK v1.8.0_66 +1 compile 2m 15s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 41s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 2s trunk passed +1 javadoc 1m 32s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 55s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 37s the patch passed +1 compile 2m 6s the patch passed with JDK v1.8.0_66 +1 cc 2m 6s the patch passed +1 javac 2m 6s the patch passed +1 compile 2m 18s the patch passed with JDK v1.7.0_85 +1 cc 2m 18s the patch passed +1 javac 2m 18s the patch passed -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 160, now 165). +1 mvnsite 1m 40s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 40s the patch passed +1 javadoc 1m 35s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 57s the patch passed with JDK v1.7.0_85 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. -1 unit 65m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 181m 6s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775335/0002-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux e86db9312e17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 53e3bf7 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9840/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9840/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9840/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Test case failures are known ones. And has separate tickets to handle the same.

          Show
          sunilg Sunil G added a comment - Test case failures are known ones. And has separate tickets to handle the same.
          Hide
          sunilg Sunil G added a comment -

          Patch has gone stale. Updating as per latest trunk. Junping Du, pls help to check the same.

          Show
          sunilg Sunil G added a comment - Patch has gone stale. Updating as per latest trunk. Junping Du , pls help to check the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 44s trunk passed
          +1 compile 2m 25s trunk passed with JDK v1.8.0_66
          +1 compile 2m 27s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 51s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 4m 0s trunk passed
          -1 javadoc 0m 23s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 3m 56s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 34s the patch passed
          +1 compile 2m 3s the patch passed with JDK v1.8.0_66
          +1 cc 2m 3s the patch passed
          +1 javac 2m 3s the patch passed
          +1 compile 2m 17s the patch passed with JDK v1.7.0_91
          +1 cc 2m 17s the patch passed
          +1 javac 2m 17s the patch passed
          -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 42s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 34s the patch passed
          -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 javadoc 4m 1s the patch passed with JDK v1.7.0_91
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          184m 6s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776604/0003-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 750e134779ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 50edcb9
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9914/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9914/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 44s trunk passed +1 compile 2m 25s trunk passed with JDK v1.8.0_66 +1 compile 2m 27s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 4m 0s trunk passed -1 javadoc 0m 23s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 3m 56s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 34s the patch passed +1 compile 2m 3s the patch passed with JDK v1.8.0_66 +1 cc 2m 3s the patch passed +1 javac 2m 3s the patch passed +1 compile 2m 17s the patch passed with JDK v1.7.0_91 +1 cc 2m 17s the patch passed +1 javac 2m 17s the patch passed -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 34s the patch passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 4m 1s the patch passed with JDK v1.7.0_91 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 184m 6s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776604/0003-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 750e134779ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 50edcb9 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9914/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9914/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9914/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Patch has gone stale. Rebasing the same. Junping Du, could you please help to check the same.

          Show
          sunilg Sunil G added a comment - Patch has gone stale. Rebasing the same. Junping Du , could you please help to check the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 9s trunk passed
          +1 compile 2m 0s trunk passed with JDK v1.8.0_66
          +1 compile 2m 17s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 42s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 59s trunk passed
          +1 javadoc 1m 32s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 52s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 35s the patch passed
          +1 compile 2m 1s the patch passed with JDK v1.8.0_66
          +1 cc 2m 1s the patch passed
          +1 javac 2m 1s the patch passed
          +1 compile 2m 16s the patch passed with JDK v1.7.0_91
          +1 cc 2m 16s the patch passed
          +1 javac 2m 16s the patch passed
          -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 41s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 21s the patch passed
          +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 0s the patch passed with JDK v1.7.0_91
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 0s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 66m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          183m 19s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestRM
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778497/0004-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 5508bfa5c205 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bfadf11
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10040/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10040/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 9s trunk passed +1 compile 2m 0s trunk passed with JDK v1.8.0_66 +1 compile 2m 17s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 59s trunk passed +1 javadoc 1m 32s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 52s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 35s the patch passed +1 compile 2m 1s the patch passed with JDK v1.8.0_66 +1 cc 2m 1s the patch passed +1 javac 2m 1s the patch passed +1 compile 2m 16s the patch passed with JDK v1.7.0_91 +1 cc 2m 16s the patch passed +1 javac 2m 16s the patch passed -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 41s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 21s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 0s the patch passed with JDK v1.7.0_91 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 0s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 66m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 183m 19s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRM JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778497/0004-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 5508bfa5c205 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bfadf11 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10040/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10040/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10040/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Rebasing against latest trunk. Junping Du could you please take a look.

          Show
          sunilg Sunil G added a comment - Rebasing against latest trunk. Junping Du could you please take a look.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 1s trunk passed
          +1 compile 2m 8s trunk passed with JDK v1.8.0_66
          +1 compile 2m 11s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 39s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 3m 49s trunk passed
          +1 javadoc 1m 31s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 44s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 23s the patch passed
          +1 compile 2m 6s the patch passed with JDK v1.8.0_66
          +1 cc 2m 6s the patch passed
          +1 javac 2m 6s the patch passed
          +1 compile 2m 7s the patch passed with JDK v1.7.0_91
          +1 cc 2m 7s the patch passed
          +1 javac 2m 7s the patch passed
          -1 checkstyle 0m 28s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 31s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 5s the patch passed
          +1 javadoc 1m 25s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 43s the patch passed with JDK v1.7.0_91
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          179m 59s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780790/0005-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux b419af6e87bf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c1462a6
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10176/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10176/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 1s trunk passed +1 compile 2m 8s trunk passed with JDK v1.8.0_66 +1 compile 2m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 39s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 3m 49s trunk passed +1 javadoc 1m 31s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 44s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 23s the patch passed +1 compile 2m 6s the patch passed with JDK v1.8.0_66 +1 cc 2m 6s the patch passed +1 javac 2m 6s the patch passed +1 compile 2m 7s the patch passed with JDK v1.7.0_91 +1 cc 2m 7s the patch passed +1 javac 2m 7s the patch passed -1 checkstyle 0m 28s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 31s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 5s the patch passed +1 javadoc 1m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 43s the patch passed with JDK v1.7.0_91 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 179m 59s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780790/0005-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux b419af6e87bf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c1462a6 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10176/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10176/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10176/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Hi Sunil G, thanks for working on the patch.
          Overall patch looks good to me,
          One nit : optimization

          1. can you check first app level blacklisting enabled or not. And later go for global blacklisting initialzation. Now , global level variable initialization are done first and then, checking for app level which we can optimize a bit.
          Show
          rohithsharma Rohith Sharma K S added a comment - Hi Sunil G , thanks for working on the patch. Overall patch looks good to me, One nit : optimization can you check first app level blacklisting enabled or not. And later go for global blacklisting initialzation. Now , global level variable initialization are done first and then, checking for app level which we can optimize a bit.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Adding to above, do you think if app-level blacklistDisableThreshold is not configured, should we consider global blacklistDisableThreshold?

          Show
          rohithsharma Rohith Sharma K S added a comment - Adding to above, do you think if app-level blacklistDisableThreshold is not configured, should we consider global blacklistDisableThreshold?
          Hide
          sunilg Sunil G added a comment -

          Thank you Rohith Sharma K S
          Updating patch addressing the comments.

          do you think if app-level blacklistDisableThreshold is not configured, should we consider global blacklistDisableThreshold?

          Since this information is coming from AM end, and blacklistDisableThreshold is a primitive type, I think it will have a value. Or we may need to see whether its 0 and then try to get from global blackListThreshold. But there is a chance that this can also be not configured, so we may need to fall to the default of 0.8. Thoughts?

          Show
          sunilg Sunil G added a comment - Thank you Rohith Sharma K S Updating patch addressing the comments. do you think if app-level blacklistDisableThreshold is not configured, should we consider global blacklistDisableThreshold? Since this information is coming from AM end, and blacklistDisableThreshold is a primitive type, I think it will have a value. Or we may need to see whether its 0 and then try to get from global blackListThreshold. But there is a chance that this can also be not configured, so we may need to fall to the default of 0.8. Thoughts?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 54s trunk passed
          +1 compile 1m 58s trunk passed with JDK v1.8.0_66
          +1 compile 2m 8s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 3m 50s trunk passed
          +1 javadoc 1m 30s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 43s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 21s the patch passed
          +1 compile 1m 49s the patch passed with JDK v1.8.0_66
          +1 cc 1m 49s the patch passed
          +1 javac 1m 49s the patch passed
          +1 compile 2m 6s the patch passed with JDK v1.7.0_91
          +1 cc 2m 6s the patch passed
          +1 javac 2m 6s the patch passed
          -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 8s the patch passed
          +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 42s the patch passed with JDK v1.7.0_91
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 64m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 65m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          177m 51s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782041/0006-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux ab6e44befc68 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c0537bc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10264/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10264/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 54s trunk passed +1 compile 1m 58s trunk passed with JDK v1.8.0_66 +1 compile 2m 8s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 3m 50s trunk passed +1 javadoc 1m 30s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 43s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 21s the patch passed +1 compile 1m 49s the patch passed with JDK v1.8.0_66 +1 cc 1m 49s the patch passed +1 javac 1m 49s the patch passed +1 compile 2m 6s the patch passed with JDK v1.7.0_91 +1 cc 2m 6s the patch passed +1 javac 2m 6s the patch passed -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 8s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 42s the patch passed with JDK v1.7.0_91 +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 64m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 65m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 177m 51s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782041/0006-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux ab6e44befc68 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c0537bc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10264/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10264/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Thanks Sunil G for delivering the patch and Rohith Sharma K S for reviewing it. The patch looks fine in overall except one issue:
          if submissionContext.getAMBlackListRequest() is null that means app doesn't have specific requirement on blacklist policy, then we should use cluster's setting instead.

          Show
          djp Junping Du added a comment - Thanks Sunil G for delivering the patch and Rohith Sharma K S for reviewing it. The patch looks fine in overall except one issue: if submissionContext.getAMBlackListRequest() is null that means app doesn't have specific requirement on blacklist policy, then we should use cluster's setting instead.
          Hide
          sunilg Sunil G added a comment -

          Thank You Junping Du for correcting. Updated patch after fixing the same.

          Show
          sunilg Sunil G added a comment - Thank You Junping Du for correcting. Updated patch after fixing the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 52s trunk passed
          +1 compile 1m 51s trunk passed with JDK v1.8.0_66
          +1 compile 2m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 36s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 44s trunk passed
          +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 44s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 19s the patch passed
          +1 compile 1m 41s the patch passed with JDK v1.8.0_66
          +1 cc 1m 41s the patch passed
          +1 javac 1m 41s the patch passed
          +1 compile 2m 3s the patch passed with JDK v1.7.0_91
          +1 cc 2m 3s the patch passed
          +1 javac 2m 3s the patch passed
          -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 4s the patch passed
          +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 45s the patch passed with JDK v1.7.0_91
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 67m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          181m 13s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782079/0007-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 61fe02b13c59 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c0537bc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10265/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10265/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 52s trunk passed +1 compile 1m 51s trunk passed with JDK v1.8.0_66 +1 compile 2m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 44s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 44s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 19s the patch passed +1 compile 1m 41s the patch passed with JDK v1.8.0_66 +1 cc 1m 41s the patch passed +1 javac 1m 41s the patch passed +1 compile 2m 3s the patch passed with JDK v1.7.0_91 +1 cc 2m 3s the patch passed +1 javac 2m 3s the patch passed -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 4s the patch passed +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 45s the patch passed with JDK v1.7.0_91 +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 67m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 181m 13s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782079/0007-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 61fe02b13c59 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c0537bc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10265/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10265/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10265/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          One small nit :
          Currently if user sets amBlacklistingEnabled explicitly to false then latest patch is considering global configuration. I think this should not be the case. Thoughts?
          Just check with an if-else clause

              if (null != submissionContext.getAMBlackListRequest()) {
            // Consider app-level configuration
              } else {
                // consider global configurations
                }
          
          Show
          rohithsharma Rohith Sharma K S added a comment - One small nit : Currently if user sets amBlacklistingEnabled explicitly to false then latest patch is considering global configuration. I think this should not be the case. Thoughts? Just check with an if-else clause if ( null != submissionContext.getAMBlackListRequest()) { // Consider app-level configuration } else { // consider global configurations }
          Hide
          sunilg Sunil G added a comment -

          Thanks Rohith Sharma K S

          This suggestion makes sense to me. With this, we will be giving option to application to enable/disable this feature regardless of the configuration in YARN. Uploading a new patch, also gave all cases as comment in code.

          Show
          sunilg Sunil G added a comment - Thanks Rohith Sharma K S This suggestion makes sense to me. With this, we will be giving option to application to enable/disable this feature regardless of the configuration in YARN. Uploading a new patch, also gave all cases as comment in code.
          Hide
          sunilg Sunil G added a comment -

          Junping Du and Rohith Sharma K S, could you please help to check the patch.

          Show
          sunilg Sunil G added a comment - Junping Du and Rohith Sharma K S , could you please help to check the patch.
          Hide
          djp Junping Du added a comment -

          Thanks Sunil G for updating the patch. The patch looks pretty good now except one NIT:
          Shall we check disable threshold to be a valid value (not a negative value, less or equally than 1.0 f) set by app? If app's value is not valid, may be we should log a warn message and use global setting instead.

          Show
          djp Junping Du added a comment - Thanks Sunil G for updating the patch. The patch looks pretty good now except one NIT: Shall we check disable threshold to be a valid value (not a negative value, less or equally than 1.0 f) set by app? If app's value is not valid, may be we should log a warn message and use global setting instead.
          Hide
          sunilg Sunil G added a comment -

          Yes Junping Du, that's perfectly fine. We could do that, and I will make necessary changes.

          Show
          sunilg Sunil G added a comment - Yes Junping Du , that's perfectly fine. We could do that, and I will make necessary changes.
          Hide
          sunilg Sunil G added a comment -

          Updating patch with validation for disableThreshold. Also added few test cases to verify all conditions.
          Junping Du/Rohith Sharma K S pls help to check the same.

          Show
          sunilg Sunil G added a comment - Updating patch with validation for disableThreshold. Also added few test cases to verify all conditions. Junping Du / Rohith Sharma K S pls help to check the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 7m 27s trunk passed
          +1 compile 1m 45s trunk passed with JDK v1.8.0_66
          +1 compile 2m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 36s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 3m 47s trunk passed
          +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 48s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 25s Maven dependency ordering for patch
          +1 mvninstall 1m 21s the patch passed
          +1 compile 1m 46s the patch passed with JDK v1.8.0_66
          +1 cc 1m 46s the patch passed
          +1 javac 1m 46s the patch passed
          +1 compile 2m 5s the patch passed with JDK v1.7.0_91
          +1 cc 2m 5s the patch passed
          +1 javac 2m 5s the patch passed
          -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 10s the patch passed
          +1 javadoc 1m 24s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 45s the patch passed with JDK v1.7.0_91
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 64m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          178m 53s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782291/0008-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux f1c7cc26bee1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c8b80eb
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10284/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10284/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 7m 27s trunk passed +1 compile 1m 45s trunk passed with JDK v1.8.0_66 +1 compile 2m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 3m 47s trunk passed +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 48s trunk passed with JDK v1.7.0_91 0 mvndep 0m 25s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 1m 46s the patch passed with JDK v1.8.0_66 +1 cc 1m 46s the patch passed +1 javac 1m 46s the patch passed +1 compile 2m 5s the patch passed with JDK v1.7.0_91 +1 cc 2m 5s the patch passed +1 javac 2m 5s the patch passed -1 checkstyle 0m 29s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 10s the patch passed +1 javadoc 1m 24s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 45s the patch passed with JDK v1.7.0_91 +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 64m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 178m 53s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782291/0008-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux f1c7cc26bee1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c8b80eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10284/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10284/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10284/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 58s Maven dependency ordering for branch
          +1 mvninstall 8m 22s trunk passed
          +1 compile 2m 10s trunk passed with JDK v1.8.0_66
          +1 compile 2m 22s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 43s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 4m 11s trunk passed
          +1 javadoc 1m 36s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 6s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 26s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 2m 6s the patch passed with JDK v1.8.0_66
          +1 cc 2m 6s the patch passed
          +1 javac 2m 6s the patch passed
          +1 compile 2m 17s the patch passed with JDK v1.7.0_91
          +1 cc 2m 17s the patch passed
          +1 javac 2m 17s the patch passed
          -1 checkstyle 0m 32s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166).
          +1 mvnsite 1m 37s the patch passed
          +1 mvneclipse 0m 35s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 39s the patch passed
          +1 javadoc 1m 43s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 11s the patch passed with JDK v1.7.0_91
          +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 62m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 63m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          179m 1s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMService
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782316/0009-YARN-4389.patch
          JIRA Issue YARN-4389
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 780b03c7fbf5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9d04f26
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10285/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10285/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 58s Maven dependency ordering for branch +1 mvninstall 8m 22s trunk passed +1 compile 2m 10s trunk passed with JDK v1.8.0_66 +1 compile 2m 22s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 4m 11s trunk passed +1 javadoc 1m 36s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 6s trunk passed with JDK v1.7.0_91 0 mvndep 0m 26s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 2m 6s the patch passed with JDK v1.8.0_66 +1 cc 2m 6s the patch passed +1 javac 2m 6s the patch passed +1 compile 2m 17s the patch passed with JDK v1.7.0_91 +1 cc 2m 17s the patch passed +1 javac 2m 17s the patch passed -1 checkstyle 0m 32s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 161, now 166). +1 mvnsite 1m 37s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 39s the patch passed +1 javadoc 1m 43s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 11s the patch passed with JDK v1.7.0_91 +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 62m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 63m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 179m 1s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMService JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782316/0009-YARN-4389.patch JIRA Issue YARN-4389 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 780b03c7fbf5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9d04f26 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10285/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10285/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10285/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Test case failures are unrelated.

          Show
          sunilg Sunil G added a comment - Test case failures are unrelated.
          Hide
          djp Junping Du added a comment -

          Agree that test failures are not related and there are already some other JIRAs (HADOOP-12687, etc.) to track similar test failures. 09 patch LGTM. Will wait for Rohith Sharma K S to see if more comments.

          Show
          djp Junping Du added a comment - Agree that test failures are not related and there are already some other JIRAs ( HADOOP-12687 , etc.) to track similar test failures. 09 patch LGTM. Will wait for Rohith Sharma K S to see if more comments.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Hi Sunil G/Junping Du , Overall patch looks good to me.

          I think I found one issue(was there earlier also), we can fix in this JIRA if agreed else we can raise new JIRA. I am fine with either of the ways. Please provide your thoughts.

          If cluster configured with global blacklistDisableFailureThreshold<0 OR blacklistDisableFailureThreshold > 1 by mistake, then also we need to reset to MINIMUM_THRESHOLD_VALUE or MAXIMUM_THRESHOLD_VALUE.
          Consider case where blacklistDisableFailureThreshold > 1 then SimpleBlacklistManager#getBlacklistUpdates will always go for blacklist addition. It never removes the nodes even though all the nodes in the cluster are blacklisted.

          Show
          rohithsharma Rohith Sharma K S added a comment - Hi Sunil G / Junping Du , Overall patch looks good to me. I think I found one issue(was there earlier also), we can fix in this JIRA if agreed else we can raise new JIRA. I am fine with either of the ways. Please provide your thoughts. If cluster configured with global blacklistDisableFailureThreshold<0 OR blacklistDisableFailureThreshold > 1 by mistake, then also we need to reset to MINIMUM_THRESHOLD_VALUE or MAXIMUM_THRESHOLD_VALUE. Consider case where blacklistDisableFailureThreshold > 1 then SimpleBlacklistManager#getBlacklistUpdates will always go for blacklist addition. It never removes the nodes even though all the nodes in the cluster are blacklisted.
          Hide
          sunilg Sunil G added a comment -

          Thanks Rohith Sharma K S,
          I think we can handle it here. let me upload a new patch by fixing this.

          Show
          sunilg Sunil G added a comment - Thanks Rohith Sharma K S , I think we can handle it here. let me upload a new patch by fixing this.
          Hide
          djp Junping Du added a comment -

          Hi Rohith Sharma K S, this is on my mind too when I raise my previous comments. However, in YARN-4576, we are talking about have a real global blacklist tracking rather than per app list. May be we can put a note there and track this later?

          Show
          djp Junping Du added a comment - Hi Rohith Sharma K S , this is on my mind too when I raise my previous comments. However, in YARN-4576 , we are talking about have a real global blacklist tracking rather than per app list. May be we can put a note there and track this later?
          Hide
          djp Junping Du added a comment -

          I think we can handle it here. let me upload a new patch by fixing this.

          Up to you. This code will be stale again when we have global blacklist instead of per app list.

          Show
          djp Junping Du added a comment - I think we can handle it here. let me upload a new patch by fixing this. Up to you. This code will be stale again when we have global blacklist instead of per app list.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          I am fine with adding note there. We need not to block this JIRA because of this.

          Show
          rohithsharma Rohith Sharma K S added a comment - I am fine with adding note there. We need not to block this JIRA because of this.
          Hide
          sunilg Sunil G added a comment -

          May be we can put a note there and track this later?

          I think YARN-4576 is full solution for this. After thinking abt this, I feel a note there is fine.
          +1 for current patch here 0009.

          Show
          sunilg Sunil G added a comment - May be we can put a note there and track this later? I think YARN-4576 is full solution for this. After thinking abt this, I feel a note there is fine. +1 for current patch here 0009.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Then I can commit this. Junping Du is it fine?

          Show
          rohithsharma Rohith Sharma K S added a comment - Then I can commit this. Junping Du is it fine?
          Hide
          djp Junping Du added a comment -

          I already put a NOTE on YARN-4576. +1 on 009 patch. Will commit the patch shortly if no further comments.

          Show
          djp Junping Du added a comment - I already put a NOTE on YARN-4576 . +1 on 009 patch. Will commit the patch shortly if no further comments.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Sure, +1 LGTM too.

          Show
          rohithsharma Rohith Sharma K S added a comment - Sure, +1 LGTM too.
          Hide
          djp Junping Du added a comment -

          Sure. Please go ahead to commit this, Rohith Sharma K S!

          Show
          djp Junping Du added a comment - Sure. Please go ahead to commit this, Rohith Sharma K S !
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Bit confusion!! I am committing shortly..

          Show
          rohithsharma Rohith Sharma K S added a comment - Bit confusion!! I am committing shortly..
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Sunil G I committed to trunk. Cheery-pick for branch-2 is failing. Could you provide patch for branch-2 and branch-2.8 please

          Show
          rohithsharma Rohith Sharma K S added a comment - Sunil G I committed to trunk. Cheery-pick for branch-2 is failing. Could you provide patch for branch-2 and branch-2.8 please
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9118 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9118/)
          YARN-4389. Allow application to enable or disable am blacklisting. (rohithsharmaks: rev f7736f464f068d2e46a454616b988b2dda345a13)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/AMBlackListingRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/AMBlackListingRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9118 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9118/ ) YARN-4389 . Allow application to enable or disable am blacklisting. (rohithsharmaks: rev f7736f464f068d2e46a454616b988b2dda345a13) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/AMBlackListingRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/AMBlackListingRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          Hide
          sunilg Sunil G added a comment -

          Sure Rohith Sharma K S, I will share in shortwhile.

          Show
          sunilg Sunil G added a comment - Sure Rohith Sharma K S , I will share in shortwhile.
          Hide
          sunilg Sunil G added a comment -

          Uploading branch-2 patch. Same patch will hold good for branch 2.8 also. Thank you Rohith Sharma K S and Junping Du for review and commit.! Really appreciate it.!!

          Show
          sunilg Sunil G added a comment - Uploading branch-2 patch. Same patch will hold good for branch 2.8 also. Thank you Rohith Sharma K S and Junping Du for review and commit.! Really appreciate it.!!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 4s YARN-4389 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782558/0009-YARN-4389-branch-2.patch
          JIRA Issue YARN-4389
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10303/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 4s YARN-4389 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782558/0009-YARN-4389-branch-2.patch JIRA Issue YARN-4389 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10303/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks Sunil G for providing patch to branch-2. Yes it is applying for branch-2.8 also.

          I committed to trunk/branch-2/branch-2.8.. thanks Sunil G for your contributions. thanks Junping Du for the review

          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks Sunil G for providing patch to branch-2. Yes it is applying for branch-2.8 also. I committed to trunk/branch-2/branch-2.8.. thanks Sunil G for your contributions. thanks Junping Du for the review

            People

            • Assignee:
              sunilg Sunil G
              Reporter:
              djp Junping Du
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development