Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4769

Add support for CSRF header in the dump capacity scheduler logs and kill app buttons in RM web UI

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      YARN-4737 adds support for CSRF filters in YARN. If the CSRF filter is enabled, the current functionality to dump the capacity scheduler logs and kill an app from the RM web UI will not work due to the missing CSRF header.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9571 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9571/)
        YARN-4769. Add support for CSRF header in the dump capacity scheduler (jianhe: rev 93bacda08bc546612f9278b31f5c38107867630a)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/RestCsrfPreventionFilter.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/AppBlock.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9571 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9571/ ) YARN-4769 . Add support for CSRF header in the dump capacity scheduler (jianhe: rev 93bacda08bc546612f9278b31f5c38107867630a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/RestCsrfPreventionFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/AppBlock.java
        Hide
        jianhe Jian He added a comment -

        Committed to trunk and branch-2, thanks Varun !

        Show
        jianhe Jian He added a comment - Committed to trunk and branch-2, thanks Varun !
        Hide
        vvasudev Varun Vasudev added a comment -

        Jian He - can you please review? Thanks!

        Show
        vvasudev Varun Vasudev added a comment - Jian He - can you please review? Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 55s Maven dependency ordering for branch
        +1 mvninstall 6m 45s trunk passed
        +1 compile 6m 14s trunk passed with JDK v1.8.0_77
        +1 compile 6m 46s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 5s trunk passed
        +1 mvnsite 1m 56s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        +1 findbugs 3m 18s trunk passed
        +1 javadoc 1m 32s trunk passed with JDK v1.8.0_77
        +1 javadoc 1m 53s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 1m 29s the patch passed
        +1 compile 6m 10s the patch passed with JDK v1.8.0_77
        +1 javac 6m 10s the patch passed
        +1 compile 6m 42s the patch passed with JDK v1.7.0_95
        +1 javac 6m 42s the patch passed
        -1 checkstyle 1m 5s root: patch generated 1 new + 91 unchanged - 1 fixed = 92 total (was 92)
        +1 mvnsite 1m 55s the patch passed
        +1 mvneclipse 0m 41s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 58s the patch passed
        +1 javadoc 1m 32s the patch passed with JDK v1.8.0_77
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
        +1 unit 7m 59s hadoop-common in the patch passed with JDK v1.8.0_77.
        +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_77.
        -1 unit 60m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
        +1 unit 8m 5s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 unit 0m 26s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95.
        -1 unit 62m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        198m 27s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestRMAdminService
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestRMAdminService
          hadoop.yarn.server.resourcemanager.TestClientRMTokens



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796889/YARN-4769.001.patch
        JIRA Issue YARN-4769
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 44a5e0d1c157 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 818d6b7
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10965/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10965/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 55s Maven dependency ordering for branch +1 mvninstall 6m 45s trunk passed +1 compile 6m 14s trunk passed with JDK v1.8.0_77 +1 compile 6m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 5s trunk passed +1 mvnsite 1m 56s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 3m 18s trunk passed +1 javadoc 1m 32s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 53s trunk passed with JDK v1.7.0_95 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 6m 10s the patch passed with JDK v1.8.0_77 +1 javac 6m 10s the patch passed +1 compile 6m 42s the patch passed with JDK v1.7.0_95 +1 javac 6m 42s the patch passed -1 checkstyle 1m 5s root: patch generated 1 new + 91 unchanged - 1 fixed = 92 total (was 92) +1 mvnsite 1m 55s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 58s the patch passed +1 javadoc 1m 32s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 +1 unit 7m 59s hadoop-common in the patch passed with JDK v1.8.0_77. +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_77. -1 unit 60m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 8m 5s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. -1 unit 62m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 198m 27s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796889/YARN-4769.001.patch JIRA Issue YARN-4769 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 44a5e0d1c157 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 818d6b7 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10965/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10965/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10965/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vvasudev Varun Vasudev added a comment -

        Uploaded a patch with the fix.

        Show
        vvasudev Varun Vasudev added a comment - Uploaded a patch with the fix.

          People

          • Assignee:
            vvasudev Varun Vasudev
            Reporter:
            vvasudev Varun Vasudev
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development