Details

      Description

      A CSRF filter was added to hadoop common (https://issues.apache.org/jira/browse/HADOOP-12691). The aim of this JIRA is to come up with a mechanism to integrate this filter into the webapps for which it is applicable (web apps that may establish an authenticated identity). That includes the RM, NM, and mapreduce jobhistory web app.

      1. YARN-4737.001.patch
        24 kB
        Jonathan Maron
      2. YARN-4737.002.patch
        28 kB
        Jonathan Maron
      3. YARN-4737.003.patch
        28 kB
        Jonathan Maron
      4. YARN-4737.004.patch
        36 kB
        Jonathan Maron

        Issue Links

          Activity

          Hide
          jmaron Jonathan Maron added a comment -

          Could this be reassigned to me (Jonathan Maron?

          Show
          jmaron Jonathan Maron added a comment - Could this be reassigned to me ( Jonathan Maron ?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Jonathan Maron added you to contributor and assigned ticket to you.

          Show
          leftnoteasy Wangda Tan added a comment - Jonathan Maron added you to contributor and assigned ticket to you.
          Hide
          jmaron Jonathan Maron added a comment -

          Thank you!

          Show
          jmaron Jonathan Maron added a comment - Thank you!
          Hide
          jmaron Jonathan Maron added a comment -

          The key elements of the uploaded patch:

          • Provides a CSRF enabling call to WebApps.Builder, taking the configuration prefix as an argument.
          • Adds the call to web apps currently capable of an SPNEGO authentication (and thus susceptible to CSRF) - RM, NM, and Job History
          • Defines the properties associated with configuration of the filter for these given web apps
          • Tests added based on TestRMWebServices (used the test as an example of client invocations of RM web endpoint)

          NOTE: Could use some assistance in ascertaining whether web apps currently have javascript invocations of the exposed REST services. Those calls will fail if CSRF is enabled.

          Show
          jmaron Jonathan Maron added a comment - The key elements of the uploaded patch: Provides a CSRF enabling call to WebApps.Builder, taking the configuration prefix as an argument. Adds the call to web apps currently capable of an SPNEGO authentication (and thus susceptible to CSRF) - RM, NM, and Job History Defines the properties associated with configuration of the filter for these given web apps Tests added based on TestRMWebServices (used the test as an example of client invocations of RM web endpoint) NOTE: Could use some assistance in ascertaining whether web apps currently have javascript invocations of the exposed REST services. Those calls will fail if CSRF is enabled.
          Hide
          vvasudev Varun Vasudev added a comment - - edited

          Jonathan Maron - to my knowledge the only web UI that uses the web services call via javascript is the Tez UI. There is a branch to change the RM UI to use javascript and web services as well.

          However, all of these should be using GET calls only so I suspect they won't be affected by this change.

          Show
          vvasudev Varun Vasudev added a comment - - edited Jonathan Maron - to my knowledge the only web UI that uses the web services call via javascript is the Tez UI. There is a branch to change the RM UI to use javascript and web services as well. However, all of these should be using GET calls only so I suspect they won't be affected by this change.
          Hide
          jmaron Jonathan Maron added a comment -

          Initial patch

          Show
          jmaron Jonathan Maron added a comment - Initial patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 6m 0s trunk passed with JDK v1.8.0_72
          +1 compile 6m 47s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 3m 22s trunk passed
          +1 mvneclipse 1m 35s trunk passed
          +1 findbugs 6m 40s trunk passed
          +1 javadoc 2m 45s trunk passed with JDK v1.8.0_72
          +1 javadoc 5m 23s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 2m 52s the patch passed
          +1 compile 6m 1s the patch passed with JDK v1.8.0_72
          +1 javac 6m 1s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          -1 checkstyle 1m 8s root: patch generated 3 new + 387 unchanged - 0 fixed = 390 total (was 387)
          +1 mvnsite 3m 22s the patch passed
          +1 mvneclipse 1m 36s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 8m 2s the patch passed
          +1 javadoc 2m 38s the patch passed with JDK v1.8.0_72
          -1 javadoc 9m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 5m 22s the patch passed with JDK v1.7.0_95
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          -1 unit 9m 1s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72.
          -1 unit 71m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 55s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 41s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72.
          +1 unit 5m 32s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 unit 9m 44s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          -1 unit 75m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 2m 31s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 53s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95.
          +1 unit 6m 11s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 26s Patch generated 14 ASF License warnings.
          269m 44s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790751/YARN-4737.001.patch
          JIRA Issue YARN-4737
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux c9cfd039e3f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 44d9bac
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10678/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10678/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 6m 0s trunk passed with JDK v1.8.0_72 +1 compile 6m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 8s trunk passed +1 mvnsite 3m 22s trunk passed +1 mvneclipse 1m 35s trunk passed +1 findbugs 6m 40s trunk passed +1 javadoc 2m 45s trunk passed with JDK v1.8.0_72 +1 javadoc 5m 23s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 2m 52s the patch passed +1 compile 6m 1s the patch passed with JDK v1.8.0_72 +1 javac 6m 1s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed -1 checkstyle 1m 8s root: patch generated 3 new + 387 unchanged - 0 fixed = 390 total (was 387) +1 mvnsite 3m 22s the patch passed +1 mvneclipse 1m 36s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 8m 2s the patch passed +1 javadoc 2m 38s the patch passed with JDK v1.8.0_72 -1 javadoc 9m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 5m 22s the patch passed with JDK v1.7.0_95 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_72. +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. -1 unit 9m 1s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72. -1 unit 71m 6s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. +1 unit 1m 55s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_72. +1 unit 0m 41s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72. +1 unit 5m 32s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 44s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. -1 unit 75m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 2m 31s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 unit 0m 53s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95. +1 unit 6m 11s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 26s Patch generated 14 ASF License warnings. 269m 44s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790751/YARN-4737.001.patch JIRA Issue YARN-4737 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c9cfd039e3f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 44d9bac Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/diff-checkstyle-root.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10678/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10678/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10678/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment - - edited

          Thanks for the patch Jonathan Maron.

          1) Can you please address the checkstyle, javadoc, and ASF license warnings in the pre-commit build?

          2) Rename "yarn.resourcemanager.rest-csrf.*" to "yarn.resourcemanager.webapp.rest-csrf.*". Similar changes for nodemanager and JHS as well. I also noticed that you haven't added CSRF protection for the ATS. Is that going to be done in a follow up patch?

          3) Currently the CSRF protection is enabled by

          +        if (hasSpnegoConf && hasCSRFEnabled(params)) {
          +          String restCsrfClassName = RestCsrfPreventionFilter.class.getName();
          +          HttpServer2.defineFilter(server.getWebAppContext(), restCsrfClassName,
          +                                   restCsrfClassName, params, new String[] {"/*"});
          +        }
          

          which means that users with custom web auth cannot use the filter. Can we remove the hasSpnegoConf check?

          Show
          vvasudev Varun Vasudev added a comment - - edited Thanks for the patch Jonathan Maron . 1) Can you please address the checkstyle, javadoc, and ASF license warnings in the pre-commit build? 2) Rename "yarn.resourcemanager.rest-csrf.*" to "yarn.resourcemanager.webapp.rest-csrf.*". Similar changes for nodemanager and JHS as well. I also noticed that you haven't added CSRF protection for the ATS. Is that going to be done in a follow up patch? 3) Currently the CSRF protection is enabled by + if (hasSpnegoConf && hasCSRFEnabled(params)) { + String restCsrfClassName = RestCsrfPreventionFilter.class.getName(); + HttpServer2.defineFilter(server.getWebAppContext(), restCsrfClassName, + restCsrfClassName, params, new String [] { "/*" }); + } which means that users with custom web auth cannot use the filter. Can we remove the hasSpnegoConf check?
          Hide
          jmaron Jonathan Maron added a comment -

          1) Will do
          2) will perform renaming. As for the ATS - the only three web apps instances I identified that have an authentication mechanism enabled were the three I modified. Is the ATS leveraging another auth mechanism (or not using WebApps to construct the endpoint)?
          3) The CSRF protection doesn't make sense in the context of not auth mechanism, and the only auth mechanism I see enabled with WebApps in SPNEGO? Is there another auth mechanism that can be enabled independent of API calls to WebApps.Builder?

          Show
          jmaron Jonathan Maron added a comment - 1) Will do 2) will perform renaming. As for the ATS - the only three web apps instances I identified that have an authentication mechanism enabled were the three I modified. Is the ATS leveraging another auth mechanism (or not using WebApps to construct the endpoint)? 3) The CSRF protection doesn't make sense in the context of not auth mechanism, and the only auth mechanism I see enabled with WebApps in SPNEGO? Is there another auth mechanism that can be enabled independent of API calls to WebApps.Builder?
          Hide
          vvasudev Varun Vasudev added a comment -

          Is the ATS leveraging another auth mechanism (or not using WebApps to construct the endpoint)?

          I took a look and it looks like the ATS doesn't use WebApps.Builder. Can you take a look at the startWebApp function in ApplicationHistoryServer.java? It handles the server setup. The impact of enabling CSRF on the ATS will have to evaluated though - the RM and the Tez AM write to it via POST requests.

          Is there another auth mechanism that can be enabled independent of API calls to WebApps.Builder?

          Admins can setup custom web authentication filters. You can look at http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/HttpAuthentication.html for more details. What's the impact of enabling csrf with no authentication?

          Show
          vvasudev Varun Vasudev added a comment - Is the ATS leveraging another auth mechanism (or not using WebApps to construct the endpoint)? I took a look and it looks like the ATS doesn't use WebApps.Builder. Can you take a look at the startWebApp function in ApplicationHistoryServer.java? It handles the server setup. The impact of enabling CSRF on the ATS will have to evaluated though - the RM and the Tez AM write to it via POST requests. Is there another auth mechanism that can be enabled independent of API calls to WebApps.Builder? Admins can setup custom web authentication filters. You can look at http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/HttpAuthentication.html for more details. What's the impact of enabling csrf with no authentication?
          Hide
          jmaron Jonathan Maron added a comment -

          Enabling CSRF w/o auth will require the inclusion of the custom header for all invocations, regardless of whether they are secure invocations or not. I don't believe that is the expected usage model for the filter.

          As far as identifying auth mechanisms - I'm trying to find instances that would show the use of custom auth filters but I'm not really finding any. One theory I have is that looking up a value other than "Simple" for "hadoop.http.authentication.type" might provide a more general indicator of auth being enabled? Does that seem correct?

          POST requests from java clients should not be an issue - the filter only executes when a browser user agent is detected.

          BTW, the license issues (asflicense) don't appear even remotely related to this patch.

          Show
          jmaron Jonathan Maron added a comment - Enabling CSRF w/o auth will require the inclusion of the custom header for all invocations, regardless of whether they are secure invocations or not. I don't believe that is the expected usage model for the filter. As far as identifying auth mechanisms - I'm trying to find instances that would show the use of custom auth filters but I'm not really finding any. One theory I have is that looking up a value other than "Simple" for "hadoop.http.authentication.type" might provide a more general indicator of auth being enabled? Does that seem correct? POST requests from java clients should not be an issue - the filter only executes when a browser user agent is detected. BTW, the license issues (asflicense) don't appear even remotely related to this patch.
          Hide
          jmaron Jonathan Maron added a comment -

          I believe all code issues have been addressed

          Show
          jmaron Jonathan Maron added a comment - I believe all code issues have been addressed
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 5m 53s trunk passed with JDK v1.8.0_72
          +1 compile 6m 51s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 3m 48s trunk passed
          +1 mvneclipse 1m 48s trunk passed
          +1 findbugs 7m 9s trunk passed
          +1 javadoc 2m 59s trunk passed with JDK v1.8.0_72
          +1 javadoc 5m 41s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 3m 10s the patch passed
          +1 compile 6m 12s the patch passed with JDK v1.8.0_72
          +1 javac 6m 12s the patch passed
          +1 compile 6m 52s the patch passed with JDK v1.7.0_95
          +1 javac 6m 52s the patch passed
          -1 checkstyle 1m 8s root: patch generated 2 new + 436 unchanged - 4 fixed = 438 total (was 440)
          +1 mvnsite 3m 46s the patch passed
          +1 mvneclipse 1m 50s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 8m 50s the patch passed
          +1 javadoc 2m 55s the patch passed with JDK v1.8.0_72
          +1 javadoc 5m 34s the patch passed with JDK v1.7.0_95
          +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 9m 18s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
          +1 unit 3m 47s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72.
          -1 unit 71m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 43s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72.
          +1 unit 5m 35s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 unit 9m 41s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 unit 3m 52s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95.
          -1 unit 72m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          -1 unit 2m 15s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95.
          +1 unit 5m 56s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 22s Patch generated 14 ASF License warnings.
          277m 49s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.tools.TestCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791028/YARN-4737.002.patch
          JIRA Issue YARN-4737
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 39c7c72ff339 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 67880cc
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10690/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10690/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 5m 53s trunk passed with JDK v1.8.0_72 +1 compile 6m 51s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 3m 48s trunk passed +1 mvneclipse 1m 48s trunk passed +1 findbugs 7m 9s trunk passed +1 javadoc 2m 59s trunk passed with JDK v1.8.0_72 +1 javadoc 5m 41s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 10s the patch passed +1 compile 6m 12s the patch passed with JDK v1.8.0_72 +1 javac 6m 12s the patch passed +1 compile 6m 52s the patch passed with JDK v1.7.0_95 +1 javac 6m 52s the patch passed -1 checkstyle 1m 8s root: patch generated 2 new + 436 unchanged - 4 fixed = 438 total (was 440) +1 mvnsite 3m 46s the patch passed +1 mvneclipse 1m 50s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 8m 50s the patch passed +1 javadoc 2m 55s the patch passed with JDK v1.8.0_72 +1 javadoc 5m 34s the patch passed with JDK v1.7.0_95 +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_72. +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 9m 18s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 3m 47s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72. -1 unit 71m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_72. +1 unit 0m 43s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72. +1 unit 5m 35s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 41s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 unit 3m 52s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95. -1 unit 72m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. -1 unit 2m 15s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95. +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95. +1 unit 5m 56s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 14 ASF License warnings. 277m 49s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791028/YARN-4737.002.patch JIRA Issue YARN-4737 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 39c7c72ff339 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 67880cc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10690/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10690/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10690/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the updated patch Jon. Some more fixes required -

          1) In WebApps.java -

          +        Map<String, String> params = getCsrfConfigParameters();
          +        if (hasCSRFEnabled(params)) {
          +          LOG.info("CSRF Protection has been enabled for the {} application. "
          +                  + "Please ensure that there is an authentication mechanism "
          +                  + "enabled (kerberos, custom, etc).",
          +              name);
          +          String restCsrfClassName = RestCsrfPreventionFilter.class.getName();
          +          HttpServer2.defineFilter(server.getWebAppContext(), restCsrfClassName,
          +              restCsrfClassName, params,
          +              new String[] {"/*"});
          +        }
          

          should be before

                   HttpServer2.defineFilter(server.getWebAppContext(), "guice",
                     GuiceFilter.class.getName(), null, new String[] { "/*" });
          

          The guice filter redirects the request to the appropriate handler and the requests get executed before going through the CSRF filter.

          2) The JHS configs in mapred-default.xml start with the prefix - mapreduce.jobhistory.webapp but the prefix used in code is mapreduce.jobhistory (no webapp) - I think you need to create a mapreduce.jobhistory.webapp prefix in the code.

          3) In yarn-default.xml, all the timeline service configs have an extra "." in them after "yarn.timeline-service". e.g. yarn.timeline-service..webapp.rest-csrf.methods-to-ignore

          The failing tests and ASF warnings are unrelated to the patch.

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the updated patch Jon. Some more fixes required - 1) In WebApps.java - + Map< String , String > params = getCsrfConfigParameters(); + if (hasCSRFEnabled(params)) { + LOG.info( "CSRF Protection has been enabled for the {} application. " + + "Please ensure that there is an authentication mechanism " + + "enabled (kerberos, custom, etc)." , + name); + String restCsrfClassName = RestCsrfPreventionFilter.class.getName(); + HttpServer2.defineFilter(server.getWebAppContext(), restCsrfClassName, + restCsrfClassName, params, + new String [] { "/*" }); + } should be before HttpServer2.defineFilter(server.getWebAppContext(), "guice" , GuiceFilter.class.getName(), null , new String [] { "/*" }); The guice filter redirects the request to the appropriate handler and the requests get executed before going through the CSRF filter. 2) The JHS configs in mapred-default.xml start with the prefix - mapreduce.jobhistory.webapp but the prefix used in code is mapreduce.jobhistory (no webapp) - I think you need to create a mapreduce.jobhistory.webapp prefix in the code. 3) In yarn-default.xml, all the timeline service configs have an extra "." in them after "yarn.timeline-service". e.g. yarn.timeline-service..webapp.rest-csrf.methods-to-ignore The failing tests and ASF warnings are unrelated to the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 5s Maven dependency ordering for branch
          +1 mvninstall 7m 6s trunk passed
          +1 compile 5m 52s trunk passed with JDK v1.8.0_72
          +1 compile 6m 47s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 3m 59s trunk passed
          +1 mvneclipse 1m 52s trunk passed
          +1 findbugs 7m 22s trunk passed
          +1 javadoc 3m 3s trunk passed with JDK v1.8.0_72
          +1 javadoc 5m 53s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 3m 12s the patch passed
          +1 compile 6m 4s the patch passed with JDK v1.8.0_72
          +1 javac 6m 4s the patch passed
          +1 compile 7m 0s the patch passed with JDK v1.7.0_95
          +1 javac 7m 0s the patch passed
          -1 checkstyle 1m 16s root: patch generated 5 new + 431 unchanged - 9 fixed = 436 total (was 440)
          +1 mvnsite 4m 1s the patch passed
          +1 mvneclipse 1m 57s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 9m 14s the patch passed
          +1 javadoc 3m 6s the patch passed with JDK v1.8.0_72
          +1 javadoc 5m 53s the patch passed with JDK v1.7.0_95
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 9m 16s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
          +1 unit 3m 41s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72.
          -1 unit 71m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
          -1 unit 1m 59s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72.
          +1 unit 0m 42s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72.
          +1 unit 5m 38s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 unit 9m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 unit 3m 53s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95.
          -1 unit 72m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 2m 23s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 49s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95.
          +1 unit 5m 57s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 22s Patch generated 14 ASF License warnings.
          282m 5s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.tools.TestCLI
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791178/YARN-4737.003.patch
          JIRA Issue YARN-4737
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d74a3782006a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0a9f00a
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10695/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10695/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 5s Maven dependency ordering for branch +1 mvninstall 7m 6s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_72 +1 compile 6m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 10s trunk passed +1 mvnsite 3m 59s trunk passed +1 mvneclipse 1m 52s trunk passed +1 findbugs 7m 22s trunk passed +1 javadoc 3m 3s trunk passed with JDK v1.8.0_72 +1 javadoc 5m 53s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 3m 12s the patch passed +1 compile 6m 4s the patch passed with JDK v1.8.0_72 +1 javac 6m 4s the patch passed +1 compile 7m 0s the patch passed with JDK v1.7.0_95 +1 javac 7m 0s the patch passed -1 checkstyle 1m 16s root: patch generated 5 new + 431 unchanged - 9 fixed = 436 total (was 440) +1 mvnsite 4m 1s the patch passed +1 mvneclipse 1m 57s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 9m 14s the patch passed +1 javadoc 3m 6s the patch passed with JDK v1.8.0_72 +1 javadoc 5m 53s the patch passed with JDK v1.7.0_95 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_72. +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 9m 16s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 3m 41s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72. -1 unit 71m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. -1 unit 1m 59s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72. +1 unit 0m 42s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72. +1 unit 5m 38s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 unit 3m 53s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95. -1 unit 72m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 2m 23s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 unit 0m 49s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95. +1 unit 5m 57s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 14 ASF License warnings. 282m 5s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.tools.TestCLI JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791178/YARN-4737.003.patch JIRA Issue YARN-4737 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d74a3782006a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a9f00a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10695/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10695/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10695/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 41s trunk passed
          +1 compile 5m 58s trunk passed with JDK v1.8.0_72
          +1 compile 6m 32s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 3m 47s trunk passed
          +1 mvneclipse 1m 40s trunk passed
          +1 findbugs 7m 9s trunk passed
          +1 javadoc 3m 22s trunk passed with JDK v1.8.0_72
          +1 javadoc 5m 38s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 3m 4s the patch passed
          +1 compile 5m 35s the patch passed with JDK v1.8.0_72
          +1 javac 5m 35s the patch passed
          +1 compile 6m 29s the patch passed with JDK v1.7.0_95
          +1 javac 6m 29s the patch passed
          -1 checkstyle 1m 8s root: patch generated 5 new + 390 unchanged - 50 fixed = 395 total (was 440)
          +1 mvnsite 3m 42s the patch passed
          +1 mvneclipse 1m 46s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 8m 44s the patch passed
          +1 javadoc 3m 0s the patch passed with JDK v1.8.0_72
          +1 javadoc 5m 42s the patch passed with JDK v1.7.0_95
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 9m 14s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72.
          -1 unit 66m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
          -1 unit 2m 6s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72.
          +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72.
          +1 unit 5m 57s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 9m 49s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 3m 25s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95.
          -1 unit 69m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 2m 24s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 51s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95.
          +1 unit 6m 0s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 24s Patch generated 14 ASF License warnings.
          269m 30s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.tools.TestCLI
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791256/YARN-4737.004.patch
          JIRA Issue YARN-4737
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d5c5511e9934 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0a9f00a
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10703/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10703/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 41s trunk passed +1 compile 5m 58s trunk passed with JDK v1.8.0_72 +1 compile 6m 32s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 3m 47s trunk passed +1 mvneclipse 1m 40s trunk passed +1 findbugs 7m 9s trunk passed +1 javadoc 3m 22s trunk passed with JDK v1.8.0_72 +1 javadoc 5m 38s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 3m 4s the patch passed +1 compile 5m 35s the patch passed with JDK v1.8.0_72 +1 javac 5m 35s the patch passed +1 compile 6m 29s the patch passed with JDK v1.7.0_95 +1 javac 6m 29s the patch passed -1 checkstyle 1m 8s root: patch generated 5 new + 390 unchanged - 50 fixed = 395 total (was 440) +1 mvnsite 3m 42s the patch passed +1 mvneclipse 1m 46s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 8m 44s the patch passed +1 javadoc 3m 0s the patch passed with JDK v1.8.0_72 +1 javadoc 5m 42s the patch passed with JDK v1.7.0_95 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_72. +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 9m 14s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72. -1 unit 66m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. -1 unit 2m 6s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72. +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_72. +1 unit 5m 57s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_72. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 9m 49s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 unit 3m 25s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95. -1 unit 69m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 2m 24s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 unit 0m 51s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95. +1 unit 6m 0s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 24s Patch generated 14 ASF License warnings. 269m 30s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.tools.TestCLI JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791256/YARN-4737.004.patch JIRA Issue YARN-4737 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d5c5511e9934 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a9f00a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10703/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10703/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10703/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the updated patch Jon! You don't need to fix all the checkstyle warnings for the ApplicationHistoryClientService. Only the ones that were caused by your patch.

          +1 for YARN-4737.003.patch. I'll commit it on Monday if no one objects.

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the updated patch Jon! You don't need to fix all the checkstyle warnings for the ApplicationHistoryClientService. Only the ones that were caused by your patch. +1 for YARN-4737 .003.patch. I'll commit it on Monday if no one objects.
          Hide
          vvasudev Varun Vasudev added a comment -

          Committed to trunk and branch-2. Thanks Jonathan Maron!

          Show
          vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks Jonathan Maron !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9431 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9431/)
          YARN-4737. Add CSRF filter support in YARN. Contributed by Jonathan (vvasudev: rev e51a8c10560e5db5cf01fd530af48825cb51c9ea)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/HistoryClientService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/jobhistory/JHAdminConfig.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/webapp/TestRMWithCSRFFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9431 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9431/ ) YARN-4737 . Add CSRF filter support in YARN. Contributed by Jonathan (vvasudev: rev e51a8c10560e5db5cf01fd530af48825cb51c9ea) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/HistoryClientService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/jobhistory/JHAdminConfig.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/webapp/TestRMWithCSRFFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml

            People

            • Assignee:
              jmaron Jonathan Maron
              Reporter:
              jmaron Jonathan Maron
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development