Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      varun_saxena Varun Saxena added a comment -

      Simple fix. Moved data generation to a separate utility class, split tests for entity and application table.

      Show
      varun_saxena Varun Saxena added a comment - Simple fix. Moved data generation to a separate utility class, split tests for entity and application table.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 15s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 11m 3s YARN-5355 passed
      +1 compile 0m 17s YARN-5355 passed
      +1 checkstyle 0m 16s YARN-5355 passed
      +1 mvnsite 0m 25s YARN-5355 passed
      +1 mvneclipse 0m 19s YARN-5355 passed
      +1 findbugs 0m 33s YARN-5355 passed
      +1 javadoc 0m 12s YARN-5355 passed
      +1 mvninstall 0m 20s the patch passed
      +1 compile 0m 16s the patch passed
      +1 javac 0m 16s the patch passed
      -1 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests: The patch generated 6 new + 3 unchanged - 4 fixed = 9 total (was 7)
      +1 mvnsite 0m 23s the patch passed
      +1 mvneclipse 0m 13s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 0m 40s the patch passed
      +1 javadoc 0m 9s the patch passed
      +1 unit 4m 49s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
      +1 asflicense 0m 17s The patch does not generate ASF License warnings.
      21m 19s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:9560f25
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822634/YARN-4765-YARN-5355.01.patch
      JIRA Issue YARN-4765
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux e135e2facf39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-5355 / 5d7ad39
      Default Java 1.8.0_101
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12676/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12676/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/12676/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 11m 3s YARN-5355 passed +1 compile 0m 17s YARN-5355 passed +1 checkstyle 0m 16s YARN-5355 passed +1 mvnsite 0m 25s YARN-5355 passed +1 mvneclipse 0m 19s YARN-5355 passed +1 findbugs 0m 33s YARN-5355 passed +1 javadoc 0m 12s YARN-5355 passed +1 mvninstall 0m 20s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -1 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests: The patch generated 6 new + 3 unchanged - 4 fixed = 9 total (was 7) +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 40s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 4m 49s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 21m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822634/YARN-4765-YARN-5355.01.patch JIRA Issue YARN-4765 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e135e2facf39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5355 / 5d7ad39 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12676/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12676/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests Console output https://builds.apache.org/job/PreCommit-YARN-Build/12676/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      varun_saxena Varun Saxena added a comment -

      Checkstyle related and can be fixed.

      Show
      varun_saxena Varun Saxena added a comment - Checkstyle related and can be fixed.
      Hide
      jrottinghuis Joep Rottinghuis added a comment -

      Looks good to me.
      One thing I'm wondering is if you're splitting the tests into apps and entities, why not also split the DataGeneratorForTest into the two separate parts? #loadApps and #loadEntities don't really have anything in common do they?
      This isn't a strong requirement imho, either one is fine (given that is is one giant class at the moment).

      Show
      jrottinghuis Joep Rottinghuis added a comment - Looks good to me. One thing I'm wondering is if you're splitting the tests into apps and entities, why not also split the DataGeneratorForTest into the two separate parts? #loadApps and #loadEntities don't really have anything in common do they? This isn't a strong requirement imho, either one is fine (given that is is one giant class at the moment).
      Hide
      jrottinghuis Joep Rottinghuis added a comment -

      Patch still applies cleanly. We have lots of other things to look at, so I suggest we leave DataGeneratorForTest as one class for now and let the patch stay as-is.
      Vrushali C please proceed and commit to the YARN-5355 branch YARN-5355-branch-2

      Show
      jrottinghuis Joep Rottinghuis added a comment - Patch still applies cleanly. We have lots of other things to look at, so I suggest we leave DataGeneratorForTest as one class for now and let the patch stay as-is. Vrushali C please proceed and commit to the YARN-5355 branch YARN-5355 -branch-2
      Hide
      varun_saxena Varun Saxena added a comment -

      Regarding checkstyle issue, IIRC it was about the length of test methods being more than 150 lines.
      I had attempted and it is hard to break it up. So lets leave that as-is.

      Maybe re-invoke Jenkins to see what comes up.

      Show
      varun_saxena Varun Saxena added a comment - Regarding checkstyle issue, IIRC it was about the length of test methods being more than 150 lines. I had attempted and it is hard to break it up. So lets leave that as-is. Maybe re-invoke Jenkins to see what comes up.
      Hide
      vrushalic Vrushali C added a comment -

      Sounds good, will commit it in shortly.

      Show
      vrushalic Vrushali C added a comment - Sounds good, will commit it in shortly.
      Hide
      hadoopqa Hadoop QA added a comment -
      +1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 13s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 16m 26s YARN-5355 passed
      +1 compile 0m 17s YARN-5355 passed
      +1 checkstyle 0m 14s YARN-5355 passed
      +1 mvnsite 0m 25s YARN-5355 passed
      +1 mvneclipse 0m 16s YARN-5355 passed
      +1 findbugs 0m 30s YARN-5355 passed
      +1 javadoc 0m 11s YARN-5355 passed
      +1 mvninstall 0m 17s the patch passed
      +1 compile 0m 16s the patch passed
      +1 javac 0m 16s the patch passed
      -0 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests: The patch generated 6 new + 3 unchanged - 4 fixed = 9 total (was 7)
      +1 mvnsite 0m 20s the patch passed
      +1 mvneclipse 0m 14s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 0m 35s the patch passed
      +1 javadoc 0m 7s the patch passed
      +1 unit 5m 23s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
      +1 asflicense 0m 16s The patch does not generate ASF License warnings.
      27m 33s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:9560f25
      JIRA Issue YARN-4765
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822634/YARN-4765-YARN-5355.01.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 8323b33c8987 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-5355 / d1e04e9
      Default Java 1.8.0_101
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13579/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13579/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/13579/console
      Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 16m 26s YARN-5355 passed +1 compile 0m 17s YARN-5355 passed +1 checkstyle 0m 14s YARN-5355 passed +1 mvnsite 0m 25s YARN-5355 passed +1 mvneclipse 0m 16s YARN-5355 passed +1 findbugs 0m 30s YARN-5355 passed +1 javadoc 0m 11s YARN-5355 passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -0 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests: The patch generated 6 new + 3 unchanged - 4 fixed = 9 total (was 7) +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 7s the patch passed +1 unit 5m 23s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 27m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4765 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822634/YARN-4765-YARN-5355.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8323b33c8987 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-5355 / d1e04e9 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13579/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13579/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests Console output https://builds.apache.org/job/PreCommit-YARN-Build/13579/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      vrushalic Vrushali C added a comment -

      Most of the checkstyle warnings are about method lengths but there is one about javadoc. I will try to fix that as I commit the patch.

      Show
      vrushalic Vrushali C added a comment - Most of the checkstyle warnings are about method lengths but there is one about javadoc. I will try to fix that as I commit the patch.
      Hide
      vrushalic Vrushali C added a comment -

      Committed to YARN-5355.

      commit 513dcf6817dd76fde8096ff04cd888d7c908461d
      Author: Vrushali Channapattan <vrushali@apache.org>
      Date:   Thu Oct 27 14:37:50 2016 -0700
      
          YARN-4765 Split TestHBaseTimelineStorage into multiple test classes (Varun Saxena via Vrushali C)
      
      

      Sangjin Lee will most likely commit this to trunk.

      Show
      vrushalic Vrushali C added a comment - Committed to YARN-5355 . commit 513dcf6817dd76fde8096ff04cd888d7c908461d Author: Vrushali Channapattan <vrushali@apache.org> Date: Thu Oct 27 14:37:50 2016 -0700 YARN-4765 Split TestHBaseTimelineStorage into multiple test classes (Varun Saxena via Vrushali C) Sangjin Lee will most likely commit this to trunk.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10712/)
      YARN-4765 Split TestHBaseTimelineStorage into multiple test classes (sjlee: rev 022bf783aa89c1c81374ebef5dba2df95b7563b5)

      • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorage.java
      • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageEntities.java
      • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageApps.java
      • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/DataGeneratorForTest.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10712/ ) YARN-4765 Split TestHBaseTimelineStorage into multiple test classes (sjlee: rev 022bf783aa89c1c81374ebef5dba2df95b7563b5) (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorage.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageEntities.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageApps.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/DataGeneratorForTest.java
      Hide
      varun_saxena Varun Saxena added a comment -

      Changing JIRA to resolved as it has been committed to trunk, YARN-5355 branch

      Show
      varun_saxena Varun Saxena added a comment - Changing JIRA to resolved as it has been committed to trunk, YARN-5355 branch

        People

        • Assignee:
          varun_saxena Varun Saxena
          Reporter:
          varun_saxena Varun Saxena
        • Votes:
          0 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development