Changing JIRA to resolved as it has been committed to trunk, YARN-5355 branch
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10712/)
YARN-4765 Split TestHBaseTimelineStorage into multiple test classes (sjlee: rev 022bf783aa89c1c81374ebef5dba2df95b7563b5)
Committed to YARN-5355.
Author: Vrushali Channapattan <email@example.com>
Date: Thu Oct 27 14:37:50 2016 -0700
YARN-4765 Split TestHBaseTimelineStorage into multiple test classes (Varun Saxena via Vrushali C)
Sangjin Lee will most likely commit this to trunk.
Most of the checkstyle warnings are about method lengths but there is one about javadoc. I will try to fix that as I commit the patch.
This message was automatically generated.
Sounds good, will commit it in shortly.
Regarding checkstyle issue, IIRC it was about the length of test methods being more than 150 lines.
I had attempted and it is hard to break it up. So lets leave that as-is.
Maybe re-invoke Jenkins to see what comes up.
Patch still applies cleanly. We have lots of other things to look at, so I suggest we leave DataGeneratorForTest as one class for now and let the patch stay as-is.
Vrushali C please proceed and commit to the YARN-5355 branch YARN-5355-branch-2
Looks good to me.
One thing I'm wondering is if you're splitting the tests into apps and entities, why not also split the DataGeneratorForTest into the two separate parts? #loadApps and #loadEntities don't really have anything in common do they?
This isn't a strong requirement imho, either one is fine (given that is is one giant class at the moment).
Checkstyle related and can be fixed.
Simple fix. Moved data generation to a separate utility class, split tests for entity and application table.