Details

    • Hadoop Flags:
      Reviewed

      Description

      This jira is similar to MAPREDUCE-6626, we can see detail info about this problem.

      1. YARN-4668.001.patch
        1 kB
        Yiqun Lin
      2. YARN-4668.002_1.patch
        2 kB
        Li Lu
      3. YARN-4668.002.patch
        2 kB
        Yiqun Lin

        Issue Links

          Activity

          Hide
          linyiqun Yiqun Lin added a comment -

          Attach a initial patch, kindly review.

          Show
          linyiqun Yiqun Lin added a comment - Attach a initial patch, kindly review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 compile 0m 24s trunk passed with JDK v1.8.0_66
          +1 compile 0m 25s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 31s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 15s trunk passed
          +1 javadoc 0m 27s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 39s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 6s Maven dependency ordering for patch
          +1 mvninstall 0m 27s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.8.0_66
          +1 javac 0m 21s the patch passed
          +1 compile 0m 24s the patch passed with JDK v1.7.0_91
          +1 javac 0m 24s the patch passed
          -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 37s the patch passed
          +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 37s the patch passed with JDK v1.7.0_91
          +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          21m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785950/YARN-4668.001.patch
          JIRA Issue YARN-4668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 34ae6b1a6422 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10478/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10478/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10478/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 0m 24s trunk passed with JDK v1.8.0_66 +1 compile 0m 25s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 15s trunk passed +1 javadoc 0m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 39s trunk passed with JDK v1.7.0_91 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 0m 27s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_66 +1 javac 0m 21s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_91 +1 javac 0m 24s the patch passed -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19) +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 37s the patch passed with JDK v1.7.0_91 +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 21m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785950/YARN-4668.001.patch JIRA Issue YARN-4668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 34ae6b1a6422 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10478/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10478/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10478/console This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Fix checkstyle errors.

          Show
          linyiqun Yiqun Lin added a comment - Fix checkstyle errors.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 7m 5s trunk passed
          +1 compile 0m 26s trunk passed with JDK v1.8.0_66
          +1 compile 0m 28s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 27s trunk passed
          +1 javadoc 0m 32s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 35s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 29s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_66
          +1 javac 0m 23s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.7.0_91
          +1 javac 0m 28s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 32s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 37s the patch passed
          +1 javadoc 0m 30s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_91
          +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          22m 47s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785957/YARN-4668.002.patch
          JIRA Issue YARN-4668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ee4b5673d406 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10479/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10479/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 5s trunk passed +1 compile 0m 26s trunk passed with JDK v1.8.0_66 +1 compile 0m 28s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 32s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 35s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 29s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_66 +1 javac 0m 23s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_91 +1 javac 0m 28s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 30s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_91 +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 22m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785957/YARN-4668.002.patch JIRA Issue YARN-4668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ee4b5673d406 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10479/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10479/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the patch, Yiqun Lin! Apologies in the delay for review.

          Patch looks good to me, but it no longer applies. Could you please rebase it?

          Show
          jlowe Jason Lowe added a comment - Thanks for the patch, Yiqun Lin ! Apologies in the delay for review. Patch looks good to me, but it no longer applies. Could you please rebase it?
          Hide
          gtCarrera9 Li Lu added a comment -

          Patch LGTM, but it no longer applies to the current trunk. I'll try to tweak it so that it applies.

          I'd like to +1 for the patch. If there are other concerns please feel free to let me know. Will put this patch in soon.

          Show
          gtCarrera9 Li Lu added a comment - Patch LGTM, but it no longer applies to the current trunk. I'll try to tweak it so that it applies. I'd like to +1 for the patch. If there are other concerns please feel free to let me know. Will put this patch in soon.
          Hide
          gtCarrera9 Li Lu added a comment -

          I quickly updated Yiqun Lin's original patch to make it apply to trunk. Kicking off Jenkins to see if there're more things need to take care of.

          Show
          gtCarrera9 Li Lu added a comment - I quickly updated Yiqun Lin 's original patch to make it apply to trunk. Kicking off Jenkins to see if there're more things need to take care of.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 2s trunk passed
          +1 compile 0m 31s trunk passed
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 5s trunk passed
          +1 javadoc 0m 32s trunk passed
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 11s the patch passed
          +1 javadoc 0m 28s the patch passed
          +1 unit 2m 28s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          19m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-4668
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835643/YARN-4668.002_1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3ab0a980f173 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6fbfb50
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13561/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13561/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 2s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 32s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 11s the patch passed +1 javadoc 0m 28s the patch passed +1 unit 2m 28s hadoop-yarn-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 19m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4668 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835643/YARN-4668.002_1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3ab0a980f173 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fbfb50 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13561/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13561/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          gtCarrera9 Li Lu added a comment -

          Looks clean. Will wait for a few hours and then commit it.

          Show
          gtCarrera9 Li Lu added a comment - Looks clean. Will wait for a few hours and then commit it.
          Hide
          gtCarrera9 Li Lu added a comment -

          Will commit the patch shortly.

          Show
          gtCarrera9 Li Lu added a comment - Will commit the patch shortly.
          Hide
          gtCarrera9 Li Lu added a comment -

          Committed to trunk and branch-2. Thanks Yiqun Lin for the contribution and Jason Lowe for the review!

          Show
          gtCarrera9 Li Lu added a comment - Committed to trunk and branch-2. Thanks Yiqun Lin for the contribution and Jason Lowe for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10711 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10711/)
          YARN-4668. Reuse objectMapper instance in Yarn. (Yiqun Lin via (gtcarrera9: rev 221582c4ab0ff1d5936f754f23da140aac656654)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10711 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10711/ ) YARN-4668 . Reuse objectMapper instance in Yarn. (Yiqun Lin via (gtcarrera9: rev 221582c4ab0ff1d5936f754f23da140aac656654) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java

            People

            • Assignee:
              linyiqun Yiqun Lin
              Reporter:
              linyiqun Yiqun Lin
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development