Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: performance
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Now in MapReduce, there are some places creating a new ObjectMapper instance every time. In wiki of ObjectMapper, it suggested:

      Further: it is beneficial to use just one instance (or small number of instances) for data binding; many optimizations for reuse (of symbol tables, some buffers) depend on ObjectMapper instances being reused. 
      

      http://webcache.googleusercontent.com/search?q=cache:kybMTIJC6F4J:wiki.fasterxml.com/JacksonFAQ+&cd=4&hl=ja&ct=clnk&gl=jp, it's similar to HDFS-9724.

      1. MAPREDUCE.001.patch
        3 kB
        Yiqun Lin
      2. MAPREDUCE-6626.002.patch
        3 kB
        Yiqun Lin
      3. MAPREDUCE-6626.003.patch
        3 kB
        Yiqun Lin
      4. MAPREDUCE-6626.004.patch
        3 kB
        Yiqun Lin

        Issue Links

          Activity

          Hide
          linyiqun Yiqun Lin added a comment -

          Attach a initial patch, kindly reviewing.

          Show
          linyiqun Yiqun Lin added a comment - Attach a initial patch, kindly reviewing.
          Hide
          linyiqun Yiqun Lin added a comment -

          Who can help me to transfer this jira to MAPREDUCE, thanks.

          Show
          linyiqun Yiqun Lin added a comment - Who can help me to transfer this jira to MAPREDUCE, thanks.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Moved to MapReduce project..Thanks for reporting and working on this..Patch looks good to me.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Moved to MapReduce project..Thanks for reporting and working on this..Patch looks good to me.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Brahma Reddy Battula. Update the latest patch.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula . Update the latest patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 51s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 1m 26s trunk passed with JDK v1.8.0_66
          +1 compile 1m 43s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 0m 34s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 0m 47s the patch passed
          +1 compile 1m 27s the patch passed with JDK v1.8.0_66
          +1 javac 1m 27s the patch passed
          +1 compile 1m 39s the patch passed with JDK v1.7.0_91
          +1 javac 1m 39s the patch passed
          -1 checkstyle 0m 26s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 2 new + 338 unchanged - 0 fixed = 340 total (was 338)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 12s the patch passed
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 39s the patch passed with JDK v1.7.0_91
          +1 unit 1m 52s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          -1 unit 9m 10s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 9s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 40s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          49m 15s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785948/MAPREDUCE.001.patch
          JIRA Issue MAPREDUCE-6626
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ff13898dab3b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 1m 26s trunk passed with JDK v1.8.0_66 +1 compile 1m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 0m 34s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 0m 47s the patch passed +1 compile 1m 27s the patch passed with JDK v1.8.0_66 +1 javac 1m 27s the patch passed +1 compile 1m 39s the patch passed with JDK v1.7.0_91 +1 javac 1m 39s the patch passed -1 checkstyle 0m 26s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 2 new + 338 unchanged - 0 fixed = 340 total (was 338) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 12s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 39s the patch passed with JDK v1.7.0_91 +1 unit 1m 52s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. -1 unit 9m 10s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. +1 unit 2m 9s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. +1 unit 9m 40s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 49m 15s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785948/MAPREDUCE.001.patch JIRA Issue MAPREDUCE-6626 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ff13898dab3b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6308/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 7m 23s trunk passed
          +1 compile 1m 42s trunk passed with JDK v1.8.0_66
          +1 compile 1m 54s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 7s trunk passed
          +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 46s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 0m 52s the patch passed
          +1 compile 1m 39s the patch passed with JDK v1.8.0_66
          +1 javac 1m 39s the patch passed
          +1 compile 1m 49s the patch passed with JDK v1.7.0_91
          +1 javac 1m 50s the patch passed
          -1 checkstyle 0m 27s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 1 new + 337 unchanged - 1 fixed = 338 total (was 338)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 0m 37s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 42s the patch passed with JDK v1.7.0_91
          +1 unit 2m 2s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 40s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          +1 unit 10m 13s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          53m 6s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785959/MAPREDUCE-6626.002.patch
          JIRA Issue MAPREDUCE-6626
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1012623045d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6309/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6309/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6309/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 23s trunk passed +1 compile 1m 42s trunk passed with JDK v1.8.0_66 +1 compile 1m 54s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 7s trunk passed +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 46s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 52s the patch passed +1 compile 1m 39s the patch passed with JDK v1.8.0_66 +1 javac 1m 39s the patch passed +1 compile 1m 49s the patch passed with JDK v1.7.0_91 +1 javac 1m 50s the patch passed -1 checkstyle 0m 27s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 1 new + 337 unchanged - 1 fixed = 338 total (was 338) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 0m 37s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 42s the patch passed with JDK v1.7.0_91 +1 unit 2m 2s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 9m 40s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66. +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. +1 unit 10m 13s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 53m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785959/MAPREDUCE-6626.002.patch JIRA Issue MAPREDUCE-6626 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1012623045d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6309/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6309/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6309/console This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Fix checkstyle errors.

          Show
          linyiqun Yiqun Lin added a comment - Fix checkstyle errors.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 42s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 1m 31s trunk passed with JDK v1.8.0_66
          +1 compile 1m 43s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 1m 53s trunk passed
          +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 44s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 0m 47s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.8.0_66
          +1 javac 1m 22s the patch passed
          +1 compile 1m 40s the patch passed with JDK v1.7.0_91
          +1 javac 1m 40s the patch passed
          +1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 13s the patch passed
          +1 javadoc 0m 31s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 38s the patch passed with JDK v1.7.0_91
          +1 unit 1m 49s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 57s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 8s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 38s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          49m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785991/MAPREDUCE-6626.003.patch
          JIRA Issue MAPREDUCE-6626
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux eccce4610aad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6310/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6310/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 1m 31s trunk passed with JDK v1.8.0_66 +1 compile 1m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 44s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 47s the patch passed +1 compile 1m 22s the patch passed with JDK v1.8.0_66 +1 javac 1m 22s the patch passed +1 compile 1m 40s the patch passed with JDK v1.7.0_91 +1 javac 1m 40s the patch passed +1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 31s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 38s the patch passed with JDK v1.7.0_91 +1 unit 1m 49s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 8m 57s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66. +1 unit 2m 8s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. +1 unit 9m 38s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 49m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785991/MAPREDUCE-6626.003.patch JIRA Issue MAPREDUCE-6626 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eccce4610aad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6310/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6310/console This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          There was no failed test. It looks fine to the current code.

          Show
          linyiqun Yiqun Lin added a comment - There was no failed test. It looks fine to the current code.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Yiqun Lin for working on this. Two comments from me.
          1.

          -    ObjectMapper mapper = new ObjectMapper();
          -    ArrayNode nodes = mapper.createArrayNode();
          +    ArrayNode nodes = MAPPER.createArrayNode();
          

          Can we replace ObjectMapper with JsonNodeFactory?

          2.

          -        ObjectMapper mapper = new ObjectMapper();
                   Map<String, String> nm = 
          -          mapper.readValue(new File(localFileName), Map.class);
          +            MAPPER.readValue(new File(localFileName), Map.class);
          

          Can we replace ObjectMapper with ObjectReader?
          ObjectMapper instance is relatively heavy, so avoid using it as possible.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Yiqun Lin for working on this. Two comments from me. 1. - ObjectMapper mapper = new ObjectMapper(); - ArrayNode nodes = mapper.createArrayNode(); + ArrayNode nodes = MAPPER.createArrayNode(); Can we replace ObjectMapper with JsonNodeFactory ? 2. - ObjectMapper mapper = new ObjectMapper(); Map< String , String > nm = - mapper.readValue( new File(localFileName), Map.class); + MAPPER.readValue( new File(localFileName), Map.class); Can we replace ObjectMapper with ObjectReader ? ObjectMapper instance is relatively heavy, so avoid using it as possible.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Akira Ajisaka for comments. Update the patch.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for comments. Update the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 28s trunk passed
          +1 compile 1m 27s trunk passed with JDK v1.8.0_66
          +1 compile 1m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 1m 47s trunk passed
          +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 41s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 17s hadoop-mapreduce-client-core in the patch failed.
          -1 compile 0m 15s hadoop-mapreduce-client in the patch failed with JDK v1.8.0_66.
          -1 javac 0m 15s hadoop-mapreduce-client in the patch failed with JDK v1.8.0_66.
          -1 compile 0m 16s hadoop-mapreduce-client in the patch failed with JDK v1.7.0_91.
          -1 javac 0m 16s hadoop-mapreduce-client in the patch failed with JDK v1.7.0_91.
          +1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338)
          -1 mvnsite 0m 17s hadoop-mapreduce-client-core in the patch failed.
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 16s hadoop-mapreduce-client-core in the patch failed.
          -1 javadoc 1m 43s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 99 unchanged - 1 fixed = 100 total (was 100)
          +1 javadoc 0m 34s the patch passed with JDK v1.8.0_66
          -1 javadoc 2m 38s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25)
          +1 javadoc 0m 40s the patch passed with JDK v1.7.0_91
          -1 unit 0m 15s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_66.
          -1 unit 9m 17s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 16s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_91.
          +1 unit 9m 28s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          40m 51s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786258/MAPREDUCE-6626.004.patch
          JIRA Issue MAPREDUCE-6626
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux decc2854e40e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 22a2b22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          compile https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91.txt
          mvnsite https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          javadoc hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt
          javadoc hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 28s trunk passed +1 compile 1m 27s trunk passed with JDK v1.8.0_66 +1 compile 1m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 41s trunk passed with JDK v1.7.0_91 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 17s hadoop-mapreduce-client-core in the patch failed. -1 compile 0m 15s hadoop-mapreduce-client in the patch failed with JDK v1.8.0_66. -1 javac 0m 15s hadoop-mapreduce-client in the patch failed with JDK v1.8.0_66. -1 compile 0m 16s hadoop-mapreduce-client in the patch failed with JDK v1.7.0_91. -1 javac 0m 16s hadoop-mapreduce-client in the patch failed with JDK v1.7.0_91. +1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338) -1 mvnsite 0m 17s hadoop-mapreduce-client-core in the patch failed. +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 16s hadoop-mapreduce-client-core in the patch failed. -1 javadoc 1m 43s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 99 unchanged - 1 fixed = 100 total (was 100) +1 javadoc 0m 34s the patch passed with JDK v1.8.0_66 -1 javadoc 2m 38s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25) +1 javadoc 0m 40s the patch passed with JDK v1.7.0_91 -1 unit 0m 15s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_66. -1 unit 9m 17s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. -1 unit 0m 16s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_91. +1 unit 9m 28s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 40m 51s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786258/MAPREDUCE-6626.004.patch JIRA Issue MAPREDUCE-6626 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux decc2854e40e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22a2b22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt compile https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91.txt mvnsite https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt javadoc hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt javadoc hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6312/console This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          Update the latest patch.

          Show
          linyiqun Yiqun Lin added a comment - Update the latest patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 27s trunk passed
          +1 compile 1m 25s trunk passed with JDK v1.8.0_66
          +1 compile 1m 38s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 0m 46s the patch passed
          +1 compile 1m 24s the patch passed with JDK v1.8.0_66
          +1 javac 1m 24s the patch passed
          +1 compile 1m 40s the patch passed with JDK v1.7.0_91
          +1 javac 1m 40s the patch passed
          +1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 38s the patch passed with JDK v1.7.0_91
          +1 unit 1m 50s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 1s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 32s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          47m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786272/MAPREDUCE-6626.004.patch
          JIRA Issue MAPREDUCE-6626
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0e042fe99df1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 22a2b22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6313/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6313/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 27s trunk passed +1 compile 1m 25s trunk passed with JDK v1.8.0_66 +1 compile 1m 38s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 46s the patch passed +1 compile 1m 24s the patch passed with JDK v1.8.0_66 +1 javac 1m 24s the patch passed +1 compile 1m 40s the patch passed with JDK v1.7.0_91 +1 javac 1m 40s the patch passed +1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 38s the patch passed with JDK v1.7.0_91 +1 unit 1m 50s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 9m 1s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66. +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. +1 unit 9m 32s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 47m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786272/MAPREDUCE-6626.004.patch JIRA Issue MAPREDUCE-6626 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0e042fe99df1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22a2b22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6313/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6313/console This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment -

          The test are all passed. The patch looks fine to the current code, can you review patch again, Brahma Reddy Battula.

          Show
          linyiqun Yiqun Lin added a comment - The test are all passed. The patch looks fine to the current code, can you review patch again, Brahma Reddy Battula .
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Yiqun Lin latest patch looks good to me. Akira Ajisaka what do you think.?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin latest patch looks good to me. Akira Ajisaka what do you think.?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for creating patches and thanks Brahma Reddy Battula for the review.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for creating patches and thanks Brahma Reddy Battula for the review.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9267 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9267/)
          MAPREDUCE-6626. Reuse ObjectMapper instance in MapReduce. Contributed by (aajisaka: rev a0b1f10a30dc2736cc136f257b0d3bf0140158bb)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9267 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9267/ ) MAPREDUCE-6626 . Reuse ObjectMapper instance in MapReduce. Contributed by (aajisaka: rev a0b1f10a30dc2736cc136f257b0d3bf0140158bb) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Akira Ajisaka for commit and thanks Brahma Reddy Battula for review.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for commit and thanks Brahma Reddy Battula for review.

            People

            • Assignee:
              linyiqun Yiqun Lin
              Reporter:
              linyiqun Yiqun Lin
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development