[YARN-4594] container-executor fails to remove directory tree when chmod required

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha1, 2.8.2
• Component/s: nodemanager
• Target Version/s: 2.9.0
• Hadoop Flags: Reviewed
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 14/Jan/16 22:02
• Updated: 16/Oct/17 16:04
• Resolved: 03/Feb/16 17:23

Description

test-container-executor.c doesn't work:

• It assumes that realpath(/bin/ls) will be /bin/ls, whereas it is actually /usr/bin/ls on many systems.
• The recursive delete logic in container-executor.c fails – nftw does the wrong thing when confronted with directories with the wrong mode (permission bits), leading to an attempt to run rmdir on a non-empty directory.

Issue Links

• breaks: YARN-4731 container-executor should not follow symlinks in recursive_unlink_children
• is related to: YARN-7333 container-executor fails to remove entries from a directory that is not writable or executable
• relates to: HADOOP-8887 Use a Maven plugin to build the native code using CMake