Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-41

The RM should handle the graceful shutdown of the NM.

    Details

    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      The behavior of shutdown a NM could be different (if NM work preserving is not enabled): NM will unregister to RM immediately rather than waiting for timeout to be LOST. A new status of NodeStatus - SHUTDOWN is involved which could affect UI, CLI and ClusterMetrics for node's status.
      Show
      The behavior of shutdown a NM could be different (if NM work preserving is not enabled): NM will unregister to RM immediately rather than waiting for timeout to be LOST. A new status of NodeStatus - SHUTDOWN is involved which could affect UI, CLI and ClusterMetrics for node's status.

      Description

      Instead of waiting for the NM expiry, RM should remove and handle the NM, which is shutdown gracefully.

      1. YARN-41-8.patch
        69 kB
        Devaraj K
      2. YARN-41-7.patch
        63 kB
        Devaraj K
      3. YARN-41-6.patch
        52 kB
        Devaraj K
      4. YARN-41-5.patch
        52 kB
        Devaraj K
      5. YARN-41-4.patch
        49 kB
        Devaraj K
      6. YARN-41-3.patch
        49 kB
        Devaraj K
      7. YARN-41-2.patch
        48 kB
        Devaraj K
      8. YARN-41-1.patch
        44 kB
        Devaraj K
      9. YARN-41.patch
        52 kB
        Devaraj K
      10. MAPREDUCE-3494.2.patch
        51 kB
        Devaraj K
      11. MAPREDUCE-3494.1.patch
        48 kB
        Devaraj K
      12. MAPREDUCE-3494.patch
        47 kB
        Devaraj K

        Issue Links

          Activity

          Hide
          jeagles Jonathan Eagles added a comment -

          A side-effect of this is that NMs using static (non-ephemeral) ports are unable to rejoin until after the expiry period (yarn.resourcemanager.nm.liveness-monitor.expiry-interval-ms default is 10 minutes!).

          Show
          jeagles Jonathan Eagles added a comment - A side-effect of this is that NMs using static (non-ephemeral) ports are unable to rejoin until after the expiry period (yarn.resourcemanager.nm.liveness-monitor.expiry-interval-ms default is 10 minutes!).
          Hide
          devaraj.k Devaraj K added a comment -

          Added the patch with the handling the shutdown scenario.

          Show
          devaraj.k Devaraj K added a comment - Added the patch with the handling the shutdown scenario.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12508501/MAPREDUCE-3494.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1501//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1501//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1501//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508501/MAPREDUCE-3494.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1501//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1501//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1501//console This message is automatically generated.
          Hide
          devaraj.k Devaraj K added a comment -

          Attaching the patch with the findbugs fix.

          Show
          devaraj.k Devaraj K added a comment - Attaching the patch with the findbugs fix.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12508624/MAPREDUCE-3494.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1505//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1505//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508624/MAPREDUCE-3494.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1505//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1505//console This message is automatically generated.
          Hide
          kam_iitkgp Bhallamudi Venkata Siva Kamesh added a comment -

          Hi Devraj,
          I think while unregistering NodeManager from RM, we should also remove the corresponding entry from NMLivelinessMonitor.
          Is this patch handle this? or it is not required?

          Show
          kam_iitkgp Bhallamudi Venkata Siva Kamesh added a comment - Hi Devraj, I think while unregistering NodeManager from RM, we should also remove the corresponding entry from NMLivelinessMonitor. Is this patch handle this? or it is not required?
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks for the comments Kamesh!

          That would be a good idea. I will upload the patch with a fix for this comment.

          Show
          devaraj.k Devaraj K added a comment - Thanks for the comments Kamesh! That would be a good idea. I will upload the patch with a fix for this comment.
          Hide
          devaraj.k Devaraj K added a comment -

          Attached the patch addressing the comments.

          Show
          devaraj.k Devaraj K added a comment - Attached the patch addressing the comments.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12508743/MAPREDUCE-3494.2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1514//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1514//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508743/MAPREDUCE-3494.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1514//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1514//console This message is automatically generated.
          Hide
          acmurthy Arun C Murthy added a comment -

          Please add 'mrv2' component for all relevant jiras, so I can track it as it becomes PA. Thanks.

          Show
          acmurthy Arun C Murthy added a comment - Please add 'mrv2' component for all relevant jiras, so I can track it as it becomes PA. Thanks.
          Hide
          mahadev Mahadev konar added a comment -

          Removing 1.0 as affects version.

          Show
          mahadev Mahadev konar added a comment - Removing 1.0 as affects version.
          Hide
          mahadev Mahadev konar added a comment -

          @Devaraj,
          I am not sure what the use case here is? What it looks like is that when the NM has any issues registering you will unregister it? Can you please elaborate on the implications and the use case?

          Show
          mahadev Mahadev konar added a comment - @Devaraj, I am not sure what the use case here is? What it looks like is that when the NM has any issues registering you will unregister it? Can you please elaborate on the implications and the use case?
          Hide
          devaraj.k Devaraj K added a comment -

          Hi Mahadev,
          This is a start scenario. When the NM shuts down gracefully, even then the NM is removed only after the expiry interval.

          Now we will introduce the unregistration with the RM when the NM is shutting down. So that the RM is aware of it and will do the necessary actions for the same, instead of waiting for expiry interval.

          Show
          devaraj.k Devaraj K added a comment - Hi Mahadev, This is a start scenario. When the NM shuts down gracefully, even then the NM is removed only after the expiry interval. Now we will introduce the unregistration with the RM when the NM is shutting down. So that the RM is aware of it and will do the necessary actions for the same, instead of waiting for expiry interval.
          Hide
          devaraj.k Devaraj K added a comment -

          Hi Mahadev,
          This is a straight scenario. When the NM shuts down gracefully, even then the NM is removed only after the expiry interval.

          Now we will introduce the unregistration with the RM when the NM is shutting down. So that the RM is aware of it and will do the necessary actions for the same, instead of waiting for expiry interval.

          Show
          devaraj.k Devaraj K added a comment - Hi Mahadev, This is a straight scenario. When the NM shuts down gracefully, even then the NM is removed only after the expiry interval. Now we will introduce the unregistration with the RM when the NM is shutting down. So that the RM is aware of it and will do the necessary actions for the same, instead of waiting for expiry interval.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Now we will introduce the unregistration with the RM when the NM is shutting down.

          +1 for doing this.

          Can you please update the patch given YARN-1 happened? Can you also upmerge it so that I can start reviewing it? Tx.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Now we will introduce the unregistration with the RM when the NM is shutting down. +1 for doing this. Can you please update the patch given YARN-1 happened? Can you also upmerge it so that I can start reviewing it? Tx.
          Hide
          devaraj.k Devaraj K added a comment -

          I updated the patch. Please review it.

          Show
          devaraj.k Devaraj K added a comment - I updated the patch. Please review it.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12588120/YARN-41.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1296//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1296//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12588120/YARN-41.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1296//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1296//console This message is automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Can you please update the patch against latest trunk?

          It's been waiting for a long while. I'd like to quickly review and commit it before it goes stale again. Few comments:

          • There is no need for UnRegistrationResponse record at all as of now. If need be, it can be added later, please remove it for now from everywhere.
          • Shouldn't be counting shut-down nodes in LOST. Adding a new state is perhaps an over-kill, DECOMMISSIONED is the closest I can think of.
          • Put ResourceTrackerService.unRegisterNodeManager after the heartbeat method.
          • We should check if this node is valid or not before trying to unRegister in ResourceTrackerService
          • NM unregister and hence the SHUTDOWN event can happen at UNHEALTHY state too.
          • Please add a test for the above.
          • MiniYarnCluster: unRegisterNodeManager shouldn't just reply null. Not sure why no tests are failing. Can you see?
          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Can you please update the patch against latest trunk? It's been waiting for a long while. I'd like to quickly review and commit it before it goes stale again. Few comments: There is no need for UnRegistrationResponse record at all as of now. If need be, it can be added later, please remove it for now from everywhere. Shouldn't be counting shut-down nodes in LOST. Adding a new state is perhaps an over-kill, DECOMMISSIONED is the closest I can think of. Put ResourceTrackerService.unRegisterNodeManager after the heartbeat method. We should check if this node is valid or not before trying to unRegister in ResourceTrackerService NM unregister and hence the SHUTDOWN event can happen at UNHEALTHY state too. Please add a test for the above. MiniYarnCluster: unRegisterNodeManager shouldn't just reply null. Not sure why no tests are failing. Can you see?
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks a lot Vinod for looking into the patch. I have updated the patch with the above comments fix.

          ■Shouldn't be counting shut-down nodes in LOST. Adding a new state is perhaps an over-kill, DECOMMISSIONED is the closest I can think of.

          Now moving the shut down nodes to DECOMMISSIONED state.

          ■MiniYarnCluster: unRegisterNodeManager shouldn't just reply null. Not sure why no tests are failing. Can you see?

          I have corrected this. I don't see any tests failing due to this.

          Show
          devaraj.k Devaraj K added a comment - Thanks a lot Vinod for looking into the patch. I have updated the patch with the above comments fix. ■Shouldn't be counting shut-down nodes in LOST. Adding a new state is perhaps an over-kill, DECOMMISSIONED is the closest I can think of. Now moving the shut down nodes to DECOMMISSIONED state. ■MiniYarnCluster: unRegisterNodeManager shouldn't just reply null. Not sure why no tests are failing. Can you see? I have corrected this. I don't see any tests failing due to this.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12593183/YARN-41-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests:

          org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1530//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1530//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12593183/YARN-41-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1530//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1530//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12593323/YARN-41-2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1542//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1542//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12593323/YARN-41-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1542//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1542//console This message is automatically generated.
          Hide
          devaraj.k Devaraj K added a comment -

          Attached an updated patch for this issue. Please have a look into this.

          Show
          devaraj.k Devaraj K added a comment - Attached an updated patch for this issue. Please have a look into this.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12694514/YARN-41-3.patch
          against trunk revision 7b82c4a.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6416//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6416//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12694514/YARN-41-3.patch against trunk revision 7b82c4a. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6416//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6416//console This message is automatically generated.
          Hide
          devaraj.k Devaraj K added a comment -

          Vinod Kumar Vavilapalli, can you have a look into the updated patch? Thanks.

          Show
          devaraj.k Devaraj K added a comment - Vinod Kumar Vavilapalli , can you have a look into the updated patch? Thanks.
          Hide
          djp Junping Du added a comment -

          Devaraj K, thanks for updating the patch! Vinod Kumar Vavilapalli is on vacation, so I will help to review here. Just a quick glance at your patch (v3), a couple of comments and questions:

             STATUS_UPDATE,
             REBOOTING,
             RECONNECTED,
          +  SHUTDOWN,
          

          Looks like we are adding a new event. Given we already have decommission event, so this is for other cases, e.g. shutdown NM daemon through CLI. Isn't it? If so, we should consider the case that NM work preserving is enabled (for rolling upgrade), and these nodes shouldn't be unregister to RM.

             protected void serviceStop() throws Exception {
          +    // the isStopped check is for avoiding multiple unregistrations.
          +    if (this.registeredWithRM && !this.isStopped) {
          +      unRegisterNM();
          +    }
          

          Like I said above, we only need to unregister NM from RM when NM recovery is disabled. We may should put a check here.

          More comments will come later.

          Show
          djp Junping Du added a comment - Devaraj K , thanks for updating the patch! Vinod Kumar Vavilapalli is on vacation, so I will help to review here. Just a quick glance at your patch (v3), a couple of comments and questions: STATUS_UPDATE, REBOOTING, RECONNECTED, + SHUTDOWN, Looks like we are adding a new event. Given we already have decommission event, so this is for other cases, e.g. shutdown NM daemon through CLI. Isn't it? If so, we should consider the case that NM work preserving is enabled (for rolling upgrade), and these nodes shouldn't be unregister to RM. protected void serviceStop() throws Exception { + // the isStopped check is for avoiding multiple unregistrations. + if ( this .registeredWithRM && ! this .isStopped) { + unRegisterNM(); + } Like I said above, we only need to unregister NM from RM when NM recovery is disabled. We may should put a check here. More comments will come later.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks Junping Du for your quick look.

          Given we already have decommission event, so this is for other cases, e.g. shutdown NM daemon through CLI. Isn't it?

          correct, It is to avoid the RM waiting for NM expiry interval to move down-NM from active to lost when NM shutdown is graceful.

          If so, we should consider the case that NM work preserving is enabled (for rolling upgrade), and these nodes shouldn't be unregister to RM.

          I realize now that RM kills all the running containers when the NM changes state from active to decommissioned. Thanks for pointing this, will consider this case.

          Show
          devaraj.k Devaraj K added a comment - Thanks Junping Du for your quick look. Given we already have decommission event, so this is for other cases, e.g. shutdown NM daemon through CLI. Isn't it? correct, It is to avoid the RM waiting for NM expiry interval to move down-NM from active to lost when NM shutdown is graceful. If so, we should consider the case that NM work preserving is enabled (for rolling upgrade), and these nodes shouldn't be unregister to RM. I realize now that RM kills all the running containers when the NM changes state from active to decommissioned. Thanks for pointing this, will consider this case.
          Hide
          djp Junping Du added a comment -

          I think I could have a little misunderstand before. After checking again, your patch is actually working on decommission node, not "shutdown" (let's define call yarn daemon stop or kill -9 on NodeManager as shutdown, just for get rid of any confusion), so the patch here shouldn't affect the work on YARN-1336 (containers can still be running after "shutdown" NM, which is different from decommission).
          From what I am understanding, now the new flow in your current patch is: when user decommission a Node, the RM heartbeat back to NM with a SHUTDOWN message, NM prepare service stop and send a unRegister message to RM (via RPC call) again before it killing itself and RM (ResourceTrackerService) try to do some cleanup work.
          IMO, there are several concerns with this approach:
          1. Another round of RPC between (NM and RM) is unnecessary, RM could do the same thing (code in unRegisterNodeManager()) during sending SHUTDOWN message back.
          2. Some work is already being covered (like sending DECOMMISSION event to RMNode) in NodeListManager when doing decommission (refresh) node operation. It seems new work in unRegisterNodeManager() only be unregister in NMLivenessMonitor.
          Am I missing anything?

          Show
          djp Junping Du added a comment - I think I could have a little misunderstand before. After checking again, your patch is actually working on decommission node, not "shutdown" (let's define call yarn daemon stop or kill -9 on NodeManager as shutdown, just for get rid of any confusion), so the patch here shouldn't affect the work on YARN-1336 (containers can still be running after "shutdown" NM, which is different from decommission). From what I am understanding, now the new flow in your current patch is: when user decommission a Node, the RM heartbeat back to NM with a SHUTDOWN message, NM prepare service stop and send a unRegister message to RM (via RPC call) again before it killing itself and RM (ResourceTrackerService) try to do some cleanup work. IMO, there are several concerns with this approach: 1. Another round of RPC between (NM and RM) is unnecessary, RM could do the same thing (code in unRegisterNodeManager()) during sending SHUTDOWN message back. 2. Some work is already being covered (like sending DECOMMISSION event to RMNode) in NodeListManager when doing decommission (refresh) node operation. It seems new work in unRegisterNodeManager() only be unregister in NMLivenessMonitor. Am I missing anything?
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks a lot Junping Du for your some more comments.

          your patch is actually working on decommission node, not "shutdown" (let's define call yarn daemon stop or kill -9 on NodeManager as shutdown, just for get rid of any confusion),

          It is not for decommissioning of NM and it is for handling 'yarn-daemon.sh stop nodemanager' and kill nmPid (not for 'kill -9 nmPid' i.e. abrupt kill)

          so the patch here shouldn't affect the work on YARN-1336 (containers can still be running after "shutdown" NM, which is different from decommission).

          I have considered your comment as you mentioned above i.e. excluding the unregister call to RM when NM recovery is enabled to continue the execution of running containers. I will include this in the next patch once we get the conclusion of the comments.

          From what I am understanding, now the new flow in your current patch is: when user decommission a Node, the RM heartbeat back to NM with a SHUTDOWN message, NM prepare service stop and send a unRegister message to RM (via RPC call) again before it killing itself and RM (ResourceTrackerService) try to do some cleanup work.
          IMO, there are several concerns with this approach:
          1. Another round of RPC between (NM and RM) is unnecessary, RM could do the same thing (code in unRegisterNodeManager()) during sending SHUTDOWN message back.
          2. Some work is already being covered (like sending DECOMMISSION event to RMNode) in NodeListManager when doing decommission (refresh) node operation. It seems new work in unRegisterNodeManager() only be unregister in NMLivenessMonitor.

          When user decommissions a node, RM sends the SHUTDOWN message to NM as part of heartbeat response and then NM calls unRegisterNodeManager() to RM during it's NodeStatusUpdaterImpl.serviceStop(). In this case, ResourceTrackerService doesn't perform any action because the node would be removed already from this.rmContext.getRMNodes() as part of DeactivateNodeTransition for DECOMMISSION event. I haven't excluded this case for unRegisterNodeManager() because to have the complete life cycle methods of NM (registerNodeManager, nodeHeartbeat, unRegisterNodeManager).

          ResourceTrackerService
                public UnRegisterNodeManagerResponse unRegisterNodeManager(
                UnRegisterNodeManagerRequest request) throws YarnException, IOException {
              UnRegisterNodeManagerResponse response = recordFactory
                  .newRecordInstance(UnRegisterNodeManagerResponse.class);
              NodeId nodeId = request.getNodeId();
              RMNode rmNode = this.rmContext.getRMNodes().get(nodeId);
              if (rmNode == null) {
                LOG.info("Node not found, ignoring the unregister from node id : "
                    + nodeId);
                return response;
              }
          
          Show
          devaraj.k Devaraj K added a comment - Thanks a lot Junping Du for your some more comments. your patch is actually working on decommission node, not "shutdown" (let's define call yarn daemon stop or kill -9 on NodeManager as shutdown, just for get rid of any confusion), It is not for decommissioning of NM and it is for handling 'yarn-daemon.sh stop nodemanager' and kill nmPid (not for 'kill -9 nmPid' i.e. abrupt kill) so the patch here shouldn't affect the work on YARN-1336 (containers can still be running after "shutdown" NM, which is different from decommission). I have considered your comment as you mentioned above i.e. excluding the unregister call to RM when NM recovery is enabled to continue the execution of running containers. I will include this in the next patch once we get the conclusion of the comments. From what I am understanding, now the new flow in your current patch is: when user decommission a Node, the RM heartbeat back to NM with a SHUTDOWN message, NM prepare service stop and send a unRegister message to RM (via RPC call) again before it killing itself and RM (ResourceTrackerService) try to do some cleanup work. IMO, there are several concerns with this approach: 1. Another round of RPC between (NM and RM) is unnecessary, RM could do the same thing (code in unRegisterNodeManager()) during sending SHUTDOWN message back. 2. Some work is already being covered (like sending DECOMMISSION event to RMNode) in NodeListManager when doing decommission (refresh) node operation. It seems new work in unRegisterNodeManager() only be unregister in NMLivenessMonitor. When user decommissions a node, RM sends the SHUTDOWN message to NM as part of heartbeat response and then NM calls unRegisterNodeManager() to RM during it's NodeStatusUpdaterImpl.serviceStop(). In this case, ResourceTrackerService doesn't perform any action because the node would be removed already from this.rmContext.getRMNodes() as part of DeactivateNodeTransition for DECOMMISSION event. I haven't excluded this case for unRegisterNodeManager() because to have the complete life cycle methods of NM (registerNodeManager, nodeHeartbeat, unRegisterNodeManager). ResourceTrackerService public UnRegisterNodeManagerResponse unRegisterNodeManager( UnRegisterNodeManagerRequest request) throws YarnException, IOException { UnRegisterNodeManagerResponse response = recordFactory .newRecordInstance(UnRegisterNodeManagerResponse.class); NodeId nodeId = request.getNodeId(); RMNode rmNode = this .rmContext.getRMNodes().get(nodeId); if (rmNode == null ) { LOG.info( "Node not found, ignoring the unregister from node id : " + nodeId); return response; }
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Junping Du, can you please respond to Devaraj K's comments?

          It is not for decommissioning of NM and it is for handling 'yarn-daemon.sh stop nodemanager' and kill nmPid (not for 'kill -9 nmPid' i.e. abrupt kill)

          This is the use-case that I am interested in addressing here, more than a decommission through RM.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Junping Du , can you please respond to Devaraj K 's comments? It is not for decommissioning of NM and it is for handling 'yarn-daemon.sh stop nodemanager' and kill nmPid (not for 'kill -9 nmPid' i.e. abrupt kill) This is the use-case that I am interested in addressing here, more than a decommission through RM.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks Vinod Kumar Vavilapalli for your comment.

          Junping Du, can you have a look into my responses for your questions? Thanks.

          Show
          devaraj.k Devaraj K added a comment - Thanks Vinod Kumar Vavilapalli for your comment. Junping Du , can you have a look into my responses for your questions? Thanks.
          Hide
          devaraj.k Devaraj K added a comment -

          Updated the patch with the change that doesn't unregister with RM when there are application running in NM with NM-recovery enabled.

          Show
          devaraj.k Devaraj K added a comment - Updated the patch with the change that doesn't unregister with RM when there are application running in NM with NM-recovery enabled.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12704146/YARN-41-4.patch
          against trunk revision ff83ae7.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests:

          org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate
          org.apache.hadoop.yarn.server.resourcemanager.TestRM

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6938//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6938//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6938//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704146/YARN-41-4.patch against trunk revision ff83ae7. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate org.apache.hadoop.yarn.server.resourcemanager.TestRM Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6938//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6938//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6938//console This message is automatically generated.
          Hide
          djp Junping Du added a comment -

          Hi Vinod Kumar Vavilapalli and Devaraj K, sorry for coming late on this as missed these comments before.

          It is not for decommissioning of NM and it is for handling 'yarn-daemon.sh stop nodemanager' and kill nmPid (not for 'kill -9 nmPid' i.e. abrupt kill)

          I see. That should be the case I expected and I closed YARN-2680 as duplicated of this. However, a little concern here is it could diverge more for behaviors between "stop nodemanager" and "kill -9 nmPid". Not sure if user expect these 2 has similar behaviors (at least, for NM restart work preserving, we expect two has the same result, please refer some discussions at YARN-2331).

          I have considered your comment as you mentioned above i.e. excluding the unregister call to RM when NM recovery is enabled to continue the execution of running containers. I will include this in the next patch once we get the conclusion of the comments.

          Sounds good. Will check your latest patch for details.

          I haven't excluded this case for unRegisterNodeManager() because to have the complete life cycle methods of NM (registerNodeManager, nodeHeartbeat, unRegisterNodeManager).

          Make sense. Let's keep decommission flow separated from shutdown case here.

          BTW, the latest patch is not applied any more (my bad ). Kindly rebase the patch against latest trunk would be great.

          Show
          djp Junping Du added a comment - Hi Vinod Kumar Vavilapalli and Devaraj K , sorry for coming late on this as missed these comments before. It is not for decommissioning of NM and it is for handling 'yarn-daemon.sh stop nodemanager' and kill nmPid (not for 'kill -9 nmPid' i.e. abrupt kill) I see. That should be the case I expected and I closed YARN-2680 as duplicated of this. However, a little concern here is it could diverge more for behaviors between "stop nodemanager" and "kill -9 nmPid". Not sure if user expect these 2 has similar behaviors (at least, for NM restart work preserving, we expect two has the same result, please refer some discussions at YARN-2331 ). I have considered your comment as you mentioned above i.e. excluding the unregister call to RM when NM recovery is enabled to continue the execution of running containers. I will include this in the next patch once we get the conclusion of the comments. Sounds good. Will check your latest patch for details. I haven't excluded this case for unRegisterNodeManager() because to have the complete life cycle methods of NM (registerNodeManager, nodeHeartbeat, unRegisterNodeManager). Make sense. Let's keep decommission flow separated from shutdown case here. BTW, the latest patch is not applied any more (my bad ). Kindly rebase the patch against latest trunk would be great.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          However, a little concern here is it could diverge more for behaviors between "stop nodemanager" and "kill -9 nmPid". Not sure if user expect these 2 has similar behaviors (at least, for NM restart work preserving, we expect two has the same result, please refer some discussions at YARN-2331).

          In the case of work-preserving NM restart (or under supervision as YARN-2331 calls it), we can make the NM not do an unregister?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - However, a little concern here is it could diverge more for behaviors between "stop nodemanager" and "kill -9 nmPid". Not sure if user expect these 2 has similar behaviors (at least, for NM restart work preserving, we expect two has the same result, please refer some discussions at YARN-2331 ). In the case of work-preserving NM restart (or under supervision as YARN-2331 calls it), we can make the NM not do an unregister?
          Hide
          djp Junping Du added a comment -

          In the case of work-preserving NM restart (or under supervision as YARN-2331 calls it), we can make the NM not do an unregister?

          I think latest patch (-4.patch) already did this, but my concern is a little broader: does user (or management tools for YARN cluster, like: Ambari) expect the same behavior for kill -9 on NM daemon and shutdown for NM daemon? With current patch (assume NM work preserving is disabled), user will find RM don't have this NM info anymore if shutdown NM daemon while the kill -9 on NM daemon has the old behavior (RM still has NM info with running state and switch to LOST after timeout). Previously, the behavior of these two operations is the same. However, I don't think we care too much about consistency behavior for these two operations, but would like to call it out loudly to make sure we don't miss anything important.

          Show
          djp Junping Du added a comment - In the case of work-preserving NM restart (or under supervision as YARN-2331 calls it), we can make the NM not do an unregister? I think latest patch (-4.patch) already did this, but my concern is a little broader: does user (or management tools for YARN cluster, like: Ambari) expect the same behavior for kill -9 on NM daemon and shutdown for NM daemon? With current patch (assume NM work preserving is disabled), user will find RM don't have this NM info anymore if shutdown NM daemon while the kill -9 on NM daemon has the old behavior (RM still has NM info with running state and switch to LOST after timeout). Previously, the behavior of these two operations is the same. However, I don't think we care too much about consistency behavior for these two operations, but would like to call it out loudly to make sure we don't miss anything important.
          Hide
          jlowe Jason Lowe added a comment -

          In light of NM restart, one of the problems with having the NM check for active applications and then take different actions is that the NM has a significantly delayed view of the cluster relative to the RM. The RM could have decided to assign new containers (and thus new applications) to the node, but the NM hasn't seen the launch request from the AM yet. This has already caused other issues, see the early discussions in YARN-3535 where containers were killed because the node reconnected with no active applications reported and was handled as a node removed/node added sequence.

          Show
          jlowe Jason Lowe added a comment - In light of NM restart, one of the problems with having the NM check for active applications and then take different actions is that the NM has a significantly delayed view of the cluster relative to the RM. The RM could have decided to assign new containers (and thus new applications) to the node, but the NM hasn't seen the launch request from the AM yet. This has already caused other issues, see the early discussions in YARN-3535 where containers were killed because the node reconnected with no active applications reported and was handled as a node removed/node added sequence.
          Hide
          djp Junping Du added a comment -

          Thanks Jason Lowe for sharing this prospective. I think YARN-3212 is facing the same situation as your last comment there.
          However, in this case, we may make things simpler if we don't care if running applications on work preserving enabled nodes. We just simply don't do unRegister NM from RM when work-preserving is enabled - this is not only simpler for implementation, but also simpler for user to understand - or it will make shutdown NM daemon's behavior sounds more randomly as sometimes it get disappeared from RM while sometimes not - this sounds the behavior is not controlled by configuration but controlled by randomly container allocation. Thoughts?

          Show
          djp Junping Du added a comment - Thanks Jason Lowe for sharing this prospective. I think YARN-3212 is facing the same situation as your last comment there. However, in this case, we may make things simpler if we don't care if running applications on work preserving enabled nodes. We just simply don't do unRegister NM from RM when work-preserving is enabled - this is not only simpler for implementation, but also simpler for user to understand - or it will make shutdown NM daemon's behavior sounds more randomly as sometimes it get disappeared from RM while sometimes not - this sounds the behavior is not controlled by configuration but controlled by randomly container allocation. Thoughts?
          Hide
          jlowe Jason Lowe added a comment -

          I think avoiding the unregister during shutdown if the NM is under supervision (i.e.: we know it will be restarted momentarily) is fine. I was only bringing up the point since you mentioned the latest patch already covered this, but that patch is checking for active applications to decide whether to unregister.

          Show
          jlowe Jason Lowe added a comment - I think avoiding the unregister during shutdown if the NM is under supervision (i.e.: we know it will be restarted momentarily) is fine. I was only bringing up the point since you mentioned the latest patch already covered this, but that patch is checking for active applications to decide whether to unregister.
          Hide
          djp Junping Du added a comment -

          I think avoiding the unregister during shutdown if the NM is under supervision (i.e.: we know it will be restarted momentarily) is fine.

          How about the case when NM is under supervision while work preserving is disabled? Sorry for forgetting to bring this out in YARN-2331, but this sounds like should be the same behavior with node with disabling work preserving and not in supervision (at least for feature of NM restart work preserving). So we should check two configurations together, only skip unregister in case both configuration are true. Isn't it?

          Show
          djp Junping Du added a comment - I think avoiding the unregister during shutdown if the NM is under supervision (i.e.: we know it will be restarted momentarily) is fine. How about the case when NM is under supervision while work preserving is disabled? Sorry for forgetting to bring this out in YARN-2331 , but this sounds like should be the same behavior with node with disabling work preserving and not in supervision (at least for feature of NM restart work preserving). So we should check two configurations together, only skip unregister in case both configuration are true. Isn't it?
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks Vinod, Junping and Jason for the discussion here.

          So we should check two configurations together, only skip unregister in case both configuration are true. Isn't it?

          If we unregister when node preserving is enabled and NM is not under supervision, we would be falling to the YARN-3535 issue again. For skipping unregister, checking whether node preserving is enabled or not wouldn't sufficient irrespective of nm is under supervision or not?

          Show
          devaraj.k Devaraj K added a comment - Thanks Vinod, Junping and Jason for the discussion here. So we should check two configurations together, only skip unregister in case both configuration are true. Isn't it? If we unregister when node preserving is enabled and NM is not under supervision, we would be falling to the YARN-3535 issue again. For skipping unregister, checking whether node preserving is enabled or not wouldn't sufficient irrespective of nm is under supervision or not?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          It will be a much easier discussion if someone here can write down a truth table with various dimensions and when we want to/don't want to have the NM unregister.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - It will be a much easier discussion if someone here can write down a truth table with various dimensions and when we want to/don't want to have the NM unregister.
          Hide
          devaraj.k Devaraj K added a comment -
          NM Graceful Shutdown NM Recovery Enabled
          yarn.nodemanager.recovery.enabled=true
          NM is Running Under Supervision
          yarn.nodemanager.recovery.supervised=true
          NM Unregister
          Y N Y Y
          Y N N Y
          Y Y Y N
          Y Y N N
          N Y/N Y/N N



          • If the NM shutdown is graceful and NM recovery is not enabled then NM unregisters with RM. Here, irrespective of NM is under supervision or not if the NM recovery is not enabled then NM will unregister with RM.
          • If the NM shutdown is graceful and NM recovery is enabled then NM will not unregister with RM.
          • If the NM gets killed abruptly(using kill -9 nm-pid) then NM will not unregister with RM as the process itself will not be available to notify anything.

          As per my understanding I assumed here that NM is under supervision enabled only when the NM recovery is enabled. Please correct me If I am wrong.

          Please give your comments, I will update the patch accordingly if there are no issues on this.

          Show
          devaraj.k Devaraj K added a comment - NM Graceful Shutdown NM Recovery Enabled yarn.nodemanager.recovery.enabled=true NM is Running Under Supervision yarn.nodemanager.recovery.supervised=true NM Unregister Y N Y Y Y N N Y Y Y Y N Y Y N N N Y/N Y/N N If the NM shutdown is graceful and NM recovery is not enabled then NM unregisters with RM. Here, irrespective of NM is under supervision or not if the NM recovery is not enabled then NM will unregister with RM. If the NM shutdown is graceful and NM recovery is enabled then NM will not unregister with RM. If the NM gets killed abruptly(using kill -9 nm-pid) then NM will not unregister with RM as the process itself will not be available to notify anything. As per my understanding I assumed here that NM is under supervision enabled only when the NM recovery is enabled. Please correct me If I am wrong. Please give your comments, I will update the patch accordingly if there are no issues on this.
          Hide
          devaraj.k Devaraj K added a comment -

          Jason Lowe/Junping Du, Any comments please?

          Show
          devaraj.k Devaraj K added a comment - Jason Lowe / Junping Du , Any comments please?
          Hide
          jlowe Jason Lowe added a comment -

          Looking at the table above, I'm wondering about the case where we are doing a graceful shutdown, recovery is enabled, but we are not running under supervision. When we are shutting down without supervision the NM will normally kill active containers, so in that sense I think we should also unregister. I'm not sure there's a point to avoiding the unregister if no containers will survive the NM shutdown. The NM only avoids killing containers on shutdown if the NM supports recovery and it has been told it is being supervised (i.e.: it is likely the NM will be restarted shortly after the shutdown completes). In the other cases it kills containers on shutdown to avoid a situation where containers are running uncontrolled on a node due to the NM being unavailable for a prolonged duration.

          Show
          jlowe Jason Lowe added a comment - Looking at the table above, I'm wondering about the case where we are doing a graceful shutdown, recovery is enabled, but we are not running under supervision. When we are shutting down without supervision the NM will normally kill active containers, so in that sense I think we should also unregister. I'm not sure there's a point to avoiding the unregister if no containers will survive the NM shutdown. The NM only avoids killing containers on shutdown if the NM supports recovery and it has been told it is being supervised (i.e.: it is likely the NM will be restarted shortly after the shutdown completes). In the other cases it kills containers on shutdown to avoid a situation where containers are running uncontrolled on a node due to the NM being unavailable for a prolonged duration.
          Hide
          djp Junping Du added a comment -

          Thanks Devaraj K for providing truth table above. Contents looks mostly good to me.
          One interesting case is when "yarn.nodemanager.recovery.enabled=true" but "yarn.nodemanager.recovery.supervised=false", the shutdown behavior after YARN-2331 is: running containers will get killed, but recovery work will continue after NM get restarted. Theoretically, I think we should unregister NM from RM because we don't expect app/container get recovered on this NM.

          As per my understanding I assumed here that NM is under supervision enabled only when the NM recovery is enabled.

          Agree. In practical, if NM is under supervision while NM recovery is disabled, the behavior should be exactly the same as both config are set to false.

          Jason Lowe, any comments here?

          Show
          djp Junping Du added a comment - Thanks Devaraj K for providing truth table above. Contents looks mostly good to me. One interesting case is when "yarn.nodemanager.recovery.enabled=true" but "yarn.nodemanager.recovery.supervised=false", the shutdown behavior after YARN-2331 is: running containers will get killed, but recovery work will continue after NM get restarted. Theoretically, I think we should unregister NM from RM because we don't expect app/container get recovered on this NM. As per my understanding I assumed here that NM is under supervision enabled only when the NM recovery is enabled. Agree. In practical, if NM is under supervision while NM recovery is disabled, the behavior should be exactly the same as both config are set to false. Jason Lowe , any comments here?
          Hide
          djp Junping Du added a comment -

          Jason Lowe, any comments here?

          Sorry. I didn't see Jason's comments when I am putting my comments. But looks like we are talking about the same thing in parallel.

          Show
          djp Junping Du added a comment - Jason Lowe, any comments here? Sorry. I didn't see Jason's comments when I am putting my comments. But looks like we are talking about the same thing in parallel.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks a lot Jason Lowe and Junping Du for your comments.

          I will update the patch considering that NM unregistering with RM when NM recovery enabled and supervision disabled as well.

          Show
          devaraj.k Devaraj K added a comment - Thanks a lot Jason Lowe and Junping Du for your comments. I will update the patch considering that NM unregistering with RM when NM recovery enabled and supervision disabled as well.
          Hide
          devaraj.k Devaraj K added a comment -

          I am attaching patch as per latest source code and also with the above comments fix.

          Show
          devaraj.k Devaraj K added a comment - I am attaching patch as per latest source code and also with the above comments fix.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 10s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 9 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          +1 javadoc 9m 40s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 30s The applied patch generated 18 new checkstyle issues (total was 15, now 33).
          +1 whitespace 0m 15s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 3m 45s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 5m 57s Tests passed in hadoop-yarn-server-nodemanager.
          +1 yarn tests 49m 59s Tests passed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 53s Tests passed in hadoop-yarn-server-tests.
              99m 18s  



          Reason Tests
          FindBugs module:hadoop-yarn-server-resourcemanager
            Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156]



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733771/YARN-41-5.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / eb4c9dd
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7996/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7996/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 9 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 30s The applied patch generated 18 new checkstyle issues (total was 15, now 33). +1 whitespace 0m 15s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 3m 45s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common. +1 yarn tests 5m 57s Tests passed in hadoop-yarn-server-nodemanager. +1 yarn tests 49m 59s Tests passed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 53s Tests passed in hadoop-yarn-server-tests.     99m 18s   Reason Tests FindBugs module:hadoop-yarn-server-resourcemanager   Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java: [line 156] Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733771/YARN-41-5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / eb4c9dd checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/7996/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7996/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7996/console This message was automatically generated.
          Hide
          devaraj.k Devaraj K added a comment - - edited

          Updated the patch with checkstyle fixes.

          Show
          devaraj.k Devaraj K added a comment - - edited Updated the patch with checkstyle fixes.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 43s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 9 new or modified test files.
          +1 javac 7m 32s There were no new javac warning messages.
          +1 javadoc 9m 42s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 54s There were no new checkstyle issues.
          +1 whitespace 0m 16s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          -1 findbugs 3m 49s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 5m 59s Tests passed in hadoop-yarn-server-nodemanager.
          +1 yarn tests 50m 15s Tests passed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 51s Tests passed in hadoop-yarn-server-tests.
              99m 0s  



          Reason Tests
          FindBugs module:hadoop-yarn-server-resourcemanager
            Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156]



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733802/YARN-41-6.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / de30d66
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7998/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7998/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 9 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 54s There were no new checkstyle issues. +1 whitespace 0m 16s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 3m 49s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common. +1 yarn tests 5m 59s Tests passed in hadoop-yarn-server-nodemanager. +1 yarn tests 50m 15s Tests passed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 51s Tests passed in hadoop-yarn-server-tests.     99m 0s   Reason Tests FindBugs module:hadoop-yarn-server-resourcemanager   Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java: [line 156] Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733802/YARN-41-6.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / de30d66 Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/7998/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7998/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7998/console This message was automatically generated.
          Hide
          devaraj.k Devaraj K added a comment -
          Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156]
          

          It is unrelated to the patch, YARN-3677 exists to track this findbugs issue.

          Show
          devaraj.k Devaraj K added a comment - Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156] It is unrelated to the patch, YARN-3677 exists to track this findbugs issue.
          Hide
          djp Junping Du added a comment -

          Thanks Devaraj K for updating the patch! Just finish my review.
          Two major comments:

          +    // the isStopped check is for avoiding multiple unregistrations.
          +    if (this.registeredWithRM && !this.isStopped && !isNMUnderSupervision()) {
          +      unRegisterNM();
          +    }
          

          According to discussion above, I think we need to check "yarn.nodemanager.recovery.enabled" as well. Because even NM is under supervision, if we disable nm recovery, we should continue to unregister NM to RM.

                .addTransition(NodeState.RUNNING, NodeState.DECOMMISSIONED,
          -         RMNodeEventType.DECOMMISSION,
          +         EnumSet.of(RMNodeEventType.DECOMMISSION, RMNodeEventType.SHUTDOWN),
          

          So, the node after shutdown will become DECOMMISSIONED as final state? I think we don't expect these nodes show in DECOMMISSIONED list. Isn't it? May be we should have some new NodeState as SHUTDOWN for this case. This could make changes incompatible, at least for behaviors and UI. We may need to mark this JIRA as incompatible and document these changes somewhere when patch is done.

          Some minor comments:
          Add tests for new PB objects UnRegisterNodeManagerRequestPBImpl, UnRegisterNodeManagerResponsePBImpl into TestYarnServerApiClasses.java.

          catch (YarnException e) {
          +      throw new ServiceException(e);
          +    } catch (IOException e) {
          +      throw new ServiceException(e);
          +    }
          

          Better to replace with

          catch (YarnException | IOException e) {
              throw new ServiceException(e);
          }
          
          +  @Test
          +  public void testUnRegisterNodeManager() throws Exception {
          +    UnRegisterNodeManagerRequest request = recordFactory
          +        .newRecordInstance(UnRegisterNodeManagerRequest.class);
          +    assertNotNull(client.unRegisterNodeManager(request));
          +
          +    ResourceTrackerTestImpl.exception = true;
          +    try {
          +      client.unRegisterNodeManager(request);
          +      fail("there  should be YarnException");
          +    } catch (YarnException e) {
          +      assertTrue(e.getMessage().startsWith("testMessage"));
          +    } finally {
          +      ResourceTrackerTestImpl.exception = false;
          +    }
          +  }
          

          If other exception get thrown here with wrong message, the test would still pass. Isn't it? better to catch all exceptions and check if it is YarnException.

          +  private void unRegisterNM() {
          +    RecordFactory recordFactory = RecordFactoryPBImpl.get();
          +    UnRegisterNodeManagerRequest request = recordFactory
          +        .newRecordInstance(UnRegisterNodeManagerRequest.class);
          +    request.setNodeId(this.nodeId);
          +    try {
          +      resourceTracker.unRegisterNodeManager(request);
          +      LOG.info("Successfully Unregistered the Node with ResourceManager");
          +    } catch (Exception e) {
          +      LOG.warn("Unregistration of Node failed.", e);
          +    }
          +  }
          

          Put nodeId in the log could help in trouble shooting, also add the missing period in log.

          Show
          djp Junping Du added a comment - Thanks Devaraj K for updating the patch! Just finish my review. Two major comments: + // the isStopped check is for avoiding multiple unregistrations. + if ( this .registeredWithRM && ! this .isStopped && !isNMUnderSupervision()) { + unRegisterNM(); + } According to discussion above, I think we need to check "yarn.nodemanager.recovery.enabled" as well. Because even NM is under supervision, if we disable nm recovery, we should continue to unregister NM to RM. .addTransition(NodeState.RUNNING, NodeState.DECOMMISSIONED, - RMNodeEventType.DECOMMISSION, + EnumSet.of(RMNodeEventType.DECOMMISSION, RMNodeEventType.SHUTDOWN), So, the node after shutdown will become DECOMMISSIONED as final state? I think we don't expect these nodes show in DECOMMISSIONED list. Isn't it? May be we should have some new NodeState as SHUTDOWN for this case. This could make changes incompatible, at least for behaviors and UI. We may need to mark this JIRA as incompatible and document these changes somewhere when patch is done. Some minor comments: Add tests for new PB objects UnRegisterNodeManagerRequestPBImpl, UnRegisterNodeManagerResponsePBImpl into TestYarnServerApiClasses.java. catch (YarnException e) { + throw new ServiceException(e); + } catch (IOException e) { + throw new ServiceException(e); + } Better to replace with catch (YarnException | IOException e) { throw new ServiceException(e); } + @Test + public void testUnRegisterNodeManager() throws Exception { + UnRegisterNodeManagerRequest request = recordFactory + .newRecordInstance(UnRegisterNodeManagerRequest.class); + assertNotNull(client.unRegisterNodeManager(request)); + + ResourceTrackerTestImpl.exception = true ; + try { + client.unRegisterNodeManager(request); + fail( "there should be YarnException" ); + } catch (YarnException e) { + assertTrue(e.getMessage().startsWith( "testMessage" )); + } finally { + ResourceTrackerTestImpl.exception = false ; + } + } If other exception get thrown here with wrong message, the test would still pass. Isn't it? better to catch all exceptions and check if it is YarnException. + private void unRegisterNM() { + RecordFactory recordFactory = RecordFactoryPBImpl.get(); + UnRegisterNodeManagerRequest request = recordFactory + .newRecordInstance(UnRegisterNodeManagerRequest.class); + request.setNodeId( this .nodeId); + try { + resourceTracker.unRegisterNodeManager(request); + LOG.info( "Successfully Unregistered the Node with ResourceManager" ); + } catch (Exception e) { + LOG.warn( "Unregistration of Node failed." , e); + } + } Put nodeId in the log could help in trouble shooting, also add the missing period in log.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks a lot Junping Du for review and for the comments.

          So, the node after shutdown will become DECOMMISSIONED as final state? I think we don't expect these nodes show in DECOMMISSIONED list. Isn't it? May be we should have some new NodeState as SHUTDOWN for this case.

          Shouldn't be counting shut-down nodes in LOST. Adding a new state is perhaps an over-kill, DECOMMISSIONED is the closest I can think of.

          Initial got the above comment from Vinod about the node state. I feel we can proceed here with DECOMMISSIONED state as Vinod suggested and also it will not create any compatibility issue. Adding a new state and Ui change can be done as per your suggestions with the following up jira and can be implemented for trunk without causing the compatibility issue in 2.x versions. Please post your comments on this.

          If other exception get thrown here with wrong message, the test would still pass. Isn't it? better to catch all exceptions and check if it is YarnException.

          I don't see any problem with this test. If any other exception gets here then that exception would be directly thrown from the test and anyway test fails with that exception. Please correct me if I am missing anything here.

          Show
          devaraj.k Devaraj K added a comment - Thanks a lot Junping Du for review and for the comments. So, the node after shutdown will become DECOMMISSIONED as final state? I think we don't expect these nodes show in DECOMMISSIONED list. Isn't it? May be we should have some new NodeState as SHUTDOWN for this case. Shouldn't be counting shut-down nodes in LOST. Adding a new state is perhaps an over-kill, DECOMMISSIONED is the closest I can think of. Initial got the above comment from Vinod about the node state. I feel we can proceed here with DECOMMISSIONED state as Vinod suggested and also it will not create any compatibility issue. Adding a new state and Ui change can be done as per your suggestions with the following up jira and can be implemented for trunk without causing the compatibility issue in 2.x versions. Please post your comments on this. If other exception get thrown here with wrong message, the test would still pass. Isn't it? better to catch all exceptions and check if it is YarnException. I don't see any problem with this test. If any other exception gets here then that exception would be directly thrown from the test and anyway test fails with that exception. Please correct me if I am missing anything here.
          Hide
          djp Junping Du added a comment -

          Initial got the above comment from Vinod about the node state. I feel we can proceed here with DECOMMISSIONED state as Vinod suggested and also it will not create any compatibility issue.

          Sorry. I could miss that comments before.
          OK. I think we are talking about UI and behavior compatibility rather than API compatibility. The previous things we can tolerant within major releases but the later one we cannot. Both ways doesn't break API compatibility as NodeState is marked as UNSTABLE and we were just adding a DECOMMISSIONING state. Isn't it?
          The compatibility issue I mentioned above is still there as behavior changes: user (and management tools) could feel confused that after this patch, the node will show up in the decommission list after normally shutdown. It has been a long time that decommission means we want to retire some nodes, so will reject the registration of these nodes when they are restarted (unless we explicitly remove these nodes from the list), but this is not the case after this patch. I agree with Vinod that LOST is pretty far away here, but DECOMMISSIONED is also not so ideal I think.
          Thoughts?

          Show
          djp Junping Du added a comment - Initial got the above comment from Vinod about the node state. I feel we can proceed here with DECOMMISSIONED state as Vinod suggested and also it will not create any compatibility issue. Sorry. I could miss that comments before. OK. I think we are talking about UI and behavior compatibility rather than API compatibility. The previous things we can tolerant within major releases but the later one we cannot. Both ways doesn't break API compatibility as NodeState is marked as UNSTABLE and we were just adding a DECOMMISSIONING state. Isn't it? The compatibility issue I mentioned above is still there as behavior changes: user (and management tools) could feel confused that after this patch, the node will show up in the decommission list after normally shutdown. It has been a long time that decommission means we want to retire some nodes, so will reject the registration of these nodes when they are restarted (unless we explicitly remove these nodes from the list), but this is not the case after this patch. I agree with Vinod that LOST is pretty far away here, but DECOMMISSIONED is also not so ideal I think. Thoughts?
          Hide
          devaraj.k Devaraj K added a comment -

          Both ways doesn't break API compatibility as NodeState is marked as UNSTABLE and we were just adding a DECOMMISSIONING state. Isn't it?

          I agree that it doesn't break Java API level compatibility. But if the users who use web services for retrieving the nodes, they may need to change the client code if we add new node state here as the node listing would contain with this new state.

          The compatibility issue I mentioned above is still there as behavior changes: user (and management tools) could feel confused that after this patch, the node will show up in the decommission list after normally shutdown.

          Here we are trying to notify the RM immediately that the NM is not available anymore for use instead of waiting for NM expiry interval to know about NM unavailability. Here users would be getting benefit with this rather than worrying about the behavior change. I think adding a new state for shut down here would rectifies the behavioral confusion as you describe.

          I agree with Vinod that LOST is pretty far away here, but DECOMMISSIONED is also not so ideal I think.

          I agree that both the states are not exactly matches for this behavior, DECOMMISSIONED was chosen because it is close one for this behavior and also not to make it complex with the new state.
          I will add a new state i.e. SHUTDOWN for nodes in the next patch.

          Show
          devaraj.k Devaraj K added a comment - Both ways doesn't break API compatibility as NodeState is marked as UNSTABLE and we were just adding a DECOMMISSIONING state. Isn't it? I agree that it doesn't break Java API level compatibility. But if the users who use web services for retrieving the nodes, they may need to change the client code if we add new node state here as the node listing would contain with this new state. The compatibility issue I mentioned above is still there as behavior changes: user (and management tools) could feel confused that after this patch, the node will show up in the decommission list after normally shutdown. Here we are trying to notify the RM immediately that the NM is not available anymore for use instead of waiting for NM expiry interval to know about NM unavailability. Here users would be getting benefit with this rather than worrying about the behavior change. I think adding a new state for shut down here would rectifies the behavioral confusion as you describe. I agree with Vinod that LOST is pretty far away here, but DECOMMISSIONED is also not so ideal I think. I agree that both the states are not exactly matches for this behavior, DECOMMISSIONED was chosen because it is close one for this behavior and also not to make it complex with the new state. I will add a new state i.e. SHUTDOWN for nodes in the next patch.
          Hide
          devaraj.k Devaraj K added a comment -

          Junping Du I have updated the patch with review comments. Can you have a look into this?

          In the latest patch I have added a new NodeState i.e. SHUTDOWN.

          Add tests for new PB objects UnRegisterNodeManagerRequestPBImpl, UnRegisterNodeManagerResponsePBImpl into TestYarnServerApiClasses.java.

          I have added test for UnRegisterNodeManagerRequestPBImpl and I haven't added test for UnRegisterNodeManagerResponsePBImpl since it doesn't have any state to verify and no value add for test.

          Show
          devaraj.k Devaraj K added a comment - Junping Du I have updated the patch with review comments. Can you have a look into this? In the latest patch I have added a new NodeState i.e. SHUTDOWN. Add tests for new PB objects UnRegisterNodeManagerRequestPBImpl, UnRegisterNodeManagerResponsePBImpl into TestYarnServerApiClasses.java. I have added test for UnRegisterNodeManagerRequestPBImpl and I haven't added test for UnRegisterNodeManagerResponsePBImpl since it doesn't have any state to verify and no value add for test.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 10 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 56s There were no new checkstyle issues.
          +1 whitespace 0m 27s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 5m 8s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 26s Tests passed in hadoop-yarn-api.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 6m 7s Tests passed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 60m 28s Tests failed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 52s Tests passed in hadoop-yarn-server-tests.
              112m 16s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
            hadoop.yarn.server.resourcemanager.webapp.TestNodesPage
            hadoop.yarn.server.resourcemanager.TestClientRMService
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735366/YARN-41-7.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 022f49d
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8089/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8089/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 10 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 56s There were no new checkstyle issues. +1 whitespace 0m 27s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 5m 8s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 26s Tests passed in hadoop-yarn-api. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common. +1 yarn tests 6m 7s Tests passed in hadoop-yarn-server-nodemanager. -1 yarn tests 60m 28s Tests failed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 52s Tests passed in hadoop-yarn-server-tests.     112m 16s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices   hadoop.yarn.server.resourcemanager.webapp.TestNodesPage   hadoop.yarn.server.resourcemanager.TestClientRMService Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735366/YARN-41-7.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 022f49d hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8089/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8089/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8089/console This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          I only briefly scan the patch and found the UnRegisterNodeManagerRequest/Response better be abstract class to be consistent with the rest records

          Show
          jianhe Jian He added a comment - I only briefly scan the patch and found the UnRegisterNodeManagerRequest/Response better be abstract class to be consistent with the rest records
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks Jian He for your review and comment, patch has also gone stale. I will update the patch with the comment fix.

          Show
          devaraj.k Devaraj K added a comment - Thanks Jian He for your review and comment, patch has also gone stale. I will update the patch with the comment fix.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 46s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 12 new or modified test files.
          +1 javac 7m 38s There were no new javac warning messages.
          +1 javadoc 9m 31s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 24s The applied patch generated 1 new checkstyle issues (total was 14, now 12).
          +1 whitespace 0m 34s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 5m 9s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 6m 8s Tests passed in hadoop-yarn-server-nodemanager.
          +1 yarn tests 50m 11s Tests passed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 53s Tests passed in hadoop-yarn-server-tests.
              102m 10s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / bb18163
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8098/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8098/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 12 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 31s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 24s The applied patch generated 1 new checkstyle issues (total was 14, now 12). +1 whitespace 0m 34s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 5m 9s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common. +1 yarn tests 6m 8s Tests passed in hadoop-yarn-server-nodemanager. +1 yarn tests 50m 11s Tests passed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 53s Tests passed in hadoop-yarn-server-tests.     102m 10s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bb18163 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8098/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8098/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8098/console This message was automatically generated.
          Hide
          devaraj.k Devaraj K added a comment -
          -1	checkstyle	2m 24s	The applied patch generated 1 new checkstyle issues (total was 14, now 12).
          
          ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java:0: Missing package-info.java file.
          

          This checkstyle issue doesn't seem to be directly related to UnRegisterNodeManagerResponse.java. I have added another class UnRegisterNodeManagerRequest.java in the same package which doesn't show up any checkstyle and also locally I don't get any checkstyle error for this class.

          Show
          devaraj.k Devaraj K added a comment - -1 checkstyle 2m 24s The applied patch generated 1 new checkstyle issues (total was 14, now 12). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java:0: Missing package-info.java file. This checkstyle issue doesn't seem to be directly related to UnRegisterNodeManagerResponse.java. I have added another class UnRegisterNodeManagerRequest.java in the same package which doesn't show up any checkstyle and also locally I don't get any checkstyle error for this class.
          Hide
          djp Junping Du added a comment -

          Junping Du I have updated the patch with review comments. Can you have a look into this?

          Sorry for being late on this as taking travel last week. I will review your latest patch today.

          Show
          djp Junping Du added a comment - Junping Du I have updated the patch with review comments. Can you have a look into this? Sorry for being late on this as taking travel last week. I will review your latest patch today.
          Hide
          djp Junping Du added a comment -

          Thanks Devaraj K for updating the patch with addressing previous comments!
          Latest patch LGTM. +1. Will commit it tomorrow if no further comments on the code from other reviewers.
          In addition, given the patch involve new SHUTDOWN category on: NodeState, UI and Cluster Metrics. Although it doesn't break any public APIs, we should mark this JIRA as incompatible for its inconsistent behaviors with previous releases in UI, CLI, Metrics (to notify users or third-party management & monitor software). In general, I think it should be fine to keep the plan to include this patch in 2.x releases. However, please comments here to let us know if you have any concerns.

          Show
          djp Junping Du added a comment - Thanks Devaraj K for updating the patch with addressing previous comments! Latest patch LGTM. +1. Will commit it tomorrow if no further comments on the code from other reviewers. In addition, given the patch involve new SHUTDOWN category on: NodeState, UI and Cluster Metrics. Although it doesn't break any public APIs, we should mark this JIRA as incompatible for its inconsistent behaviors with previous releases in UI, CLI, Metrics (to notify users or third-party management & monitor software). In general, I think it should be fine to keep the plan to include this patch in 2.x releases. However, please comments here to let us know if you have any concerns.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks a lot Junping Du for your review and comments, I really appreciate your help on reviewing the patch.

          Show
          devaraj.k Devaraj K added a comment - Thanks a lot Junping Du for your review and comments, I really appreciate your help on reviewing the patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 20m 30s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 12 new or modified test files.
          +1 javac 9m 47s There were no new javac warning messages.
          +1 javadoc 12m 20s There were no new javadoc warning messages.
          +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 3m 15s There were no new checkstyle issues.
          +1 whitespace 0m 42s The patch has no lines that end in whitespace.
          +1 install 2m 6s mvn install still works.
          +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
          +1 findbugs 7m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 35s Tests passed in hadoop-yarn-api.
          +1 yarn tests 0m 39s Tests passed in hadoop-yarn-server-common.
          -1 yarn tests 7m 23s Tests failed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 48m 0s Tests failed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 56s Tests passed in hadoop-yarn-server-tests.
              115m 37s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
            hadoop.yarn.server.resourcemanager.TestRMRestart
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c59e745
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8175/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8175/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 30s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 12 new or modified test files. +1 javac 9m 47s There were no new javac warning messages. +1 javadoc 12m 20s There were no new javadoc warning messages. +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 3m 15s There were no new checkstyle issues. +1 whitespace 0m 42s The patch has no lines that end in whitespace. +1 install 2m 6s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. +1 findbugs 7m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 35s Tests passed in hadoop-yarn-api. +1 yarn tests 0m 39s Tests passed in hadoop-yarn-server-common. -1 yarn tests 7m 23s Tests failed in hadoop-yarn-server-nodemanager. -1 yarn tests 48m 0s Tests failed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 56s Tests passed in hadoop-yarn-server-tests.     115m 37s   Reason Tests Failed unit tests hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService   hadoop.yarn.server.resourcemanager.TestRMRestart Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c59e745 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8175/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8175/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8175/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 22m 55s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 12 new or modified test files.
          +1 javac 10m 25s There were no new javac warning messages.
          +1 javadoc 11m 42s There were no new javadoc warning messages.
          +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 4m 3s The applied patch generated 25 new checkstyle issues (total was 0, now 25).
          -1 checkstyle 4m 34s The applied patch generated 165 new checkstyle issues (total was 0, now 165).
          +1 whitespace 0m 38s The patch has no lines that end in whitespace.
          +1 install 1m 56s mvn install still works.
          +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
          +1 findbugs 6m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 6m 20s Tests passed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 65m 49s Tests failed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 56s Tests passed in hadoop-yarn-server-tests.
              135m 1s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSLeafQueue
            hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c59e745
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8177/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8177/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 22m 55s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 12 new or modified test files. +1 javac 10m 25s There were no new javac warning messages. +1 javadoc 11m 42s There were no new javadoc warning messages. +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 4m 3s The applied patch generated 25 new checkstyle issues (total was 0, now 25). -1 checkstyle 4m 34s The applied patch generated 165 new checkstyle issues (total was 0, now 165). +1 whitespace 0m 38s The patch has no lines that end in whitespace. +1 install 1m 56s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. +1 findbugs 6m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common. +1 yarn tests 6m 20s Tests passed in hadoop-yarn-server-nodemanager. -1 yarn tests 65m 49s Tests failed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 56s Tests passed in hadoop-yarn-server-tests.     135m 1s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSLeafQueue   hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c59e745 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8177/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8177/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8177/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 19m 45s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 12 new or modified test files.
          +1 javac 7m 35s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 53s There were no new checkstyle issues.
          +1 whitespace 0m 33s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 5m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 22s Tests passed in hadoop-yarn-api.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 6m 3s Tests passed in hadoop-yarn-server-nodemanager.
          +1 yarn tests 50m 16s Tests passed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 52s Tests passed in hadoop-yarn-server-tests.
              107m 51s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b5f0d29
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8190/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8190/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 45s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 12 new or modified test files. +1 javac 7m 35s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 53s There were no new checkstyle issues. +1 whitespace 0m 33s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 5m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 22s Tests passed in hadoop-yarn-api. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common. +1 yarn tests 6m 3s Tests passed in hadoop-yarn-server-nodemanager. +1 yarn tests 50m 16s Tests passed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 52s Tests passed in hadoop-yarn-server-tests.     107m 51s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b5f0d29 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8190/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8190/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8190/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 20m 58s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 12 new or modified test files.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 53s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 3m 1s There were no new checkstyle issues.
          +1 whitespace 0m 35s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 6m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 30s Tests passed in hadoop-yarn-api.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 6m 16s Tests passed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 50m 29s Tests failed in hadoop-yarn-server-resourcemanager.
          +1 yarn tests 1m 52s Tests passed in hadoop-yarn-server-tests.
              110m 24s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1bb79c9
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8192/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8192/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 58s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 12 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 3m 1s There were no new checkstyle issues. +1 whitespace 0m 35s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 6m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 30s Tests passed in hadoop-yarn-api. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-server-common. +1 yarn tests 6m 16s Tests passed in hadoop-yarn-server-nodemanager. -1 yarn tests 50m 29s Tests failed in hadoop-yarn-server-resourcemanager. +1 yarn tests 1m 52s Tests passed in hadoop-yarn-server-tests.     110m 24s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735565/YARN-41-8.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1bb79c9 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/8192/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8192/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8192/console This message was automatically generated.
          Hide
          devaraj.k Devaraj K added a comment -
          -1	pre-patch	19m 45s	Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
          

          These findbugs are not related to the patch here.

          Show
          devaraj.k Devaraj K added a comment - -1 pre-patch 19m 45s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. These findbugs are not related to the patch here.
          Hide
          djp Junping Du added a comment -

          These findbugs are not related to the patch here.

          Agree. Also, the test failure is not related and the same failure also show up in other patches, like: YARN-3248. We may should file a separated JIRA to fix this. Committing latest patch in.

          Show
          djp Junping Du added a comment - These findbugs are not related to the patch here. Agree. Also, the test failure is not related and the same failure also show up in other patches, like: YARN-3248 . We may should file a separated JIRA to fix this. Committing latest patch in.
          Hide
          djp Junping Du added a comment -

          I have commit latest patch to trunk and branch-2. Thanks Devaraj K for contributing the patch, and review and comments from Jason Lowe, Vinod Kumar Vavilapalli and Jian He!

          Show
          djp Junping Du added a comment - I have commit latest patch to trunk and branch-2. Thanks Devaraj K for contributing the patch, and review and comments from Jason Lowe , Vinod Kumar Vavilapalli and Jian He !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7963 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7963/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7963 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7963/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/216/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/216/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2164/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2164/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #219 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/219/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #219 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/219/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #949 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/949/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #949 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/949/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2147 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2147/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2147 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2147/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #208 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/208/)
          YARN-41. The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #208 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/208/ ) YARN-41 . The RM should handle the graceful shutdown of the NM. Contributed by Devaraj K. (junping_du: rev d7e7f6aa03c67b6a6ccf664adcb06d90bc963e58) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/ResourceTracker.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeEventType.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/UnRegisterNodeManagerRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/LocalRMInterface.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/client/ResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestResourceTrackerPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdaterForLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/impl/pb/service/ResourceTrackerPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYarnServerApiClasses.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestNodesPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/TestYSCRPCFactories.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/ResourceTracker.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/UnRegisterNodeManagerRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClusterMetrics.java

            People

            • Assignee:
              devaraj.k Devaraj K
              Reporter:
              raviteja Ravi Teja Ch N V
            • Votes:
              1 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development