[YARN-3963] AddNodeLabel on duplicate label addition shows success

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Bibin Chundatt
• Reporter: Bibin Chundatt
• Created: 23/Jul/15 05:49
• Updated: 30/Aug/16 01:18
• Resolved: 30/Jul/15 16:45

Description

Currently as per the code in CommonNodeLabelManager#addToClusterNodeLabels when we add same nodelabel again event will not be fired so no updation is done.

./yarn rmadmin –addToClusterNodeLabels x
./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
 

All these commands will give success when applied again through CLI

2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: [<z:exclusivity=true>]
2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   IP=10.19.92.117 OPERATION=addToClusterNodeLabels        TARGET=AdminService     RESULT=SUCCESS
2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: [<z:exclusivity=false>]
2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   IP=<IP> OPERATION=addToClusterNodeLabels        TARGET=AdminService     RESULT=SUCCESS
 

Also since exclusive=true to false is not supported success is misleading