Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3963

AddNodeLabel on duplicate label addition shows success

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently as per the code in CommonNodeLabelManager#addToClusterNodeLabels when we add same nodelabel again event will not be fired so no updation is done.

      ./yarn rmadmin –addToClusterNodeLabels x
      ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
      ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
       

      All these commands will give success when applied again through CLI

      2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: [<z:exclusivity=true>]
      2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   IP=10.19.92.117 OPERATION=addToClusterNodeLabels        TARGET=AdminService     RESULT=SUCCESS
      2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: [<z:exclusivity=false>]
      2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   IP=<IP> OPERATION=addToClusterNodeLabels        TARGET=AdminService     RESULT=SUCCESS
       

      Also since exclusive=true to false is not supported success is misleading

        Attachments

        1. 0001-YARN-3963.patch
          1.0 kB
          Bibin A Chundatt
        2. 0002-YARN-3963.patch
          2 kB
          Bibin A Chundatt
        3. 0003-YARN-3963.patch
          3 kB
          Bibin A Chundatt
        4. 0004-YARN-3963.patch
          3 kB
          Bibin A Chundatt

          Activity

            People

            • Assignee:
              bibinchundatt Bibin A Chundatt
              Reporter:
              bibinchundatt Bibin A Chundatt
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: