Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3963

AddNodeLabel on duplicate label addition shows success

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently as per the code in CommonNodeLabelManager#addToClusterNodeLabels when we add same nodelabel again event will not be fired so no updation is done.

      ./yarn rmadmin –addToClusterNodeLabels x
      ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
      ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
       

      All these commands will give success when applied again through CLI

      2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: [<z:exclusivity=true>]
      2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   IP=10.19.92.117 OPERATION=addToClusterNodeLabels        TARGET=AdminService     RESULT=SUCCESS
      2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: [<z:exclusivity=false>]
      2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   IP=<IP> OPERATION=addToClusterNodeLabels        TARGET=AdminService     RESULT=SUCCESS
       

      Also since exclusive=true to false is not supported success is misleading

      1. 0001-YARN-3963.patch
        1.0 kB
        Bibin A Chundatt
      2. 0002-YARN-3963.patch
        2 kB
        Bibin A Chundatt
      3. 0003-YARN-3963.patch
        3 kB
        Bibin A Chundatt
      4. 0004-YARN-3963.patch
        3 kB
        Bibin A Chundatt

        Activity

        Hide
        sunilg Sunil G added a comment -

        Hi Bibin A Chundatt
        Thanks for reporting this.

        I feel it is better to throw back an error from NodeLabelManager when a duplication occurs. Because if we are trying to overwrite the exclusivity of a label, we may need few more tuning in scheduler side.

        Thoughts?

        Show
        sunilg Sunil G added a comment - Hi Bibin A Chundatt Thanks for reporting this. I feel it is better to throw back an error from NodeLabelManager when a duplication occurs. Because if we are trying to overwrite the exclusivity of a label, we may need few more tuning in scheduler side. Thoughts?
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Exclusive updation for label from true to false is not supported.
        IMO can handle in two ways

        1. Add validation in CommonNodeLabelsManager#addToCluserNodeLabels when duplicate added and exception to console
        2. Improve logs in RM as below
         if (null != dispatcher && !newLabels.isEmpty()) {
              dispatcher.getEventHandler().handle(
                  new StoreNewClusterNodeLabels(newLabels));
             LOG.info("Add labels: [" + StringUtils.join(labels.iterator(), ",") + "]");
            }else{
             LOG.info("Skipped labels: [" + StringUtils.join(skippedlabels.iterator(), ",") + "]");
             }    
        

        Any comments?

        Show
        bibinchundatt Bibin A Chundatt added a comment - Exclusive updation for label from true to false is not supported. IMO can handle in two ways Add validation in CommonNodeLabelsManager#addToCluserNodeLabels when duplicate added and exception to console Improve logs in RM as below if ( null != dispatcher && !newLabels.isEmpty()) { dispatcher.getEventHandler().handle( new StoreNewClusterNodeLabels(newLabels)); LOG.info( "Add labels: [" + StringUtils.join(labels.iterator(), "," ) + "]" ); } else { LOG.info( "Skipped labels: [" + StringUtils.join(skippedlabels.iterator(), "," ) + "]" ); } Any comments?
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Sunil G

        I feel it is better to throw back an error from NodeLabelManager when a duplication occurs.

        I do support this . Any impact in distributed mode?

        Show
        bibinchundatt Bibin A Chundatt added a comment - Sunil G I feel it is better to throw back an error from NodeLabelManager when a duplication occurs. I do support this . Any impact in distributed mode?
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Wangda Tan , Sunil G attaching initial patch for review

        Show
        bibinchundatt Bibin A Chundatt added a comment - Wangda Tan , Sunil G attaching initial patch for review
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch with testcase for review

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch with testcase for review
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 4s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 53s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 1m 56s Tests passed in hadoop-yarn-common.
            40m 1s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747230/0002-YARN-3963.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 156f24e
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8675/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8675/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8675/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 53s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 56s Tests passed in hadoop-yarn-common.     40m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747230/0002-YARN-3963.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 156f24e hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8675/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8675/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8675/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        I think we shouldn't throw exception in this case. It's better to print some WARN message at client side when trying to add existed labels, but currently YARN lack of channel to put diagnostic information. I would prefer to print WARN message at service side, and keeps the behavior unchanged.

        Thoughts? Sunil G, Bibin A Chundatt.

        Show
        leftnoteasy Wangda Tan added a comment - I think we shouldn't throw exception in this case. It's better to print some WARN message at client side when trying to add existed labels, but currently YARN lack of channel to put diagnostic information. I would prefer to print WARN message at service side, and keeps the behavior unchanged. Thoughts? Sunil G , Bibin A Chundatt .
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Wangda Tan,
        How will the user know if he is not informed that the last operation failed ? Any limitations if we throw exception ? I feel user need to be informed if not he will assume that last operation succeeded.

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Wangda Tan , How will the user know if he is not informed that the last operation failed ? Any limitations if we throw exception ? I feel user need to be informed if not he will assume that last operation succeeded.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Bibin A Chundatt,
        In Distributed mode, only node to label mapping is done by individual NM's so there should not be any impact in distributed mode.

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Bibin A Chundatt , In Distributed mode, only node to label mapping is done by individual NM's so there should not be any impact in distributed mode.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks comment, Naganarasimha G R. I think we can throw exception only if added node label has different attribute. If node label has same name and attribute, it should be simply ignored.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks comment, Naganarasimha G R . I think we can throw exception only if added node label has different attribute. If node label has same name and attribute, it should be simply ignored.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        this approach should be fine !

        Show
        Naganarasimha Naganarasimha G R added a comment - this approach should be fine !
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Wangda Tan and Naganarasimha G R Thanks for review and comments.
        Have updated the patch as per the comments. Only when parameters are changed the exception is thrown now .

        Show
        bibinchundatt Bibin A Chundatt added a comment - Wangda Tan and Naganarasimha G R Thanks for review and comments. Have updated the patch as per the comments. Only when parameters are changed the exception is thrown now .
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Bibin A Chundatt,
        throw new IOException("Label=" + label.getName() + "(" + rmNodeLabel.getIsExclusive() + ")" + " already added");
        message would be better as
        throw new IOException("Exclusivity cannot be modified for an existing label : " + label.getName() + "(" + rmNodeLabel.getIsExclusive() + ")" );

        In test case Assert.fail("IOException not thrown should have on adding same labels");
        I think better message would be "IOException is expected when exlusivity is modified"

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Bibin A Chundatt , throw new IOException("Label=" + label.getName() + "(" + rmNodeLabel.getIsExclusive() + ")" + " already added"); message would be better as throw new IOException("Exclusivity cannot be modified for an existing label : " + label.getName() + "(" + rmNodeLabel.getIsExclusive() + ")" ); In test case Assert.fail("IOException not thrown should have on adding same labels"); I think better message would be "IOException is expected when exlusivity is modified"
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Also can we check for all labels and print one message ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Also can we check for all labels and print one message ?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 55s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 10m 42s There were no new javac warning messages.
        +1 javadoc 12m 3s There were no new javadoc warning messages.
        +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 36s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
        +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 2m 20s Tests passed in hadoop-yarn-common.
            49m 19s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747398/0003-YARN-3963.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f36835f
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8679/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8679/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8679/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 55s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 10m 42s There were no new javac warning messages. +1 javadoc 12m 3s There were no new javadoc warning messages. +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 2m 20s Tests passed in hadoop-yarn-common.     49m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747398/0003-YARN-3963.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f36835f hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8679/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8679/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8679/console This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Naganarasimha G R Thank you for your review comments.
        Wangda Tan Updated patch handling all comments.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Naganarasimha G R Thank you for your review comments. Wangda Tan Updated patch handling all comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 3s There were no new javac warning messages.
        +1 javadoc 9m 56s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 56s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 1m 55s Tests passed in hadoop-yarn-common.
            42m 20s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747408/0004-YARN-3963.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f36835f
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8681/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8681/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8681/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 3s There were no new javac warning messages. +1 javadoc 9m 56s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 56s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 55s Tests passed in hadoop-yarn-common.     42m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747408/0004-YARN-3963.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f36835f hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8681/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8681/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8681/console This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Bibin A Chundatt,
        Latest patch looks fine ...

        Show
        Naganarasimha Naganarasimha G R added a comment - Bibin A Chundatt , Latest patch looks fine ...
        Hide
        sunilg Sunil G added a comment -

        Thanks Bibin A Chundatt for the updated patch. +1 for same.
        As mentioned by Wangda Tan and Naganarasimha G R, its better to throw exception in client side while we fail to update/add node label.
        As I see it, I can see full exception stack trace in client side in this case (also in case of other commands too) and its too verbose. I think we can make its compact and n it will be more easily readable. I ll file a separate ticket if its ok.

        Show
        sunilg Sunil G added a comment - Thanks Bibin A Chundatt for the updated patch. +1 for same. As mentioned by Wangda Tan and Naganarasimha G R , its better to throw exception in client side while we fail to update/add node label. As I see it, I can see full exception stack trace in client side in this case (also in case of other commands too) and its too verbose. I think we can make its compact and n it will be more easily readable. I ll file a separate ticket if its ok.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Looks good, committing..

        Show
        leftnoteasy Wangda Tan added a comment - Looks good, committing..
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to branch-2/trunk, thanks Bibin A Chundatt and review from Sunil G/Naganarasimha G R!

        Show
        leftnoteasy Wangda Tan added a comment - Committed to branch-2/trunk, thanks Bibin A Chundatt and review from Sunil G / Naganarasimha G R !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8244 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8244/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8244 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8244/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/273/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/273/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1003 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1003/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1003 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1003/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #262 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/262/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #262 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/262/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2219 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2219/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2219 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2219/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2200/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2200/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/270/)
        YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/270/ ) YARN-3963 . AddNodeLabel on duplicate label addition shows success. (Bibin A Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            bibinchundatt Bibin A Chundatt
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development