Hadoop YARN
  1. Hadoop YARN
  2. YARN-357

App submission should not be synchronized

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 3.0.0, 2.0.0-alpha
    • Fix Version/s: 2.0.3-alpha, 0.23.7
    • Component/s: resourcemanager
    • Labels:
      None

      Description

      MAPREDUCE-2953 fixed a race condition with querying of app status by making RMClientService#submitApplication synchronously invoke RMAppManager#submitApplication. However, the synchronized keyword was also added to RMAppManager#submitApplication with the comment:

      I made the submitApplication synchronized to keep it consistent with the other routines in RMAppManager although I do not believe it needs it since the rmapp datastructure is already a concurrentMap and I don't see anything else that would be an issue.

      It's been observed that app submission latency is being unnecessarily impacted.

      1. YARN-357.patch
        0.9 kB
        Daryn Sharp
      2. YARN-357.patch
        8 kB
        Daryn Sharp
      3. YARN-357.txt
        8 kB
        Siddharth Seth
      4. YARN-357.branch-23.patch
        8 kB
        Daryn Sharp

        Issue Links

          Activity

          Allen Wittenauer made changes -
          Fix Version/s 3.0.0 [ 12323268 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Daryn Sharp made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 2.0.3-alpha [ 12323272 ]
          Fix Version/s 0.23.7 [ 12323953 ]
          Fix Version/s 3.0.0 [ 12323268 ]
          Resolution Fixed [ 1 ]
          Daryn Sharp made changes -
          Attachment YARN-357.branch-23.patch [ 12568245 ]
          Siddharth Seth made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Siddharth Seth made changes -
          Attachment YARN-357.txt [ 12568093 ]
          Siddharth Seth made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Daryn Sharp made changes -
          Attachment YARN-357.patch [ 12566815 ]
          Daryn Sharp made changes -
          Link This issue requires YARN-360 [ YARN-360 ]
          Daryn Sharp made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Daryn Sharp made changes -
          Field Original Value New Value
          Attachment YARN-357.patch [ 12566348 ]
          Daryn Sharp created issue -

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development