[YARN-357] App submission should not be synchronized

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.3, 2.0.0-alpha, 3.0.0-alpha1
• Fix Version/s: 2.0.3-alpha, 0.23.7
• Component/s: resourcemanager
• Target Version/s: 2.0.3-alpha, 0.23.7
• Assignee: Daryn Sharp
• Reporter: Daryn Sharp
• Created: 24/Jan/13 19:09
• Updated: 12/May/16 18:29
• Resolved: 06/Feb/13 16:38

Description

MAPREDUCE-2953 fixed a race condition with querying of app status by making RMClientService#submitApplication synchronously invoke RMAppManager#submitApplication. However, the synchronized keyword was also added to RMAppManager#submitApplication with the comment:

I made the submitApplication synchronized to keep it consistent with the other routines in RMAppManager although I do not believe it needs it since the rmapp datastructure is already a concurrentMap and I don't see anything else that would be an issue.

It's been observed that app submission latency is being unnecessarily impacted.

Issue Links

• requires: YARN-360 Allow apps to concurrently register tokens for renewal