[YARN-3457] NPE when NodeManager.serviceInit fails and stopRecoveryStore called

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
• Component/s: nodemanager
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Bibin Chundatt
• Reporter: Bibin Chundatt
• Created: 07/Apr/15 11:28
• Updated: 06/Jan/17 01:53
• Resolved: 08/Apr/15 06:58

Description

When NodeManager service init fails during stopRecoveryStore null pointer exception is thrown

 @Override
  protected void serviceInit(Configuration conf) throws Exception {
   ..
  try {
      exec.init();
    } catch (IOException e) {
      throw new YarnRuntimeException("Failed to initialize container executor", e);
    }    

this.context = createNMContext(containerTokenSecretManager,
        nmTokenSecretManager, nmStore);
    

context is null when service init fails

  private void stopRecoveryStore() throws IOException {
    nmStore.stop();
    if (context.getDecommissioned() && nmStore.canRecover()) {
   ..
    }
  }

Null pointer exception thrown

015-04-07 17:31:45,807 WARN org.apache.hadoop.service.AbstractService: When stopping the service NodeManager : java.lang.NullPointerException
java.lang.NullPointerException
at org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:168)
at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:280)
at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
at org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
at org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
at org.apache.hadoop.service.AbstractService.init(AbstractService.java:171)
at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:484)
at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:534)

Issue Links

• is related to: YARN-3537 NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked