Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.7.0
-
Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
-
Component/s: nodemanager
-
Labels:None
-
Hadoop Flags:Reviewed
Description
2015-04-23 19:30:34,961 INFO [main] service.AbstractService (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state STOPPED; cause: java.lang.NullPointerException
java.lang.NullPointerException
at org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:181)
at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:326)
at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
at org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerShutdown.tearDown(TestNodeManagerShutdown.java:106)
Issue Links
- relates to
-
YARN-3457
NPE when NodeManager.serviceInit fails and stopRecoveryStore called
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 14m 49s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | javac | 7m 43s | There were no new javac warning messages. |
| +1 | javadoc | 9m 50s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 8m 0s | There were no new checkstyle issues. |
| +1 | install | 1m 34s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 2s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| +1 | yarn tests | 5m 58s | Tests passed in hadoop-yarn-server-nodemanager. |
| 49m 54s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12727593/YARN-3537.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / baf8bc6 |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7471/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7471/testReport/ |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7471/console |
This message was automatically generated.
The code checks for a null store to avoid invoking the stop method, but then a few lines later it has the potential to invoke the canRecover method. Seems like we want to avoid doing anything at all in this method if the store is null.
Jason Lowe thanks for taking look into this issue..Yes, you are correct...Updated the patch,kindly review...
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 14m 38s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | javac | 7m 34s | There were no new javac warning messages. |
| +1 | javadoc | 9m 32s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 5m 19s | There were no new checkstyle issues. |
| +1 | install | 1m 34s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 3s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| +1 | yarn tests | 5m 56s | Tests passed in hadoop-yarn-server-nodemanager. |
| 46m 52s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12727625/YARN-3537-002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 189a63a |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7472/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7472/testReport/ |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7472/console |
This message was automatically generated.
If the store is not null then we want to close it regardless of whether the context is null or not, because that means we opened it earlier. My previous point is that if we don't have a store then this method has nothing to do. If the context is null but the store isn't then there is something that still needs to be done.
Thanks again for your input..Updated patch..
The patch artifact directory on has been removed!
This is a fatal error for test-patch.sh. Aborting.
Jenkins (node H8) information at https://builds.apache.org/job/PreCommit-YARN-Build/7477/ may provide some hints.
Jason Lowe Kindly review updated patch...
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 14m 39s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | javac | 7m 32s | There were no new javac warning messages. |
| +1 | javadoc | 9m 34s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 7m 49s | There were no new checkstyle issues. |
| +1 | install | 1m 35s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 1s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| +1 | yarn tests | 5m 54s | Tests passed in hadoop-yarn-server-nodemanager. |
| 49m 6s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12727649/YARN-3537-003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 91b97c2 |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7495/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7495/testReport/ |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7495/console |
This message was automatically generated.
+1, committing this.
Thanks, Brahma! I committed this to trunk and branch-2.
FAILURE: Integrated in Hadoop-trunk-Commit #7670 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7670/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
- hadoop-yarn-project/CHANGES.txt
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
Thanks Jason Lowe for reviewing and committing!!!!
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
- hadoop-yarn-project/CHANGES.txt
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/908/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
- hadoop-yarn-project/CHANGES.txt
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
- hadoop-yarn-project/CHANGES.txt
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/)
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula (jlowe: rev 5e093f0d400f82f67d9b2d24253c79e4a5abacf9)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
- hadoop-yarn-project/CHANGES.txt
Fix commit version forYARN-3537(jlowe: rev 78fe6e57c7697dae192d74e2f5b91040a3579dfd) - hadoop-yarn-project/CHANGES.txt
I pulled this into branch-2.7 as well.
FAILURE: Integrated in Hadoop-trunk-Commit #7822 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7822/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Yarn-trunk #927 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/927/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #196 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/196/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/195/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Hdfs-trunk #2125 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2125/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/185/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2143/)
Update fix version for YARN-3457 and YARN-3537. (jlowe: rev f7de6198da030cb9cd62dcfd3c378dbbf857e017)
- hadoop-yarn-project/CHANGES.txt
Attached patch to handle NPE..Kindly review..