Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3349

Treat all exceptions as failure in TestFSRMStateStore#testFSRMStateStoreClientRetry

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.7.0
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      treat all exceptions as failure in testFSRMStateStoreClientRetry.
      Currently the exception "could only be replicated to 0 nodes instead of minReplication (=1)" is not treated as failure in testFSRMStateStoreClientRetry.

                  // TODO 0 datanode exception will not be retried by dfs client, fix
                  // that separately.
                  if (!e.getMessage().contains("could only be replicated" +
                      " to 0 nodes instead of minReplication (=1)")) {
                      assertionFailedInThread.set(true);
                   }
      

      With YARN-2820(Retry in FileSystemRMStateStore), we needn't treat this exception specially. We can remove the check and treat all exceptions as failure in testFSRMStateStoreClientRetry.

        Attachments

          Activity

            People

            • Assignee:
              zxu zhihai xu
              Reporter:
              zxu zhihai xu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: