[YARN-3349] Treat all exceptions as failure in TestFSRMStateStore#testFSRMStateStoreClientRetry

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Component/s: test
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Zhihai Xu
• Reporter: Zhihai Xu
• Created: 15/Mar/15 08:27
• Updated: 10/Apr/15 20:09
• Resolved: 16/Mar/15 23:12

Description

treat all exceptions as failure in testFSRMStateStoreClientRetry.
Currently the exception "could only be replicated to 0 nodes instead of minReplication (=1)" is not treated as failure in testFSRMStateStoreClientRetry.

            // TODO 0 datanode exception will not be retried by dfs client, fix
            // that separately.
            if (!e.getMessage().contains("could only be replicated" +
                " to 0 nodes instead of minReplication (=1)")) {
                assertionFailedInThread.set(true);
             }

With YARN-2820(Retry in FileSystemRMStateStore), we needn't treat this exception specially. We can remove the check and treat all exceptions as failure in testFSRMStateStoreClientRetry.