Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3249

Add a "kill application" button to Resource Manager's Web UI

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It want to kill the application on the JobTracker similarly Web UI.

      1. killapp-failed.log
        6 kB
        Tsuyoshi Ozawa
      2. killapp-failed2.log
        6 kB
        Tsuyoshi Ozawa
      3. screenshot.png
        13 kB
        Ryu Kobayashi
      4. screenshot2.png
        40 kB
        Ryu Kobayashi
      5. YARN-3249.2.patch
        14 kB
        Ryu Kobayashi
      6. YARN-3249.2.patch
        14 kB
        Ryu Kobayashi
      7. YARN-3249.3.patch
        14 kB
        Ryu Kobayashi
      8. YARN-3249.4.patch
        10 kB
        Ryu Kobayashi
      9. YARN-3249.5.patch
        11 kB
        Ryu Kobayashi
      10. YARN-3249.6.patch
        4 kB
        Ryu Kobayashi
      11. YARN-3249.patch
        13 kB
        Ryu Kobayashi

        Activity

        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Submitting a patch. Let me review.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Submitting a patch. Let me review.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700467/screenshot.png
        against trunk revision 6cbd9f1.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6720//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700467/screenshot.png against trunk revision 6cbd9f1. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6720//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Ryu Kobayashi thank you for contribution. Unfortunatelly, your changes conflict with YARN-3230. Could you rebase it? Personally, +1 for the change itself.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Ryu Kobayashi thank you for contribution. Unfortunatelly, your changes conflict with YARN-3230 . Could you rebase it? Personally, +1 for the change itself.
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        Tsuyoshi Ozawa Okay, I'll rebase it.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - Tsuyoshi Ozawa Okay, I'll rebase it.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700464/YARN-3249.patch
        against trunk revision 6cbd9f1.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6721//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700464/YARN-3249.patch against trunk revision 6cbd9f1. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6721//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700677/screenshot.png
        against trunk revision 6cbd9f1.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6722//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700677/screenshot.png against trunk revision 6cbd9f1. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6722//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700684/YARN-3249.2.patch
        against trunk revision 6cbd9f1.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6724//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6724//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6724//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700684/YARN-3249.2.patch against trunk revision 6cbd9f1. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6724//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6724//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6724//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700695/YARN-3249.2.patch
        against trunk revision 6cbd9f1.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6727//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6727//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6727//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700695/YARN-3249.2.patch against trunk revision 6cbd9f1. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6727//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6727//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6727//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Ryu Kobayashi thank you for updating. I deployed pseudo distributed hadoop cluster with your patch, but it cannot kill the application on my local. After pushing the kill app button, I got 50x error. Attached a log when I faced the problem. Could you check it?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Ryu Kobayashi thank you for updating. I deployed pseudo distributed hadoop cluster with your patch, but it cannot kill the application on my local. After pushing the kill app button, I got 50x error. Attached a log when I faced the problem. Could you check it?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700711/killapp-failed.log
        against trunk revision ad8ed3e.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6730//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700711/killapp-failed.log against trunk revision ad8ed3e. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6730//console This message is automatically generated.
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        Tsuyoshi Ozawa got it. I have attached a patch that was updated.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - Tsuyoshi Ozawa got it. I have attached a patch that was updated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700724/YARN-3249.3.patch
        against trunk revision ad8ed3e.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

        org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6731//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6731//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6731//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700724/YARN-3249.3.patch against trunk revision ad8ed3e. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6731//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6731//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6731//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Ryu Kobayashi I faced another 500 error. Please check attached log. BTW, is it possible to add a test to TestRMWebServicesApps? It would be good to avoid this kind of errors.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Ryu Kobayashi I faced another 500 error. Please check attached log. BTW, is it possible to add a test to TestRMWebServicesApps? It would be good to avoid this kind of errors.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700767/killapp-failed2.log
        against trunk revision ad8ed3e.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6735//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700767/killapp-failed2.log against trunk revision ad8ed3e. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6735//console This message is automatically generated.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Comments on your patch

        • Can we please move this to the per-application page? Kill buttons on the listing page is not something that we should add - makes it too easy for people to accidentally click on a random application.
        • In the same line, we should not add a new /killapp path. It should just be a path under /apps/appid/
        • KillAppBlock should reuse code from the web-service - RMWebService.killApp().
        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Comments on your patch Can we please move this to the per-application page? Kill buttons on the listing page is not something that we should add - makes it too easy for people to accidentally click on a random application. In the same line, we should not add a new /killapp path. It should just be a path under /apps/appid/ KillAppBlock should reuse code from the web-service - RMWebService.killApp().
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        Vinod Kumar Vavilapalli I see. Okay, I'll try to fix code it.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - Vinod Kumar Vavilapalli I see. Okay, I'll try to fix code it.
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        New patch has the above update.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - New patch has the above update.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Ryu Kobayashi thank you for updating patch! I've deployed RM with your patch. It works well and looks good to me overall.

        Minor nits:
        Following lines should have line breaks not to exceed 80 characters per line

        +        .button().$onclick(String.format("confirmAction('%s')", url(String.format("/killapp/%s", aid)))).b("Kill Application")._()
        
        +      _("function confirmAction(href) { b = confirm(\"Are you sure?\"); if (b == true){ location.href = href; } }")._();
        

        Note: Ryu's patch reuses killApp via updateAppState. It looks reasonable to me.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Ryu Kobayashi thank you for updating patch! I've deployed RM with your patch. It works well and looks good to me overall. Minor nits: Following lines should have line breaks not to exceed 80 characters per line + .button().$onclick( String .format( "confirmAction('%s')" , url( String .format( "/killapp/%s" , aid)))).b( "Kill Application" )._() + _( "function confirmAction(href) { b = confirm(\" Are you sure?\ "); if (b == true ){ location.href = href; } }" )._(); Note: Ryu's patch reuses killApp via updateAppState. It looks reasonable to me.
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        Tsuyoshi Ozawa thanks! I updated 80 characters per line.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - Tsuyoshi Ozawa thanks! I updated 80 characters per line.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Ryu Kobayashi can you deal with Vinod's comment about path?

        In the same line, we should not add a new /killapp path. It should just be a path under /apps/appid/

            route(pajoin("/killapp", APPLICATION_ID), RmController.class, "killapp");
        

        The latest patch still uses /killapp path.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Ryu Kobayashi can you deal with Vinod's comment about path? In the same line, we should not add a new /killapp path. It should just be a path under /apps/appid/ route(pajoin( "/killapp" , APPLICATION_ID), RmController.class, "killapp" ); The latest patch still uses /killapp path.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        One more minor comment about indentation:

        +      html.div()
        +        .button()
        +          .$onclick(String.format("confirmAction('%s')",
        +                    url(String.format("/killapp/%s", aid))))
        +            .b("Kill Application")
        +          ._()
        +      ._();
        

        Above lines should be same as following lines:

        +      html.script().$type("text/javascript")
        +      ._("function confirmAction(href) { "
        +          + "b = confirm(\"Are you sure?\");"
        +          + "if (b == true) {"
        +          + "  location.href = href;"
        +          + "}"
        +        + "}")
        +      ._();
        
        Show
        ozawa Tsuyoshi Ozawa added a comment - One more minor comment about indentation: + html.div() + .button() + .$onclick( String .format( "confirmAction('%s')" , + url( String .format( "/killapp/%s" , aid)))) + .b( "Kill Application" ) + ._() + ._(); Above lines should be same as following lines: + html.script().$type( "text/javascript" ) + ._( "function confirmAction(href) { " + + "b = confirm(\" Are you sure?\ ");" + + " if (b == true ) {" + + " location.href = href;" + + "}" + + "}" ) + ._();
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12702071/YARN-3249.5.patch
        against trunk revision 742f9d9.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6817//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6817//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6817//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702071/YARN-3249.5.patch against trunk revision 742f9d9. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6817//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6817//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6817//console This message is automatically generated.
        Hide
        jianhe Jian He added a comment -

        Ryu Kobayashi, thanks for your work !
        here, can this be directly routed to the RMWebService ? "/ws/v1/cluster/apps/

        {appid}

        /state";

                  .$onclick(String.format("confirmAction('%s')",
                            url(String.format("/killapp/%s", aid))))
        
        Show
        jianhe Jian He added a comment - Ryu Kobayashi , thanks for your work ! here, can this be directly routed to the RMWebService ? "/ws/v1/cluster/apps/ {appid} /state"; .$onclick( String .format( "confirmAction('%s')" , url( String .format( "/killapp/%s" , aid))))
        Hide
        jianhe Jian He added a comment -

        Also, I think it's ok to enable this by default, assuming all the acl permission checks are handled correctly already

        Show
        jianhe Jian He added a comment - Also, I think it's ok to enable this by default, assuming all the acl permission checks are handled correctly already
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        Jian He I see. Sure, looks good that. I'll try it.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - Jian He I see. Sure, looks good that. I'll try it.
        Hide
        ryu_kobayashi Ryu Kobayashi added a comment -

        I was to call directly RMWebService. And, I was changed enable so that by default.

        Show
        ryu_kobayashi Ryu Kobayashi added a comment - I was to call directly RMWebService. And, I was changed enable so that by default.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12702452/YARN-3249.6.patch
        against trunk revision 3560180.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 7 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6836//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6836//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6836//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702452/YARN-3249.6.patch against trunk revision 3560180. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 7 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6836//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6836//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6836//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1, committing this shortly.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1, committing this shortly.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Ryu for your contribution and thanks Vinod and Jian for your review!

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Ryu for your contribution and thanks Vinod and Jian for your review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7267 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7267/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7267 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7267/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2055 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2055/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2055 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2055/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #114 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/114/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #114 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/114/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #123 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/123/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #123 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/123/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2073 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2073/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2073 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2073/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #124 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/124/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #124 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/124/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #858 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/858/)
        YARN-3249. Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #858 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/858/ ) YARN-3249 . Add a 'kill application' button to Resource Manager's Web UI. Contributed by Ryu Kobayashi. (ozawa: rev 1b672096121fef775572b517d4f5721997abbac6) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Pulled this into 2.6.1 as a dependency for YARN-1809. Ran compilation before the push. Patch applied cleanly.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1 as a dependency for YARN-1809 . Ran compilation before the push. Patch applied cleanly.
        Hide
        zxzxy1988 Xiaoyong Zhu added a comment -

        Hello,

        Thanks for the work for enabling this! I am using YARN 2.6.1, but didn't find it in the YARN UI - is it enabled by default? Or should I log in using a different user?

        Thanks!

        Xiaoyong

        Show
        zxzxy1988 Xiaoyong Zhu added a comment - Hello, Thanks for the work for enabling this! I am using YARN 2.6.1, but didn't find it in the YARN UI - is it enabled by default? Or should I log in using a different user? Thanks! Xiaoyong
        Hide
        javadba Stephen Boesch added a comment -

        I have the same question as Xiaoyong Zhu: can not find the Kill job on the Yarn UI.

        Show
        javadba Stephen Boesch added a comment - I have the same question as Xiaoyong Zhu: can not find the Kill job on the Yarn UI.

          People

          • Assignee:
            ryu_kobayashi Ryu Kobayashi
            Reporter:
            ryu_kobayashi Ryu Kobayashi
          • Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development