[YARN-2993] Several fixes (missing acl check, error log msg ...) and some refinement in AdminService

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Component/s: resourcemanager
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Yi Liu
• Reporter: Yi Liu
• Created: 26/Dec/14 01:49
• Updated: 25/Oct/19 20:25
• Resolved: 26/Dec/14 14:53

Description

This JIRA is to resolve following issues in org.apache.hadoop.yarn.server.resourcemanager.AdminService:

1. There is no ACLs check for refreshServiceAcls

2. log message in refreshAdminAcls is incorrect, it should be "... Can not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""

3. some unnecessary header import.

4.

if (!isRMActive()) {
  RMAuditLogger.logFailure(user.getShortUserName(), argName,
      adminAcl.toString(), "AdminService",
      "ResourceManager is not active. Can not remove labels.");
  throwStandbyException();
}

is common in lots of methods, just the message is different, we should refine it into one common method.

5.

LOG.info("Exception remove labels", ioe);
RMAuditLogger.logFailure(user.getShortUserName(), argName,
    adminAcl.toString(), "AdminService", "Exception remove label");
throw RPCUtil.getRemoteException(ioe);

is common in lots of methods, just the message is different, we should refine it into one common method.