Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2993

Several fixes (missing acl check, error log msg ...) and some refinement in AdminService

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0
    • Component/s: resourcemanager
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This JIRA is to resolve following issues in org.apache.hadoop.yarn.server.resourcemanager.AdminService:

      1. There is no ACLs check for refreshServiceAcls

      2. log message in refreshAdminAcls is incorrect, it should be "... Can not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""

      3. some unnecessary header import.

      4.

      if (!isRMActive()) {
        RMAuditLogger.logFailure(user.getShortUserName(), argName,
            adminAcl.toString(), "AdminService",
            "ResourceManager is not active. Can not remove labels.");
        throwStandbyException();
      }
      

      is common in lots of methods, just the message is different, we should refine it into one common method.

      5.

      LOG.info("Exception remove labels", ioe);
      RMAuditLogger.logFailure(user.getShortUserName(), argName,
          adminAcl.toString(), "AdminService", "Exception remove label");
      throw RPCUtil.getRemoteException(ioe);
      

      is common in lots of methods, just the message is different, we should refine it into one common method.

        Attachments

        1. YARN-2993.001.patch
          13 kB
          Yi Liu

          Activity

            People

            • Assignee:
              hitliuyi Yi Liu
              Reporter:
              hitliuyi Yi Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: